)]}'
{"designate/backend/impl_pdns4.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e7703d8fb891d290e4a0495837d0d4dc7f90c66f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        masters \u003d []"},{"line_number":59,"context_line":"        for master in self.masters:"},{"line_number":60,"context_line":"            host \u003d master.host"},{"line_number":61,"context_line":"            if netaddr.IPAddress(master.host).version \u003d\u003d 6:"},{"line_number":62,"context_line":"                host \u003d \u0027[%s]\u0027 % host"},{"line_number":63,"context_line":"            masters.append(\u0027%s:%d\u0027 % (host, master.port))"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_cc21d1fe","line":61,"updated":"2019-08-27 18:11:12.000000000","message":"nit: s/master.host/host/","commit_id":"414b7191c406762a365e79b8383b53cce7ad2c71"}],"designate/tests/unit/backend/test_pdns4.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e7703d8fb891d290e4a0495837d0d4dc7f90c66f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    @mock.patch.object(mdns_rpcapi.MdnsAPI, \u0027notify_zone_changed\u0027)"},{"line_number":85,"context_line":"    def test_create_zone_ipv6(self, req_mock, mock_notify_zone_changed):"},{"line_number":86,"context_line":"        self.target[\u0027masters\u0027] \u003d ["},{"line_number":87,"context_line":"            {\u0027host\u0027: \u00272607:ff68:100:54:f816:3eff:fe28:ca\u0027, \u0027port\u0027: 53},"},{"line_number":88,"context_line":"        ]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.backend \u003d impl_pdns4.PDNS4Backend("}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_ec0a8d77","line":87,"range":{"start_line":87,"start_character":22,"end_line":87,"end_character":56},"updated":"2019-08-27 18:11:12.000000000","message":"Please don\u0027t use real world examples, there\u0027s the documentation prefix 2001:db8::/32 that should be used, similar to the v4 prefix 192.0.2/24","commit_id":"414b7191c406762a365e79b8383b53cce7ad2c71"}],"devstack/designate_plugins/backend-powerdns":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0b14b74cdc155150ad306444ae2f83db42d30f5c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"# Launch gpgsql backend"},{"line_number":120,"context_line":"launch\u003dgpgsql"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# gmysql parameters"},{"line_number":123,"context_line":"gpgsql-host\u003d$MYSQL_HOST"},{"line_number":124,"context_line":"gpgsql-user\u003d$DATABASE_USER"},{"line_number":125,"context_line":"gpgsql-password\u003d$DATABASE_PASSWORD"}],"source_content_type":"application/octet-stream","patch_set":27,"id":"7faddb67_0abf8660","line":122,"updated":"2019-08-29 14:46:16.000000000","message":"gpgsql","commit_id":"17358a72d92731bad397140734c8f0b06916251d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0b14b74cdc155150ad306444ae2f83db42d30f5c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"launch\u003dgpgsql"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# gmysql parameters"},{"line_number":123,"context_line":"gpgsql-host\u003d$MYSQL_HOST"},{"line_number":124,"context_line":"gpgsql-user\u003d$DATABASE_USER"},{"line_number":125,"context_line":"gpgsql-password\u003d$DATABASE_PASSWORD"},{"line_number":126,"context_line":"gpgsql-dbname\u003ddesignate_pdns"}],"source_content_type":"application/octet-stream","patch_set":27,"id":"7faddb67_6aaf1a2b","line":123,"updated":"2019-08-29 14:46:16.000000000","message":"This one looks wrong.","commit_id":"17358a72d92731bad397140734c8f0b06916251d"}],"devstack/settings":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e7703d8fb891d290e4a0495837d0d4dc7f90c66f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"DESIGNATE_SERVICE_PORT_MDNS\u003d${DESIGNATE_SERVICE_PORT_MDNS:-5354}"},{"line_number":40,"context_line":"DESIGNATE_SERVICE_PORT_AGENT\u003d${DESIGNATE_SERVICE_PORT_AGENT:-5358}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# IP address used to DNS servers (e.g. bind9, pdns)"},{"line_number":43,"context_line":"if [[ $SERVICE_IP_VERSION \u003d\u003d 4 ]]; then"},{"line_number":44,"context_line":"    DESIGNATE_DNS_BACKEND_HOST\u003d${DESIGNATE_DNS_BACKEND_HOST:-$HOST_IP}"},{"line_number":45,"context_line":"else"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"7faddb67_455cb67c","line":42,"updated":"2019-08-27 18:11:12.000000000","message":"This sentence seems incomplete to me","commit_id":"414b7191c406762a365e79b8383b53cce7ad2c71"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e7703d8fb891d290e4a0495837d0d4dc7f90c66f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# IP address used to DNS servers (e.g. bind9, pdns)"},{"line_number":43,"context_line":"if [[ $SERVICE_IP_VERSION \u003d\u003d 4 ]]; then"},{"line_number":44,"context_line":"    DESIGNATE_DNS_BACKEND_HOST\u003d${DESIGNATE_DNS_BACKEND_HOST:-$HOST_IP}"},{"line_number":45,"context_line":"else"},{"line_number":46,"context_line":"    DESIGNATE_DNS_BACKEND_HOST\u003d${DESIGNATE_DNS_BACKEND_HOST:-$HOST_IPV6}"},{"line_number":47,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"7faddb67_a5fa4a40","line":44,"updated":"2019-08-27 18:11:12.000000000","message":"I\u0027m not sure how this will work out in a multinode scenario. SERVICE_HOST always points to the primary node, while HOST_IP is the local node.","commit_id":"414b7191c406762a365e79b8383b53cce7ad2c71"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"672fad8a698192583d030dd75983a2949ed2e216","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# IP address used to DNS servers (e.g. bind9, pdns)"},{"line_number":43,"context_line":"if [[ $SERVICE_IP_VERSION \u003d\u003d 4 ]]; then"},{"line_number":44,"context_line":"    DESIGNATE_DNS_BACKEND_HOST\u003d${DESIGNATE_DNS_BACKEND_HOST:-$HOST_IP}"},{"line_number":45,"context_line":"else"},{"line_number":46,"context_line":"    DESIGNATE_DNS_BACKEND_HOST\u003d${DESIGNATE_DNS_BACKEND_HOST:-$HOST_IPV6}"},{"line_number":47,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"7faddb67_d03866d5","line":44,"in_reply_to":"7faddb67_70ff3200","updated":"2019-08-27 18:20:22.000000000","message":"You could override DESIGNATE_DNS_BACKEND_HOST in multinode scenarios thou.","commit_id":"414b7191c406762a365e79b8383b53cce7ad2c71"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"74b28fd1f4d048840856ae9153aa407dd2052de3","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# IP address used to DNS servers (e.g. bind9, pdns)"},{"line_number":43,"context_line":"if [[ $SERVICE_IP_VERSION \u003d\u003d 4 ]]; then"},{"line_number":44,"context_line":"    DESIGNATE_DNS_BACKEND_HOST\u003d${DESIGNATE_DNS_BACKEND_HOST:-$HOST_IP}"},{"line_number":45,"context_line":"else"},{"line_number":46,"context_line":"    DESIGNATE_DNS_BACKEND_HOST\u003d${DESIGNATE_DNS_BACKEND_HOST:-$HOST_IPV6}"},{"line_number":47,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"7faddb67_70ff3200","line":44,"in_reply_to":"7faddb67_a5fa4a40","updated":"2019-08-27 18:18:57.000000000","message":"Yep - probably not. Is there an alternative in devstack to get a ipv6 address not wrapped in []?","commit_id":"414b7191c406762a365e79b8383b53cce7ad2c71"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a3bb91694ad77e781eae2aa1563c68f7a15e9e09","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# IP address used to DNS servers (e.g. bind9, pdns)"},{"line_number":43,"context_line":"if [[ $SERVICE_IP_VERSION \u003d\u003d 4 ]]; then"},{"line_number":44,"context_line":"    DESIGNATE_DNS_BACKEND_HOST\u003d${DESIGNATE_DNS_BACKEND_HOST:-$HOST_IP}"},{"line_number":45,"context_line":"else"},{"line_number":46,"context_line":"    DESIGNATE_DNS_BACKEND_HOST\u003d${DESIGNATE_DNS_BACKEND_HOST:-$HOST_IPV6}"},{"line_number":47,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"7faddb67_48ccc2ba","line":44,"in_reply_to":"7faddb67_d03866d5","updated":"2019-08-28 08:43:16.000000000","message":"I made a function in devstack \"ipv6_unquote\", see https://opendev.org/openstack/devstack/src/branch/master/lib/nova#L91 for an example usage. Sorry I didn\u0027t remember that one earlier. With this, I think you could drop the additional variable below and just use\n\n$(ipv6_unquote $DESIGNATE_SERVICE_HOST)\n\nin those locations where a raw IPv6 address would be needed.","commit_id":"414b7191c406762a365e79b8383b53cce7ad2c71"}]}