)]}'
{"designate/__init__.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e3121fc3ccd4dac8209632ba73fe2ee53ffe41bc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"import oslo_messaging as messaging"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_EXTRA_DEFAULT_LOG_LEVELS \u003d ["},{"line_number":27,"context_line":"    \u0027eventlet.wsgi.server\u003dWARN\u0027,"},{"line_number":28,"context_line":"    \u0027kazoo.client\u003dWARN\u0027,"},{"line_number":29,"context_line":"    \u0027keystone\u003dINFO\u0027,"},{"line_number":30,"context_line":"    \u0027oslo_service.loopingcall\u003dWARN\u0027,"}],"source_content_type":"text/x-python","patch_set":35,"id":"5faad753_7254e121","side":"PARENT","line":27,"updated":"2019-09-12 17:35:56.000000000","message":"This is the new namespace for api logging. Was previously just eventlet.wsgi.","commit_id":"3f38b24ed4e010455d356a757d67e6a316890f10"}],"designate/agent/service.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"be8e6ec83fc7925299f2e219d919f96a7a131083","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.backend.start()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def stop(self, graceful\u003dFalse):"},{"line_number":64,"context_line":"        self.dns_service.start()"},{"line_number":65,"context_line":"        self.backend.stop()"},{"line_number":66,"context_line":"        super(Service, self).stop(graceful)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"3fa7e38b_550f96e0","line":64,"updated":"2019-09-19 14:58:39.000000000","message":"Shouldn\u0027t that be stop()?","commit_id":"6da97079513a69802e08fa192dd8907cda9b2a3d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"fed658dff5e4f55dcc8225e551ef9dd0e7a05b02","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.backend.start()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def stop(self, graceful\u003dFalse):"},{"line_number":64,"context_line":"        self.dns_service.start()"},{"line_number":65,"context_line":"        self.backend.stop()"},{"line_number":66,"context_line":"        super(Service, self).stop(graceful)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"3fa7e38b_bb983b1b","line":64,"in_reply_to":"3fa7e38b_550f96e0","updated":"2019-09-19 16:32:08.000000000","message":"Haha I found this bug before I saw this comment because of your comment on the testing. Nice find!","commit_id":"6da97079513a69802e08fa192dd8907cda9b2a3d"}],"designate/service.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e3121fc3ccd4dac8209632ba73fe2ee53ffe41bc","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        self.tg.add_thread(self._dns_handle_tcp, sock_tcp)"},{"line_number":204,"context_line":"        self.tg.add_thread(self._dns_handle_udp, sock_udp)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def stop(self):"},{"line_number":207,"context_line":"        for sock_tcp in self._dns_socks_tcp:"},{"line_number":208,"context_line":"            sock_tcp.close()"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"5faad753_0d01cc05","line":206,"updated":"2019-09-12 17:35:56.000000000","message":"We need to re-visit stop here, as it does not support graceful shutdown. Most likely due to the while tcp/udp loops, but we can revisit that later.","commit_id":"e183044a1baee8fe310ad2cbaf02c5ba4a1e5e83"}],"designate/tests/unit/agent/test_service.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"be8e6ec83fc7925299f2e219d919f96a7a131083","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from designate.agent import service"},{"line_number":22,"context_line":"from designate.backend import agent_backend"},{"line_number":23,"context_line":"from designate.backend.agent_backend import impl_fake"},{"line_number":24,"context_line":"import designate.service"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class AgentServiceTest(designate.tests.TestCase):"}],"source_content_type":"text/x-python","patch_set":37,"id":"3fa7e38b_95b8aec8","line":24,"updated":"2019-09-19 14:58:39.000000000","message":"I can\u0027t see this being used anywhere, why are you adding this?","commit_id":"6da97079513a69802e08fa192dd8907cda9b2a3d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"be8e6ec83fc7925299f2e219d919f96a7a131083","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertTrue(self.service.dns_service._start.called)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_service_stop(self):"},{"line_number":46,"context_line":"        self.service.stop()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_get_backend(self):"},{"line_number":49,"context_line":"        backend \u003d agent_backend.get_backend(\u0027fake\u0027, agent_service\u003dself.service)"}],"source_content_type":"text/x-python","patch_set":37,"id":"3fa7e38b_95a18eac","line":46,"updated":"2019-09-19 14:58:39.000000000","message":"This test seems not to be testing anything.","commit_id":"6da97079513a69802e08fa192dd8907cda9b2a3d"}],"releasenotes/notes/new-service-layer-8023c242de89075a.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"be8e6ec83fc7925299f2e219d919f96a7a131083","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The options `api_host`, `api_port`, `host` and `port` have been permanently removed"},{"line_number":5,"context_line":"    and is replaced by `listen`."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    e.g."}],"source_content_type":"text/x-yaml","patch_set":37,"id":"3fa7e38b_f54322ae","line":4,"updated":"2019-09-19 14:58:39.000000000","message":"We may want to note that these were already deprecated for some time.\n\nAlso, while this is not being used consistently, I think using double backticks gives bold instead of italic formatting that would look nicer.","commit_id":"6da97079513a69802e08fa192dd8907cda9b2a3d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"be8e6ec83fc7925299f2e219d919f96a7a131083","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The options `api_host`, `api_port`, `host` and `port` have been permanently removed"},{"line_number":5,"context_line":"    and is replaced by `listen`."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    e.g."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"3fa7e38b_15283ee0","line":5,"updated":"2019-09-19 14:58:39.000000000","message":"Nit: s/is/are/","commit_id":"6da97079513a69802e08fa192dd8907cda9b2a3d"}]}