)]}'
{"designate/scheduler/base.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cc9f7a78675b5cc6159a251bf39648b450e505bc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                name_order\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            self.filters \u003d [f.plugin(storage\u003dself.storage) for f in filters]"},{"line_number":44,"context_line":"            for f in self.filters:"},{"line_number":45,"context_line":"                LOG.info(\"Loaded Scheduler Filter: %s\", f.name)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf51134e_367a94f0","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":17},"updated":"2020-06-19 00:03:44.000000000","message":"Single letter variable names are a bad practice","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"300ce1a866b61cac9191bd79bc116f65e33cfe24","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                name_order\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            self.filters \u003d [f.plugin(storage\u003dself.storage) for f in filters]"},{"line_number":44,"context_line":"            for f in self.filters:"},{"line_number":45,"context_line":"                LOG.info(\"Loaded Scheduler Filter: %s\", f.name)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"1f621f24_bdf1d603","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":17},"in_reply_to":"1f621f24_02d22b28","updated":"2020-11-16 23:38:44.000000000","message":"Yea - not a big fan, but that works.","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"0d4c6db5bae3069709939325f40168793f9ffb64","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                name_order\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            self.filters \u003d [f.plugin(storage\u003dself.storage) for f in filters]"},{"line_number":44,"context_line":"            for f in self.filters:"},{"line_number":45,"context_line":"                LOG.info(\"Loaded Scheduler Filter: %s\", f.name)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"1f621f24_add99e83","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":17},"in_reply_to":"1f621f24_bdf1d603","updated":"2020-11-17 13:52:24.000000000","message":"True, it does look a little funny with that leading \u0027_\u0027 :)","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"fc0f3369d21ff734bcced3d0307ad0e990e499ea","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                name_order\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            self.filters \u003d [f.plugin(storage\u003dself.storage) for f in filters]"},{"line_number":44,"context_line":"            for f in self.filters:"},{"line_number":45,"context_line":"                LOG.info(\"Loaded Scheduler Filter: %s\", f.name)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"1f621f24_02d22b28","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":17},"in_reply_to":"5f681702_8812bab0","updated":"2020-11-16 22:10:21.000000000","message":"How about _filter?","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"529c51365420817e9d1b8f1c852f4599a51887fd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                name_order\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            self.filters \u003d [f.plugin(storage\u003dself.storage) for f in filters]"},{"line_number":44,"context_line":"            for f in self.filters:"},{"line_number":45,"context_line":"                LOG.info(\"Loaded Scheduler Filter: %s\", f.name)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf51134e_717ff666","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":17},"in_reply_to":"bf51134e_367a94f0","updated":"2020-06-19 00:20:42.000000000","message":"Agreed.","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"c81be8bdbd1ad9a0ee5d3e31dbd3af40f3dcb83b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                name_order\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            self.filters \u003d [f.plugin(storage\u003dself.storage) for f in filters]"},{"line_number":44,"context_line":"            for f in self.filters:"},{"line_number":45,"context_line":"                LOG.info(\"Loaded Scheduler Filter: %s\", f.name)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f681702_8812bab0","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":17},"in_reply_to":"bf51134e_717ff666","updated":"2020-10-18 07:55:21.000000000","message":"I prefer to not use a reserved keyword. It\u0027s likely why I changed it to f. Got any good alternatives?","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"4f762b5dd44fcfccbfe27c6bd0167577c2b52a42","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                name_order\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            self.filters \u003d [f.plugin(storage\u003dself.storage) for f in filters]"},{"line_number":44,"context_line":"            for _filter in self.filters:"},{"line_number":45,"context_line":"                LOG.info(\"Loaded Scheduler Filter: %s\", _filter.name)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f621f24_adc23e83","line":44,"updated":"2020-11-17 13:55:18.000000000","message":"Looking at it now I think the `f` was ok too to be honest. The variable is used only in the following line and it\u0027s pretty clear I think what the `f` means. The leading `_` definitely looks a little strange. In my opinion a simple `f` would have looked better here, but I\u0027ll let Michael chime in. I am ok with either version.","commit_id":"6e08b5061a2c0d63d8762b84585d3b9d1af54c55"}],"designate/scheduler/filters/attribute_filter.py":[{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"57460df3a579fcb04b1ce53e1f89997362cd6598","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    list"},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @staticmethod"},{"line_number":60,"context_line":"    def evaluate_pool(pool, zone_attributes):"},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            pool_attributes \u003d pool.attributes.to_dict()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_861cbac1","line":59,"updated":"2019-09-12 21:04:05.000000000","message":"Why change the scope of this method, from inner method to static?","commit_id":"fda12c412fb17ab4dc44791b9722ae046bfa7bd6"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"6772fe75cd791d515449fd503c72d7c0d34c7185","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    list"},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @staticmethod"},{"line_number":60,"context_line":"    def evaluate_pool(pool, zone_attributes):"},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            pool_attributes \u003d pool.attributes.to_dict()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_e96a1feb","line":59,"in_reply_to":"5faad753_861cbac1","updated":"2019-09-12 22:07:11.000000000","message":"Mostly for test-ability. With this change this method can be tested directly without first having to call filter.","commit_id":"fda12c412fb17ab4dc44791b9722ae046bfa7bd6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cc9f7a78675b5cc6159a251bf39648b450e505bc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            return False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Check if the keys requested exist in this pool"},{"line_number":76,"context_line":"        if not {key for key in six.iterkeys(pool_attributes)}.issuperset("},{"line_number":77,"context_line":"                zone_attributes):"},{"line_number":78,"context_line":"            LOG.debug("},{"line_number":79,"context_line":"                \u0027%(pool)s did not match list of requested attribute keys - \u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf51134e_364d749a","line":76,"updated":"2020-06-19 00:03:44.000000000","message":"designate is py3 only, so no need to use six here.","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"529c51365420817e9d1b8f1c852f4599a51887fd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            return False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Check if the keys requested exist in this pool"},{"line_number":76,"context_line":"        if not {key for key in six.iterkeys(pool_attributes)}.issuperset("},{"line_number":77,"context_line":"                zone_attributes):"},{"line_number":78,"context_line":"            LOG.debug("},{"line_number":79,"context_line":"                \u0027%(pool)s did not match list of requested attribute keys - \u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf51134e_f192e69d","line":76,"in_reply_to":"bf51134e_364d749a","updated":"2020-06-19 00:20:42.000000000","message":"Will fix. This commit is old. :D","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cc9f7a78675b5cc6159a251bf39648b450e505bc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            # Missing required keys - remove from the list"},{"line_number":88,"context_line":"            return False"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        for key in six.iterkeys(zone_attributes):"},{"line_number":91,"context_line":"            LOG.debug(\u0027Checking value of %s for %s\u0027, key, pool)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            pool_attr \u003d bool_from_string(pool_attributes[key],"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf51134e_7647ec79","line":90,"updated":"2020-06-19 00:03:44.000000000","message":"Same, no need for six.","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"529c51365420817e9d1b8f1c852f4599a51887fd","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            # Missing required keys - remove from the list"},{"line_number":88,"context_line":"            return False"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        for key in six.iterkeys(zone_attributes):"},{"line_number":91,"context_line":"            LOG.debug(\u0027Checking value of %s for %s\u0027, key, pool)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            pool_attr \u003d bool_from_string(pool_attributes[key],"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf51134e_11edda24","line":90,"in_reply_to":"bf51134e_7647ec79","updated":"2020-06-19 00:20:42.000000000","message":"Will fix.","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"}],"designate/scheduler/filters/fallback_filter.py":[{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"1d87caff1910f7a86124e271e7ffffef118c9719","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            pools \u003d objects.PoolList()"},{"line_number":45,"context_line":"            pools.append("},{"line_number":46,"context_line":"                objects.Pool(id\u003dcfg.CONF[\u0027service:central\u0027].default_pool_id))"},{"line_number":47,"context_line":"            return pools"},{"line_number":48,"context_line":"        return pools"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_4c326161","line":47,"updated":"2019-09-12 22:56:33.000000000","message":"This return can also be removed.","commit_id":"fda12c412fb17ab4dc44791b9722ae046bfa7bd6"}],"designate/scheduler/filters/random_filter.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"142080aa64d8fc4ba5c459ebc162f26617e5b4fa","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class RandomFilter(base.Filter):"},{"line_number":25,"context_line":"    \"\"\"Randomly chooses one of the input pools if there is multiple supplied."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    .. note::"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"a4151dbf_42de0722","line":25,"updated":"2020-11-26 09:44:06.000000000","message":"... if there are multiple ones supplied.\n\nWould sound better to me.","commit_id":"86f5ee4c3d664c6628b360faca762a8d8d472f62"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"dc84ef774a1010e2323cd4b39cb338abed8065eb","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class RandomFilter(base.Filter):"},{"line_number":25,"context_line":"    \"\"\"Randomly chooses one of the input pools if there is multiple supplied."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    .. note::"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"904cfbde_4500945e","line":25,"in_reply_to":"a4151dbf_42de0722","updated":"2021-01-16 23:37:37.000000000","message":"Done","commit_id":"86f5ee4c3d664c6628b360faca762a8d8d472f62"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"142080aa64d8fc4ba5c459ebc162f26617e5b4fa","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def filter(self, context, pools, zone):"},{"line_number":38,"context_line":"        new_list \u003d PoolList()"},{"line_number":39,"context_line":"        if pools:"},{"line_number":40,"context_line":"            new_list.append(random.choice(pools))"},{"line_number":41,"context_line":"            return new_list"}],"source_content_type":"text/x-python","patch_set":22,"id":"ab39e061_e37904e0","line":38,"updated":"2020-11-26 09:44:06.000000000","message":"Move this into the if block since it isn\u0027t used otherwise?","commit_id":"86f5ee4c3d664c6628b360faca762a8d8d472f62"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"dc84ef774a1010e2323cd4b39cb338abed8065eb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def filter(self, context, pools, zone):"},{"line_number":38,"context_line":"        new_list \u003d PoolList()"},{"line_number":39,"context_line":"        if pools:"},{"line_number":40,"context_line":"            new_list.append(random.choice(pools))"},{"line_number":41,"context_line":"            return new_list"}],"source_content_type":"text/x-python","patch_set":22,"id":"ef45acb6_e3510e20","line":38,"in_reply_to":"ab39e061_e37904e0","updated":"2021-01-16 23:37:37.000000000","message":"Done","commit_id":"86f5ee4c3d664c6628b360faca762a8d8d472f62"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"142080aa64d8fc4ba5c459ebc162f26617e5b4fa","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    def filter(self, context, pools, zone):"},{"line_number":38,"context_line":"        new_list \u003d PoolList()"},{"line_number":39,"context_line":"        if pools:"},{"line_number":40,"context_line":"            new_list.append(random.choice(pools))"},{"line_number":41,"context_line":"            return new_list"},{"line_number":42,"context_line":"        return pools"}],"source_content_type":"text/x-python","patch_set":22,"id":"7e401de6_575e7ef4","line":40,"updated":"2020-11-26 09:44:06.000000000","message":"Or can we just do\n\npools \u003d PoolList(random.choice(pools))\n\nhere and skip the extra return and the new_list above completely?","commit_id":"86f5ee4c3d664c6628b360faca762a8d8d472f62"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"dc84ef774a1010e2323cd4b39cb338abed8065eb","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def filter(self, context, pools, zone):"},{"line_number":38,"context_line":"        new_list \u003d PoolList()"},{"line_number":39,"context_line":"        if pools:"},{"line_number":40,"context_line":"            new_list.append(random.choice(pools))"},{"line_number":41,"context_line":"            return new_list"},{"line_number":42,"context_line":"        return pools"}],"source_content_type":"text/x-python","patch_set":22,"id":"a9795b44_cc421abf","line":40,"in_reply_to":"7e401de6_575e7ef4","updated":"2021-01-16 23:37:37.000000000","message":"Done","commit_id":"86f5ee4c3d664c6628b360faca762a8d8d472f62"}],"designate/tests/unit/scheduler/test_scenario.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cc9f7a78675b5cc6159a251bf39648b450e505bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"bf51134e_760fec88","updated":"2020-06-19 00:03:44.000000000","message":"It\u0027s a little awkward calling this scenario as typically \"scenario\" tests are run under tempest and they don\u0027t use mock. Anyway we can pick a different name? permutations maybe?","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"529c51365420817e9d1b8f1c852f4599a51887fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"bf51134e_71cd36b7","in_reply_to":"bf51134e_760fec88","updated":"2020-06-19 00:20:42.000000000","message":"Permutations could work.","commit_id":"c0efad0636ed780982bffb770a685b14b57c6ce8"}]}