)]}'
{"designate/notification_handler/neutron.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"0a67ebde3556fcbe8f7f3d0a9cad0f495bfe5967","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def get_event_types(self):"},{"line_number":48,"context_line":"        return ["},{"line_number":49,"context_line":"            \u0027floatingip.update.end\u0027,"},{"line_number":50,"context_line":"            \u0027floatingip.delete.start\u0027"},{"line_number":51,"context_line":"        ]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def process_notification(self, event_type, payload):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B0DM%3D","line":50,"updated":"2014-01-21 20:59:24.000000000","message":"Is there a floatingip.delete.end and a floatingip.update.start too?  If so is there a reason we handle the start of delete but the end of update?","commit_id":"2210ed1c70e8a0224ace33d79e83261411c799fa"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"1d85a256ecf57e23a892a83a706316faf37d008c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def get_event_types(self):"},{"line_number":48,"context_line":"        return ["},{"line_number":49,"context_line":"            \u0027floatingip.update.end\u0027,"},{"line_number":50,"context_line":"            \u0027floatingip.delete.start\u0027"},{"line_number":51,"context_line":"        ]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def process_notification(self, event_type, payload):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Bx3U%3D","line":50,"in_reply_to":"AAAAUH%2F%2B0DM%3D","updated":"2014-01-22 08:19:58.000000000","message":"The floatingip.update events handles when you update a floatingip allocation I believe. like associate / disassociating a floatingip with a Port. We only care for .end events since then it\u0027s done.\n\nWhilst a floatingip.delete happens when you release the floatingip from the project / tenant itself. Here I use the start since that is the event that the bug reports.","commit_id":"2210ed1c70e8a0224ace33d79e83261411c799fa"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"0a67ebde3556fcbe8f7f3d0a9cad0f495bfe5967","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            raise ValueError(msg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        if event_type.startswith(\u0027floatingip.delete\u0027):"},{"line_number":65,"context_line":"            self._delete(resource_id\u003dpayload[\u0027floatingip_id\u0027],"},{"line_number":66,"context_line":"                         resource_type\u003d\u0027floatingip\u0027)"},{"line_number":67,"context_line":"        elif event_type.startswith(\u0027floatingip.update\u0027):"},{"line_number":68,"context_line":"            if payload[\u0027floatingip\u0027][\u0027fixed_ip_address\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B0HE%3D","line":65,"updated":"2014-01-21 20:59:24.000000000","message":"Is the payload different between update and delete?  The other create/delete calls have resource_id set as payload[\u0027floatingip\u0027][\u0027id\u0027].  Should it not be the same here?","commit_id":"2210ed1c70e8a0224ace33d79e83261411c799fa"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"1d85a256ecf57e23a892a83a706316faf37d008c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            raise ValueError(msg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        if event_type.startswith(\u0027floatingip.delete\u0027):"},{"line_number":65,"context_line":"            self._delete(resource_id\u003dpayload[\u0027floatingip_id\u0027],"},{"line_number":66,"context_line":"                         resource_type\u003d\u0027floatingip\u0027)"},{"line_number":67,"context_line":"        elif event_type.startswith(\u0027floatingip.update\u0027):"},{"line_number":68,"context_line":"            if payload[\u0027floatingip\u0027][\u0027fixed_ip_address\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Bx3Q%3D","line":65,"in_reply_to":"AAAAUH%2F%2B0HE%3D","updated":"2014-01-22 08:19:58.000000000","message":"See above comments.","commit_id":"2210ed1c70e8a0224ace33d79e83261411c799fa"}]}