)]}'
{"id":"openstack%2Fdesignate~683300","triplet_id":"openstack%2Fdesignate~master~Ia3e07c42dc548207aa7ff9efcc35a215c9660e54","project":"openstack/designate","branch":"master","hashtags":[],"change_id":"Ia3e07c42dc548207aa7ff9efcc35a215c9660e54","subject":"fix get the name servers for a zone not validate zone_id","status":"MERGED","created":"2019-09-20 06:51:45.000000000","updated":"2019-10-10 08:15:52.000000000","submitted":"2019-09-25 18:29:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683300-1569436189540-e03b07bf","meta_rev_id":"5c33dea0ee8278598c855897758d62d45101a1f6","_number":683300,"virtual_id_number":683300,"owner":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-25 18:29:49.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":2,"date":"2019-09-25 17:10:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-22 07:52:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":1,"date":"2019-09-25 17:10:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-22 07:52:32.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2019-09-25 17:10:47.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"},{"updated":"2019-09-25 18:29:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6c4a00e20c6426a5b19313f0e627ecc0b2bf08e7","author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"date":"2019-09-20 06:51:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"22b3ce85de665f48544a58e4b93e6da6bfe074dd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 08:31:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/ed6e41bb2d144b1595971f11cda297c1 : SUCCESS in 48m 32s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/e7e7ad2403604f229c91be69b14ce40e : SUCCESS in 35m 12s\n- designate-bind9-manager-model https://zuul.opendev.org/t/openstack/build/087c90b93bd44fbabd6b195a5742b00a : SUCCESS in 42m 01s\n- designate-bind9-py27 https://zuul.opendev.org/t/openstack/build/e0205e7d16254277a1c1dc78547f4550 : SUCCESS in 42m 43s\n- designate-pdns4-py27 https://zuul.opendev.org/t/openstack/build/d80cfecf1d234d9bab9e2c7152372e6d : SUCCESS in 38m 28s\n- designate-pdns4-postgres https://zuul.opendev.org/t/openstack/build/ebb469f0caea464bb537490764fb0340 : FAILURE in 31m 25s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/9bee5977dd384f81bf3f2f1dc2959e78 : SUCCESS in 1h 02m 16s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/4a2e6546ee8f4891bf24ea7fb5d8fd92 : SUCCESS in 42m 31s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/0d9c4f3f7d9b418db4a9f33c081a3f9c : SUCCESS in 43m 12s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bbe3b1d54f4d47e68c4e50dff974b4b2 : SUCCESS in 5m 31s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/712dd88ade034424ac3a542e4e6cd621 : SUCCESS in 4m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/67d0bc2e25d449808fd21971a335811c : SUCCESS in 4m 24s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/e8b8cbb2e2a24040a4ef75020b220b82 : SUCCESS in 5m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a2e8d4238dd54f9ca04c6e66c7f9299f : SUCCESS in 5m 06s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/efa7a635e17d4b5b844ec3cf17a34d49 : SUCCESS in 5m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8b7cc929ffe645dc87a91e9726804e9e : SUCCESS in 9m 50s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/31182260c7174f1f9057c562420d8167 : SUCCESS in 37m 46s","accounts_in_message":[],"_revision_number":1},{"id":"faf892cf5e289bc71d03cd0ed68b28ee7c376df2","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-09-22 07:52:32.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f335adb12e615143cbea841fa25d0179b45f13e1","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2019-09-25 17:10:47.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0885fdb906e75dfdb53dad1ba67aa61e9a34b7db","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 17:11:00.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2e85fb3d4ef456876d478867511d7908f819f1fd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 18:29:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"2e7ff15c29a288e15f01bb40c6b66ab77c2a202a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 18:29:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/4b0db51154a2422385e1aeb771e5296c : SUCCESS in 48m 06s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/6f703bf287eb41fd8c649168804e860c : SUCCESS in 37m 20s\n- designate-bind9-py27 https://zuul.opendev.org/t/openstack/build/c2b2c622929341f9bfc8407083dc63ee : SUCCESS in 45m 19s\n- designate-pdns4-py27 https://zuul.opendev.org/t/openstack/build/02052b586b6c49ad93cfced8125d0155 : SUCCESS in 47m 08s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/caaf675dbd7a4922b976450eb4d1c3c8 : SUCCESS in 58m 15s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/62d8067d94d44a7cbd0fa9df7a9ba2f6 : SUCCESS in 34m 04s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/f80b706daf334de8a9c63924b745dc3b : SUCCESS in 34m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1af7dcae3ab5423cae58c1180eebb240 : SUCCESS in 3m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d567311fee284d6a89a8e688295c2122 : SUCCESS in 3m 47s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/bdeac5c55fff402eab8db4b422eb2093 : SUCCESS in 5m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e9e30225e35a487c948f0750f8ce4ae3 : SUCCESS in 4m 27s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/637f56bce0a64184add525d498c25efd : SUCCESS in 4m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5b07da123fcf4465a3a082890ee22374 : SUCCESS in 7m 16s","accounts_in_message":[],"_revision_number":1},{"id":"1a94b7bf1cb6a87f34836d936a235b804d4632b0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 18:34:51.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c4a04d61e8d5454f9b4f5a2005364428 : SUCCESS in 50s","accounts_in_message":[],"_revision_number":1},{"id":"5c33dea0ee8278598c855897758d62d45101a1f6","author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"date":"2019-10-10 08:15:52.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 357a41c4281181cd0cffa04b377cdfc3020eaf1f","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0ba52bfb62cb64992a06b64c44f3e6a9dcadc193","revisions":{"0ba52bfb62cb64992a06b64c44f3e6a9dcadc193":{"kind":"REWORK","_number":1,"created":"2019-09-20 06:51:45.000000000","uploader":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"ref":"refs/changes/00/683300/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/00/683300/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/00/683300/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/00/683300/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/00/683300/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/00/683300/1"}}},"commit":{"parents":[{"commit":"23f6a79aef1303d25f8eb1c9d5090fe7f4326d46","subject":"Merge \"Add missing RabbitMQ configuration to install guides\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/23f6a79aef1303d25f8eb1c9d5090fe7f4326d46"}]}],"author":{"name":"zhouhenglc","email":"zhouhenglc@inspur.com","date":"2019-09-20 06:46:36.000000000","tz":480},"committer":{"name":"zhouhenglc","email":"zhouhenglc@inspur.com","date":"2019-09-20 06:46:49.000000000","tz":480},"subject":"fix get the name servers for a zone not validate zone_id","message":"fix get the name servers for a zone not validate zone_id\n\nnow the api of get /v2/zones/{zone_id}/nameservers not validate zone_id,\nif set zone_id contain spaces, will trigger DBError and return 500.\n\nChange-Id: Ia3e07c42dc548207aa7ff9efcc35a215c9660e54\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/0ba52bfb62cb64992a06b64c44f3e6a9dcadc193"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/0ba52bfb62cb64992a06b64c44f3e6a9dcadc193"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
