)]}'
{"id":"openstack%2Fdesignate~685646","triplet_id":"openstack%2Fdesignate~master~I2a8b8d137b31866dac40d2f80e47f09fe1a2b68d","project":"openstack/designate","branch":"master","topic":"reduce_log_spam","hashtags":[],"change_id":"I2a8b8d137b31866dac40d2f80e47f09fe1a2b68d","subject":"Reduce log spam from coordinator","status":"MERGED","created":"2019-09-30 05:47:11.000000000","updated":"2019-10-02 21:58:24.000000000","submitted":"2019-10-02 21:57:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"685646-1570053426995-b42f53c0","meta_rev_id":"137f5f83cb687980265229bc321b702b91c46347","_number":685646,"virtual_id_number":685646,"owner":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-02 21:57:06.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":2,"date":"2019-10-01 17:54:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-02 20:21:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-01 17:54:18.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-10-02 21:57:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8bee6c7e69479bffff0948ca94da8f60d1b060f8","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-09-30 05:47:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"69a0ac2afe0190950fe3fbea8a9d1a5b1e02cecb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-30 06:47:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/6e52a7e30b834d24a3abc88fe6b0938f : SUCCESS in 44m 38s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/3176a84f0ac24fb5ae1f798bc087bf90 : SUCCESS in 41m 57s\n- designate-bind9-py27 https://zuul.opendev.org/t/openstack/build/c97d926e06fe46a49de88b35fdda6d80 : SUCCESS in 1h 00m 00s\n- designate-pdns4-py27 https://zuul.opendev.org/t/openstack/build/f66057ed9f5147bab3549e157b0d8f87 : SUCCESS in 39m 20s\n- designate-pdns4-postgres https://zuul.opendev.org/t/openstack/build/8a4678c23e8546df8ab629cd0deac978 : FAILURE in 29m 53s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/46722439dbc84cbba2c3d6c0be4ed1f3 : SUCCESS in 58m 33s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/359211982f114da091e276076e1f746f : SUCCESS in 42m 22s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/daa35f3813d044cfa57479afcbcd0bea : SUCCESS in 41m 43s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8ebb1bc1ae5f4d06a92c699f65ed247d : SUCCESS in 6m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/feef2a0eb42c48d89f80bfbac2fc2209 : SUCCESS in 4m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/30b5ab17d9684eeeb24c8579bbabdf8f : SUCCESS in 4m 39s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/84595a192f5d4f07b06fe1e086caf5fa : SUCCESS in 5m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4e4a4d79f3014a728d0ef1720566b788 : SUCCESS in 4m 02s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0540adf9508d4d3c94ede37e1b438759 : SUCCESS in 4m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b060b59ddd6f4839a302dc8a2f552c1c : SUCCESS in 7m 42s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/d1e7a5f868fc48ecb4c96bb9edfa7cfa : SUCCESS in 38m 12s","accounts_in_message":[],"_revision_number":1},{"id":"212d37c2567ba7aa7242b00fa0c90aa92eeae89c","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-10-01 06:33:09.000000000","message":"Patch Set 1:\n\nThe current settings would spam ~10 lines per second per worker when unable to connect to memcached. The above changes would lower it to 1 line per five seconds per worker.","accounts_in_message":[],"_revision_number":1},{"id":"4cdf76af9145d5d16b23d5368da0343b1da552ab","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-10-01 09:36:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4053691e4c9602af8c0490ca850f416d48776a08","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-10-01 17:44:57.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n\n\u003e Do we need this warning at all?\nIt was the only thing throwing errors for me when stopping memcached. So I think we need to keep it now to make users aware of issues.\n\n\u003e Also it seems to be an option in tooz to let it handle the heartbeat internally, any reason we don\u0027t use that?\nWe should look at maybe having tooz handle it.\n\nWe should for sure follow up with a bigger fix for this. The implementation isn\u0027t super solid.","accounts_in_message":[],"_revision_number":1},{"id":"485b70afb38c92bf3fcd063ec1da343815c40a15","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-10-01 17:54:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"74a7027c3e040e6ebccfcdbfb13de1ee1b3268a1","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-10-02 20:21:48.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4667db52f828cc99229f5ca7ba807849b52bab75","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 20:23:07.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"decc5abd9e2e9b68fbb3957d39439ff970c86f99","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 21:57:06.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"9931d15007914e4c6015755bdd4406d09ae78479","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 21:57:06.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/e4b1fb7a36be4b35a64bc40dc251b5cd : SUCCESS in 39m 06s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/3fcc15ead67f4360a2a4d1e8d214fff8 : SUCCESS in 34m 56s\n- designate-bind9-py27 https://zuul.opendev.org/t/openstack/build/8fea44c3e9264769b73daa81b29a54b7 : SUCCESS in 40m 45s\n- designate-pdns4-py27 https://zuul.opendev.org/t/openstack/build/41f5aa8eeab8417bb93941ad1984ab11 : SUCCESS in 36m 57s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/650aa022e38740af9872232e0a7e2370 : SUCCESS in 1h 01m 06s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/5641aa7855fc4b7b81485f63abe8fc1d : SUCCESS in 37m 08s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/dbbd8779863746b280c6badafac81ecd : SUCCESS in 35m 43s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/889a23fd90cc4425938e8ebad276a595 : SUCCESS in 3m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a3c7086a69304987812e69a35793e645 : SUCCESS in 4m 00s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/ab70c44e7bcb4211857adb9bbba46fef : SUCCESS in 4m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d602881b054a49a086c70eb71b941f70 : SUCCESS in 3m 49s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/baed77525f754c4e8e7d97829f2063ff : SUCCESS in 4m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6ed2218c3c4942c6a58af3e158d16815 : SUCCESS in 8m 40s","accounts_in_message":[],"_revision_number":1},{"id":"cfc72f60d6c4262838563c4eeb12e092f35e44ca","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 21:58:24.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b07e1c4f3f294d288051a3d91119cb4c : SUCCESS in 57s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"acab709da5f699dd4531fbe8e739c1ab9a821746","revisions":{"acab709da5f699dd4531fbe8e739c1ab9a821746":{"kind":"REWORK","_number":1,"created":"2019-09-30 05:47:11.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/46/685646/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/46/685646/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/46/685646/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/46/685646/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/46/685646/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/46/685646/1"}}},"commit":{"parents":[{"commit":"d078b0abf375a93fd56580c380746171d1ec1d39","subject":"Update master for stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/d078b0abf375a93fd56580c380746171d1ec1d39"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-09-30 05:44:56.000000000","tz":-420},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-09-30 05:44:56.000000000","tz":-420},"subject":"Reduce log spam from coordinator","message":"Reduce log spam from coordinator\n\nThe current implementation has slightly\ntoo aggresive defaults and logs an exception\nfor every missed heartbeat. This can cause\nmany lines of error logs from a millisecond\noutage.\n\n* Reduced default heartbeat from 1s to 5s.\n* Changed heartbeat error into warning.\n\nChange-Id: I2a8b8d137b31866dac40d2f80e47f09fe1a2b68d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/acab709da5f699dd4531fbe8e739c1ab9a821746"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/acab709da5f699dd4531fbe8e739c1ab9a821746"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}