)]}'
{"id":"openstack%2Fdesignate~697346","triplet_id":"openstack%2Fdesignate~stable%2Fstein~Id8206ee5285d3a73e00ef21b7d3961a29c23ab4b","project":"openstack/designate","branch":"stable/stein","topic":"bug/1828534-stable/stein","hashtags":[],"change_id":"Id8206ee5285d3a73e00ef21b7d3961a29c23ab4b","subject":"Ensure coordination IDs are encoded","status":"ABANDONED","created":"2019-12-04 19:17:13.000000000","updated":"2021-12-24 04:28:48.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e51d08c018ae068ffe15bf26b242222fc46bfa40","_number":697346,"virtual_id_number":697346,"owner":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"tag":"autogenerated:zuul:check","value":1,"date":"2019-12-04 20:34:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-12-05 14:38:29.000000000","_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":-2,"date":"2019-12-05 09:39:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-04 20:34:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-05 09:39:00.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"}],"messages":[{"id":"6da66431c3f46f9a8cb5586fd7627864139bc3cf","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2019-12-04 19:17:13.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"90e2b0aefdf216cd7d67c8cddb6879dbb85caf84","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2019-12-04 19:18:32.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit 52424bd7353db9c62325987becfd91dd889c04f6","accounts_in_message":[],"_revision_number":1},{"id":"50ebb467fc420ab012cafe1dd647e60ad7558ac7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-04 20:34:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/9a76b34fa36044de8b3a874041fce77d : SUCCESS in 37m 34s\n- designate-bind9-manager-model https://zuul.opendev.org/t/openstack/build/fc59390f95714e05a1505f5e56743049 : SUCCESS in 44m 12s\n- designate-bind9-py36 https://zuul.opendev.org/t/openstack/build/d028df6bd2e84436b83bb643cbde787a : SUCCESS in 44m 51s\n- designate-devstack-pdns4 https://zuul.opendev.org/t/openstack/build/c8fddce8deac467c85a533db0d002bea : SUCCESS in 47m 12s\n- designate-devstack-pdns4-postgres https://zuul.opendev.org/t/openstack/build/6ec4f85007264f8d890042bde4fa6894 : SUCCESS in 36m 42s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/ebf7239ab2644cfe94eb936e2e184b92 : SUCCESS in 1h 03m 03s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c476bdac8fa74ed591e281768527cdc6 : SUCCESS in 7m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e0aeb80c4ea74df48cc4f6a05e957e94 : SUCCESS in 3m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e4bae596c1b24aa58afa634a73c4102e : SUCCESS in 4m 34s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/3e284c96c8614a51842bb4ee286ed4f6 : SUCCESS in 6m 11s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/7aac5b6ac3b1449dbf04f16629663e8d : SUCCESS in 6m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ca44ef094f564a8eafe4093327bb0f8b : SUCCESS in 5m 36s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8aa51f8150af4fe5825d3fcfff8dee62 : SUCCESS in 5m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0c49d3a59deb437cb016a9acbb3b4e04 : SUCCESS in 4m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/147fd9856bba4ffb9e42cf35a4c26f0f : SUCCESS in 9m 08s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/7171eee64d8b4130bf1144e71abfa569 : SUCCESS in 36m 31s","accounts_in_message":[],"_revision_number":1},{"id":"b61654b0c355508ace7fdfd7b1249bc9322103ff","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-12-05 09:39:00.000000000","message":"Patch Set 1: Code-Review-2\n\nIIUC this would break existing deployments, so this patch is non-backportable to me.","accounts_in_message":[],"_revision_number":1},{"id":"6fcf9829ad140b2959cd5964942daa06d42a510e","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2019-12-05 14:38:29.000000000","message":"Patch Set 1:\n\n@frickler, Yes, it would break existing py3 deployments so probably not nice for a stable release, but it would fix py2 deployments that upgrade to py3. Definitely a trade off and I\u0027m not sure it\u0027s worth it either.","accounts_in_message":[],"_revision_number":1},{"id":"85c894a41a346306e47cffb664f901d118f76d04","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-12-05 15:44:08.000000000","message":"Patch Set 1:\n\nOne solution this is a bit more involved would be to introduce a flag to switch this behaviour that is immediately deprated again.\n\nThat way operators could change the setup on their own pace, instead of being broken by a simple minor update.\n\nBut I\u0027m also not sure whether just sticking to the status quo for the stable branches would be better. You can still carry the patch downstream in Ubuntu, as I think you are already doing anyway IIRC.","accounts_in_message":[],"_revision_number":1},{"id":"e51d08c018ae068ffe15bf26b242222fc46bfa40","tag":"autogenerated:gerrit:abandon","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2021-12-24 04:28:48.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4ad8defd4a4ad0f5b0d29de34a3b6e9e90aa4b43","revisions":{"4ad8defd4a4ad0f5b0d29de34a3b6e9e90aa4b43":{"kind":"REWORK","_number":1,"created":"2019-12-04 19:17:13.000000000","uploader":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"ref":"refs/changes/46/697346/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/46/697346/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/46/697346/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/46/697346/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/46/697346/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/46/697346/1"}}},"commit":{"parents":[{"commit":"3382867b38cf3f72ec494794bceaa5523b43d9c4","subject":"Fixing 404 link","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/3382867b38cf3f72ec494794bceaa5523b43d9c4"}]}],"author":{"name":"Corey Bryant","email":"corey.bryant@canonical.com","date":"2019-07-29 19:44:48.000000000","tz":-240},"committer":{"name":"Corey Bryant","email":"corey.bryant@canonical.com","date":"2019-12-04 19:17:13.000000000","tz":0},"subject":"Ensure coordination IDs are encoded","message":"Ensure coordination IDs are encoded\n\nEnsure coordination IDs are encoded when working with coordination\nbackend. This fixes an issue when upgrading to Python 3 (where bytes\nand str are different types) and _update_partitions() attempts to\nsort types of \u0027str\u0027 and \u0027bytes\u0027, causing designate-producer to crash.\n\nChange-Id: Id8206ee5285d3a73e00ef21b7d3961a29c23ab4b\nCloses-Bug: #1828534\n(cherry picked from commit 556a27e4e9c9c4e21fb0ea46d8d8832d28c85314)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/4ad8defd4a4ad0f5b0d29de34a3b6e9e90aa4b43"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/4ad8defd4a4ad0f5b0d29de34a3b6e9e90aa4b43"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}