)]}'
{"id":"openstack%2Fdesignate~700283","triplet_id":"openstack%2Fdesignate~master~Ie9863dc1fbdbcc24c2baa73f8768c47985afcd09","project":"openstack/designate","branch":"master","hashtags":[],"change_id":"Ie9863dc1fbdbcc24c2baa73f8768c47985afcd09","subject":"Resolve potential race condition when updating zone","status":"ABANDONED","created":"2019-12-21 20:21:11.000000000","updated":"2020-04-13 22:28:27.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"16a3565d04ccfc43074b18fdd0906d88107e48a1","_number":700283,"virtual_id_number":700283,"owner":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-03-16 03:52:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":2,"date":"2020-03-16 02:46:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-13 11:19:31.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"},{"updated":"2020-03-15 10:24:05.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2020-03-16 03:52:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6ca02ca29e0ff63d61a995be4456d8ce43f6aa1a","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-12-21 20:21:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fa2f604ffdc83e2ed2ef33d26bdcb53522ff801d","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-12-21 20:34:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8298da2c08b16ef7417d2186cc2a0acb21e69075","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-21 21:30:58.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/2ed000482e2d4a589344bc1d3d3bb7a8 : SUCCESS in 38m 48s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/81a9843c31244c3fb31caa18999d1208 : SUCCESS in 39m 14s\n- designate-pdns4-postgres https://zuul.opendev.org/t/openstack/build/61a814f286f1479c87033e4b16ad35ed : FAILURE in 28m 12s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/5acb3f5a28644a44a32447d058ed0cbb : SUCCESS in 54m 34s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/d3b0466693194225bb392f6b0bdac5ec : SUCCESS in 37m 27s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/85e7db14294446b78605e46892b39219 : SUCCESS in 38m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4e65951677bf497ba1800bb353968335 : SUCCESS in 5m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a2bcc888c1944ecb8e0acf57775a702c : SUCCESS in 3m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/32a3e04c0d764d2fb6aef7c7e3eb8657 : SUCCESS in 3m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9a6f4b5a0d114dba9e62fad105b25edd : SUCCESS in 4m 53s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/049146708be9483f8b30b875eace07c9 : POST_FAILURE in 5m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3282c53ebda7420ba3fe12c7390cd1ab : SUCCESS in 6m 20s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/f6c3645d204a4ba1b1ee993296af542a : SUCCESS in 29m 18s","accounts_in_message":[],"_revision_number":2},{"id":"a3241f650dbedd882a4f73cd3641915b4c31bd52","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-12-21 21:42:14.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"992cb0e52f49d4c6db9b39174339636f4a275f84","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-21 22:40:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/6da8f7d3a3af4b9280ad11511f42a3e8 : SUCCESS in 37m 40s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/867a176df043469e918960a345b5cc46 : SUCCESS in 35m 41s\n- designate-pdns4-postgres https://zuul.opendev.org/t/openstack/build/b326e7f2f0894baaa4591da364030eb3 : FAILURE in 25m 00s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/006c4d683c2e41fc89dc96f905d531dd : SUCCESS in 56m 13s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/33901e73c8ea4609be26482b8d6a24bb : SUCCESS in 32m 15s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/d0d33b0c18a74129b20ac0ada6dc4aae : SUCCESS in 39m 11s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f537740379064797ad97a078218aece6 : SUCCESS in 5m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/204facba3c2a404aa23e4a15a89e6ccb : SUCCESS in 3m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c036985a2e3345ccb5458a990638216d : SUCCESS in 3m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a42e15bd7d17497e869388bebb9f5a97 : SUCCESS in 4m 08s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/188305e439f14fa9bd0f1ca6910a20ab : SUCCESS in 4m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ca057515ce65488a823217a50340fcaf : SUCCESS in 6m 53s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/9280e9cf522f4a158b4ba20edd82e1b6 : SUCCESS in 34m 18s","accounts_in_message":[],"_revision_number":2},{"id":"e1e093aa35568591b3d0c34e0016315080e99d0d","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-12-24 23:15:38.000000000","message":"Patch Set 2:\n\nIt does not look like this is needed after we have\nhttps://review.opendev.org/#/c/700404/\n\nBut I stress tested both changes and both solve\nhttps://bugs.launchpad.net/designate/+bug/1768618\n\nWe could go with just one of the patches or both.","accounts_in_message":[],"_revision_number":2},{"id":"86e15fe12d2d05ae0753df33d07716ac36cbe4dd","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-12-24 23:16:17.000000000","message":"Patch Set 2:\n\nI use the following to test this.\nhttp://paste.openstack.org/show/787877/","accounts_in_message":[],"_revision_number":2},{"id":"859d4af3c090289f613cf9d0ea27586baeba0d41","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-01-16 18:55:15.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"f7311b4f97a9914181e53f55d554a6e012a05c50","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-16 19:53:42.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/b3d4739dd41f49738dfdd2cd61b49f30 : SUCCESS in 39m 49s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/85d1306413004845838a648a383988fa : SUCCESS in 38m 10s\n- designate-pdns4-postgres https://zuul.opendev.org/t/openstack/build/603088d4113a4d6c95952f2515cd5567 : FAILURE in 28m 38s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/7da78e4d03274e01927d55d31f02a87b : SUCCESS in 56m 13s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/5a07cdc103bc468e97cf5d6ae2272eaf : SUCCESS in 38m 36s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/58cba5815cf0401e8c92a298f83d50e3 : SUCCESS in 40m 56s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f5697f5de8744b1691ce0f027c2827b8 : SUCCESS in 7m 47s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b88bffe4329e4c2b8b768e9d8ebdfdff : SUCCESS in 3m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/34c35b385a2e46e7a575389af6d0f663 : SUCCESS in 3m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5229e0b283364790a33e089beb1140a0 : SUCCESS in 4m 35s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4124eaa1252744e7b15d5298fbb5629f : SUCCESS in 10m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/87cec6d78caf47339ee3dc975edc74a4 : SUCCESS in 8m 57s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/db859ff4e1f4465b84b50ae3de36a635 : SUCCESS in 35m 03s","accounts_in_message":[],"_revision_number":3},{"id":"6f34c6fb858509b877c2bf579f37c64ac840bd51","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2020-02-13 11:19:31.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"5b15826c7db4b0b7bb305443b1dd16ac409b5f96","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-03-15 10:24:05.000000000","message":"Patch Set 3:\n\nDo you still want this? From your comments I\u0027m not sure whether to approve or abandon.","accounts_in_message":[],"_revision_number":3},{"id":"18a561d8c4cfdd0c3aad926a985c9ccd05d223e4","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-03-15 18:46:22.000000000","message":"Patch Set 3:\n\n\u003e Do you still want this? From your comments I\u0027m not sure whether to\n \u003e approve or abandon.\n\nNot sure. There is still a race condition with how serial numbers are updated, and it’s possible this fixes it. But it’s been real difficult to reproduce.","accounts_in_message":[],"_revision_number":3},{"id":"16cc7565214bc05b69188c5983ee08bf5b10e10a","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-03-15 20:39:32.000000000","message":"Patch Set 3:\n\n\u003e \u003e Do you still want this? From your comments I\u0027m not sure whether\n \u003e to\n \u003e \u003e approve or abandon.\n \u003e \n \u003e Not sure. There is still a race condition with how serial numbers\n \u003e are updated, and it’s possible this fixes it. But it’s been real\n \u003e difficult to reproduce.\n\ntl;dr probably worth merging","accounts_in_message":[],"_revision_number":3},{"id":"97b553511ff9727fb46638cf4b82894ecadd84bd","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-03-16 02:46:15.000000000","message":"Patch Set 4: Patch Set 3 was rebased","accounts_in_message":[],"_revision_number":4},{"id":"2e7db7bc58ba8fef346515aeeb353396a10a911c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-16 03:52:31.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/9f192b0ff26e4103a525bbf77dd121d0 : SUCCESS in 38m 19s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/6ac5c31d54b046d3a0edcf94ed8e9a0f : SUCCESS in 57m 12s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/843ed6b1df1d4475bdf7a4dd29d897e8 : SUCCESS in 1h 00m 36s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/ac28c87f70f24bbcaf51d699f634eae7 : SUCCESS in 41m 25s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/bfac8409486f46f2bfc5212f0253e243 : SUCCESS in 42m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b92f1d4c906b4cbca67e80ca1a267a90 : SUCCESS in 5m 30s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c706fab5f1da43c7aeaae0f55bf0c1b0 : SUCCESS in 4m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0d0fdab1b33b4912b074bb9ccf2b947c : SUCCESS in 4m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f2790e0d0c14499aac9c11e6a60b0982 : SUCCESS in 6m 18s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/853f754633094a6daea4a8601dffcaab : SUCCESS in 5m 52s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5fe7421fbb284fb18bf94147ef31ab0a : SUCCESS in 4m 09s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6328a48117f0420688e8876d87b9b504 : SUCCESS in 8m 34s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/6c560a0b646449fdb9abdeb63caa57b1 : SUCCESS in 36m 11s","accounts_in_message":[],"_revision_number":4},{"id":"16a3565d04ccfc43074b18fdd0906d88107e48a1","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-04-13 22:28:27.000000000","message":"Abandoned\n\nI am going to abandon this for now. I believe the sink patch and the coordination patch for central should be enough to permanently prevent this issue.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"7363cdb5736d5718301ece5ddf27020945287a90","revisions":{"881d0890a9f263a0de2cf74c268bd5c5ca3197ab":{"kind":"REWORK","_number":1,"created":"2019-12-21 20:21:11.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/83/700283/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/83/700283/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/83/700283/1"}}},"commit":{"parents":[{"commit":"8fee76623e113f8a76af14b9515b968367c0c1fc","subject":"Don\u0027t use hasattr to lazy-load properties","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/8fee76623e113f8a76af14b9515b968367c0c1fc"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-12-21 20:14:12.000000000","tz":-480},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-12-21 20:18:09.000000000","tz":-480},"subject":"Resolve potential race condition when updating zone","message":"Resolve potential race condition when updating zone\n\nWhen there are two or more changes in flight for a zone\nit\u0027s possible that the first or second request\nwill finish before the other requests gets handled\nby the worker. This will lead to the request failing\non the worker as an UPDATE request had already been handled.\n\nThe problem here is that while the UPDATE request\nmay have been handled, there is no way of knowing\nif it was the first or second request that was\nhandled.\n\nChange-Id: Ie9863dc1fbdbcc24c2baa73f8768c47985afcd09\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/881d0890a9f263a0de2cf74c268bd5c5ca3197ab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/881d0890a9f263a0de2cf74c268bd5c5ca3197ab"}]},"branch":"refs/heads/master"},"6d0b7f7a369b14a9e06848adcba57b18b017f267":{"kind":"REWORK","_number":2,"created":"2019-12-21 20:34:53.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/83/700283/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/83/700283/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/83/700283/2"}}},"commit":{"parents":[{"commit":"8fee76623e113f8a76af14b9515b968367c0c1fc","subject":"Don\u0027t use hasattr to lazy-load properties","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/8fee76623e113f8a76af14b9515b968367c0c1fc"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-12-21 20:14:12.000000000","tz":-480},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-12-21 20:34:19.000000000","tz":-480},"subject":"Resolve potential race condition when updating zone","message":"Resolve potential race condition when updating zone\n\nWhen there are two or more changes in flight for a zone\nit\u0027s possible that the first request will finish before\nthe second requests gets handled.\n\nThe problem here is that while the UPDATE request\nmay have been handled, there is no way of knowing\nif it was the second request that was handled\nsuccessfully.\n\nThis patch changes UPDATES on the worker to always\nbe honored. Worst case we will be updating the same\nsame zone twice.\n\nPartial-Bug: #1768618\nChange-Id: Ie9863dc1fbdbcc24c2baa73f8768c47985afcd09\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/6d0b7f7a369b14a9e06848adcba57b18b017f267"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/6d0b7f7a369b14a9e06848adcba57b18b017f267"}]},"branch":"refs/heads/master"},"f4e0a1b89e5785d92028e2bbf137576489ef5397":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2020-01-16 18:55:15.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/83/700283/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/83/700283/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/83/700283/3"}}},"commit":{"parents":[{"commit":"f355aae93955b76df9ea9ef5554b451df0ac91b4","subject":"Merge \"Improve sink recordset creation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/f355aae93955b76df9ea9ef5554b451df0ac91b4"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-12-21 20:14:12.000000000","tz":-480},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2020-01-16 18:55:15.000000000","tz":0},"subject":"Resolve potential race condition when updating zone","message":"Resolve potential race condition when updating zone\n\nWhen there are two or more changes in flight for a zone\nit\u0027s possible that the first request will finish before\nthe second requests gets handled.\n\nThe problem here is that while the UPDATE request\nmay have been handled, there is no way of knowing\nif it was the second request that was handled\nsuccessfully.\n\nThis patch changes UPDATES on the worker to always\nbe honored. Worst case we will be updating the same\nsame zone twice.\n\nPartial-Bug: #1768618\nChange-Id: Ie9863dc1fbdbcc24c2baa73f8768c47985afcd09\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/f4e0a1b89e5785d92028e2bbf137576489ef5397"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/f4e0a1b89e5785d92028e2bbf137576489ef5397"}]},"branch":"refs/heads/master"},"7363cdb5736d5718301ece5ddf27020945287a90":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2020-03-16 02:46:15.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/83/700283/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/83/700283/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/83/700283/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/83/700283/4"}}},"commit":{"parents":[{"commit":"dd359ba38dc74868379f445983185a870a54cc55","subject":"Merge \"Fix issue with neutron_api tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/dd359ba38dc74868379f445983185a870a54cc55"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-12-21 20:14:12.000000000","tz":-480},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2020-03-16 02:46:15.000000000","tz":0},"subject":"Resolve potential race condition when updating zone","message":"Resolve potential race condition when updating zone\n\nWhen there are two or more changes in flight for a zone\nit\u0027s possible that the first request will finish before\nthe second requests gets handled.\n\nThe problem here is that while the UPDATE request\nmay have been handled, there is no way of knowing\nif it was the second request that was handled\nsuccessfully.\n\nThis patch changes UPDATES on the worker to always\nbe honored. Worst case we will be updating the same\nsame zone twice.\n\nPartial-Bug: #1768618\nChange-Id: Ie9863dc1fbdbcc24c2baa73f8768c47985afcd09\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7363cdb5736d5718301ece5ddf27020945287a90"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7363cdb5736d5718301ece5ddf27020945287a90"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}