)]}'
{"id":"openstack%2Fdesignate~705278","triplet_id":"openstack%2Fdesignate~stable%2Ftrain~Ida918a2d670a69cc8995983d23e5424bd48de8a9","project":"openstack/designate","branch":"stable/train","hashtags":[],"change_id":"Ida918a2d670a69cc8995983d23e5424bd48de8a9","subject":"Fixing services getting stuck on shutdown","status":"MERGED","created":"2020-01-31 19:05:06.000000000","updated":"2020-02-12 19:19:36.000000000","submitted":"2020-02-12 19:17:57.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"705278-1581535077170-b4850ae3","meta_rev_id":"d814a2d51f8b5f36d402f019b819918e2987518e","_number":705278,"virtual_id_number":705278,"owner":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-12 19:17:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":2,"date":"2020-02-12 16:40:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":2,"date":"2020-02-11 09:38:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":1,"date":"2020-02-12 16:40:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-02-10 18:06:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-11 09:38:01.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2020-02-12 16:40:01.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"},{"updated":"2020-02-12 19:17:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ea1d53b4a85020da698741b9c01c0d7b596284fd","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-01-31 19:05:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"696adbc75438b960ce875c0940e748668a543a7c","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-01-31 19:05:30.000000000","message":"Patch Set 1: Review-Priority+2","accounts_in_message":[],"_revision_number":1},{"id":"16fd2ad5c47d16d7e3991f0d1604b3b19800dc61","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-31 20:20:14.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/8f698828504542049fe330e8bbe6aca2 : SUCCESS in 48m 28s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/84f1865c49e14374b59e798443236d2c : SUCCESS in 50m 25s\n- designate-bind9-py27 https://zuul.opendev.org/t/openstack/build/8bf68e0736cc4e2a8b9f4a52c4837f3a : FAILURE in 51m 58s\n- designate-pdns4-py27 https://zuul.opendev.org/t/openstack/build/fecf67512d77476bb2f3e1a451fab5b8 : FAILURE in 56m 09s\n- designate-pdns4-postgres https://zuul.opendev.org/t/openstack/build/b5017cda882740898a5e61ee951ba363 : FAILURE in 38m 11s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/f3487f9eab5a4e23b0701b621587151a : FAILURE in 1h 11m 17s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/67bd682db1b24feb8e86f3313b2ea1f7 : SUCCESS in 49m 24s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/8c53872ba6c64cc4a08dd34a3957b2ae : SUCCESS in 56m 48s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/78efe81d1a2246fa8ab743904b736a94 : SUCCESS in 7m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b7958a684f58401f81b341a5c1cdfc1b : SUCCESS in 5m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e87683749536422da70b097e696f6df7 : SUCCESS in 4m 49s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7cbf15378cda4469b35f22910af6bbcc : SUCCESS in 6m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f18ba7afa7934e18baa0d50c1784f7d7 : SUCCESS in 6m 02s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e6361c402bc641ee80b6b7f3354bb8c4 : SUCCESS in 6m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cf38295dd1e44065a1d57d136028c55b : SUCCESS in 8m 38s\n- neutron-tempest-plugin-designate-scenario-train https://zuul.opendev.org/t/openstack/build/ff606bf17b0f455f9e2ae2726bd9376f : SUCCESS in 39m 00s","accounts_in_message":[],"_revision_number":1},{"id":"a2a0b4cf8e70dc27b8a5804b0ffcd3a7ea72ac91","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-02-10 18:06:00.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"b4211e21ed91d674064b29bf8a30874c536400a6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 19:22:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/7ba78144ef8c48d589fdcb7feb57bd6f : SUCCESS in 46m 12s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/121dd4cce2864eb7be424e732ffc9727 : SUCCESS in 50m 03s\n- designate-bind9-py27 https://zuul.opendev.org/t/openstack/build/d07935ad964f40219aa7a1bbe945393a : SUCCESS in 46m 42s\n- designate-pdns4-py27 https://zuul.opendev.org/t/openstack/build/e49a7a1b1e7c4b52bc996be6eee1e0c0 : SUCCESS in 40m 19s\n- designate-pdns4-postgres https://zuul.opendev.org/t/openstack/build/813e35eb76ea4234a874eadd7a2e42cc : FAILURE in 37m 33s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/52a523750b1e42e1be34669fc864259b : SUCCESS in 1h 05m 52s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/8af8aecfe8484aedbad24c57243cadd4 : SUCCESS in 46m 29s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/af5501c072c84aa9867b2cd374cdc640 : SUCCESS in 42m 04s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6e3995e339eb483f8607bbb1b8ae2186 : SUCCESS in 7m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0ca2f48bb0624ac285d3caeeefafdf26 : SUCCESS in 6m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a7d75dd049db46b2b9b33f1be7ecdb46 : SUCCESS in 6m 11s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2ea68f3675d5443084be307a34c1b4ce : SUCCESS in 6m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/208393435eb846d08317fbf45ce2b0e9 : SUCCESS in 7m 30s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d51c9c15364146d292064b87fe2f4519 : SUCCESS in 7m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a39fbca4a02f4ac1873e40a94958e02d : SUCCESS in 8m 40s\n- neutron-tempest-plugin-designate-scenario-train https://zuul.opendev.org/t/openstack/build/756b8575a2624d8183952eba8c5bd128 : SUCCESS in 47m 14s","accounts_in_message":[],"_revision_number":2},{"id":"76eea2981c9518d690d0eaa1a21e2d9b0d756af2","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-02-11 09:38:01.000000000","message":"Patch Set 2: Code-Review+2\n\nClean backport except for designate/api/wsgi.py which was added only recently in master","accounts_in_message":[],"_revision_number":2},{"id":"a8e9df71f335532ea72e3253aa3752e95574ee2f","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2020-02-12 16:40:01.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"217bbe80b55496d6a6bd0b0e134698f7426b2851","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-12 16:40:15.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9aa7fce33bb0544058806f044a3633215ea251ed","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-12 19:17:56.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/268cb4d180694654a92d32e849ae4662 : SUCCESS in 42m 51s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/25209ad542bf4b9ab2dc606a514a9b7e : SUCCESS in 42m 58s\n- designate-bind9-py27 https://zuul.opendev.org/t/openstack/build/62b19c17bd794e1b9d36018b4b10d6c2 : SUCCESS in 46m 17s\n- designate-pdns4-py27 https://zuul.opendev.org/t/openstack/build/2e79331bd6d74a5782d75a2efa08ae7f : SUCCESS in 41m 25s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/cd48162f3b544de1b73bbb91d34d4415 : SUCCESS in 1h 06m 49s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/cec61ced1c0a4daca8aa462b94672ed0 : SUCCESS in 43m 51s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/1ba36e0247d049b2bc54c8cb23d5223a : SUCCESS in 46m 34s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/edbe8210f5a547b58cdf77926a3f4211 : SUCCESS in 5m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/66f98be8c6aa46f6aa4857885cb7a978 : SUCCESS in 5m 45s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/ee211af7415e4f6b86337bee0ea5c003 : SUCCESS in 7m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8950b6702fd44118ae442351305eba96 : SUCCESS in 5m 58s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ce6c56ab553e4993b0b602333b7285d7 : SUCCESS in 6m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/73281311984540d5af0c94f080b92387 : SUCCESS in 9m 36s","accounts_in_message":[],"_revision_number":2},{"id":"9539c88f450028654b78e1882727b3a4d4642d74","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-12 19:17:57.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"d814a2d51f8b5f36d402f019b819918e2987518e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-12 19:19:36.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/395f6e7420cf41b6a2bc550ff11309f8 : SUCCESS in 1m 21s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7600620be8a2dd6b014ebd3d9891393f8b2ea7e7","revisions":{"5a0f25fee012d3a89797758a0a17bbbf1705e26f":{"kind":"REWORK","_number":1,"created":"2020-01-31 19:05:06.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/78/705278/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/78/705278/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/78/705278/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/78/705278/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/78/705278/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/78/705278/1"}}},"commit":{"parents":[{"commit":"4871561dd05b084e72042ef6bfeeaab8b5f3212b","subject":"Use stable branch scenario job","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/4871561dd05b084e72042ef6bfeeaab8b5f3212b"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-12-23 08:23:39.000000000","tz":-480},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2020-01-31 19:04:51.000000000","tz":-480},"subject":"Fixing services getting stuck on shutdown","message":"Fixing services getting stuck on shutdown\n\nThe new heartbeat code was causing the service to\nnot exit properly. This patch removes the use of a\nthread group for handling heartbeats and replaces\nit with a FixedIntervalLoopingCall instead.\n\nCloses-Bug: #1857476\nChange-Id: Ida918a2d670a69cc8995983d23e5424bd48de8a9\n(cherry picked from commit 136a9f79fafaf94d18b81618943c0f73b38bfdfe)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/5a0f25fee012d3a89797758a0a17bbbf1705e26f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/5a0f25fee012d3a89797758a0a17bbbf1705e26f"}]},"branch":"refs/heads/stable/train"},"7600620be8a2dd6b014ebd3d9891393f8b2ea7e7":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-02-10 18:06:00.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/78/705278/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/78/705278/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/78/705278/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/78/705278/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/78/705278/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/78/705278/2"}}},"commit":{"parents":[{"commit":"2c20d109423f350145b4c4c77b364f79e9e0c0a8","subject":"Remove unused legacy playbooks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/2c20d109423f350145b4c4c77b364f79e9e0c0a8"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-12-23 08:23:39.000000000","tz":-480},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2020-02-10 18:06:00.000000000","tz":0},"subject":"Fixing services getting stuck on shutdown","message":"Fixing services getting stuck on shutdown\n\nThe new heartbeat code was causing the service to\nnot exit properly. This patch removes the use of a\nthread group for handling heartbeats and replaces\nit with a FixedIntervalLoopingCall instead.\n\nCloses-Bug: #1857476\nChange-Id: Ida918a2d670a69cc8995983d23e5424bd48de8a9\n(cherry picked from commit 136a9f79fafaf94d18b81618943c0f73b38bfdfe)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7600620be8a2dd6b014ebd3d9891393f8b2ea7e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7600620be8a2dd6b014ebd3d9891393f8b2ea7e7"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}