)]}'
{"designate/network_api/neutron.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"03b3d5bbf2d4879e1dfd369e484d0622c524628e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    project_id\u003dcontext.project_id"},{"line_number":78,"context_line":"                ) for endpoint, region in endpoints"},{"line_number":79,"context_line":"            ]"},{"line_number":80,"context_line":"            for future in concurrent.futures.as_completed(executors):"},{"line_number":81,"context_line":"                try:"},{"line_number":82,"context_line":"                    floating_ips.extend(future.result())"},{"line_number":83,"context_line":"                except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_ca579126","line":80,"updated":"2020-03-12 08:59:57.000000000","message":"I\u0027ve been looking at https://docs.python.org/dev/library/concurrent.futures.html#concurrent.futures.as_completed to check whether this would need to be amended. While it seems to be o.k. as it stands, I\u0027m wondering whether we\u0027d want to introduce some timeout here. Or is there some inherent timeout in the list_floatingips() call already?","commit_id":"4916fe115fea151b36f6d63d45ea1dbe8e7a003f"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"4028699af447af64a6117749e148169488a5dae0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    project_id\u003dcontext.project_id"},{"line_number":78,"context_line":"                ) for endpoint, region in endpoints"},{"line_number":79,"context_line":"            ]"},{"line_number":80,"context_line":"            for future in concurrent.futures.as_completed(executors):"},{"line_number":81,"context_line":"                try:"},{"line_number":82,"context_line":"                    floating_ips.extend(future.result())"},{"line_number":83,"context_line":"                except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_0a091fdc","line":80,"in_reply_to":"1fa4df85_ca579126","updated":"2020-03-12 17:06:47.000000000","message":"Yea - could be worth following up with that, but I am pretty sure requests has an inbuilt timeout.","commit_id":"4916fe115fea151b36f6d63d45ea1dbe8e7a003f"}]}