)]}'
{"designate/central/service.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4e90c115be6a8b7ea4c09464279d5484e7cd3982","unresolved":false,"context_lines":[{"line_number":59,"context_line":"NOTIFICATION_BUFFER \u003d threading.local()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def synchronized_zone(zone_arg\u003d1, new_zone\u003dFalse):"},{"line_number":63,"context_line":"    \"\"\"Ensures only a single operation is in progress for each zone"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    A Decorator which ensures only a single operation can be happening"},{"line_number":66,"context_line":"    on a single zone at once, within the current designate-central instance"},{"line_number":67,"context_line":"    \"\"\""},{"line_number":68,"context_line":"    def outer(f):"},{"line_number":69,"context_line":"        @functools.wraps(f)"},{"line_number":70,"context_line":"        def sync_wrapper(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_b947d8bc","line":67,"range":{"start_line":62,"start_character":0,"end_line":67,"end_character":7},"updated":"2020-04-07 06:28:52.000000000","message":"Maybe we\u0027d need to make this a global sync instead of per instance?","commit_id":"109d3705862c0afce0e777e08028438316d87678"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"dfd568ca224f9380895f48d3a8b5f876a3b3fb07","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        \"\"\"Update the zone serial and the SOA record"},{"line_number":482,"context_line":"        Optionally set delayed_notify to have PM issue delayed notify"},{"line_number":483,"context_line":"        \"\"\""},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        # Increment the serial number"},{"line_number":486,"context_line":"        zone.serial \u003d utils.increment_serial(zone.serial)"},{"line_number":487,"context_line":"        if set_delayed_notify:"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_b39b7064","side":"PARENT","line":484,"updated":"2020-04-07 11:46:35.000000000","message":"unrelated?","commit_id":"65736672da70cea9fc795c5f4c0d9a195f852ce8"}],"designate/coordination.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"dfd568ca224f9380895f48d3a8b5f876a3b3fb07","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_lock(self, name):"},{"line_number":56,"context_line":"        if self._coordinator:"},{"line_number":57,"context_line":"            return self._coordinator.get_lock(name)"},{"line_number":58,"context_line":"        return lockutils.lock(name)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_6e39fba1","line":57,"updated":"2020-04-07 11:46:35.000000000","message":"Seems we need to convert str to bytes for this? Or should the library handle it?\n\nhttps://zuul.opendev.org/t/openstack/build/1afd6452934b43779914837c6f38aa87/log/controller/logs/screen-designate-central.txt#369-392","commit_id":"4dbb29b9dbecaaaa297428b885c6e63c844b8db3"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e5cd93fc1594681eab87d5fdd89a7a8efb5846dd","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_lock(self, name):"},{"line_number":56,"context_line":"        if self._coordinator:"},{"line_number":57,"context_line":"            return self._coordinator.get_lock(name)"},{"line_number":58,"context_line":"        return lockutils.lock(name)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_ad4f7fbc","line":57,"in_reply_to":"df33271e_6e39fba1","updated":"2020-04-07 17:59:23.000000000","message":"We should probably handle it. My local test env is still running Python 2.7 (Train). So I didn\u0027t catch it there.","commit_id":"4dbb29b9dbecaaaa297428b885c6e63c844b8db3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"76174fc554887e211fbdee0bf7119e3d9637f7cd","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_lock(self, name):"},{"line_number":56,"context_line":"        if self._coordinator:"},{"line_number":57,"context_line":"            return self._coordinator.get_lock(name.encode())"},{"line_number":58,"context_line":"        return lockutils.lock(name)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"df33271e_3ea2694c","line":57,"updated":"2020-04-08 06:57:03.000000000","message":"tooz is trying to encode most other names it receives by itself, see https://github.com/openstack/tooz/blob/master/tooz/drivers/memcached.py#L304-L311\n\nso I think that this could actually be considered a bug in the tooz memcached driver that the encode() is needed here. we should likely mark this as workaround and try to get it fixed over there","commit_id":"99890220dc165a9dc10a9fed6faf49ab25352d97"}],"requirements.txt":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"73985fa5daedabbb5aecddd51ab2ccc299248a84","unresolved":false,"context_lines":[{"line_number":50,"context_line":"monasca-statsd\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":51,"context_line":"futurist\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":52,"context_line":"edgegrid-python\u003e\u003d1.1.1 # Apache-2.0"},{"line_number":53,"context_line":"pymemcache!\u003d1.3.0,\u003e\u003d1.2.9 # Apache 2.0 License"}],"source_content_type":"text/plain","patch_set":7,"id":"df33271e_c26c600a","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":10},"updated":"2020-04-07 09:50:40.000000000","message":"is this to add the atomic lock? There are multiple backends (memcached, Zookeeper, etcd) that can do it.","commit_id":"4dbb29b9dbecaaaa297428b885c6e63c844b8db3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"dfd568ca224f9380895f48d3a8b5f876a3b3fb07","unresolved":false,"context_lines":[{"line_number":50,"context_line":"monasca-statsd\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":51,"context_line":"futurist\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":52,"context_line":"edgegrid-python\u003e\u003d1.1.1 # Apache-2.0"},{"line_number":53,"context_line":"pymemcache!\u003d1.3.0,\u003e\u003d1.2.9 # Apache 2.0 License"}],"source_content_type":"text/plain","patch_set":7,"id":"df33271e_ae430313","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":10},"in_reply_to":"df33271e_c26c600a","updated":"2020-04-07 11:46:35.000000000","message":"If this is missing for the deployment our devstack plugin produces, we should rather add it there, yes.","commit_id":"4dbb29b9dbecaaaa297428b885c6e63c844b8db3"}],"test-requirements.txt":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e2cf203dcdd1a30b1ada03f529df8ae3d965e627","unresolved":false,"context_lines":[{"line_number":18,"context_line":"bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":19,"context_line":"zake\u003e\u003d0.1.6 # Apache-2.0"},{"line_number":20,"context_line":"doc8\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":21,"context_line":"Pygments\u003e\u003d2.2.0 # BSD license"}],"source_content_type":"text/plain","patch_set":3,"id":"df33271e_39abc71d","line":21,"updated":"2020-04-07 07:38:34.000000000","message":"pep8:  D005 No newline at end of file","commit_id":"109d3705862c0afce0e777e08028438316d87678"}]}