)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"c914929d52b4041573d998f64b1060f6567877c1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding the option to set the zone quota to unlimited"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"by assigning negative value for the resource like -1"},{"line_number":10,"context_line":"Closes-Bug: #1876198"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iaeca2be8b38075e3e7e8f79621b4b41cbe9934f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ff570b3c_193eee28","line":10,"updated":"2020-05-11 18:22:58.000000000","message":"Could you add an empty line here?","commit_id":"e6b29a4d70e4e508ccc0cdb67dfb860ddff0d1b1"}],"designate/quota/base.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f4e47d40a201bf4fee12471a1462274c023c35eb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            if resource in quotas:"},{"line_number":36,"context_line":"                # Setting the resource quota to negative value will make"},{"line_number":37,"context_line":"                # the resource unlimited"},{"line_number":38,"context_line":"                if quotas[resource] \u003e 0 and value \u003e\u003d quotas[resource]:"},{"line_number":39,"context_line":"                    raise exceptions.OverQuota()"},{"line_number":40,"context_line":"            else:"},{"line_number":41,"context_line":"                raise exceptions.QuotaResourceUnknown(\"%s is not a valid quota\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_a282304e","line":38,"range":{"start_line":38,"start_character":36,"end_line":38,"end_character":37},"updated":"2020-05-11 12:41:57.000000000","message":"Shouldn\u0027t this be \"\u003e\u003d\"? Currently you are also ignoring a quota that is \u003d\u003d 0. Seems we are also lacking a test for that situation.","commit_id":"532f403f8a543b10df260059ff56a12ca41a0004"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"8a04bf92c9a0b50757cb77875a05f855fd33cf72","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            if resource in quotas:"},{"line_number":36,"context_line":"                # Setting the resource quota to negative value will make"},{"line_number":37,"context_line":"                # the resource unlimited"},{"line_number":38,"context_line":"                if quotas[resource] \u003e 0 and value \u003e\u003d quotas[resource]:"},{"line_number":39,"context_line":"                    raise exceptions.OverQuota()"},{"line_number":40,"context_line":"            else:"},{"line_number":41,"context_line":"                raise exceptions.QuotaResourceUnknown(\"%s is not a valid quota\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_a3898f27","line":38,"range":{"start_line":38,"start_character":36,"end_line":38,"end_character":37},"in_reply_to":"ff570b3c_a282304e","updated":"2020-05-11 16:36:24.000000000","message":"yeah it should be","commit_id":"532f403f8a543b10df260059ff56a12ca41a0004"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"c914929d52b4041573d998f64b1060f6567877c1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            if resource in quotas:"},{"line_number":36,"context_line":"                # Setting the resource quota to negative value will make"},{"line_number":37,"context_line":"                # the resource unlimited"},{"line_number":38,"context_line":"                if quotas[resource] \u003e\u003d 0 and value \u003e\u003d quotas[resource]:"},{"line_number":39,"context_line":"                    raise exceptions.OverQuota()"},{"line_number":40,"context_line":"            else:"},{"line_number":41,"context_line":"                raise exceptions.QuotaResourceUnknown(\"%s is not a valid quota\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_f9685a22","line":38,"updated":"2020-05-11 18:22:58.000000000","message":"Could you address Jens\u0027 comment regarding quotas \u003c -1?","commit_id":"e6b29a4d70e4e508ccc0cdb67dfb860ddff0d1b1"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"0a1fd5f173255eee400509efe1c53d6843454468","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            if resource in quotas:"},{"line_number":36,"context_line":"                # Setting the resource quota to negative value will make"},{"line_number":37,"context_line":"                # the resource unlimited"},{"line_number":38,"context_line":"                if quotas[resource] \u003e\u003d 0 and value \u003e\u003d quotas[resource]:"},{"line_number":39,"context_line":"                    raise exceptions.OverQuota()"},{"line_number":40,"context_line":"            else:"},{"line_number":41,"context_line":"                raise exceptions.QuotaResourceUnknown(\"%s is not a valid quota\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_b4b6e7d8","line":38,"in_reply_to":"ff570b3c_f9685a22","updated":"2020-05-11 19:17:41.000000000","message":"i agree with him, but when u think about its because -2 quota does not mean anything it should be considered as one logic value which it in this case unlimited","commit_id":"e6b29a4d70e4e508ccc0cdb67dfb860ddff0d1b1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c08788d52b364c4b9a93c63ba54f8b0c256d8c69","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        for resource, value in values.items():"},{"line_number":35,"context_line":"            if resource in quotas:"},{"line_number":36,"context_line":"                # Setting the resource quota to negative value will make"},{"line_number":37,"context_line":"                # the resource unlimited"},{"line_number":38,"context_line":"                if quotas[resource] \u003e\u003d 0 and value \u003e\u003d quotas[resource]:"},{"line_number":39,"context_line":"                    raise exceptions.OverQuota()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_73f0dbca","line":36,"range":{"start_line":36,"start_character":45,"end_line":36,"end_character":56},"updated":"2020-05-12 07:14:55.000000000","message":"nit: \"... to a negative ...\"","commit_id":"f82e60fd063dcdc1260fdb7908b773ecf3b3a97e"}],"designate/tests/test_quota/test_quota.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c08788d52b364c4b9a93c63ba54f8b0c256d8c69","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        }"},{"line_number":120,"context_line":"        self.quota.get_quotas.return_value \u003d ret"},{"line_number":121,"context_line":"        with testtools.ExpectedException(exceptions.OverQuota):"},{"line_number":122,"context_line":"            self.quota.limit_check(context, \u0027tenant_id\u0027, zones\u003d99999)"},{"line_number":123,"context_line":"        with testtools.ExpectedException(exceptions.OverQuota):"},{"line_number":124,"context_line":"            self.quota.limit_check(context, \u0027tenant_id\u0027, zone_recordsets\u003d99999)"},{"line_number":125,"context_line":"        with testtools.ExpectedException(exceptions.OverQuota):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_33cf8380","line":122,"updated":"2020-05-12 07:14:55.000000000","message":"In order to verify that the limit is actually triggered, use \"zones\u003d0\" here, similarly for the following cases.","commit_id":"f82e60fd063dcdc1260fdb7908b773ecf3b3a97e"}],"doc/source/user/rest/admin/quotas.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c08788d52b364c4b9a93c63ba54f8b0c256d8c69","unresolved":false,"context_lines":[{"line_number":84,"context_line":".. http:patch:: /quotas/TENANT_ID"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    Updates the specified quota(s) to their new values."},{"line_number":87,"context_line":"    negitive quota(s) values means unlimited."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    **Example request:**"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ff570b3c_f3986b6b","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":34},"updated":"2020-05-12 07:14:55.000000000","message":"\"Negative quota values mean ...\"","commit_id":"f82e60fd063dcdc1260fdb7908b773ecf3b3a97e"}],"releasenotes/notes/zones_unlimited_quota-81a2dfba1f532c9c.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c08788d52b364c4b9a93c63ba54f8b0c256d8c69","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allowing the user to set zone quota to unlimited by assigning"},{"line_number":5,"context_line":"    negtive value to the resource quota value"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_33cb0354","line":4,"range":{"start_line":4,"start_character":29,"end_line":4,"end_character":33},"updated":"2020-05-12 07:14:55.000000000","message":"s/zone/resource/ , this applies to all values.","commit_id":"f82e60fd063dcdc1260fdb7908b773ecf3b3a97e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c08788d52b364c4b9a93c63ba54f8b0c256d8c69","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allowing the user to set zone quota to unlimited by assigning"},{"line_number":5,"context_line":"    negtive value to the resource quota value"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_f3b18be3","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":17},"updated":"2020-05-12 07:14:55.000000000","message":"\"a negative value ...\"","commit_id":"f82e60fd063dcdc1260fdb7908b773ecf3b3a97e"}]}