)]}'
{"id":"openstack%2Fdesignate~727211","triplet_id":"openstack%2Fdesignate~master~I28de0ffa68f9bff4685d81fe7b5a5d8909e2313c","project":"openstack/designate","branch":"master","topic":"fix-pep8","hashtags":[],"change_id":"I28de0ffa68f9bff4685d81fe7b5a5d8909e2313c","subject":"Fix issues with newer flake8","status":"MERGED","created":"2020-05-12 14:41:14.000000000","updated":"2020-05-12 22:08:26.000000000","submitted":"2020-05-12 22:05:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"727211-1589321132609-df443003","meta_rev_id":"7f17f380547727e21d98f50905717f393f58faee","_number":727211,"virtual_id_number":727211,"owner":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-05-12 22:05:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-05-12 19:44:46.000000000","_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"value":0,"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"value":2,"date":"2020-05-12 17:05:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":2,"date":"2020-05-12 17:11:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"value":0,"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":1,"date":"2020-05-12 17:11:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"value":0,"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":2,"date":"2020-05-12 17:11:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-12 17:05:26.000000000","updated_by":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"reviewer":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"state":"REVIEWER"},{"updated":"2020-05-12 17:11:02.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"},{"updated":"2020-05-12 19:44:46.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2020-05-12 22:05:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f2fa39c9479f0499762e4c73838cbd060d609666","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-05-12 14:41:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b0c2d5b190eb0ab1b94dc59a612dff398665c8de","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-12 15:47:05.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/51dbc7bdd6ce4edabe168cf2035fb10e : POST_FAILURE in 56m 09s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/8c3b4cffa80c4af2b01c838b1e70e44a : SUCCESS in 38m 39s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/bcdd88a9c3e845f29965ccb0872772ca : SUCCESS in 1h 00m 08s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/575e8f12312045e4b5fd9e72fff8749a : SUCCESS in 45m 31s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/ae6d1f84cf8145328252fde873e7fe76 : SUCCESS in 47m 55s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3f72a5729721434b86101f3a2eb35be3 : SUCCESS in 5m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/03ccba8433e440868398d35da0682476 : SUCCESS in 5m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/65c3c129c1954c2ca5e52494579e4c6f : SUCCESS in 4m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e0f810ed53614ef8883f1a01fecd37e3 : SUCCESS in 5m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e7d0b56394d3485892d76bb629377246 : SUCCESS in 5m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/682ea95022ee4b219b8ec887173614b2 : SUCCESS in 9m 31s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/4d73f3e16c214dad83b579c6de2a1977 : SUCCESS in 41m 42s","accounts_in_message":[],"_revision_number":1},{"id":"d5afa1709f5fc83ec77c5031a2ed34909ea3ee22","author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"date":"2020-05-12 17:05:26.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"31b33876e66817426d4e85bb7b926a558679ce87","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2020-05-12 17:11:02.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1 Review-Priority+2\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e6eeb665b9dd41cd0e24f8d43f35b2a4628c7106","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-05-12 17:44:25.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"67c22b112a23b044e9acbb3a07db78dd56c5ba38","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-12 18:18:52.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/8d60dd74412a482182c7e558aa62cc33 : SUCCESS in 47m 54s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/1928f54b17ad4a38ad94f918fc5946d7 : FAILURE in 39m 57s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/5711ddb90be44de1b50affda5a621df6 : SUCCESS in 57m 52s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/c561031f98ed47eb86b8a4561890a9c1 : SUCCESS in 47m 07s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/3325a92d8f8841f2b2c653f43fb9d963 : SUCCESS in 40m 20s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fbfd92d44994467cb1c71ad86c72e382 : SUCCESS in 5m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f3cf64d2ffcf41228ed4731aab5d6d0a : SUCCESS in 5m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bac0f0ab0f9644a38c1394bf86601ec1 : SUCCESS in 4m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6eec2a706fdd4848be7f008f26a1a38a : SUCCESS in 5m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6b75cce7ac1d4a3eadcb2e166952c471 : SUCCESS in 5m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/42a1bc8c38e0429bb78ed16a98d57bb4 : SUCCESS in 8m 12s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/d8cc92898268438dacfaf543467321e3 : SUCCESS in 36m 06s","accounts_in_message":[],"_revision_number":1},{"id":"2e235ed06a63a910f74d80742ff41ed2664f1b93","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-05-12 19:44:46.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"eac0a8ffb2e12d6ace7a0b0bb5c4b12f402010fa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-12 20:53:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/46afa99da5d0475696794b51d9890a34 : SUCCESS in 40m 21s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/e904976151324cddad07c38c79a63631 : SUCCESS in 41m 31s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/9dd62caf59db4f27ae13c9593ba83a1c : SUCCESS in 58m 49s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/2a14066ca2a643b79aefa5e2e79df5e3 : SUCCESS in 41m 55s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/0e135f0a29c74dc4bf3c9c3262a44919 : SUCCESS in 39m 38s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/728f453a1a6d44c3bf8bf729aef137ed : SUCCESS in 10m 53s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6e3a7764a7834b678b88ff8bfbc7cbbc : SUCCESS in 10m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4f23aa626e604a19854bdf452164fcc6 : SUCCESS in 6m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/92b8fbed5def4d7eb3d3df9db1d3c243 : SUCCESS in 7m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/28be1e754fb244788911b0f9f6cbe8d2 : SUCCESS in 9m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4e141bd9eafc435f8d115ce0196df192 : SUCCESS in 9m 05s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/9a3c0775bd8249df97569284d1d46ec0 : SUCCESS in 35m 50s","accounts_in_message":[],"_revision_number":1},{"id":"62d7d76d564f6119a192a43b83b0c8a80dd3a0fc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-12 20:53:28.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e59eec8379ab85c31673d68296a2325938c2ecba","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-12 22:05:32.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"9397b1f658fae6b3e431e25ea671c3674c6467a5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-12 22:05:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/695ca536c29a40d0919614e3733abfb3 : SUCCESS in 40m 52s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/9a3af12e35364a9abb581080668c9d0c : SUCCESS in 44m 08s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/df0f64f110804f6fa09144e1e5cd31b3 : SUCCESS in 1h 05m 07s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/3bf75ffb61104a45bc591466bea334c0 : SUCCESS in 43m 05s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/4bfc49b17e714121943ac27183dbb651 : SUCCESS in 44m 24s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/797ec75ff6ad4c858bd0b064619ea4b6 : SUCCESS in 5m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/166b9be80b4448f28149137f47fe76ad : SUCCESS in 6m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f0d464d75c81493d883aaf1f67fbc87c : SUCCESS in 8m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/edd016a5591f44a4a5505f2f5477fe75 : SUCCESS in 5m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/430dca18681a490ab914b382b4fe9814 : SUCCESS in 11m 05s","accounts_in_message":[],"_revision_number":1},{"id":"1d7aaddcef77302e4d7be9cac1af44a1fd083f17","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-12 22:08:26.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/01ffc2f149d14fcaa16b462011821c45 : SUCCESS in 2m 25s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"31884f77d548371d14cd789f82b85ceefb525a0e","revisions":{"31884f77d548371d14cd789f82b85ceefb525a0e":{"kind":"REWORK","_number":1,"created":"2020-05-12 14:41:14.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/11/727211/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/11/727211/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/11/727211/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/11/727211/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/11/727211/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/11/727211/1"}}},"commit":{"parents":[{"commit":"814cc0aa5157112da36af8d13c1bb2b5605bc02b","subject":"Merge \"Add Python3 victoria unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/814cc0aa5157112da36af8d13c1bb2b5605bc02b"}]}],"author":{"name":"Dr. Jens Harbott","email":"j.harbott@x-ion.de","date":"2020-05-12 14:39:03.000000000","tz":0},"committer":{"name":"Dr. Jens Harbott","email":"j.harbott@x-ion.de","date":"2020-05-12 14:39:03.000000000","tz":0},"subject":"Fix issues with newer flake8","message":"Fix issues with newer flake8\n\nThe updated flake8 seems to have fixed a check for .format() issues that\ndiscovered a bug in one of our tests, which is fixed here.\n\nAlso get rid of using \"l\" as a variable name and tag the imports that\nneed to stay in order after setting an environment variable.\n\nChange-Id: I28de0ffa68f9bff4685d81fe7b5a5d8909e2313c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/31884f77d548371d14cd789f82b85ceefb525a0e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/31884f77d548371d14cd789f82b85ceefb525a0e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}