)]}'
{"id":"openstack%2Fdesignate~728641","triplet_id":"openstack%2Fdesignate~master~I8f24431db0ec88385b4b916e181d6da3e598c764","project":"openstack/designate","branch":"master","topic":"add-healthcheck-url","hashtags":[],"change_id":"I8f24431db0ec88385b4b916e181d6da3e598c764","subject":"Add a /healthcheck middleware","status":"MERGED","created":"2020-05-16 15:34:35.000000000","updated":"2020-07-28 01:06:02.000000000","submitted":"2020-07-28 01:03:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"728641-1595898222848-be75a880","meta_rev_id":"d2150065cf7f1fb844489d6c844e6dd5897d9f2c","_number":728641,"virtual_id_number":728641,"owner":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-28 01:03:42.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"all":[{"value":2,"date":"2020-07-26 13:13:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-07-28 00:53:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-07-28 00:53:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-26 13:13:21.000000000","updated_by":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"reviewer":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"state":"REVIEWER"},{"updated":"2020-07-28 00:53:17.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2020-07-28 01:03:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b88480d1679a5bdae3ea36b0ce3ee731664ff9d4","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2020-05-16 15:34:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"48374dee26ec391eecd71cf10e3b80b54550c00c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-16 16:06:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d8b0414997264fa588fc449f5716d97a : SUCCESS in 6m 26s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9c5f529a11324f849da10f9ca6f39aab : SUCCESS in 4m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/37c01bf10df54b6d97623afbbccd49bc : SUCCESS in 4m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5fb4492028de413fa9c204871f7f8e0e : SUCCESS in 4m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/97530c1ae77b476e8ff95081f33212b9 : SUCCESS in 5m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d9bbb39220034393a0ca318cd62c4f5e : SUCCESS in 7m 30s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/b6ca6a15013c4bc78a7f7b875012948c : SUCCESS in 30m 46s","accounts_in_message":[],"_revision_number":1},{"id":"659e98a6215a4f756368d5b7dc74d516e78ff961","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-07-24 22:21:05.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"953b7a48b0472b4fcff895fe238d1c0de539f454","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-24 23:02:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/56736df7d56b465db0dd9a11366e9e14 : SUCCESS in 6m 36s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0057cf42641e444a914275544888ff5d : SUCCESS in 5m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/afe699c01e4c4b6fb0718b8b06f231a4 : SUCCESS in 4m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8cdc55c3df4f4121808ac0c45496b788 : SUCCESS in 5m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/725ad155b0164ab5bff2a6a4057e6832 : SUCCESS in 6m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3435abe302d5497fbbfa0b965777c0c6 : SUCCESS in 8m 48s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/f14d1b8bc6e045ddac80768e65e59fde : SUCCESS in 35m 47s","accounts_in_message":[],"_revision_number":2},{"id":"2a7987f9b8472aedd13af9cdfd5212bb0bedf38e","author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"date":"2020-07-26 13:13:21.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"d85b73917893c1e5df131f4a2d8c8f1e4699729e","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-07-28 00:53:17.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"d98ea05c0e67291bdca0b444fb07a1b82cc5995c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-28 00:53:29.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ccfada7623d82f9105a5a82f8ec2711d68e775fa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-28 01:03:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"18f9dcd298b48b71e2ca9f13261a2ecfd2539da4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-28 01:03:42.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2fa9bb3128a54b9d921163db31899baa : SUCCESS in 5m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/28b58e8cbf504e1e92b0059a6e65f361 : SUCCESS in 4m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f049f84e323f4e3590525bedcc89918f : SUCCESS in 4m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/86437d2f76b541239f9fb9af05ec41e5 : SUCCESS in 5m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/136875a6360546c1aa1aeec54658b4bc : SUCCESS in 6m 56s","accounts_in_message":[],"_revision_number":2},{"id":"b8a2fba93b90f58c83bf8ab54123f259d8e484f3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-28 01:06:02.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/093e27d1f8db4c86a1b5ef8f715bc607 : SUCCESS in 1m 54s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3321092928a91e1a6b6d8b8a4d68b809798a4492","revisions":{"5c991e94e0c80ef3fc81d69a298a2e8db8d93b2d":{"kind":"REWORK","_number":1,"created":"2020-05-16 15:34:35.000000000","uploader":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"ref":"refs/changes/41/728641/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/41/728641/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/41/728641/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/41/728641/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/41/728641/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/41/728641/1"}}},"commit":{"parents":[{"commit":"9a52ea1cdfad3d208b97cc1a3a08df558bae8d41","subject":"Merge \"Adding the option to set the zone quota to unlimited\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/9a52ea1cdfad3d208b97cc1a3a08df558bae8d41"}]}],"author":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2020-05-16 15:30:59.000000000","tz":120},"committer":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2020-05-16 15:30:59.000000000","tz":120},"subject":"Add a /healthcheck middleware","message":"Add a /healthcheck middleware\n\nThe /healthcheck URL, as provided by oslo.middleware, is very\nuseful for operators to setup haproxy and to do monitoring.\nSuch feature is already in many services like Keystone, Glance,\nand others.\n\nThe same type of patch has been approved in Neutronm, Heat, and\nCinder. It\u0027s under discussion in Nova, where they want to check\nmore than just the wsgi app, though the pricinple to add it has\nbeen accepted already.\n\nChange-Id: I8f24431db0ec88385b4b916e181d6da3e598c764\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/5c991e94e0c80ef3fc81d69a298a2e8db8d93b2d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/5c991e94e0c80ef3fc81d69a298a2e8db8d93b2d"}]},"branch":"refs/heads/master"},"3321092928a91e1a6b6d8b8a4d68b809798a4492":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-07-24 22:21:05.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/41/728641/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/41/728641/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/41/728641/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/41/728641/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/41/728641/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/41/728641/2"}}},"commit":{"parents":[{"commit":"522ab45d51d919e815946d9e4c4d86065e154f34","subject":"Merge \"Fix inspect module deprecation warning\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/522ab45d51d919e815946d9e4c4d86065e154f34"}]}],"author":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2020-05-16 15:30:59.000000000","tz":120},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2020-07-24 22:21:05.000000000","tz":0},"subject":"Add a /healthcheck middleware","message":"Add a /healthcheck middleware\n\nThe /healthcheck URL, as provided by oslo.middleware, is very\nuseful for operators to setup haproxy and to do monitoring.\nSuch feature is already in many services like Keystone, Glance,\nand others.\n\nThe same type of patch has been approved in Neutronm, Heat, and\nCinder. It\u0027s under discussion in Nova, where they want to check\nmore than just the wsgi app, though the pricinple to add it has\nbeen accepted already.\n\nChange-Id: I8f24431db0ec88385b4b916e181d6da3e598c764\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/3321092928a91e1a6b6d8b8a4d68b809798a4492"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/3321092928a91e1a6b6d8b8a4d68b809798a4492"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}