)]}'
{"designate/backend/base.py":[{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"0f8c55389e4bc518ab3e813f8e1e072261bd6fa4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        :param zone: the DNS zone."},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @abc.abstractmethod"},{"line_number":76,"context_line":"    def update_zone(self, context, zone):"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        Update a DNS zone."}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_706eea00","line":75,"updated":"2020-06-11 15:26:47.000000000","message":"Don\u0027t make this an abstractmethod and...","commit_id":"bf0f94240e5b9b1f4f5bf7bc8050d9593a1eae3a"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"0f8c55389e4bc518ab3e813f8e1e072261bd6fa4","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        :param context: Security context information."},{"line_number":81,"context_line":"        :param zone: the DNS zone."},{"line_number":82,"context_line":"        \"\"\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @abc.abstractmethod"},{"line_number":85,"context_line":"    def delete_zone(self, context, zone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_d07416d3","line":82,"updated":"2020-06-11 15:26:47.000000000","message":"... leave this code here and then call super() in the bind9 implementation.","commit_id":"bf0f94240e5b9b1f4f5bf7bc8050d9593a1eae3a"}],"designate/backend/impl_akamai.py":[{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"0f8c55389e4bc518ab3e813f8e1e072261bd6fa4","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        \"\"\"Delete a DNS zone\"\"\""},{"line_number":259,"context_line":"        self.client.deleteZone(zoneName\u003dzone[\u0027name\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def update_zone(self, context, zone):"},{"line_number":262,"context_line":"        \"\"\""},{"line_number":263,"context_line":"        Update a DNS zone."},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_304d9299","line":261,"updated":"2020-06-11 15:26:47.000000000","message":"Now you can remove this implementation.","commit_id":"bf0f94240e5b9b1f4f5bf7bc8050d9593a1eae3a"}],"designate/backend/impl_bind9.py":[{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"0f8c55389e4bc518ab3e813f8e1e072261bd6fa4","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        :param context: Security context information."},{"line_number":138,"context_line":"        :param zone: the DNS zone."},{"line_number":139,"context_line":"        \"\"\""},{"line_number":140,"context_line":"        LOG.debug(\u0027Update Zone\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        masters \u003d []"},{"line_number":143,"context_line":"        for master in self.masters:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_b06fe2f8","line":140,"updated":"2020-06-11 15:26:47.000000000","message":"Call super().update_zone(context, zone) here.","commit_id":"bf0f94240e5b9b1f4f5bf7bc8050d9593a1eae3a"},{"author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"change_message_id":"6350ddad5a14749b815360e6ebcbe72aba6059b6","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            self._execute_rndc(rndc_op)"},{"line_number":162,"context_line":"        except exceptions.Backend as e:"},{"line_number":163,"context_line":"            LOG.warning(\"Error updating zone: %s\", e)"},{"line_number":164,"context_line":"            raise"},{"line_number":165,"context_line":"        super().update_zone(context, zone)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _execute_rndc(self, rndc_op):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_0153423a","line":164,"range":{"start_line":164,"start_character":12,"end_line":164,"end_character":17},"updated":"2020-06-29 05:04:34.000000000","message":"Besides, can we skip the error here? As bind9 server with old version don\u0027t have modzone command. Is so, it will block zone update function.","commit_id":"65bed9c7142f8e91f3f6111554a62e545d6783ac"}],"designate/manage/pool.py":[{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"e6296bf612c5440c90d4c3c718c9e77cb0529ccb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        action\u003d\"store_true\","},{"line_number":95,"context_line":"        default\u003dFalse)"},{"line_number":96,"context_line":"    @base.args("},{"line_number":97,"context_line":"        \u0027--update_zones\u0027,"},{"line_number":98,"context_line":"        help\u003d\u0027Update all the zones masters if the given pool targets\u0027"},{"line_number":99,"context_line":"             \u0027masters change\u0027,"},{"line_number":100,"context_line":"        default\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_a899bcc4","line":97,"updated":"2020-06-03 22:19:00.000000000","message":"Could you change this to `--update-zones` for consistency?","commit_id":"0112307eee1432bb5345ddf2166f6de29ae5fcca"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"ff7b2a6be45b14b4815b059a3689380b81ace1b8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        default\u003dFalse)"},{"line_number":96,"context_line":"    @base.args("},{"line_number":97,"context_line":"        \u0027--update_zones\u0027,"},{"line_number":98,"context_line":"        help\u003d\u0027Update all the zones masters if the given pool targets\u0027"},{"line_number":99,"context_line":"             \u0027masters change\u0027,"},{"line_number":100,"context_line":"        default\u003dFalse)"},{"line_number":101,"context_line":"    def update(self, file, delete, dry_run, update_zones):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_a8c7fc95","line":98,"updated":"2020-06-03 22:25:00.000000000","message":"Maybe simply\n\nUpdate masters of all zones","commit_id":"0112307eee1432bb5345ddf2166f6de29ae5fcca"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"02b74f63c91ae2ea1ce59267fd01e3426341004c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        \u0027--update_zones\u0027,"},{"line_number":98,"context_line":"        help\u003d\u0027Update all the zones masters if the given pool targets\u0027"},{"line_number":99,"context_line":"             \u0027masters change\u0027,"},{"line_number":100,"context_line":"        default\u003dFalse)"},{"line_number":101,"context_line":"    def update(self, file, delete, dry_run, update_zones):"},{"line_number":102,"context_line":"        self._startup()"},{"line_number":103,"context_line":"        print(\u0027Updating Pools Configuration\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_68ca04a1","line":100,"updated":"2020-06-03 22:24:09.000000000","message":"Please add\n\naction\u003d\"store_true\"\n\nOtherwise an argument is required.","commit_id":"0112307eee1432bb5345ddf2166f6de29ae5fcca"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"97ae3903c120dfa4e040d6f0b20da3359c6b756f","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                else:"},{"line_number":148,"context_line":"                    pool \u003d self.central_api.update_pool(self.context, pool)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"                    def __get_masters_from_pool(pool):"},{"line_number":151,"context_line":"                        masters \u003d []"},{"line_number":152,"context_line":"                        for target in pool.targets:"},{"line_number":153,"context_line":"                            for master in target.get(\"masters\", []):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_e3a8dc8c","line":150,"updated":"2020-06-05 03:35:12.000000000","message":"I would just make this a function outside of update. We don\u0027t want update to get much more complex.","commit_id":"0112307eee1432bb5345ddf2166f6de29ae5fcca"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"fb9917195bd5789d81176ae427ad5a5066a7ebd1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        rpc.init(cfg.CONF)"},{"line_number":45,"context_line":"        self.central_api \u003d central_rpcapi.CentralAPI()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def update_zones(self, context, pool):"},{"line_number":48,"context_line":"        LOG.info(\"Updating zone masters for pool: {}\".format(pool.id))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def __get_masters_from_pool(pool):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_76c3a939","line":47,"updated":"2020-06-09 20:40:11.000000000","message":"Nit: Worth adding a single _ to highlight that it is a \"private\" function.","commit_id":"28aff4ae9fcd401823afb8b140a2b433c5fd5e7e"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"390f273130b3af528bc5342ed70dca172d22d11b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        rpc.init(cfg.CONF)"},{"line_number":45,"context_line":"        self.central_api \u003d central_rpcapi.CentralAPI()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _update_zones(self, context, pool):"},{"line_number":48,"context_line":"        LOG.info(\"Updating zone masters for pool: {}\".format(pool.id))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def __get_masters_from_pool(pool):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_b02082fa","line":47,"range":{"start_line":47,"start_character":28,"end_line":47,"end_character":35},"updated":"2020-06-11 15:19:18.000000000","message":"if we remove this arg, and then use `self.context` on lines 61 and 67, it should work","commit_id":"bf0f94240e5b9b1f4f5bf7bc8050d9593a1eae3a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d6ada69655c3316e4de8b28fb414939c31a7df36","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        \u0027--update-zones\u0027,"},{"line_number":121,"context_line":"        help\u003d\u0027Update masters of all zones\u0027,"},{"line_number":122,"context_line":"        action\u003d\"store_true\","},{"line_number":123,"context_line":"        default\u003dTrue)"},{"line_number":124,"context_line":"    def update(self, file, delete, dry_run, update_zones):"},{"line_number":125,"context_line":"        self._startup()"},{"line_number":126,"context_line":"        print(\u0027Updating Pools Configuration\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_b6fcfa3f","line":123,"updated":"2020-06-11 16:59:06.000000000","message":"store_true with default\u003dtrue doesn\u0027t look useful. I also haven\u0027t seen an answer to the question in which situation one would not want this option to be set.","commit_id":"bf0f94240e5b9b1f4f5bf7bc8050d9593a1eae3a"},{"author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"change_message_id":"62fdf684d974dce0b5d828dc895b3e1962cba6d2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        policy.init()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        zones \u003d self.central_api.find_zones("},{"line_number":61,"context_line":"            self.context,"},{"line_number":62,"context_line":"            criterion\u003d{\u0027pool_id\u0027: pool.id})"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        for zone in zones:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_6165de1d","line":61,"updated":"2020-06-29 04:55:02.000000000","message":"The default self.context.all_tenants is False, we need to set it to True to get all zones.","commit_id":"65bed9c7142f8e91f3f6111554a62e545d6783ac"}]}