)]}'
{"designate/central/rpcapi.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"683ed8910ae0f1430820a8cd2f825afc99083ec9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        return self.call(context, msg)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def find_servers(self, context, criterion\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":86,"context_line":"                     sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":87,"context_line":"        LOG.info(\"find_servers: Calling central\u0027s find_servers.\")"},{"line_number":88,"context_line":"        msg \u003d self.make_msg(\u0027find_servers\u0027, criterion\u003dcriterion)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2BwBM%3D","line":86,"updated":"2014-02-19 10:21:02.000000000","message":"You forgot to pass these through into the message :)","commit_id":"cf7d9eb5603a975eaf9658cd86275cf7fa3aa2b2"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"f9d577d5741bdb2ad7c374415d9fb32ba38f3e0e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    # Tenant Methods"},{"line_number":148,"context_line":"    def find_tenants(self, context):"},{"line_number":149,"context_line":"        LOG.info(\"find_tenants: Calling central\u0027s find_tenants.\")"},{"line_number":150,"context_line":"        msg \u003d self.make_msg(\u0027find_tenants\u0027)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        return self.call(context, msg)"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2BtXg%3D","line":150,"updated":"2014-02-19 17:00:30.000000000","message":"What about find_tenants? Wouldn\u0027t it need paging, too?","commit_id":"7ac185344bbb406881a22006d6f6e0c1020c402f"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"aed3cd94b14ec3dfcfa33bd62f21920d2498b86a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    # Tenant Methods"},{"line_number":148,"context_line":"    def find_tenants(self, context):"},{"line_number":149,"context_line":"        LOG.info(\"find_tenants: Calling central\u0027s find_tenants.\")"},{"line_number":150,"context_line":"        msg \u003d self.make_msg(\u0027find_tenants\u0027)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        return self.call(context, msg)"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Bk7o%3D","line":150,"in_reply_to":"AAAAUX%2F%2BtXg%3D","updated":"2014-02-20 12:22:52.000000000","message":"For now, odd ones out like tenants and floatingips are being ignored.. We\u0027ll get them next week.","commit_id":"7ac185344bbb406881a22006d6f6e0c1020c402f"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"f9d577d5741bdb2ad7c374415d9fb32ba38f3e0e","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        LOG.info(\"get_recordset: Calling central\u0027s get_recordset.\")"},{"line_number":270,"context_line":"        msg \u003d self.make_msg(\u0027get_recordset\u0027,"},{"line_number":271,"context_line":"                            domain_id\u003ddomain_id,"},{"line_number":272,"context_line":"                            recordset_id\u003drecordset_id)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        return self.call(context, msg)"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2BtWA%3D","line":272,"updated":"2014-02-19 17:00:30.000000000","message":"This probably needs to page, also. One domain could possibly have hundreds of A records in a set that would need to page. Same probably goes for all the recordset functions.","commit_id":"7ac185344bbb406881a22006d6f6e0c1020c402f"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"aed3cd94b14ec3dfcfa33bd62f21920d2498b86a","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        LOG.info(\"get_recordset: Calling central\u0027s get_recordset.\")"},{"line_number":270,"context_line":"        msg \u003d self.make_msg(\u0027get_recordset\u0027,"},{"line_number":271,"context_line":"                            domain_id\u003ddomain_id,"},{"line_number":272,"context_line":"                            recordset_id\u003drecordset_id)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        return self.call(context, msg)"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Bk5Y%3D","line":272,"in_reply_to":"AAAAUX%2F%2BtWA%3D","updated":"2014-02-20 12:22:52.000000000","message":"This only returns the recordset entry itself, and not the records within - so paging is unnecessary.","commit_id":"7ac185344bbb406881a22006d6f6e0c1020c402f"}],"designate/central/service.py":[{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"f9d577d5741bdb2ad7c374415d9fb32ba38f3e0e","unresolved":false,"context_lines":[{"line_number":722,"context_line":"        policy.check(\u0027find_recordset\u0027, context, target)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        return self.storage_api.find_recordset(context, criterion)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"    def update_recordset(self, context, domain_id, recordset_id, values,"},{"line_number":727,"context_line":"                         increment_serial\u003dTrue):"},{"line_number":728,"context_line":"        domain \u003d self.storage_api.get_domain(context, domain_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2BtS4%3D","line":725,"updated":"2014-02-19 17:00:30.000000000","message":"Same here. I think all the recordset methods need to be paged.","commit_id":"7ac185344bbb406881a22006d6f6e0c1020c402f"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"aed3cd94b14ec3dfcfa33bd62f21920d2498b86a","unresolved":false,"context_lines":[{"line_number":722,"context_line":"        policy.check(\u0027find_recordset\u0027, context, target)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        return self.storage_api.find_recordset(context, criterion)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"    def update_recordset(self, context, domain_id, recordset_id, values,"},{"line_number":727,"context_line":"                         increment_serial\u003dTrue):"},{"line_number":728,"context_line":"        domain \u003d self.storage_api.get_domain(context, domain_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Bk6w%3D","line":725,"in_reply_to":"AAAAUX%2F%2BtS4%3D","updated":"2014-02-20 12:22:52.000000000","message":"This method only returns a single record set, so paging is unnecessary here.","commit_id":"7ac185344bbb406881a22006d6f6e0c1020c402f"}]}