)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"4c1ec44c9009065f71be2532bec35b94d1807123","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"561d4b16_90ba5249","updated":"2022-11-07 20:01:50.000000000","message":"Hey;\n\nI\u0027m not typically a designate contributor but I\u0027m helping Scott get this over the finish line. What do we need to get this in?\n\nThanks!\n-Jay","commit_id":"88b3cd6a1fdc4b087bee21f45892321826fbe3e6"},{"author":{"_account_id":29543,"name":"Scott Solkhon","email":"scott.solkhon@gresearch.co.uk","username":"scott.solkhon"},"change_message_id":"524a8e42a741aaa9c0c80b48d345522580e39fa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5f5d0bc6_166afc9a","updated":"2022-09-23 08:58:19.000000000","message":"recheck ","commit_id":"88b3cd6a1fdc4b087bee21f45892321826fbe3e6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"88c32d7e395485a0fcad24c800a7e52849851c9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"04af15be_ee659fb9","updated":"2022-11-09 15:45:46.000000000","message":"I wish overall test coverage was higher in this driver (59%, 81%, 46%), but the meat of this change is getting some coverage so I don\u0027t think that should block this patch. It would be nice if someone took an afternoon to improve the overall coverage in this driver.","commit_id":"70bc4230115768e2e4b0745c9bd514bd501904af"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"28037bb2825a6b3e612d89026b7bdfef27f4ab66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fd898bd1_7612a751","updated":"2022-11-09 16:41:14.000000000","message":"LGTM - \n\n1} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_missing_wapi_url [0.006943s] ... ok\n{0} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_delete_zone [0.012586s] ... ok\n{4} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_update_zone [0.005846s] ... ok\n{4} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_wrong_port [0.004592s] ... ok\n{5} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_missing_ns_group [0.006370s] ... ok\n{5} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_missing_password [0.005004s] ... ok\n{2} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_create_zone [0.009429s] ... ok\n{3} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_missing_username [0.009301s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 8 tests in 0.4493 sec.\n - Passed: 8\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 0.0601 sec.\n","commit_id":"70bc4230115768e2e4b0745c9bd514bd501904af"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2390e9123caf0583f8a478a7f051b3e4d3a19e6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"60a66548_d85f4ab2","updated":"2022-11-14 16:31:33.000000000","message":"LGTM","commit_id":"d0e1bb18721352007c1c0356658ee73d0bed8c06"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"6a2c9b35af59ff34a021dfa7f74061f805b78807","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4b98734a_790a5842","updated":"2022-11-14 15:34:05.000000000","message":"LGTM - \n\n1} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_missing_wapi_url [0.006943s] ... ok\n{0} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_delete_zone [0.012586s] ... ok\n{4} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_update_zone [0.005846s] ... ok\n{4} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_wrong_port [0.004592s] ... ok\n{5} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_missing_ns_group [0.006370s] ... ok\n{5} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_missing_password [0.005004s] ... ok\n{2} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_create_zone [0.009429s] ... ok\n{3} designate.tests.unit.backend.test_infoblox.InfobloxBackendTestCase.test_missing_username [0.009301s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 8 tests in 0.4493 sec.\n - Passed: 8\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 0.0601 sec.\n","commit_id":"d0e1bb18721352007c1c0356658ee73d0bed8c06"}],"designate/backend/impl_infoblox/object_manipulator.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"fe186162c673afd841dfce76156c381621f1b730","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        try:"},{"line_number":212,"context_line":"            ib_object_ref \u003d self._get_infoblox_object_or_none(\u0027grid\u0027)"},{"line_number":213,"context_line":"            if not ib_object_ref:"},{"line_number":214,"context_line":"                LOG.warning(warn_msg % {\u0027obj_type\u0027: obj_type,"},{"line_number":215,"context_line":"                                        \u0027payload\u0027: payload})"},{"line_number":216,"context_line":"        except exc.InfobloxSearchError as e:"},{"line_number":217,"context_line":"            LOG.warning(warn_msg, {\u0027obj_type\u0027: obj_type, \u0027payload\u0027: payload})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7f0ce83a","line":214,"updated":"2020-07-30 18:03:59.000000000","message":"Where is this warn_msg defined?","commit_id":"917cd487c67af3214f4c9d69a6f25d2f52a7e2f5"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a3f8448f712478831c57b233526816c70f1ca86d","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            if not ib_object_ref:"},{"line_number":217,"context_line":"                LOG.warning(warn_msg)"},{"line_number":218,"context_line":"        except exc.InfobloxSearchError as e:"},{"line_number":219,"context_line":"            LOG.warning(warn_msg)"},{"line_number":220,"context_line":"            LOG.info(e)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if ib_object_ref:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_cfe0e199","line":219,"updated":"2020-07-30 23:06:02.000000000","message":"You need to provide the obj type as well e.g. \n\u003e LOG.warning(warn_mg, {\u0027obj_type\u0027: obj_type})\n\nAlso, missing the s in warning_msg, %(obj_type)s","commit_id":"ac8613098a399c35f383eacb62d9dc561451dd06"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"10e016241a3ba98ebf015c810392b3d891183300","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        try:"},{"line_number":216,"context_line":"            ib_object_ref \u003d self._get_infoblox_object_or_none(obj_type)"},{"line_number":217,"context_line":"            if not ib_object_ref:"},{"line_number":218,"context_line":"                LOG.warning(warn_msg, {\u0027obj_type\u0027: obj_type})"},{"line_number":219,"context_line":"        except exc.InfobloxSearchError as e:"},{"line_number":220,"context_line":"            LOG.warning(warn_msg, {\u0027obj_type\u0027: obj_type})"},{"line_number":221,"context_line":"            LOG.info(e)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_28e13c9c","line":218,"updated":"2020-08-24 18:17:53.000000000","message":"Could you add a test for this kind of failure?","commit_id":"0bf50b00a6236ecd6c70c16d103a3f432ad86507"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"10e016241a3ba98ebf015c810392b3d891183300","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            if not ib_object_ref:"},{"line_number":218,"context_line":"                LOG.warning(warn_msg, {\u0027obj_type\u0027: obj_type})"},{"line_number":219,"context_line":"        except exc.InfobloxSearchError as e:"},{"line_number":220,"context_line":"            LOG.warning(warn_msg, {\u0027obj_type\u0027: obj_type})"},{"line_number":221,"context_line":"            LOG.info(e)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        if ib_object_ref:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_08def8d8","line":220,"updated":"2020-08-24 18:17:53.000000000","message":"Same here, it would be nice to be able to test the failures as well.","commit_id":"0bf50b00a6236ecd6c70c16d103a3f432ad86507"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"dcb4b6b0227f6e7c100382a4994a4a46637879f0","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            payload \u003d {\"restart_option\": \"RESTART_IF_NEEDED\","},{"line_number":225,"context_line":"                       \"member_order\": \"SIMULTANEOUSLY\","},{"line_number":226,"context_line":"                       \"service_option\": \"ALL\"}"},{"line_number":227,"context_line":"            self.connector.call_func("},{"line_number":228,"context_line":"                \u0027restartservices\u0027, ib_object_ref, payload)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_35823001","line":227,"updated":"2020-08-24 23:14:38.000000000","message":"I missed that this branch isn\u0027t getting covered by the unit tests and probably should be.","commit_id":"0bf50b00a6236ecd6c70c16d103a3f432ad86507"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a670c72bd6894f8739481745c4d974830d6711d7","unresolved":true,"context_lines":[{"line_number":211,"context_line":"    def _restart_if_needed(self):"},{"line_number":212,"context_line":"        ib_object_ref \u003d None"},{"line_number":213,"context_line":"        obj_type \u003d \u0027grid\u0027"},{"line_number":214,"context_line":"        warn_msg \u003d _(\u0027Infoblox %(obj_type)s will not be restarted because\u0027"},{"line_number":215,"context_line":"                     \u0027 the API object reference cannot be found\u0027)"},{"line_number":216,"context_line":"        try:"},{"line_number":217,"context_line":"            ib_object_ref \u003d self._get_infoblox_object_or_none(obj_type)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c5943d15_9b9b850a","line":214,"updated":"2022-11-11 06:42:49.000000000","message":"We shouldn’t be translating our logs here.","commit_id":"70bc4230115768e2e4b0745c9bd514bd501904af"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e15d5dc9d65d1a84adfed468d6eea41643a8a854","unresolved":true,"context_lines":[{"line_number":211,"context_line":"    def _restart_if_needed(self):"},{"line_number":212,"context_line":"        ib_object_ref \u003d None"},{"line_number":213,"context_line":"        obj_type \u003d \u0027grid\u0027"},{"line_number":214,"context_line":"        warn_msg \u003d _(\u0027Infoblox %(obj_type)s will not be restarted because\u0027"},{"line_number":215,"context_line":"                     \u0027 the API object reference cannot be found\u0027)"},{"line_number":216,"context_line":"        try:"},{"line_number":217,"context_line":"            ib_object_ref \u003d self._get_infoblox_object_or_none(obj_type)"}],"source_content_type":"text/x-python","patch_set":9,"id":"89c40568_5b8e511d","line":214,"in_reply_to":"c5943d15_9b9b850a","updated":"2022-11-11 16:04:51.000000000","message":"Fixed it; thanks for the review!","commit_id":"70bc4230115768e2e4b0745c9bd514bd501904af"}]}