)]}'
{"designate/api/v2/controllers/records.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"83189751537be764fb666677384179ee5983529d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    _collection_schema \u003d schema.Schema(\u0027v2\u0027, \u0027records\u0027)"},{"line_number":32,"context_line":"    sort_keys \u003d [\u0027created_at\u0027, \u0027id\u0027, \u0027updated_at\u0027, \u0027domain_id\u0027, \u0027tenant_id\u0027,"},{"line_number":33,"context_line":"                 \u0027recordset_id\u0027, \u0027status\u0027, \u0027managed\u0027, \u0027managed_resource_id\u0027,"},{"line_number":34,"context_line":"                 \u0027managed_tenant_id\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @pecan.expose(template\u003d\u0027json:\u0027, content_type\u003d\u0027application/json\u0027)"},{"line_number":37,"context_line":"    def get_one(self, zone_id, recordset_id, record_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2BVvc%3D","line":34,"updated":"2014-02-22 12:06:29.000000000","message":"managed / managed_* are not exposed to end users, so should be invalid","commit_id":"038f4964469164b7e8bf852143ebce6d8aae0388"}],"designate/api/v2/controllers/rest.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"02713be35fb8f045d58648c13ad87318547dd9ae","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Negative and zero limits are not caught in storage."},{"line_number":54,"context_line":"        # With a number bigger than MAXSIZE, rpc throws a \u0027OverflowError long"},{"line_number":55,"context_line":"        #  too big to convert\u0027."},{"line_number":56,"context_line":"        # So the parameter \u0027limit\u0027 is checked here."},{"line_number":57,"context_line":"        if limit:"},{"line_number":58,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2BZes%3D","line":55,"updated":"2014-02-21 12:31:48.000000000","message":"Nice catch :)","commit_id":"70352b698049201559d7c3f13ba50fd4a0698123"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"02713be35fb8f045d58648c13ad87318547dd9ae","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                    \u0027limit should be an integer between 1 and {0}\u0027, six.MAXSIZE)"},{"line_number":61,"context_line":"                int_limit \u003d int(limit)"},{"line_number":62,"context_line":"                if int_limit \u003c\u003d 0 or int_limit \u003e six.MAXSIZE:"},{"line_number":63,"context_line":"                    raise exceptions.ValueError(error_message)"},{"line_number":64,"context_line":"            except ValueError:"},{"line_number":65,"context_line":"                raise exceptions.ValueError(error_message)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2BZeA%3D","line":63,"updated":"2014-02-21 12:31:48.000000000","message":"Maybe exceptions.InvalidLimit for clarity?","commit_id":"70352b698049201559d7c3f13ba50fd4a0698123"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"02713be35fb8f045d58648c13ad87318547dd9ae","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                if int_limit \u003c\u003d 0 or int_limit \u003e six.MAXSIZE:"},{"line_number":63,"context_line":"                    raise exceptions.ValueError(error_message)"},{"line_number":64,"context_line":"            except ValueError:"},{"line_number":65,"context_line":"                raise exceptions.ValueError(error_message)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        sort_key \u003d params.pop(\u0027sort_key\u0027, None)"},{"line_number":68,"context_line":"        sort_dir \u003d params.pop(\u0027sort_dir\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2BZdU%3D","line":65,"updated":"2014-02-21 12:31:48.000000000","message":"I assume this except block is for the case where a string or some other non-integer is passed?","commit_id":"70352b698049201559d7c3f13ba50fd4a0698123"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"51e8590829ab0f00ec481bdf38b8ce947f2d5354","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                if int_limit \u003c\u003d 0 or int_limit \u003e six.MAXSIZE:"},{"line_number":63,"context_line":"                    raise exceptions.ValueError(error_message)"},{"line_number":64,"context_line":"            except ValueError:"},{"line_number":65,"context_line":"                raise exceptions.ValueError(error_message)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        sort_key \u003d params.pop(\u0027sort_key\u0027, None)"},{"line_number":68,"context_line":"        sort_dir \u003d params.pop(\u0027sort_dir\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2BYXM%3D","line":65,"in_reply_to":"AAAAUX%2F%2BZdU%3D","updated":"2014-02-21 15:13:37.000000000","message":"Yes that is correct.  This exception is thrown when we do a int(limit)","commit_id":"70352b698049201559d7c3f13ba50fd4a0698123"}],"designate/api/v2/controllers/zones.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"83189751537be764fb666677384179ee5983529d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    _collection_schema \u003d schema.Schema(\u0027v2\u0027, \u0027zones\u0027)"},{"line_number":37,"context_line":"    sort_keys \u003d [\u0027created_at\u0027, \u0027id\u0027, \u0027updated_at\u0027, \u0027name\u0027, \u0027tenant_id\u0027,"},{"line_number":38,"context_line":"                 \u0027parent_domain_id\u0027, \u0027serial\u0027, \u0027refresh\u0027, \u0027retry\u0027, \u0027expire\u0027,"},{"line_number":39,"context_line":"                 \u0027minimum\u0027, \u0027ttl\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    recordsets \u003d recordsets.RecordSetsController()"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2BVvw%3D","line":39,"updated":"2014-02-22 12:06:29.000000000","message":"parent_domain_id / refresh / retry / expire / minimun are not exposed to end users, so should be invalid","commit_id":"038f4964469164b7e8bf852143ebce6d8aae0388"}],"designate/exceptions.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"02713be35fb8f045d58648c13ad87318547dd9ae","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    error_type \u003d \u0027marker_not_found\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class ValueError(BadRequest):"},{"line_number":95,"context_line":"    error_type \u003d \u0027value_error\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2BZe0%3D","line":94,"updated":"2014-02-21 12:31:48.000000000","message":"ValueError seems a bit vague to be passed onto an end-user.. Maybe we should have InvalidSortDir etc exceptions instead?","commit_id":"70352b698049201559d7c3f13ba50fd4a0698123"}]}