)]}'
{"contrib/devstack/lib/designate":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"42ed589a4de32a0619b3bd332caf062e7f0cc5a8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    iniset $DESIGNATE_CONF DEFAULT state_path $DESIGNATE_STATE_PATH"},{"line_number":67,"context_line":"    iniset $DESIGNATE_CONF storage:sqlalchemy database_connection `database_connection_url designate`"},{"line_number":68,"context_line":"    sudo cp $DESIGNATE_DIR/etc/designate/rootwrap.conf.sample $DESIGNATE_CONF_DIR/rootwrap.conf"},{"line_number":69,"context_line":"    sudo cp -avr $DESIGNATE_DIR/etc/designate/rootwrap.d $DESIGNATE_CONF_DIR/rootwrap.d"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    if [[ \"$DESIGNATE_BACKEND_DRIVER\" \u003d \u0027powerdns\u0027 ]]; then"},{"line_number":72,"context_line":"        iniset $DESIGNATE_CONF backend:powerdns database_connection `database_connection_url designate_pdns`"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAUX%2F%2BZXY%3D","line":69,"updated":"2014-02-21 12:49:57.000000000","message":"This could be replaced with:\n\nAt the top:\n\n    DESIGNATE_ROOTWRAP_CONF\u003d$DESIGNATE_CONF_DIR/rootwrap.conf\n\nthen, at this line:\n\n    sudo cp $DESIGNATE_DIR/etc/designate/rootwrap.conf.sample $DESIGNATE_ROOTWRAP_CONF\n    iniset $DESIGNATE_ROOTWRAP_CONF DEFAULT filters_path $DESIGNATE_DIR/etc/designate/rootwrap.d\n    root-helper\n    iniset $DESIGNATE_CONF DEFAULT root-helper sudo designate-rootwrap $DESIGNATE_ROOTWRAP_CONF\n\nThe goal being to reduce the amount of \"stuff\" we shuffle around during the devstack run.. e.g. If I\u0027m hacking on the bind9 plugin and need to add a new rootwrap filter, the filters should be in the clone so we can just edit, test, commit.\n\nThe final iniset is intended to ensure that the root-helper config is correctly pointed at the right binary + config file, regardless of the default value.","commit_id":"b485553a0ca1d1b77f0b6f2ba88c5a5147d6acf8"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"8e701da34b66abee304d934a0a77c1fc82be02d5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    iniset $DESIGNATE_CONF DEFAULT state_path $DESIGNATE_STATE_PATH"},{"line_number":67,"context_line":"    iniset $DESIGNATE_CONF storage:sqlalchemy database_connection `database_connection_url designate`"},{"line_number":68,"context_line":"    sudo cp $DESIGNATE_DIR/etc/designate/rootwrap.conf.sample $DESIGNATE_CONF_DIR/rootwrap.conf"},{"line_number":69,"context_line":"    sudo cp -avr $DESIGNATE_DIR/etc/designate/rootwrap.d $DESIGNATE_CONF_DIR/rootwrap.d"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    if [[ \"$DESIGNATE_BACKEND_DRIVER\" \u003d \u0027powerdns\u0027 ]]; then"},{"line_number":72,"context_line":"        iniset $DESIGNATE_CONF backend:powerdns database_connection `database_connection_url designate_pdns`"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAUX%2F%2BXUw%3D","line":69,"in_reply_to":"AAAAUX%2F%2BZXY%3D","updated":"2014-02-21 16:04:54.000000000","message":"Ok will do.","commit_id":"b485553a0ca1d1b77f0b6f2ba88c5a5147d6acf8"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"42ed589a4de32a0619b3bd332caf062e7f0cc5a8","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    fi"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    if [[ \"$DESIGNATE_BACKEND_DRIVER\" \u003d \u0027bind9\u0027 ]]; then"},{"line_number":181,"context_line":"        install_package bind9 bind9-doc"},{"line_number":182,"context_line":"    fi"},{"line_number":183,"context_line":"}"},{"line_number":184,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAUX%2F%2BZVQ%3D","line":181,"updated":"2014-02-21 12:49:57.000000000","message":"Is the bind9-doc package required? Generally, the number of things installed here should be A) as little as possible, and B) representative of a production env. Most production env\u0027s won\u0027t have the documentation packages installed :)","commit_id":"b485553a0ca1d1b77f0b6f2ba88c5a5147d6acf8"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"8e701da34b66abee304d934a0a77c1fc82be02d5","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    fi"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    if [[ \"$DESIGNATE_BACKEND_DRIVER\" \u003d \u0027bind9\u0027 ]]; then"},{"line_number":181,"context_line":"        install_package bind9 bind9-doc"},{"line_number":182,"context_line":"    fi"},{"line_number":183,"context_line":"}"},{"line_number":184,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAUX%2F%2BXWw%3D","line":181,"in_reply_to":"AAAAUX%2F%2BZVQ%3D","updated":"2014-02-21 16:04:54.000000000","message":"Yeah definitely not.","commit_id":"b485553a0ca1d1b77f0b6f2ba88c5a5147d6acf8"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"42ed589a4de32a0619b3bd332caf062e7f0cc5a8","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    sudo /etc/init.d/apparmor stop"},{"line_number":219,"context_line":"    sudo /etc/init.d/apparmor teardown"},{"line_number":220,"context_line":"    sudo update-rc.d -f apparmor remove"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    sudo echo \u0027\u0027 \u003e\u003e /etc/bind/rndc.conf"},{"line_number":223,"context_line":"    sudo sed -i -e \u00271a\\include \"/etc/bind/rndc.key\";\u0027 /etc/bind/rndc.conf"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAUX%2F%2BZRc%3D","line":220,"updated":"2014-02-21 12:49:57.000000000","message":"These should be wrapped in an if block, to prevent running on RedHat etc\n\nif is_ubuntu; then\n    ....\nfi\n\nAlso - Rather than disabling AppArmor entirely, we should just disable it for BIND9 - This means if/when this gets merged into DevStack proper, we don\u0027t disable AppArmor when one of the other services wants it..\n\n    touch /etc/apparmor.d/disable/usr.sbin.named\n    service apparmor reload","commit_id":"b485553a0ca1d1b77f0b6f2ba88c5a5147d6acf8"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"8e701da34b66abee304d934a0a77c1fc82be02d5","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    sudo /etc/init.d/apparmor stop"},{"line_number":219,"context_line":"    sudo /etc/init.d/apparmor teardown"},{"line_number":220,"context_line":"    sudo update-rc.d -f apparmor remove"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    sudo echo \u0027\u0027 \u003e\u003e /etc/bind/rndc.conf"},{"line_number":223,"context_line":"    sudo sed -i -e \u00271a\\include \"/etc/bind/rndc.key\";\u0027 /etc/bind/rndc.conf"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAUX%2F%2BXWk%3D","line":220,"in_reply_to":"AAAAUX%2F%2BZRc%3D","updated":"2014-02-21 16:04:54.000000000","message":"Good call.","commit_id":"b485553a0ca1d1b77f0b6f2ba88c5a5147d6acf8"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"42ed589a4de32a0619b3bd332caf062e7f0cc5a8","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    sudo sed -i -e \u00273a\\    default-key \"rndc-key\";\u0027 /etc/bind/rndc.conf"},{"line_number":226,"context_line":"    sudo sed -i -e \u00274a\\    default-server 127.0.0.1;\u0027 /etc/bind/rndc.conf"},{"line_number":227,"context_line":"    sudo sed -i -e \u00275a\\    default-port 953;\u0027 /etc/bind/rndc.conf"},{"line_number":228,"context_line":"    sudo sed -i -e \u00276a\\};\u0027 /etc/bind/rndc.conf"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    sudo service bind9 restart"},{"line_number":231,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAUX%2F%2BZTw%3D","line":228,"updated":"2014-02-21 12:49:57.000000000","message":"I wonder if we should instead just replace the whole bind9 and rndc.conf files rather than editing the samples?\n\n\nThe reasoning being, this should work on various versions Ubuntu, RedHat, CentOS, Fedora.. etc etc The sample files are likely to change between each of these.","commit_id":"b485553a0ca1d1b77f0b6f2ba88c5a5147d6acf8"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"8e701da34b66abee304d934a0a77c1fc82be02d5","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    sudo sed -i -e \u00273a\\    default-key \"rndc-key\";\u0027 /etc/bind/rndc.conf"},{"line_number":226,"context_line":"    sudo sed -i -e \u00274a\\    default-server 127.0.0.1;\u0027 /etc/bind/rndc.conf"},{"line_number":227,"context_line":"    sudo sed -i -e \u00275a\\    default-port 953;\u0027 /etc/bind/rndc.conf"},{"line_number":228,"context_line":"    sudo sed -i -e \u00276a\\};\u0027 /etc/bind/rndc.conf"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    sudo service bind9 restart"},{"line_number":231,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAUX%2F%2BXVA%3D","line":228,"in_reply_to":"AAAAUX%2F%2BZTw%3D","updated":"2014-02-21 16:04:54.000000000","message":"Well this was replacing the rndc.conf file entirely (it isn\u0027t there by default, at least in the environments I was working with).\nShould I just include the config files in the plugin tree somewhere and copy them over?","commit_id":"b485553a0ca1d1b77f0b6f2ba88c5a5147d6acf8"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"708ff47ffefb4088245e960d182c1174731a38d2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    iniset $DESIGNATE_CONF DEFAULT verbose True"},{"line_number":67,"context_line":"    iniset $DESIGNATE_CONF DEFAULT state_path $DESIGNATE_STATE_PATH"},{"line_number":68,"context_line":"    iniset $DESIGNATE_CONF storage:sqlalchemy database_connection `database_connection_url designate`"},{"line_number":69,"context_line":"    # sudo cp $DESIGNATE_DIR/etc/designate/rootwrap.conf.sample $DESIGNATE_CONF_DIR/rootwrap.conf"},{"line_number":70,"context_line":"    # sudo cp -avr $DESIGNATE_DIR/etc/designate/rootwrap.d $DESIGNATE_CONF_DIR/rootwrap.d"},{"line_number":71,"context_line":"    sudo cp $DESIGNATE_DIR/etc/designate/rootwrap.conf.sample $DESIGNATE_ROOTWRAP_CONF"},{"line_number":72,"context_line":"    iniset $DESIGNATE_ROOTWRAP_CONF DEFAULT filters_path $DESIGNATE_DIR/etc/designate/rootwrap.d root-helper"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAUX%2F%2BVF8%3D","line":69,"updated":"2014-02-21 20:45:53.000000000","message":"Crap.","commit_id":"a9d60bc0c84cad3884ff031aec52d9ea37511993"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"b83cb3375da165b591b47bf08ad966395ac592c0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    sudo cp $DESIGNATE_DIR/etc/designate/rootwrap.conf.sample $DESIGNATE_ROOTWRAP_CONF"},{"line_number":71,"context_line":"    iniset $DESIGNATE_ROOTWRAP_CONF DEFAULT filters_path $DESIGNATE_DIR/etc/designate/rootwrap.d root-helper"},{"line_number":72,"context_line":"    iniset $DESIGNATE_CONF DEFAULT root-helper sudo designate-rootwrap $DESIGNATE_ROOTWRAP_CONF"},{"line_number":73,"context_line":"    sudo cp $DESIGNATE_DIR/etc/designate/api-paste.ini $DESIGNATE_APIPASTE_CONF"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if [[ \"$DESIGNATE_BACKEND_DRIVER\" \u003d \u0027powerdns\u0027 ]]; then"},{"line_number":76,"context_line":"        iniset $DESIGNATE_CONF backend:powerdns database_connection `database_connection_url designate_pdns`"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAUX%2F%2BVAY%3D","line":73,"updated":"2014-02-21 20:50:51.000000000","message":"I ran it a couple of times and it needed this file in the conf directory too.","commit_id":"55b80e7764d7dd57956b1081826affebcf90fb54"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"b83cb3375da165b591b47bf08ad966395ac592c0","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    sudo chown $USER /etc/bind/"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    if is_ubuntu; then"},{"line_number":221,"context_line":"        sudo touch /etc/apparmor.d/disable/usr.sbin.named"},{"line_number":222,"context_line":"        sudo service apparmor reload"},{"line_number":223,"context_line":"        sudo cat \u003c\u003c EOF \u003e /etc/bind/named.conf.options"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAUX%2F%2BVAw%3D","line":220,"updated":"2014-02-21 20:50:51.000000000","message":"Should just this wrap the call up on line 77?","commit_id":"55b80e7764d7dd57956b1081826affebcf90fb54"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"2c817386fc107584b7ff6c28a54977a07d899e03","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    sudo chown $USER /etc/bind/"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    if is_ubuntu; then"},{"line_number":221,"context_line":"        sudo touch /etc/apparmor.d/disable/usr.sbin.named"},{"line_number":222,"context_line":"        sudo service apparmor reload"},{"line_number":223,"context_line":"        sudo cat \u003c\u003c EOF \u003e /etc/bind/named.conf.options"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAUX%2F%2BSJc%3D","line":220,"in_reply_to":"AAAAUX%2F%2BVAw%3D","updated":"2014-02-22 12:01:41.000000000","message":"I\u0027d say no, this way it\u0027s obvious where to put the `elif is_fedora` etc","commit_id":"55b80e7764d7dd57956b1081826affebcf90fb54"}]}