)]}'
{"id":"openstack%2Fdesignate~754604","triplet_id":"openstack%2Fdesignate~master~I90af3a092296f943509833608f25522b6f8e9ab6","project":"openstack/designate","branch":"master","topic":"fix-pdns","hashtags":[],"change_id":"I90af3a092296f943509833608f25522b6f8e9ab6","subject":"Fix pdns4 devstack plugin","status":"MERGED","created":"2020-09-27 10:26:59.000000000","updated":"2020-09-30 00:15:47.000000000","submitted":"2020-09-28 18:09:03.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"754604-1601316543161-d888da8a","meta_rev_id":"a5720b65e9d8c60e5aae170249f47f8894d0a615","_number":754604,"virtual_id_number":754604,"owner":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-28 18:09:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"all":[{"value":2,"date":"2020-09-28 12:24:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-09-28 16:16:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-09-28 16:16:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-28 12:24:06.000000000","updated_by":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"reviewer":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"state":"REVIEWER"},{"updated":"2020-09-28 16:16:36.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2020-09-28 18:09:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2e1247df63baa72bb622072773344a5dfd306662","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-09-27 10:26:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f3d29129a00a7cbfd0ae63a71e566d0140561938","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-27 11:22:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/c758b97658664dbdbc3f9536fa5d7788 : SUCCESS in 33m 26s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/905e71e10d7a4d45826179bd3ff499e8 : FAILURE in 25m 27s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/239054607545406cba209b714ab92b94 : SUCCESS in 50m 48s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/2a9ba3fe18e04194bf3fe518e1b477fb : FAILURE in 29m 25s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/7b3e94551b63485abbe7cea111010d4b : SUCCESS in 34m 27s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/03ebe7cf9e3e41f0bc9adf180ae0d8cd : SUCCESS in 4m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/806af0c1e1b44242afa653d7912f9a2a : SUCCESS in 5m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/212a4cf24a4b4f4293c857ad6dda5732 : SUCCESS in 3m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0222a0da5c44417ea6743eb72d15907d : SUCCESS in 4m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6817b787d2ab45b59d216d7a325d388d : SUCCESS in 4m 21s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/43e0fbeae9ea4d7f91cb976a1bb48fd6 : SUCCESS in 6m 19s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/09d8a10a0f7a4be1acdf00f1bf6dc446 : SUCCESS in 35m 40s","accounts_in_message":[],"_revision_number":1},{"id":"6d9f980a4e2a8476623688cd991ed98c4e950feb","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-09-27 16:25:28.000000000","message":"Patch Set 1: Workflow-1\n\npdns_server[72655]: Fatal error: Trying to set unknown parameter \u0027out-of-zone-additional-processing\u0027\nwill need to do some local debugging","accounts_in_message":[],"_revision_number":1},{"id":"fd5fae6297e0b92803e78152df691f5337fdd202","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-09-28 08:59:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2fb06b2257a21deb2fe16121850c783fc5f65687","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-28 10:11:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/cb60146995a0447f8eb0081d58b72696 : SUCCESS in 33m 31s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/d2931f6e30254625a04b7b0295c7bed1 : SUCCESS in 47m 03s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/83bd636e3b5c465b9466908a235085e4 : SUCCESS in 1h 02m 45s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/619be80e695645638d44e9a7c0a60066 : SUCCESS in 41m 00s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/05cd43111b4145768fe89f2f76260121 : SUCCESS in 43m 48s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/32bcb0a043dd4c8c85786ddaac6acd49 : SUCCESS in 6m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/317220a316d84ddc9857c6b20a4bbf19 : SUCCESS in 5m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/48b0b499920d4301a9dc65927ae56ce8 : SUCCESS in 4m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/77e145b4c3854fc599cfbb189cf48f92 : SUCCESS in 5m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/58141469aa3f499abca54740fc47f6c2 : SUCCESS in 5m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0f0ce75e46344ad6883acf84b0784e8d : SUCCESS in 7m 38s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/1046ddb235d04b658db51019811cd33b : SUCCESS in 29m 45s","accounts_in_message":[],"_revision_number":2},{"id":"dfb7131659325e253aa714670a798677d353c6e5","author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"date":"2020-09-28 12:24:06.000000000","message":"Patch Set 2: Code-Review+2\n\nNice catch! Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"2a84b861c61db5e01b88225669d11331f4585cd8","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-09-28 16:16:36.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"cd98ce601487156ac8f4ea64ccc2bbbf787ce4d6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-28 16:17:47.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"0ead29729263042a743cc7de9c7368d74baa4c31","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-28 18:09:02.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/898dee36f40148b2ac2a00fbea5e9944 : SUCCESS in 34m 03s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/9dec788f8faa42418d868e1063d1cf28 : SUCCESS in 38m 12s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/f4b8127ed7414fbfb7f8d7551c9de2da : SUCCESS in 1h 36m 57s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/336ff4d729664891a8ff6c372a88a9b3 : SUCCESS in 41m 41s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/a4eb5b281bd84fc888df1e12e288bab3 : SUCCESS in 40m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9c0ca4984bd84903b716f635678151be : SUCCESS in 5m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/86191f2d7e0142bbad0597ed4957d0da : SUCCESS in 3m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6b036790f6fc4d3687cb7bcabc3d3d43 : SUCCESS in 5m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/844f6f44dc8846af9118e96edb74c6b8 : SUCCESS in 5m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5538864ca2e14715a412f6fd243f1f53 : SUCCESS in 8m 06s","accounts_in_message":[],"_revision_number":2},{"id":"f5a4fa2524795d03f0747f1b4af1c269d5a72a19","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-28 18:09:03.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"04a5099851687e65ea15888ce4f698831ff231db","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-28 18:10:38.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/85a534140cfc4e3fbca4783f06548763 : SUCCESS in 1m 08s","accounts_in_message":[],"_revision_number":2},{"id":"e27b01f9beb081137b3392dd0dab4846c43cfb06","author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"date":"2020-09-29 23:03:21.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ussuri as commit 8326963de7abeecbd59d2c3fe5ec1c0847d03d28","accounts_in_message":[],"_revision_number":2},{"id":"07cab04e24232cac71fc2db7fc48e6e09edd2a5f","author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"date":"2020-09-30 00:15:47.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/victoria as commit b1d588cdf9857c18654e37971c9895d6d5e30b59","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6f17fe10bb37d71944e16a422606ccf0f78c6771","revisions":{"60980c4527ecfe214b0b144aa0c283096b2a419b":{"kind":"REWORK","_number":1,"created":"2020-09-27 10:26:59.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/04/754604/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/04/754604/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/04/754604/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/04/754604/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/04/754604/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/04/754604/1"}}},"commit":{"parents":[{"commit":"2168b4367d483ce420afee4bc1e5fca371cc40b8","subject":"Merge \"fix database sync always get the wrong  value\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/2168b4367d483ce420afee4bc1e5fca371cc40b8"}]}],"author":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2020-09-27 10:23:37.000000000","tz":120},"committer":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2020-09-27 10:23:37.000000000","tz":120},"subject":"Drop version check for pdns4 devstack plugin","message":"Drop version check for pdns4 devstack plugin\n\nWe no longer need to deal with xenial or older distro versions, so we\ncan assume that we can always install pdns4 from the distro directly.\n\nChange-Id: I90af3a092296f943509833608f25522b6f8e9ab6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/60980c4527ecfe214b0b144aa0c283096b2a419b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/60980c4527ecfe214b0b144aa0c283096b2a419b"}]},"branch":"refs/heads/master"},"6f17fe10bb37d71944e16a422606ccf0f78c6771":{"kind":"REWORK","_number":2,"created":"2020-09-28 08:59:26.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/04/754604/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/04/754604/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/04/754604/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/04/754604/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/04/754604/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/04/754604/2"}}},"commit":{"parents":[{"commit":"2168b4367d483ce420afee4bc1e5fca371cc40b8","subject":"Merge \"fix database sync always get the wrong  value\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/2168b4367d483ce420afee4bc1e5fca371cc40b8"}]}],"author":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2020-09-27 10:23:37.000000000","tz":120},"committer":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2020-09-28 08:59:24.000000000","tz":0},"subject":"Fix pdns4 devstack plugin","message":"Fix pdns4 devstack plugin\n\nWe no longer need to deal with xenial or older distro versions, so we\ncan assume that we can always install pdns4 from the distro directly\nand don\u0027t need the distro version check any longer.\n\nDrop a config option that was removed in pdns 4.2.x.\n\nUse mysql credentials correctly.\n\nChange-Id: I90af3a092296f943509833608f25522b6f8e9ab6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/6f17fe10bb37d71944e16a422606ccf0f78c6771"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/6f17fe10bb37d71944e16a422606ccf0f78c6771"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
