)]}'
{"designate/storage/impl_sqlalchemy/migrate_repo/versions/103_add_notification_tsig-column.py":[{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"0fc8ee5d28ad834d1afcfa21ff0b1db7b1158687","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Federico Ceratto \u003cfederico.ceratto@hpe.com\u003e"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"7b1e5a06_16244bbc","line":1,"updated":"2021-02-25 14:14:57.000000000","message":"Could you update the copyright statement?","commit_id":"5187029321af5606966c1c33ab708edb93e05ccd"}],"designate/worker/tasks/zone.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1522f0fc5513ec28eccf689918fda1a2438734df","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        # If notification tsigkey use it to sign the notification"},{"line_number":130,"context_line":"        notify_tsig \u003d self.target.options.get(\u0027notification_tsigkey\u0027)"},{"line_number":131,"context_line":"        tsigkey \u003d None"},{"line_number":132,"context_line":"        if notify_tsig and notify_tsig !\u003d \u0027NoSign\u0027:"},{"line_number":133,"context_line":"            tsigkey \u003d wutils.get_tsigkey(self.context, notify_tsig,"},{"line_number":134,"context_line":"                                         self.storage)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"b887c8c6_303d6ad5","line":132,"updated":"2021-03-12 06:02:55.000000000","message":"Why do we need to use such a special value? Can\u0027t we have the value be nullable and just check the \"if notify_tsig\" part?","commit_id":"eae7e19a298a442dc891035ee42f0b8a4a397283"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"3a3fe17012875d1ae34dde1e4d4c1f3b5747f579","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        # If notification tsigkey use it to sign the notification"},{"line_number":130,"context_line":"        notify_tsig \u003d self.target.options.get(\u0027notification_tsigkey\u0027)"},{"line_number":131,"context_line":"        tsigkey \u003d None"},{"line_number":132,"context_line":"        if notify_tsig and notify_tsig !\u003d \u0027NoSign\u0027:"},{"line_number":133,"context_line":"            tsigkey \u003d wutils.get_tsigkey(self.context, notify_tsig,"},{"line_number":134,"context_line":"                                         self.storage)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"88a2a158_1ddcf434","line":132,"in_reply_to":"b887c8c6_303d6ad5","updated":"2021-03-12 18:11:36.000000000","message":"in the DB the UniqueConstraint(\u0027pool_id\u0027, \u0027host\u0027, \u0027port\u0027, \u0027notification_tsigkey\u0027)\nit used to be \u0027pool_id\u0027, \u0027host\u0027, \u0027port\u0027\nand changed to the constrain above so it cant be null","commit_id":"eae7e19a298a442dc891035ee42f0b8a4a397283"}],"designate/worker/utils.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"9c6cf72fe79b28ae0d859108aa0fe2ef077ac260","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        tsigkey \u003d storage.find_tsigkey(context, criterion)"},{"line_number":36,"context_line":"        return tsigkey"},{"line_number":37,"context_line":"    except exceptions.TsigKeyNotFound as e:"},{"line_number":38,"context_line":"        LOG.info(\"TSIGkey %s not found: %s\" % (keyname, e))"},{"line_number":39,"context_line":"        return None"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9c470fdc_4acd0136","line":38,"updated":"2021-01-19 00:37:28.000000000","message":"NIT: All log lines should be lazy loaded\n\u003e LOG.info(\"TSIGkey %s not found: %s\", keyname, e)","commit_id":"ecbef72936e806117ca3a01b505bc1988712316a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1522f0fc5513ec28eccf689918fda1a2438734df","unresolved":true,"context_lines":[{"line_number":18,"context_line":"import dns.tsig"},{"line_number":19,"context_line":"import dns.tsigkeyring"},{"line_number":20,"context_line":"import dns.query"},{"line_number":21,"context_line":"from designate import exceptions"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"aabb580d_8497a95c","line":21,"updated":"2021-03-12 06:02:55.000000000","message":"This should be in its own group following the external imports?","commit_id":"eae7e19a298a442dc891035ee42f0b8a4a397283"}],"releasenotes/notes/notify_backend_with_tsig-6b4fbc0a0122cc18.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1522f0fc5513ec28eccf689918fda1a2438734df","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Signed Notificatios: send signed notifications to designate backend and to also notify dns servers"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"issues:"},{"line_number":11,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"684fabbf_4ef0b4b1","line":8,"range":{"start_line":8,"start_character":11,"end_line":8,"end_character":23},"updated":"2021-03-12 06:02:55.000000000","message":"notifications","commit_id":"eae7e19a298a442dc891035ee42f0b8a4a397283"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1522f0fc5513ec28eccf689918fda1a2438734df","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Signed Notificatios: send signed notifications to designate backend and to also notify dns servers"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"issues:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    [`bug 1875939 \u003chttps://bugs.launchpad.net/designate/+bug/1875939\u003e`_] Send DNS notification based on TSIG is not supported"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"632a6169_b2bf2fea","line":10,"updated":"2021-03-12 06:02:55.000000000","message":"This is wrong, \"issues\" is for open, unresolved issues, use \"fixes\" instead. See https://docs.openstack.org/reno/latest/user/usage.html#editing-a-release-note","commit_id":"eae7e19a298a442dc891035ee42f0b8a4a397283"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1522f0fc5513ec28eccf689918fda1a2438734df","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"issues:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    [`bug 1875939 \u003chttps://bugs.launchpad.net/designate/+bug/1875939\u003e`_] Send DNS notification based on TSIG is not supported"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a2b6f1ff_ae3d4357","line":12,"range":{"start_line":12,"start_character":73,"end_line":12,"end_character":77},"updated":"2021-03-12 06:02:55.000000000","message":"Sending","commit_id":"eae7e19a298a442dc891035ee42f0b8a4a397283"}]}