)]}'
{"id":"openstack%2Fdesignate~755429","triplet_id":"openstack%2Fdesignate~master~Ic794ae3091bf264213e2bdcdc24674e7801bfa0f","project":"openstack/designate","branch":"master","topic":"bug/1897936","hashtags":[],"change_id":"Ic794ae3091bf264213e2bdcdc24674e7801bfa0f","subject":"Revert \"Fix pool update with duplicate masters\"","status":"ABANDONED","created":"2020-10-01 05:50:58.000000000","updated":"2020-10-01 18:07:00.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5e23e149090474e4a8c6e6ce819836295d60a032","_number":755429,"virtual_id_number":755429,"owner":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"date":"2020-10-01 05:53:18.000000000","_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"date":"2020-10-01 05:50:58.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"date":"2020-10-01 05:50:58.000000000","_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"date":"2020-10-01 05:50:58.000000000","_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-10-01 05:50:58.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-01 05:50:58.000000000","updated_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"reviewer":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"state":"REVIEWER"},{"updated":"2020-10-01 05:50:58.000000000","updated_by":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"reviewer":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"state":"REVIEWER"},{"updated":"2020-10-01 05:50:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-10-01 05:50:58.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"}],"messages":[{"id":"9639c4749b77196750757e7a53a6c79b6ab9c8eb","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-10-01 05:50:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8079f568db8b2abc7c14f69ca5c50e61df6ad1be","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-10-01 05:53:18.000000000","message":"Patch Set 1:\n\nThis patch was approved so fast I didn\u0027t have a chance to intervene, so let\u0027s discuss the possibility of a revert. My concerns are:\n\na) Why do we have to support multiple identical masters in the configuration? To me that sounds like a configuration error.\n\nb) If we somehow decide that this is a sensible configuration, let\u0027s make the code more pythonic by using a set instead of clumsily rebuilding set behaviour.","accounts_in_message":[],"_revision_number":1},{"id":"d3553dff565cf6e989fa9a44a845d4efbe85db9c","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-10-01 06:04:52.000000000","message":"Abandoned\n\nO.k., with the example from the bug this does make sense, I\u0027ll just propose a followup to renice the code.","accounts_in_message":[],"_revision_number":1},{"id":"8085a3ca691c65ffc741d23a7b93a775a1c9bca3","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-10-01 08:24:34.000000000","message":"Patch Set 1:\n\n\u003e This patch was approved so fast I didn\u0027t have a chance to\n \u003e intervene, so let\u0027s discuss the possibility of a revert. My\n \u003e concerns are:\n \u003e \n \u003e a) Why do we have to support multiple identical masters in the\n \u003e configuration? To me that sounds like a configuration error.\n \u003e \n \u003e b) If we somehow decide that this is a sensible configuration,\n \u003e let\u0027s make the code more pythonic by using a set instead of\n \u003e clumsily rebuilding set behaviour.\n\nI put the code together quickly at the end of the day, and while I did test it, I wasn\u0027t particularly proud of it. I tried the set approach, but since dicts aren\u0027t hashable they can\u0027t be added to a set. I considered conversion to and from a tuple, but decided to see my family instead :) Happy to help review any refactor.","accounts_in_message":[],"_revision_number":1},{"id":"7ad3bd7fc574485719c18cbe8e747ae311aaed27","author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"date":"2020-10-01 18:07:00.000000000","message":"Patch Set 1:\n\n\u003e This patch was approved so fast I didn\u0027t have a chance to intervene...\n\nSorry for pushing this through without giving you time to\nreview it. I am happy to review any follow-up you would like\nto propose.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1afd633aab9614853cee93b65c831b2b72675a07","revisions":{"1afd633aab9614853cee93b65c831b2b72675a07":{"kind":"REWORK","_number":1,"created":"2020-10-01 05:50:58.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/29/755429/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/29/755429/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/29/755429/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/29/755429/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/29/755429/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/29/755429/1"}}},"commit":{"parents":[{"commit":"4e86bc2a58f00371a2f22217cb8a79e5ac33677c","subject":"Fix pool update with duplicate masters","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/4e86bc2a58f00371a2f22217cb8a79e5ac33677c"}]}],"author":{"name":"Jens Harbott (frickler)","email":"j.harbott@x-ion.de","date":"2020-10-01 05:50:58.000000000","tz":0},"committer":{"name":"Jens Harbott (frickler)","email":"j.harbott@x-ion.de","date":"2020-10-01 05:50:58.000000000","tz":0},"subject":"Revert \"Fix pool update with duplicate masters\"","message":"Revert \"Fix pool update with duplicate masters\"\n\nThis reverts commit 4e86bc2a58f00371a2f22217cb8a79e5ac33677c.\n\nChange-Id: Ic794ae3091bf264213e2bdcdc24674e7801bfa0f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/1afd633aab9614853cee93b65c831b2b72675a07"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/1afd633aab9614853cee93b65c831b2b72675a07"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}