)]}'
{"tox.ini":[{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"8441db55fda317aa9bc62a28236621315cea0b5e","unresolved":false,"context_lines":[{"line_number":183,"context_line":"[testenv:lower-constraints]"},{"line_number":184,"context_line":"skip_install \u003d True"},{"line_number":185,"context_line":"commands \u003d"},{"line_number":186,"context_line":"  python -m pip install --no-deps -U ."},{"line_number":187,"context_line":"  stestr run {posargs}"},{"line_number":188,"context_line":"deps \u003d"},{"line_number":189,"context_line":"  -c{toxinidir}/lower-constraints.txt"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7f6b1bfe_f7b7b385","line":186,"updated":"2020-10-15 14:02:00.000000000","message":"Will the deps still be used if you specify the command explicitly here?","commit_id":"568b559b67b0d9a663172d681fe887bf06feea0a"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"652bb4a7701a2604c57558c8a94bb560dfc663c0","unresolved":false,"context_lines":[{"line_number":183,"context_line":"[testenv:lower-constraints]"},{"line_number":184,"context_line":"skip_install \u003d True"},{"line_number":185,"context_line":"commands \u003d"},{"line_number":186,"context_line":"  python -m pip install --no-deps -U ."},{"line_number":187,"context_line":"  stestr run {posargs}"},{"line_number":188,"context_line":"deps \u003d"},{"line_number":189,"context_line":"  -c{toxinidir}/lower-constraints.txt"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5f681702_e431e4ee","line":186,"in_reply_to":"7f6b1bfe_a8b15592","updated":"2020-10-16 12:31:18.000000000","message":"Thanks for the explanation.","commit_id":"568b559b67b0d9a663172d681fe887bf06feea0a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0ca1308e9eb76c67506c87bda2c346fc99556524","unresolved":false,"context_lines":[{"line_number":183,"context_line":"[testenv:lower-constraints]"},{"line_number":184,"context_line":"skip_install \u003d True"},{"line_number":185,"context_line":"commands \u003d"},{"line_number":186,"context_line":"  python -m pip install --no-deps -U ."},{"line_number":187,"context_line":"  stestr run {posargs}"},{"line_number":188,"context_line":"deps \u003d"},{"line_number":189,"context_line":"  -c{toxinidir}/lower-constraints.txt"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7f6b1bfe_a8b15592","line":186,"in_reply_to":"7f6b1bfe_f7b7b385","updated":"2020-10-15 19:11:51.000000000","message":"Deps should still be used since install_command handles that. But the default install_command is basically what is defined above, so I think it may be better to actually remove that line.\n\nThis is a little redundant here. Setting skip_isntall \u003d True tells tox not to do a local install, but then the command does a local install. Can you explain why that is being done?\n\nThen the rest of the commands defined in [testenv] should (or could) just be run as is, making this change not necessary.\n\nRunning a local lower-constraints run with the existing code in master does install the correctly constrained requirements. So I\u0027m not sure why this change is needed.","commit_id":"568b559b67b0d9a663172d681fe887bf06feea0a"}]}