)]}'
{"designate/service.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"c7171f6204a3c05182e837c03b9df1d7fa23481f","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        self.name \u003d name"},{"line_number":50,"context_line":"        self.host \u003d CONF.host"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        CONF([], project\u003d\u0027designate\u0027)"},{"line_number":53,"context_line":"        policy.init()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if not rpc.initialized():"}],"source_content_type":"text/x-python","patch_set":5,"id":"3901bddb_46560be9","line":52,"updated":"2021-03-08 02:35:28.000000000","message":"This shouldn\u0027t be needed.\n\nIt\u0027s handled here.\nhttps://github.com/openstack/designate/blob/75668d084c2a27fcc25c67741ca309bfe43b1322/designate/utils.py#L81","commit_id":"15dd5620f60a464f89fde274a817ae3e7d29582d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"682ed5a6f0a393142d9943f4ea45ee171ba6d7e4","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        self.name \u003d name"},{"line_number":50,"context_line":"        self.host \u003d CONF.host"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        CONF([], project\u003d\u0027designate\u0027)"},{"line_number":53,"context_line":"        policy.init()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if not rpc.initialized():"}],"source_content_type":"text/x-python","patch_set":5,"id":"d2402dd2_4990fd64","line":52,"in_reply_to":"3901bddb_46560be9","updated":"2021-03-08 02:41:09.000000000","message":"but that is not called for this file policy.init(). that is used for all CLI side only so we need to prepare the CONF object before oslo policy Enforcer is called (vis L53 policy.init())\n\nI can use that until method here instead of direct constructing the CONF.","commit_id":"15dd5620f60a464f89fde274a817ae3e7d29582d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ae7ffe18fe485c81f21ce5aaf58b77aa6b8e807d","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        self.name \u003d name"},{"line_number":50,"context_line":"        self.host \u003d CONF.host"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        CONF([], project\u003d\u0027designate\u0027)"},{"line_number":53,"context_line":"        policy.init()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if not rpc.initialized():"}],"source_content_type":"text/x-python","patch_set":5,"id":"639206e2_a51cc677","line":52,"in_reply_to":"439f2b4a_3536b005","updated":"2021-03-08 22:56:34.000000000","message":"fixed the tests side.","commit_id":"15dd5620f60a464f89fde274a817ae3e7d29582d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"5a4ae1e7e4edf3e627742b2c3a6d3f65883f4525","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        self.name \u003d name"},{"line_number":50,"context_line":"        self.host \u003d CONF.host"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        CONF([], project\u003d\u0027designate\u0027)"},{"line_number":53,"context_line":"        policy.init()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if not rpc.initialized():"}],"source_content_type":"text/x-python","patch_set":5,"id":"d5bd0778_175fdf39","line":52,"in_reply_to":"639206e2_a51cc677","updated":"2021-03-09 00:05:44.000000000","message":"I see now. I changed the unit tests to be faster, but that caused an issue because the config isn\u0027t loaded.\n\nI think this solution is fine, but might be worth looking at how this is done for other tests.\nhttps://github.com/openstack/designate/blob/master/designate/tests/__init__.py#L325","commit_id":"15dd5620f60a464f89fde274a817ae3e7d29582d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"00a74e0194db301358b26c7f6146a85383be8091","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        self.name \u003d name"},{"line_number":50,"context_line":"        self.host \u003d CONF.host"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        CONF([], project\u003d\u0027designate\u0027)"},{"line_number":53,"context_line":"        policy.init()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if not rpc.initialized():"}],"source_content_type":"text/x-python","patch_set":5,"id":"facbb2a3_d9533041","line":52,"in_reply_to":"d2402dd2_4990fd64","updated":"2021-03-08 05:48:06.000000000","message":"It\u0027s called in the cmd entrypoint for all services e.g.\nhttps://github.com/openstack/designate/blob/master/designate/cmd/api.py#L37","commit_id":"15dd5620f60a464f89fde274a817ae3e7d29582d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b2c37e7be5898e42c4999e94707a2b60918ab142","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        self.name \u003d name"},{"line_number":50,"context_line":"        self.host \u003d CONF.host"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        CONF([], project\u003d\u0027designate\u0027)"},{"line_number":53,"context_line":"        policy.init()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if not rpc.initialized():"}],"source_content_type":"text/x-python","patch_set":5,"id":"439f2b4a_3536b005","line":52,"in_reply_to":"facbb2a3_d9533041","updated":"2021-03-08 20:04:47.000000000","message":"yeah it seem yes, let me check why test failed on that or it is just test we need to update.","commit_id":"15dd5620f60a464f89fde274a817ae3e7d29582d"}],"designate/tests/unit/mdns/test_service.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"0512a59ca4a82cac12d2211100b86791defe84b1","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        self.useFixture(self.stdlog)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.useFixture(cfg_fixture.Config(CONF))"},{"line_number":42,"context_line":"        CONF([], project\u003d\u0027designate\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        self.service \u003d service.Service()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7bd90dd8_50e3d10c","line":42,"updated":"2021-03-09 00:19:06.000000000","message":"Maybe change it to this\n\u003e conf \u003d self.useFixture(cfg_fixture.Config(CONF)).conf\n\u003e conf.CONF([], project\u003d\u0027designate\u0027)","commit_id":"e2286ce770ca67293b183ee3cfc36e5a2c02ba03"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"836107e2ef32472bdae6136cdc229ebf4d58eeb4","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        self.useFixture(self.stdlog)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.useFixture(cfg_fixture.Config(CONF))"},{"line_number":42,"context_line":"        CONF([], project\u003d\u0027designate\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        self.service \u003d service.Service()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"77c3e178_5b763d81","line":42,"in_reply_to":"7bd90dd8_50e3d10c","updated":"2021-03-09 01:01:21.000000000","message":"yeah we can use the fixture return value which is same as CONF","commit_id":"e2286ce770ca67293b183ee3cfc36e5a2c02ba03"}],"designate/tests/unit/test_central/test_basic.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2cbdaac1e7719e42f87e01a0b27fadbe6797e197","unresolved":true,"context_lines":[{"line_number":274,"context_line":"            \u0027all_tenants\u0027,"},{"line_number":275,"context_line":"        ])"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        cfg.CONF([], project\u003d\u0027designate\u0027)"},{"line_number":278,"context_line":"        self.service \u003d Service()"},{"line_number":279,"context_line":"        self.service.check_for_tlds \u003d True"},{"line_number":280,"context_line":"        self.service.notifier \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"43126c32_3c6d71fa","line":277,"updated":"2021-03-09 00:30:21.000000000","message":"There is a self.CONF fixture in this class. I think we should use it here.","commit_id":"e2286ce770ca67293b183ee3cfc36e5a2c02ba03"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"836107e2ef32472bdae6136cdc229ebf4d58eeb4","unresolved":true,"context_lines":[{"line_number":274,"context_line":"            \u0027all_tenants\u0027,"},{"line_number":275,"context_line":"        ])"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        cfg.CONF([], project\u003d\u0027designate\u0027)"},{"line_number":278,"context_line":"        self.service \u003d Service()"},{"line_number":279,"context_line":"        self.service.check_for_tlds \u003d True"},{"line_number":280,"context_line":"        self.service.notifier \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"d3ef440f_c8c126f5","line":277,"in_reply_to":"43126c32_3c6d71fa","updated":"2021-03-09 01:01:21.000000000","message":"sure.","commit_id":"e2286ce770ca67293b183ee3cfc36e5a2c02ba03"}]}