)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"f59d914e00dc109690ec1227fc0864655d22511c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29f20aba_7e006d1e","updated":"2021-10-11 13:37:00.000000000","message":"@Nicolas - I applied and tested this patch and ran into a missing piece actually handling the switch to your new increment_serial function on the storage backend:\n\n-----\n\ndiff --git a/designate/central/service.py b/designate/central/service.py\nindex 4d504be5..bcca87f9 100644\n--- a/designate/central/service.py\n+++ b/designate/central/service.py\n@@ -489,11 +489,9 @@ class Service(service.RPCService):\n         \"\"\"\n \n         # Increment the serial number\n-        zone.serial \u003d utils.increment_serial(zone.serial)\n         if set_delayed_notify:\n             zone.delayed_notify \u003d True\n-\n-        zone \u003d self.storage.update_zone(context, zone)\n+        zone.serial \u003d self.storage.increment_serial(context, zone)\n \n         # Update SOA record\n         self._update_soa(context, zone)\n\n\n-----\n\nWith this patch applied I then tested creating, deleting and updating tons of records concurrently via terraform with no apparent issues anymore - no missing records, no leftovers on deletions.\n\n\nMay I kindly suggest to get this patch ready, tested and merged to fix the race condition.\nCertainly batched processing of many changes would be another improvement, but let\u0027s move incrementally and fix bugs first.\n\n\n","commit_id":"056cb62ce8dd73bccce63c7fe307219d04fe041d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"84d91ac85b0436eb6a62489a237e86ddb179f4dd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18c2dd53_80650776","in_reply_to":"29f20aba_7e006d1e","updated":"2021-10-11 18:56:43.000000000","message":"The only reason this hasn\u0027t been of higher priority is because you can also fix the race conditions by enabling a coordinator (e.g. Zookeeper or memcached).\nhttps://docs.openstack.org/designate/latest/admin/config.html#coordination\n\nIf you don\u0027t have a coordinator you should be getting this error message\nhttps://github.com/openstack/designate/blob/05343d4226822da8b9776201ea18e000d366573d/designate/coordination.py#L72","commit_id":"056cb62ce8dd73bccce63c7fe307219d04fe041d"}]}