)]}'
{"designate/api/v2/controllers/root.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"60721c703072e31be952279c881ca854810a37c9","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    # Designate API reference that listed the URL path as /v2/service_status"},{"line_number":64,"context_line":"    # instead of /v2/service_statuses as it was implemented."},{"line_number":65,"context_line":"    # https://bugs.launchpad.net/designate/+bug/1919183"},{"line_number":66,"context_line":"    service_status \u003d service_statuses"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    tsigkeys \u003d tsigkeys.TsigKeysController()"},{"line_number":69,"context_line":"    recordsets \u003d recordsets.RecordSetsViewController()"}],"source_content_type":"text/x-python","patch_set":1,"id":"0ddea398_c8e7062e","line":66,"updated":"2021-03-25 17:43:42.000000000","message":"I\u0027m not sure that we really need to do this. People who have been using the incorrect documentation will have noticed that it is broken. People that might benefit from this fix in the future will also only see the fixed documentation.","commit_id":"2e6611b112df9d32128103ba72e46819840c003f"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"9e2be09958d1c0ccb4b58dca97b3e2c37a4ec49e","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    # Designate API reference that listed the URL path as /v2/service_status"},{"line_number":64,"context_line":"    # instead of /v2/service_statuses as it was implemented."},{"line_number":65,"context_line":"    # https://bugs.launchpad.net/designate/+bug/1919183"},{"line_number":66,"context_line":"    service_status \u003d service_statuses"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    tsigkeys \u003d tsigkeys.TsigKeysController()"},{"line_number":69,"context_line":"    recordsets \u003d recordsets.RecordSetsViewController()"}],"source_content_type":"text/x-python","patch_set":1,"id":"b3cfa22e_8fb2e782","line":66,"in_reply_to":"0ddea398_c8e7062e","updated":"2021-03-25 17:59:10.000000000","message":"On top of that service status is completely broken. There is no scenario where it isn\u0027t \"UP\". The only thing that works in the current implementation is updating the heartbeated_at field.","commit_id":"2e6611b112df9d32128103ba72e46819840c003f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ec62c2137f5f08ecbec73c1375d180f0bcc48d70","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    # Designate API reference that listed the URL path as /v2/service_status"},{"line_number":64,"context_line":"    # instead of /v2/service_statuses as it was implemented."},{"line_number":65,"context_line":"    # https://bugs.launchpad.net/designate/+bug/1919183"},{"line_number":66,"context_line":"    service_status \u003d service_statuses"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    tsigkeys \u003d tsigkeys.TsigKeysController()"},{"line_number":69,"context_line":"    recordsets \u003d recordsets.RecordSetsViewController()"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb6fbff1_460daf81","line":66,"in_reply_to":"3b543455_07c50f4a","updated":"2021-03-25 18:38:39.000000000","message":"It is totally a courtesy for anyone that has the published PDFs or a library that was blindly coded to the API.\nI try to honor any API reference that has been published as the specification of the API, and any deviation is a bug.\nSince this is simply an alias, it is not a maintenance burden.\nIf you feel strongly please -1 it.","commit_id":"2e6611b112df9d32128103ba72e46819840c003f"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"3e360cef82c132f43b0c250791784c102379218b","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    # Designate API reference that listed the URL path as /v2/service_status"},{"line_number":64,"context_line":"    # instead of /v2/service_statuses as it was implemented."},{"line_number":65,"context_line":"    # https://bugs.launchpad.net/designate/+bug/1919183"},{"line_number":66,"context_line":"    service_status \u003d service_statuses"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    tsigkeys \u003d tsigkeys.TsigKeysController()"},{"line_number":69,"context_line":"    recordsets \u003d recordsets.RecordSetsViewController()"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6faa429_51486502","line":66,"in_reply_to":"4d9ae154_d674ca9b","updated":"2021-03-25 19:02:20.000000000","message":"An easy \"fix\" would be to implement a periodic check on central to keep track of all heartbeats and if one does not report back it sets it as down at some point.","commit_id":"2e6611b112df9d32128103ba72e46819840c003f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cd75bcb6b0fef62d8c4417c62f66ed851c31a122","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    # Designate API reference that listed the URL path as /v2/service_status"},{"line_number":64,"context_line":"    # instead of /v2/service_statuses as it was implemented."},{"line_number":65,"context_line":"    # https://bugs.launchpad.net/designate/+bug/1919183"},{"line_number":66,"context_line":"    service_status \u003d service_statuses"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    tsigkeys \u003d tsigkeys.TsigKeysController()"},{"line_number":69,"context_line":"    recordsets \u003d recordsets.RecordSetsViewController()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b543455_07c50f4a","line":66,"in_reply_to":"b3cfa22e_8fb2e782","updated":"2021-03-25 18:31:33.000000000","message":"lol, really? sigh. Is there an open bug for the \"UP\" issue?","commit_id":"2e6611b112df9d32128103ba72e46819840c003f"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e1a28cd75711699d3b27762fc0fe9d1659eb15be","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    # Designate API reference that listed the URL path as /v2/service_status"},{"line_number":64,"context_line":"    # instead of /v2/service_statuses as it was implemented."},{"line_number":65,"context_line":"    # https://bugs.launchpad.net/designate/+bug/1919183"},{"line_number":66,"context_line":"    service_status \u003d service_statuses"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    tsigkeys \u003d tsigkeys.TsigKeysController()"},{"line_number":69,"context_line":"    recordsets \u003d recordsets.RecordSetsViewController()"}],"source_content_type":"text/x-python","patch_set":1,"id":"4d9ae154_d674ca9b","line":66,"in_reply_to":"eb6fbff1_460daf81","updated":"2021-03-25 18:51:46.000000000","message":"Unsure if there is an bug open for \"UP\". If you look at the implementation there isn\u0027t actually any \"set\" functionality implemented, only get. So there is currently no way of changing or updating any of the fields (e.g. UP/DOWN, Capabilities, Status, Stats etc)\nhttps://github.com/openstack/designate/blob/master/designate/heartbeat_emitter.py#L38\n\nThere was original some functionality for this (but not actually used), but the problem is that none of this worked with multi-processing. Each process used to have its own instance of the heartbeat emitter, but obviously there is no way to distinguish between the various workers and they all reported for the same service instance.","commit_id":"2e6611b112df9d32128103ba72e46819840c003f"}]}