)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"659d9129b57d82ade69b4a58b49f8774ddd2e47c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     kpdev \u003ckinpaa@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-05-06 09:56:42 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate records during recordset create or update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If invalid record is provided during recordset create or valid record is"},{"line_number":10,"context_line":"updated to invalid record during recordset set, causes recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e6def2ec_fb40e2f1","line":7,"updated":"2021-05-18 04:01:32.000000000","message":"I think it\u0027s worth mentioning this is only for MX records in the commit msg.","commit_id":"4a9eab456fe3b8cf22b008eef977dc477b98a5bd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ae1262023edc89b2f7808efd96d571074a08b2c2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kpdev \u003ckinpaa@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-05-06 09:56:42 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate records during recordset create or update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If invalid record is provided during recordset create or valid record is"},{"line_number":10,"context_line":"updated to invalid record during recordset set, causes recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c3691972_197169f4","line":7,"in_reply_to":"e6def2ec_fb40e2f1","updated":"2022-08-15 07:45:11.000000000","message":"Done","commit_id":"4a9eab456fe3b8cf22b008eef977dc477b98a5bd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"46121250eaaf7bf5ee3131f72e47171348301874","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"db890898_be3a7f36","updated":"2022-08-14 21:41:28.000000000","message":"I wonder if we shouldn\u0027t be handling this here instead?\nhttps://github.com/openstack/designate/blob/master/designate/objects/rrdata_mx.py","commit_id":"44727c29e4f9d968c1a53b9ce7492ab5d7433b37"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"5191cf12b544267f78f8c64671c37dc8339cec90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f7d6f2c_2b92032c","updated":"2022-08-14 22:11:01.000000000","message":"Maybe something like this?\nhttps://paste.openstack.org/show/bQTQ8krjZK95ftBRT0n6/","commit_id":"44727c29e4f9d968c1a53b9ce7492ab5d7433b37"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ae1262023edc89b2f7808efd96d571074a08b2c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"08f3f824_c976ce5e","in_reply_to":"db890898_be3a7f36","updated":"2022-08-15 07:45:11.000000000","message":"looks good to me. I have updated the patch.. please approve and merge.","commit_id":"44727c29e4f9d968c1a53b9ce7492ab5d7433b37"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"137baee48797c94f0f562e7d5191126ec22b41ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0f810601_3d7aa4d7","updated":"2022-08-15 19:57:49.000000000","message":"LGTM","commit_id":"536315e38ccc06193d9f8b83770aab8f671f6fa8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a22bad57d0518aa910da36be55e20830fa5474cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5aab411b_6e798f1c","updated":"2022-08-26 10:19:42.000000000","message":"Michael/Erik/DEkehn,\nPlease merge it.","commit_id":"536315e38ccc06193d9f8b83770aab8f671f6fa8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"be642bb427d81d365a81ac2bbc580fdc176c47aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8ce4eb51_cf02b172","updated":"2022-08-29 21:09:14.000000000","message":"Wish it had a release note so it could be backported.\nOtherwise LGTM","commit_id":"536315e38ccc06193d9f8b83770aab8f671f6fa8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"8a5c9125658a7ccf84e77752f32c4bd4a628258e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"42708bdd_6c918299","updated":"2022-08-28 20:35:34.000000000","message":"recheck","commit_id":"536315e38ccc06193d9f8b83770aab8f671f6fa8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"02d5bc3689d69f25fe2251d6e86f34fbf8ba9b6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"da051fdb_fab0d048","updated":"2022-08-29 18:21:49.000000000","message":"recheck","commit_id":"536315e38ccc06193d9f8b83770aab8f671f6fa8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ed822b8fdfb9dcfd2901e72f1e7a58e18879ca4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"edb67f1b_4aec7e8a","updated":"2022-08-29 07:19:45.000000000","message":"recheck","commit_id":"536315e38ccc06193d9f8b83770aab8f671f6fa8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"b1dae08d94987f399e2400de50be5c7102c7184d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f23401e6_1e26d47a","updated":"2022-08-29 19:47:01.000000000","message":"recheck","commit_id":"536315e38ccc06193d9f8b83770aab8f671f6fa8"}],"designate/central/service.py":[{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"9f53ccc3feff920eac368aef10ece6a2651d465c","unresolved":true,"context_lines":[{"line_number":397,"context_line":"            if recordset.type \u003d\u003d \u0027MX\u0027:"},{"line_number":398,"context_line":"                for record in recordset.records:"},{"line_number":399,"context_line":"                    if not record.data.endswith(\u0027.\u0027):"},{"line_number":400,"context_line":"                        raise ValueError(\u0027Please supply a FQDN\u0027)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def _is_blacklisted_zone_name(self, context, zone_name):"},{"line_number":403,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"29bdf046_45e185cb","line":400,"updated":"2021-05-28 00:50:53.000000000","message":"This results in a\n\n{\"code\": 500, \"type\": \"unknown\", \"request_id\": \"req-f50a9745-4e32-4ad1-906b-5554afc635dd\"}\n\nresponse which is not very helpful. Better would be\n\nraise exceptions.BadRequest(\u0027Please supply a FQDN\u0027)","commit_id":"4ac3c27386bba75e59cc8dbecc45bb72a3ff5611"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3b6df20de3aaf931948177d7704d554c28e1659b","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            if recordset.type \u003d\u003d \u0027MX\u0027:"},{"line_number":398,"context_line":"                for record in recordset.records:"},{"line_number":399,"context_line":"                    if not record.data.endswith(\u0027.\u0027):"},{"line_number":400,"context_line":"                        raise ValueError(\u0027Please supply a FQDN\u0027)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def _is_blacklisted_zone_name(self, context, zone_name):"},{"line_number":403,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"f4f33342_6a7173d8","line":400,"in_reply_to":"29bdf046_45e185cb","updated":"2021-05-29 07:10:05.000000000","message":"Done","commit_id":"4ac3c27386bba75e59cc8dbecc45bb72a3ff5611"}]}