)]}'
{"designate/tests/unit/scheduler/test_permutations.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2282946cc084fcf13269d7666267c6d5b0264b7c","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        attrs \u003d {"},{"line_number":166,"context_line":"            \u0027find_pools.return_value\u0027: build_test_pools()"},{"line_number":167,"context_line":"        }"},{"line_number":168,"context_line":"        mock_storage \u003d mock.Mock(**attrs)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        self.scheduler \u003d scheduler.get_scheduler(storage\u003dmock_storage)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2aef48a5_32ef5163","line":168,"updated":"2021-06-16 22:18:28.000000000","message":"Wouldn\u0027t it be a more complete test if you set the default pool ID through the fixture?\n\n[service:central] default_pool_id\n\nThe default pool filter doesn\u0027t need storage right?","commit_id":"3ae1519d579c42f84dbe3efe534d7b963f1adc73"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e26162e38b65b161b62f0114f38b5b9ad7c734c5","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        attrs \u003d {"},{"line_number":166,"context_line":"            \u0027find_pools.return_value\u0027: build_test_pools()"},{"line_number":167,"context_line":"        }"},{"line_number":168,"context_line":"        mock_storage \u003d mock.Mock(**attrs)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        self.scheduler \u003d scheduler.get_scheduler(storage\u003dmock_storage)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1adb8446_53866a68","line":168,"in_reply_to":"2aef48a5_32ef5163","updated":"2021-06-17 00:48:18.000000000","message":"Yea - I like that. I added new default IDs for all tests.\n\nAs for the storage. That is always required because that is where it loads the pool from and even if you use the default \"pool\" it\u0027s still user defined. It\u0027s just the uuid that is the \"default\".\n\ne.g.\n\nstack@ubuntu:~/designate$ cat /etc/designate/pools.yaml \n---\n- name: default\n  description: DevStack BIND Pool\n  attributes: {}","commit_id":"3ae1519d579c42f84dbe3efe534d7b963f1adc73"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca2e5fa252276a8edae34773004b8e8aa5f627f1","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from designate import tests"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def build_test_pools(default_pool_id\u003d\u0027794ccc2c-d751-44fe-b57f-8894c9f5c842\u0027):"},{"line_number":24,"context_line":"    pools \u003d objects.PoolList.from_list("},{"line_number":25,"context_line":"        ["},{"line_number":26,"context_line":"            {\u0027id\u0027: default_pool_id},"}],"source_content_type":"text/x-python","patch_set":6,"id":"3e7a1982_2b33d042","line":23,"updated":"2021-06-17 17:36:39.000000000","message":"Did we intend to have three different \"default_pool_id\" UUIDs?\nHere, line 63, and line 183\nMaybe these should be unified with a constant or called something different if we want to use different UUIDs?","commit_id":"7ea620e4c0f60b7a7007eecdbb5978af54babb88"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"9b4884d366a0f2c65fac77ad40110437677ed135","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from designate import tests"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def build_test_pools(default_pool_id\u003d\u0027794ccc2c-d751-44fe-b57f-8894c9f5c842\u0027):"},{"line_number":24,"context_line":"    pools \u003d objects.PoolList.from_list("},{"line_number":25,"context_line":"        ["},{"line_number":26,"context_line":"            {\u0027id\u0027: default_pool_id},"}],"source_content_type":"text/x-python","patch_set":6,"id":"4fd9fdbb_1f0ad65d","line":23,"in_reply_to":"3e7a1982_2b33d042","updated":"2021-06-17 17:43:39.000000000","message":"+1","commit_id":"7ea620e4c0f60b7a7007eecdbb5978af54babb88"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b4160ee89d937c83d5fdd81ce34b530b2b601572","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        result \u003d self.scheduler.schedule_zone(self.context, zone)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        self.assertEqual(\u002724702e43-8a52-440f-ab74-19fc16048860\u0027, result)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_get_silver_tier(self):"},{"line_number":103,"context_line":"        zone \u003d objects.Zone("}],"source_content_type":"text/x-python","patch_set":6,"id":"0c9cf022_f574301d","line":100,"updated":"2021-06-17 06:01:48.000000000","message":"Better make the UUID a global constant instead of having to verify that this is the same string as used in the pool definitions above?","commit_id":"7ea620e4c0f60b7a7007eecdbb5978af54babb88"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca2e5fa252276a8edae34773004b8e8aa5f627f1","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        result \u003d self.scheduler.schedule_zone(self.context, zone)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        self.assertEqual(\u002724702e43-8a52-440f-ab74-19fc16048860\u0027, result)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_get_silver_tier(self):"},{"line_number":103,"context_line":"        zone \u003d objects.Zone("}],"source_content_type":"text/x-python","patch_set":6,"id":"b7dd8e7f_ea1b9e62","line":100,"in_reply_to":"0c9cf022_f574301d","updated":"2021-06-17 17:36:39.000000000","message":"+1 That would be nice.","commit_id":"7ea620e4c0f60b7a7007eecdbb5978af54babb88"}]}