)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"081f35c989a97329ec4f4ab15fded0fa90f11dcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4afc9b66_7faa02a2","updated":"2022-10-23 12:51:36.000000000","message":"Not a complete review yet, just some initial comments and questions.","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92f4f4c8da5c00dbb74ac9bea0cf201e888b4f76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4592b1b8_f44a7c29","updated":"2022-11-03 09:03:29.000000000","message":"Please approve as discussed in PTG.","commit_id":"a1e3b7f6e38af1a58ab2cdbc752daabab855e503"},{"author":{"_account_id":20104,"name":"Dmitrii Galkin","display_name":"Dmitry Galkin","email":"galkindmitrii@gmail.com","username":"galkindmitrii"},"change_message_id":"bd2ef16fe362c12f7ee3d4e72c95fef1d8283abc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8d9c67f8_6a0eaf06","updated":"2023-04-14 07:31:02.000000000","message":"Hi Michael, Jens.\nIs there any further feedback on this?\nWe\u0027d really appreciate getting this merged.\nThanks.","commit_id":"66916be2ebfa15919203dda9b10d83fa0e102a72"},{"author":{"_account_id":36073,"name":"Ihor Zashchelkin","email":"igorzash@tutanota.com","username":"ihorzash"},"change_message_id":"f0ecfc7f1e87579ef7f02f4d9730a849daacfe98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ec0bda72_880faf1d","updated":"2023-06-08 09:38:55.000000000","message":"LGTM, I\u0027ve tested the changes locally together with the related designateclient changes.","commit_id":"a2670d822f29a74fc873f7ef08e9161d194394a0"},{"author":{"_account_id":20104,"name":"Dmitrii Galkin","display_name":"Dmitry Galkin","email":"galkindmitrii@gmail.com","username":"galkindmitrii"},"change_message_id":"d745b7bb91610c518fc7d3349be7d5aa2efde87f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"8ed977b1_5eb5fa1c","updated":"2023-06-08 09:55:34.000000000","message":"Thanks Ihor! Michael, Erik, can we get this PR merged?","commit_id":"a2670d822f29a74fc873f7ef08e9161d194394a0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8793a6f68aba107dac843d4379f9a90ce710917a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"82692820_ae65ae1c","in_reply_to":"5b0866ef_86e72444","updated":"2023-06-09 09:03:29.000000000","message":"test added, please review and get this merged.","commit_id":"a2670d822f29a74fc873f7ef08e9161d194394a0"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"99908d61311334362e7a21a4666bdf379734539c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"5b0866ef_86e72444","in_reply_to":"8ed977b1_5eb5fa1c","updated":"2023-06-08 17:02:52.000000000","message":"I am in the middle of a move so won\u0027t have time to properly look at this, but looking over it quickly and I see no unit tests coverage. It\u0027s likely going to help get this merged sooner with some test coverage.","commit_id":"a2670d822f29a74fc873f7ef08e9161d194394a0"},{"author":{"_account_id":20104,"name":"Dmitrii Galkin","display_name":"Dmitry Galkin","email":"galkindmitrii@gmail.com","username":"galkindmitrii"},"change_message_id":"b35668b4865ecbc7ebf2577e4d319ddaa635f7a4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"f27edd43_97c5764c","updated":"2023-06-26 14:26:05.000000000","message":"Hi All,\nAny other feedback or suggestions?\nIf not, let\u0027s please get this merged 😊\nThanks!","commit_id":"3a0f440b036686573164a777f452cfdec2d0a60d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"16cd4a335d9189d8ddc3546fd4244abc44fb4af3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"67611bf9_85a53af0","updated":"2023-07-25 13:15:51.000000000","message":"Ping. Reminder for all core reviewers whoever has rights to merge, please merge this PR.","commit_id":"3a0f440b036686573164a777f452cfdec2d0a60d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"704a6de5dcb0294dde6d9187da5b78c1cb86afd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"d8e08547_e9299966","updated":"2023-08-08 14:53:52.000000000","message":"Added more tests to pass tox-cover","commit_id":"ce45d7aace9e75ce9823b4ad6857f986cdb51d8e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"96f8004889981219fc2719f031f1a39141f02bbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b3a88413_21891091","updated":"2023-08-10 20:25:36.000000000","message":"I have some questions here.","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c8bc0bb73b41ce1eef39a2371b42acacac43649f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"57d6cec9_5b3faf87","updated":"2023-09-22 08:49:21.000000000","message":"Hi Michael/DEKehn,\nCan you please merge this PR ? We are using downstream for couple of months.","commit_id":"56bfe49573f737203daea837dc2737ea1f22cfb0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"865deeaea6bcbb9431f44c2a2b9ffc75fc3a89de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"6464b96a_4fc211b9","updated":"2023-10-30 13:43:45.000000000","message":"recheck","commit_id":"8bc11efae9c498fc52a880d2f2d0680119ae7539"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d663d384b68051d36e2480513d427469b97a47e8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":27,"id":"fd8ada97_c7cafda7","updated":"2023-11-07 11:04:00.000000000","message":"designate/tests/test_api/test_v2/test_zones.py contains all tests to cover the code from designate/api/v2/controllers/zones/tasks/pool_move.py. But still tox cover show less percentage, I am not sure why. \n@Michael,\ncan you comment on it ?","commit_id":"4a761b5b10d0f218f7522d55f6dd8855e710dfa4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b4b66b0db4808c205e8b4e54f3f72654ec3b59fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"c45ebc8d_141c971c","updated":"2023-11-03 15:58:11.000000000","message":"recheck","commit_id":"4a761b5b10d0f218f7522d55f6dd8855e710dfa4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3b11454db6c532190a44431baa9f920d1ccb5639","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"6cdbea25_238027a9","updated":"2023-11-06 13:35:07.000000000","message":"recheck openstack-tox-cover","commit_id":"4a761b5b10d0f218f7522d55f6dd8855e710dfa4"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e7ec62f4165632332a978774939ac5f2d20a1103","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":27,"id":"fd7a3396_3debfdb0","in_reply_to":"54eed550_8dbffb34","updated":"2023-11-07 16:25:14.000000000","message":"Yep, but the coverage bug only affects the api. Full Central coverage would still be nice to see.\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a6a/796633/27/check/openstack-tox-cover/a6a6abd/cover/d_e9626a620b80a833_service_py.html#t1366","commit_id":"4a761b5b10d0f218f7522d55f6dd8855e710dfa4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"081585f03561dd36ad4822c1526f135772d1476f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":27,"id":"54eed550_8dbffb34","in_reply_to":"faebe26a_e792e061","updated":"2023-11-07 15:22:41.000000000","message":"coverage of the code is what is asked in PTG, otherwise this PR is +1 by other reviewers. So please merge it.","commit_id":"4a761b5b10d0f218f7522d55f6dd8855e710dfa4"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"3b02d487994e818c3daff6b9b5c8f12cddefd6c3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":27,"id":"faebe26a_e792e061","in_reply_to":"fd8ada97_c7cafda7","updated":"2023-11-07 14:57:24.000000000","message":"I think this is a bug with cover, and not related to your code.","commit_id":"4a761b5b10d0f218f7522d55f6dd8855e710dfa4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"27b24bc912d41f7253a4ee26a1ce96912eff4ccc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"53909757_323b563b","updated":"2023-12-05 11:05:31.000000000","message":"Hi Erik/Michael/DeKehn,\nplease merge this change.","commit_id":"de7a1292acbf078b95e0285a06157cf3817ff9f2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a1468281edf69fcf6ba0f7b8a2d1314c44e7c2d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"dbdad879_fa196e20","updated":"2023-12-14 19:11:32.000000000","message":"Some minor things except for the tsig change in the mini-DNS handler. That is a big issue that needs addressed.","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"960340bb853d1f5c854673026a52c04fc404de4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"6120fa06_f3cb3ae8","updated":"2023-12-15 22:26:42.000000000","message":"I think this look ok now.","commit_id":"47e5b069d20f58e546039c34b0d53a27815ebdae"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f8c0985d5a440ec74c990782f1df5b33581a605e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3b2b5a72_ef2fbdf0","updated":"2023-12-15 23:56:21.000000000","message":"recheck\nUnrelated: The DNS operation timed out.","commit_id":"8733f8f85bf0b8c3cedc35d9a41a511a3cb8dd78"}],"api-ref/source/dns-api-v2-zone-tasks.inc":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"081f35c989a97329ec4f4ab15fded0fa90f11dcc","unresolved":true,"context_lines":[{"line_number":108,"context_line":"Pool Move Zone"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. rest_method::  POST /v2/zones/{zone_id}/tasks/pool_move"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Move a zone to another pool."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"82b84c86_42e462f6","line":111,"updated":"2022-10-23 12:51:36.000000000","message":"Do we really need the \"_move\" suffix? To me it seems like just \".../pool\" should be fine.","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92f4f4c8da5c00dbb74ac9bea0cf201e888b4f76","unresolved":false,"context_lines":[{"line_number":108,"context_line":"Pool Move Zone"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. rest_method::  POST /v2/zones/{zone_id}/tasks/pool_move"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Move a zone to another pool."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"0620148c_7bfef729","line":111,"in_reply_to":"82b84c86_42e462f6","updated":"2022-11-03 09:03:29.000000000","message":"I believe pool_move is more descriptive and also future-prone.","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"081f35c989a97329ec4f4ab15fded0fa90f11dcc","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Move a zone to another pool."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"This moves a zone from the existing designate pool to specified target pool."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. rest_status_code:: success status.yaml"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"6dba9ab0_d3293294","line":115,"updated":"2022-10-23 12:51:36.000000000","message":"This should be more explicit about the \"pool_id\" parameter being optional and how it is determined if it is not specified in the request.","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92f4f4c8da5c00dbb74ac9bea0cf201e888b4f76","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Move a zone to another pool."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"This moves a zone from the existing designate pool to specified target pool."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. rest_status_code:: success status.yaml"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"fd5bb893_dcc55581","line":115,"in_reply_to":"6dba9ab0_d3293294","updated":"2022-11-03 09:03:29.000000000","message":"Done","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"081f35c989a97329ec4f4ab15fded0fa90f11dcc","unresolved":true,"context_lines":[{"line_number":126,"context_line":"   - 403"},{"line_number":127,"context_line":"   - 404"},{"line_number":128,"context_line":"   - 405"},{"line_number":129,"context_line":"   - 503"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9b7535fd_3a230d1d","line":129,"updated":"2022-10-23 12:51:36.000000000","message":"From looking at the API implementation, there can be a 500 status, so that should be added. Also not sure whether all the other codes really apply?","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92f4f4c8da5c00dbb74ac9bea0cf201e888b4f76","unresolved":false,"context_lines":[{"line_number":126,"context_line":"   - 403"},{"line_number":127,"context_line":"   - 404"},{"line_number":128,"context_line":"   - 405"},{"line_number":129,"context_line":"   - 503"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"914fed2d_0f2c3535","line":129,"in_reply_to":"9b7535fd_3a230d1d","updated":"2022-11-03 09:03:29.000000000","message":"Done","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9daf2c007569c8bf68ebe14f350281f38b365b7b","unresolved":true,"context_lines":[{"line_number":138,"context_line":"   - x-auth-all-projects: x-auth-all-projects"},{"line_number":139,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":140,"context_line":"   - zone_id: path_zone_id"},{"line_number":141,"context_line":"   - pool_id: zone_pool_id"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Response Parameters"},{"line_number":144,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"f5d02b6c_8a5c0232","line":141,"updated":"2022-10-23 13:18:38.000000000","message":"zone_pool_id is marked as required argument, I think you need to create a variant of the parameter definition marking it optional.","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92f4f4c8da5c00dbb74ac9bea0cf201e888b4f76","unresolved":false,"context_lines":[{"line_number":138,"context_line":"   - x-auth-all-projects: x-auth-all-projects"},{"line_number":139,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":140,"context_line":"   - zone_id: path_zone_id"},{"line_number":141,"context_line":"   - pool_id: zone_pool_id"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Response Parameters"},{"line_number":144,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"fd90abcf_c534c139","line":141,"in_reply_to":"f5d02b6c_8a5c0232","updated":"2022-11-03 09:03:29.000000000","message":"Done","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"db150215f74919b0e261e22c6b5162f8203d77e7","unresolved":true,"context_lines":[{"line_number":141,"context_line":"   - x-auth-all-projects: x-auth-all-projects"},{"line_number":142,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":143,"context_line":"   - zone_id: path_zone_id"},{"line_number":144,"context_line":"   - pool_id: zone_pool_id2"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Response Parameters"},{"line_number":147,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"9e7334e5_9cd62afd","line":144,"updated":"2023-04-17 17:17:33.000000000","message":"maybe zool_pool_target_id?","commit_id":"0a6e2dbf245260e4750c0b235b82046d8874098f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c01a765cc7b5bc38ea4e32c5ce5642bb03e56e04","unresolved":false,"context_lines":[{"line_number":141,"context_line":"   - x-auth-all-projects: x-auth-all-projects"},{"line_number":142,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":143,"context_line":"   - zone_id: path_zone_id"},{"line_number":144,"context_line":"   - pool_id: zone_pool_id2"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Response Parameters"},{"line_number":147,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"e708fcee_f5fe4efe","line":144,"in_reply_to":"9e7334e5_9cd62afd","updated":"2023-04-18 12:31:44.000000000","message":"Done","commit_id":"0a6e2dbf245260e4750c0b235b82046d8874098f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"96f8004889981219fc2719f031f1a39141f02bbc","unresolved":true,"context_lines":[{"line_number":142,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":143,"context_line":"   - zone_id: path_zone_id"},{"line_number":144,"context_line":"   - pool_id: zone_pool_target_id"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Response Parameters"},{"line_number":147,"context_line":"-------------------"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":21,"id":"5d1a9021_afdbfdca","line":145,"updated":"2023-08-10 20:25:36.000000000","message":"For consistency and clarity, since this post call has a body, we should include a json example here.","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"36dfc98dbd8b3bbc15b14a10596cafac302429da","unresolved":false,"context_lines":[{"line_number":142,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":143,"context_line":"   - zone_id: path_zone_id"},{"line_number":144,"context_line":"   - pool_id: zone_pool_target_id"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Response Parameters"},{"line_number":147,"context_line":"-------------------"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":21,"id":"543e33e4_977cc199","line":145,"in_reply_to":"5d1a9021_afdbfdca","updated":"2023-08-21 14:55:14.000000000","message":"Done","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a1468281edf69fcf6ba0f7b8a2d1314c44e7c2d3","unresolved":true,"context_lines":[{"line_number":44,"context_line":"   - x-auth-all-projects: x-auth-all-projects"},{"line_number":45,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":46,"context_line":"   - zone_id: path_zone_id"},{"line_number":47,"context_line":"   - pool_id: pool_id"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Request Example"}],"source_content_type":"text/x-c++src","patch_set":33,"id":"fb3540d0_64a4793b","line":47,"updated":"2023-12-14 19:11:32.000000000","message":"This does not belong under zone abandon, it does not have a pool_id parameter.","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"176558e6feed9dd1d551483457962757e04ff1f9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   - x-auth-all-projects: x-auth-all-projects"},{"line_number":45,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":46,"context_line":"   - zone_id: path_zone_id"},{"line_number":47,"context_line":"   - pool_id: pool_id"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Request Example"}],"source_content_type":"text/x-c++src","patch_set":33,"id":"aa2bf652_deb1e289","line":47,"in_reply_to":"fb3540d0_64a4793b","updated":"2023-12-15 15:51:16.000000000","message":"Done","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a1468281edf69fcf6ba0f7b8a2d1314c44e7c2d3","unresolved":true,"context_lines":[{"line_number":50,"context_line":"Request Example"},{"line_number":51,"context_line":"---------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. literalinclude:: samples/zones/poolmove-zone-request.json"},{"line_number":54,"context_line":"   :language: javascript"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":33,"id":"2d91ebd0_1a381578","line":53,"updated":"2023-12-14 19:11:32.000000000","message":"Same, this example is not for zone abandon.","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"176558e6feed9dd1d551483457962757e04ff1f9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Request Example"},{"line_number":51,"context_line":"---------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. literalinclude:: samples/zones/poolmove-zone-request.json"},{"line_number":54,"context_line":"   :language: javascript"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":33,"id":"3592d4e3_6135124b","line":53,"in_reply_to":"2d91ebd0_1a381578","updated":"2023-12-15 15:51:16.000000000","message":"Done","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a1468281edf69fcf6ba0f7b8a2d1314c44e7c2d3","unresolved":true,"context_lines":[{"line_number":145,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   - x-auth-token: x-auth-token"},{"line_number":148,"context_line":"   - x-auth-all-projects: x-auth-all-projects"},{"line_number":149,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":150,"context_line":"   - zone_id: path_zone_id"},{"line_number":151,"context_line":"   - pool_id: zone_pool_target_id"}],"source_content_type":"text/x-c++src","patch_set":33,"id":"ef00b462_a83b8097","line":148,"updated":"2023-12-14 19:11:32.000000000","message":"Is this used? From the code change, it doesn\u0027t look like this is used.","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"176558e6feed9dd1d551483457962757e04ff1f9","unresolved":true,"context_lines":[{"line_number":145,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   - x-auth-token: x-auth-token"},{"line_number":148,"context_line":"   - x-auth-all-projects: x-auth-all-projects"},{"line_number":149,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":150,"context_line":"   - zone_id: path_zone_id"},{"line_number":151,"context_line":"   - pool_id: zone_pool_target_id"}],"source_content_type":"text/x-c++src","patch_set":33,"id":"5eb697e0_b2d89264","line":148,"in_reply_to":"ef00b462_a83b8097","updated":"2023-12-15 15:51:16.000000000","message":"they are common params, no ?","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"70633b5ae8a09cad981ca5f637de0719611ef319","unresolved":true,"context_lines":[{"line_number":953,"context_line":"  required: true"},{"line_number":954,"context_line":"  type: uuid"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"zone_pool_id2:"},{"line_number":957,"context_line":"  description: |"},{"line_number":958,"context_line":"    ID for the pool hosting this zone"},{"line_number":959,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"204f2dc3_c4517810","line":956,"updated":"2023-04-17 17:18:43.000000000","message":"Maybe same here zone_pool_target_id? \n\u003e ID of the new pool hosting this zone","commit_id":"0a6e2dbf245260e4750c0b235b82046d8874098f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c01a765cc7b5bc38ea4e32c5ce5642bb03e56e04","unresolved":false,"context_lines":[{"line_number":953,"context_line":"  required: true"},{"line_number":954,"context_line":"  type: uuid"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"zone_pool_id2:"},{"line_number":957,"context_line":"  description: |"},{"line_number":958,"context_line":"    ID for the pool hosting this zone"},{"line_number":959,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9054b360_5aec427f","line":956,"in_reply_to":"204f2dc3_c4517810","updated":"2023-04-18 12:31:44.000000000","message":"Done","commit_id":"0a6e2dbf245260e4750c0b235b82046d8874098f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a1468281edf69fcf6ba0f7b8a2d1314c44e7c2d3","unresolved":true,"context_lines":[{"line_number":955,"context_line":""},{"line_number":956,"context_line":"zone_pool_target_id:"},{"line_number":957,"context_line":"  description: |"},{"line_number":958,"context_line":"    ID for the pool hosting this target zone for zone move operation"},{"line_number":959,"context_line":"  in: body"},{"line_number":960,"context_line":"  required: false"},{"line_number":961,"context_line":"  type: uuid"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"2918aaaf_b6537196","line":958,"updated":"2023-12-14 19:11:32.000000000","message":"nit: The target pool ID to move the zone into","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"176558e6feed9dd1d551483457962757e04ff1f9","unresolved":false,"context_lines":[{"line_number":955,"context_line":""},{"line_number":956,"context_line":"zone_pool_target_id:"},{"line_number":957,"context_line":"  description: |"},{"line_number":958,"context_line":"    ID for the pool hosting this target zone for zone move operation"},{"line_number":959,"context_line":"  in: body"},{"line_number":960,"context_line":"  required: false"},{"line_number":961,"context_line":"  type: uuid"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"e7c04dfa_a8d2531d","line":958,"in_reply_to":"2918aaaf_b6537196","updated":"2023-12-15 15:51:16.000000000","message":"Done","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"}],"api-ref/source/samples/zones/poolmove-zone-request.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a1468281edf69fcf6ba0f7b8a2d1314c44e7c2d3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"pool_id\": \"1112e37df46af42089710e2ae39111c2f\""},{"line_number":3,"context_line":"}"}],"source_content_type":"application/json","patch_set":33,"id":"5a1b0f72_8583844e","line":2,"updated":"2023-12-14 19:11:32.000000000","message":"Shouldn\u0027t this be in UUID format with hyphens?","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"176558e6feed9dd1d551483457962757e04ff1f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"pool_id\": \"1112e37df46af42089710e2ae39111c2f\""},{"line_number":3,"context_line":"}"}],"source_content_type":"application/json","patch_set":33,"id":"87b9ae11_cf5e021e","line":2,"in_reply_to":"5a1b0f72_8583844e","updated":"2023-12-15 15:51:16.000000000","message":"Done","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"}],"designate/api/v2/controllers/zones/tasks/move.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"28e507bbc814ded7c1d1d724e5fed5f0b7ff20be","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    @pecan.expose(template\u003d\u0027json:\u0027, content_type\u003d\u0027application/json\u0027)"},{"line_number":31,"context_line":"    @pecan.expose(template\u003d\u0027json:\u0027, content_type\u003d\u0027application/json-patch+json\u0027)"},{"line_number":32,"context_line":"    @utils.validate_uuid(\u0027zone_id\u0027)"},{"line_number":33,"context_line":"    def post_all(self, zone_id):"},{"line_number":34,"context_line":"        \"\"\"Move a zone\"\"\""},{"line_number":35,"context_line":"        request \u003d pecan.request"},{"line_number":36,"context_line":"        response \u003d pecan.response"}],"source_content_type":"text/x-python","patch_set":1,"id":"88b5818e_3fed2935","line":33,"updated":"2021-06-16 14:22:29.000000000","message":"This is an HTTP POST method.","commit_id":"8f74260a64404b857bf42c08c2330ee25cce27f2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"18528e7e90140461250aedc1ba6c0fde2411c5b0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @pecan.expose(template\u003d\u0027json:\u0027, content_type\u003d\u0027application/json\u0027)"},{"line_number":31,"context_line":"    @pecan.expose(template\u003d\u0027json:\u0027, content_type\u003d\u0027application/json-patch+json\u0027)"},{"line_number":32,"context_line":"    @utils.validate_uuid(\u0027zone_id\u0027)"},{"line_number":33,"context_line":"    def post_all(self, zone_id):"},{"line_number":34,"context_line":"        \"\"\"Move a zone\"\"\""},{"line_number":35,"context_line":"        request \u003d pecan.request"},{"line_number":36,"context_line":"        response \u003d pecan.response"}],"source_content_type":"text/x-python","patch_set":1,"id":"83cbdf2a_b4177db1","line":33,"in_reply_to":"88b5818e_3fed2935","updated":"2022-04-30 12:20:19.000000000","message":"Done","commit_id":"8f74260a64404b857bf42c08c2330ee25cce27f2"}],"designate/api/v2/controllers/zones/tasks/pool_move.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"081f35c989a97329ec4f4ab15fded0fa90f11dcc","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        if \u0027pool_id\u0027 in body:"},{"line_number":46,"context_line":"            if zone.pool_id \u003d\u003d body[\u0027pool_id\u0027]:"},{"line_number":47,"context_line":"                raise exceptions.BadRequest("},{"line_number":48,"context_line":"                    \u0027Target pool should be different for zone pool move\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        zone \u003d DesignateAdapter.parse(\u0027API_v2\u0027, body, zone)"},{"line_number":51,"context_line":"        zone.validate()"}],"source_content_type":"text/x-python","patch_set":10,"id":"b4617551_cdcd707c","line":48,"range":{"start_line":48,"start_character":33,"end_line":48,"end_character":39},"updated":"2022-10-23 12:51:36.000000000","message":"s/should/must/","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92f4f4c8da5c00dbb74ac9bea0cf201e888b4f76","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if \u0027pool_id\u0027 in body:"},{"line_number":46,"context_line":"            if zone.pool_id \u003d\u003d body[\u0027pool_id\u0027]:"},{"line_number":47,"context_line":"                raise exceptions.BadRequest("},{"line_number":48,"context_line":"                    \u0027Target pool should be different for zone pool move\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        zone \u003d DesignateAdapter.parse(\u0027API_v2\u0027, body, zone)"},{"line_number":51,"context_line":"        zone.validate()"}],"source_content_type":"text/x-python","patch_set":10,"id":"095a5bfd_06dad7e2","line":48,"range":{"start_line":48,"start_character":33,"end_line":48,"end_character":39},"in_reply_to":"b4617551_cdcd707c","updated":"2022-11-03 09:03:29.000000000","message":"Done","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"081f35c989a97329ec4f4ab15fded0fa90f11dcc","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        zone \u003d DesignateAdapter.parse(\u0027API_v2\u0027, body, zone)"},{"line_number":51,"context_line":"        zone.validate()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        LOG.info(\"Triggered pool move for %(zone)s\", {\u0027zone\u0027: zone})"},{"line_number":54,"context_line":"        zone \u003d self.central_api.pool_move_zone(context, zone)"},{"line_number":55,"context_line":"        if zone.status \u003d\u003d \u0027PENDING\u0027:"},{"line_number":56,"context_line":"            response.status_int \u003d 202"}],"source_content_type":"text/x-python","patch_set":10,"id":"dbf2a49f_56df117f","line":53,"updated":"2022-10-23 12:51:36.000000000","message":"Add the pool_id to the message if present?","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92f4f4c8da5c00dbb74ac9bea0cf201e888b4f76","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        zone \u003d DesignateAdapter.parse(\u0027API_v2\u0027, body, zone)"},{"line_number":51,"context_line":"        zone.validate()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        LOG.info(\"Triggered pool move for %(zone)s\", {\u0027zone\u0027: zone})"},{"line_number":54,"context_line":"        zone \u003d self.central_api.pool_move_zone(context, zone)"},{"line_number":55,"context_line":"        if zone.status \u003d\u003d \u0027PENDING\u0027:"},{"line_number":56,"context_line":"            response.status_int \u003d 202"}],"source_content_type":"text/x-python","patch_set":10,"id":"b0fb52f5_96e290ec","line":53,"in_reply_to":"dbf2a49f_56df117f","updated":"2022-11-03 09:03:29.000000000","message":"Detailed log message added in central/service.py","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"96f8004889981219fc2719f031f1a39141f02bbc","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        body \u003d request.body_dict"},{"line_number":38,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        zone \u003d self.central_api.get_zone(context, zone_id)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        if zone.action \u003d\u003d \"DELETE\":"},{"line_number":43,"context_line":"            raise exceptions.BadRequest(\u0027Can not move a deleting zone\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"dc7eb253_5610a8cb","line":40,"updated":"2023-08-10 20:25:36.000000000","message":"Can we move this validation logic to central and behind an RBAC check? Or move the RBAC check out here?\nget_zone does DB round trips and it is best if we can put that behind an RBAC check so that unauthorized people can\u0027t DDoS the DB.\nThis also means we don\u0027t have to put the zone object on the messaging bus.","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"36dfc98dbd8b3bbc15b14a10596cafac302429da","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        body \u003d request.body_dict"},{"line_number":38,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        zone \u003d self.central_api.get_zone(context, zone_id)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        if zone.action \u003d\u003d \"DELETE\":"},{"line_number":43,"context_line":"            raise exceptions.BadRequest(\u0027Can not move a deleting zone\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"6633cb84_ec94d5b1","line":40,"in_reply_to":"dc7eb253_5610a8cb","updated":"2023-08-21 14:55:14.000000000","message":"the central_api.get_zone() internally has RBAC check. Also, we can not move validation logic to central because we have to update zone object from body and validation is needed before it. I checked other usage of get_zone in desigante/api and followed the same.","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a1468281edf69fcf6ba0f7b8a2d1314c44e7c2d3","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        zone \u003d DesignateAdapter.parse(\u0027API_v2\u0027, body, zone)"},{"line_number":52,"context_line":"        zone.validate()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        LOG.info(\"Triggered pool move for %(zone)s\", {\u0027zone\u0027: zone})"},{"line_number":55,"context_line":"        zone \u003d self.central_api.pool_move_zone(context, zone)"},{"line_number":56,"context_line":"        if zone.status \u003d\u003d \u0027PENDING\u0027:"},{"line_number":57,"context_line":"            response.status_int \u003d 202"}],"source_content_type":"text/x-python","patch_set":33,"id":"d59e541d_4297244b","line":54,"updated":"2023-12-14 19:11:32.000000000","message":"nit: For history in the log, it might be nice to log the target pool_id. It may be None, but if one was specified it would be nice to have.","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"176558e6feed9dd1d551483457962757e04ff1f9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        zone \u003d DesignateAdapter.parse(\u0027API_v2\u0027, body, zone)"},{"line_number":52,"context_line":"        zone.validate()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        LOG.info(\"Triggered pool move for %(zone)s\", {\u0027zone\u0027: zone})"},{"line_number":55,"context_line":"        zone \u003d self.central_api.pool_move_zone(context, zone)"},{"line_number":56,"context_line":"        if zone.status \u003d\u003d \u0027PENDING\u0027:"},{"line_number":57,"context_line":"            response.status_int \u003d 202"}],"source_content_type":"text/x-python","patch_set":33,"id":"f6ab6752_2bcd35c0","line":54,"in_reply_to":"d59e541d_4297244b","updated":"2023-12-15 15:51:16.000000000","message":"that info is added in central/service.py.","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a1468281edf69fcf6ba0f7b8a2d1314c44e7c2d3","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        zone.validate()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        LOG.info(\"Triggered pool move for %(zone)s\", {\u0027zone\u0027: zone})"},{"line_number":55,"context_line":"        zone \u003d self.central_api.pool_move_zone(context, zone)"},{"line_number":56,"context_line":"        if zone.status \u003d\u003d \u0027PENDING\u0027:"},{"line_number":57,"context_line":"            response.status_int \u003d 202"},{"line_number":58,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":33,"id":"930399f2_40098af1","line":55,"updated":"2023-12-14 19:11:32.000000000","message":"nit: We don\u0027t need to pass the whole zone across the RPC bus. It would be better to only pass the needed information, i.e. the zone_id and pool_id.","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"176558e6feed9dd1d551483457962757e04ff1f9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        zone.validate()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        LOG.info(\"Triggered pool move for %(zone)s\", {\u0027zone\u0027: zone})"},{"line_number":55,"context_line":"        zone \u003d self.central_api.pool_move_zone(context, zone)"},{"line_number":56,"context_line":"        if zone.status \u003d\u003d \u0027PENDING\u0027:"},{"line_number":57,"context_line":"            response.status_int \u003d 202"},{"line_number":58,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":33,"id":"97d7ba19_a256e049","line":55,"in_reply_to":"930399f2_40098af1","updated":"2023-12-15 15:51:16.000000000","message":"ok, updated","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"}],"designate/central/service.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"081f35c989a97329ec4f4ab15fded0fa90f11dcc","unresolved":true,"context_lines":[{"line_number":1163,"context_line":""},{"line_number":1164,"context_line":"    @rpc.expected_exceptions()"},{"line_number":1165,"context_line":"    @notification.notify_type(\u0027dns.domain.delete\u0027)"},{"line_number":1166,"context_line":"    @notification.notify_type(\u0027dns.zone.delete\u0027)"},{"line_number":1167,"context_line":"    def pool_move_zone(self, context, zone):"},{"line_number":1168,"context_line":"        \"\"\"Move zone. Perform checks and then create zone in destination pool"},{"line_number":1169,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"033f5030_5afb9a35","line":1166,"updated":"2022-10-23 12:51:36.000000000","message":"Why \"delete\" notifications?","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92f4f4c8da5c00dbb74ac9bea0cf201e888b4f76","unresolved":false,"context_lines":[{"line_number":1163,"context_line":""},{"line_number":1164,"context_line":"    @rpc.expected_exceptions()"},{"line_number":1165,"context_line":"    @notification.notify_type(\u0027dns.domain.delete\u0027)"},{"line_number":1166,"context_line":"    @notification.notify_type(\u0027dns.zone.delete\u0027)"},{"line_number":1167,"context_line":"    def pool_move_zone(self, context, zone):"},{"line_number":1168,"context_line":"        \"\"\"Move zone. Perform checks and then create zone in destination pool"},{"line_number":1169,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"6ed318f9_17c7ef21","line":1166,"in_reply_to":"033f5030_5afb9a35","updated":"2022-11-03 09:03:29.000000000","message":"Done","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"081f35c989a97329ec4f4ab15fded0fa90f11dcc","unresolved":true,"context_lines":[{"line_number":1184,"context_line":"            pool_id \u003d self.scheduler.schedule_zone(context, zone)"},{"line_number":1185,"context_line":"            if pool_id \u003d\u003d orig_pool_id:"},{"line_number":1186,"context_line":"                raise exceptions.BadRequest(\u0027No valid pool selected\u0027)"},{"line_number":1187,"context_line":"            zone.pool_id \u003d pool_id"},{"line_number":1188,"context_line":""},{"line_number":1189,"context_line":"        # Need elevated context to get the pool"},{"line_number":1190,"context_line":"        elevated_context \u003d context.elevated(all_tenants\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":10,"id":"8897cc61_355db00e","line":1187,"updated":"2022-10-23 12:51:36.000000000","message":"IIUC this would update the old zone, which I think is wrong, as we should only set the new pool_id for the cloned zone?","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92f4f4c8da5c00dbb74ac9bea0cf201e888b4f76","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"            pool_id \u003d self.scheduler.schedule_zone(context, zone)"},{"line_number":1185,"context_line":"            if pool_id \u003d\u003d orig_pool_id:"},{"line_number":1186,"context_line":"                raise exceptions.BadRequest(\u0027No valid pool selected\u0027)"},{"line_number":1187,"context_line":"            zone.pool_id \u003d pool_id"},{"line_number":1188,"context_line":""},{"line_number":1189,"context_line":"        # Need elevated context to get the pool"},{"line_number":1190,"context_line":"        elevated_context \u003d context.elevated(all_tenants\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":10,"id":"581d15fe_556276b6","line":1187,"in_reply_to":"8897cc61_355db00e","updated":"2022-11-03 09:03:29.000000000","message":"This is expected, we update the new pool_id of original zone object in DB. New zone object i.e. clone only created on backend.","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"96f8004889981219fc2719f031f1a39141f02bbc","unresolved":true,"context_lines":[{"line_number":1341,"context_line":"        \"\"\""},{"line_number":1342,"context_line":"        target \u003d {"},{"line_number":1343,"context_line":"            \u0027zone_id\u0027: zone.obj_get_original_value(\u0027id\u0027),"},{"line_number":1344,"context_line":"            \u0027tenant_id\u0027: zone.obj_get_original_value(\u0027tenant_id\u0027),"},{"line_number":1345,"context_line":"        }"},{"line_number":1346,"context_line":""},{"line_number":1347,"context_line":"        policy.check(\u0027pool_move_zone\u0027, context, target)"}],"source_content_type":"text/x-python","patch_set":21,"id":"36cfcd1b_dfe80f46","line":1344,"updated":"2023-08-10 20:25:36.000000000","message":"This needs to be fixed for the \"new_defaults\" keystone RBAC.\nSee line 1303 above.","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"36dfc98dbd8b3bbc15b14a10596cafac302429da","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"        \"\"\""},{"line_number":1342,"context_line":"        target \u003d {"},{"line_number":1343,"context_line":"            \u0027zone_id\u0027: zone.obj_get_original_value(\u0027id\u0027),"},{"line_number":1344,"context_line":"            \u0027tenant_id\u0027: zone.obj_get_original_value(\u0027tenant_id\u0027),"},{"line_number":1345,"context_line":"        }"},{"line_number":1346,"context_line":""},{"line_number":1347,"context_line":"        policy.check(\u0027pool_move_zone\u0027, context, target)"}],"source_content_type":"text/x-python","patch_set":21,"id":"f795d7db_8cbff50f","line":1344,"in_reply_to":"36cfcd1b_dfe80f46","updated":"2023-08-21 14:55:14.000000000","message":"Done","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"96f8004889981219fc2719f031f1a39141f02bbc","unresolved":true,"context_lines":[{"line_number":1355,"context_line":"            if pool_id \u003d\u003d orig_pool_id:"},{"line_number":1356,"context_line":"                raise exceptions.BadRequest(\u0027No valid pool selected\u0027)"},{"line_number":1357,"context_line":"            # Update the orignal zone with new pool_id"},{"line_number":1358,"context_line":"            zone.pool_id \u003d pool_id"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        try:"},{"line_number":1361,"context_line":"            # Need elevated context to get the pool"}],"source_content_type":"text/x-python","patch_set":21,"id":"2a0434e0_b6bb21a0","line":1358,"updated":"2023-08-10 20:25:36.000000000","message":"Curious, so this will update the pool_id on the old zone (combined with line 1373), only if no pool_id was passed in via the API. Why would we update it in one case and not the other?","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"36dfc98dbd8b3bbc15b14a10596cafac302429da","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"            if pool_id \u003d\u003d orig_pool_id:"},{"line_number":1356,"context_line":"                raise exceptions.BadRequest(\u0027No valid pool selected\u0027)"},{"line_number":1357,"context_line":"            # Update the orignal zone with new pool_id"},{"line_number":1358,"context_line":"            zone.pool_id \u003d pool_id"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        try:"},{"line_number":1361,"context_line":"            # Need elevated context to get the pool"}],"source_content_type":"text/x-python","patch_set":21,"id":"12684e8e_f3263ceb","line":1358,"in_reply_to":"2a0434e0_b6bb21a0","updated":"2023-08-21 14:55:14.000000000","message":"in designate/api/v2/controllers/zones/tasks/pool_move.py zone is updated with values from body. So if pool_id is specified there, it will be already present in zone.pool_id else we have to get the suitable one and fill in here.","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"96f8004889981219fc2719f031f1a39141f02bbc","unresolved":true,"context_lines":[{"line_number":1371,"context_line":"            raise exceptions.NoServersConfigured()"},{"line_number":1372,"context_line":""},{"line_number":1373,"context_line":"        zone \u003d self._update_zone_in_storage("},{"line_number":1374,"context_line":"                context, zone, increment_serial\u003dTrue)"},{"line_number":1375,"context_line":""},{"line_number":1376,"context_line":"        LOG.info(\"Moving zone \u0027%(zone)s\u0027 to pool \u0027%(pool)s\u0027\","},{"line_number":1377,"context_line":"                 {\u0027zone\u0027: zone.name, \u0027pool\u0027: pool_id})"}],"source_content_type":"text/x-python","patch_set":21,"id":"7b48719f_6cfd5b8f","line":1374,"updated":"2023-08-10 20:25:36.000000000","message":"Why do we need to increment the serial number here?\nAll I see is you changed the pool_id in the zone, which is not part of the DNS zone that would be transferred to secondaries.","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"36dfc98dbd8b3bbc15b14a10596cafac302429da","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"            raise exceptions.NoServersConfigured()"},{"line_number":1372,"context_line":""},{"line_number":1373,"context_line":"        zone \u003d self._update_zone_in_storage("},{"line_number":1374,"context_line":"                context, zone, increment_serial\u003dTrue)"},{"line_number":1375,"context_line":""},{"line_number":1376,"context_line":"        LOG.info(\"Moving zone \u0027%(zone)s\u0027 to pool \u0027%(pool)s\u0027\","},{"line_number":1377,"context_line":"                 {\u0027zone\u0027: zone.name, \u0027pool\u0027: pool_id})"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a2dc38d_ee0306ba","line":1374,"in_reply_to":"7b48719f_6cfd5b8f","updated":"2023-08-21 14:55:14.000000000","message":"ok, remoevd","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"96f8004889981219fc2719f031f1a39141f02bbc","unresolved":true,"context_lines":[{"line_number":1381,"context_line":"        clone_zone.action \u003d \u0027CREATE\u0027"},{"line_number":1382,"context_line":"        clone_zone.status \u003d \u0027PENDING\u0027"},{"line_number":1383,"context_line":"        self.worker_api.create_zone(context, clone_zone)"},{"line_number":1384,"context_line":""},{"line_number":1385,"context_line":"        return clone_zone"},{"line_number":1386,"context_line":""},{"line_number":1387,"context_line":"    # RecordSet Methods"}],"source_content_type":"text/x-python","patch_set":21,"id":"f8a39566_3172cfad","line":1384,"updated":"2023-08-10 20:25:36.000000000","message":"What happens to the old zone? Will we have two with the same zone ID?","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"36dfc98dbd8b3bbc15b14a10596cafac302429da","unresolved":false,"context_lines":[{"line_number":1381,"context_line":"        clone_zone.action \u003d \u0027CREATE\u0027"},{"line_number":1382,"context_line":"        clone_zone.status \u003d \u0027PENDING\u0027"},{"line_number":1383,"context_line":"        self.worker_api.create_zone(context, clone_zone)"},{"line_number":1384,"context_line":""},{"line_number":1385,"context_line":"        return clone_zone"},{"line_number":1386,"context_line":""},{"line_number":1387,"context_line":"    # RecordSet Methods"}],"source_content_type":"text/x-python","patch_set":21,"id":"dc77428f_a2018784","line":1384,"in_reply_to":"f8a39566_3172cfad","updated":"2023-08-21 14:55:14.000000000","message":"As per spec,\n1) After DB update, designate will create copy of zone (can also be called as clone) except it should not create new db entry for the clone zone. The clone zone will be created on target pool backend servers i.e. pool B.\n2) The zone transfer(AXFR/IXFR) will happen and the zone on pool B gets synced with  the designate DB.\n3) At this point zone still exists in pool A. It can be removed after the administrator has changed the settings manually at domain registrar. This is a manual process.\n\nhttps://review.opendev.org/c/openstack/designate-specs/+/794705","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"23179885f659983d9b236ae38bd0f877d9e36c7e","unresolved":true,"context_lines":[{"line_number":1384,"context_line":"        orig_pool_ns_records \u003d self._get_pool_ns_records(context,"},{"line_number":1385,"context_line":"                                                         orig_pool_id)"},{"line_number":1386,"context_line":""},{"line_number":1387,"context_line":"        target_ns \u003d set([n.hostname for n in target_pool_ns_records])"},{"line_number":1388,"context_line":"        orig_ns \u003d set([n.hostname for n in orig_pool_ns_records])"},{"line_number":1389,"context_line":"        create_ns \u003d target_ns.difference(orig_ns)"},{"line_number":1390,"context_line":"        delete_ns \u003d orig_ns.difference(target_ns)"}],"source_content_type":"text/x-python","patch_set":29,"id":"146ccedd_ef843795","line":1387,"updated":"2023-11-09 11:27:52.000000000","message":"pyupgrade recommend the following changes.\n\u003e pyupgrade --py38-plus $(git ls-files | grep \".py$\")\n\n-        target_ns \u003d set([n.hostname for n in target_pool_ns_records])\n-        orig_ns \u003d set([n.hostname for n in orig_pool_ns_records])\n+        target_ns \u003d {n.hostname for n in target_pool_ns_records}\n+        orig_ns \u003d {n.hostname for n in orig_pool_ns_records}","commit_id":"46f8cc33461f75af5dd96b2cbf0be4e8ea5f099b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4c9895597339a099e65135265ae091fca388652c","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"        orig_pool_ns_records \u003d self._get_pool_ns_records(context,"},{"line_number":1385,"context_line":"                                                         orig_pool_id)"},{"line_number":1386,"context_line":""},{"line_number":1387,"context_line":"        target_ns \u003d set([n.hostname for n in target_pool_ns_records])"},{"line_number":1388,"context_line":"        orig_ns \u003d set([n.hostname for n in orig_pool_ns_records])"},{"line_number":1389,"context_line":"        create_ns \u003d target_ns.difference(orig_ns)"},{"line_number":1390,"context_line":"        delete_ns \u003d orig_ns.difference(target_ns)"}],"source_content_type":"text/x-python","patch_set":29,"id":"2afdfa42_0cf43959","line":1387,"in_reply_to":"146ccedd_ef843795","updated":"2023-11-09 12:27:10.000000000","message":"Done","commit_id":"46f8cc33461f75af5dd96b2cbf0be4e8ea5f099b"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"23179885f659983d9b236ae38bd0f877d9e36c7e","unresolved":true,"context_lines":[{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"        LOG.info(\"Moving zone \u0027%(zone)s\u0027 to pool \u0027%(pool)s\u0027\","},{"line_number":1404,"context_line":"                 {\u0027zone\u0027: zone.name, \u0027pool\u0027: target_pool_id})"},{"line_number":1405,"context_line":"        clone_zone \u003d copy.deepcopy(zone)"},{"line_number":1406,"context_line":"        clone_zone.pool_id \u003d target_pool_id"},{"line_number":1407,"context_line":"        clone_zone.refresh \u003d self._generate_soa_refresh_interval()"},{"line_number":1408,"context_line":"        clone_zone.action \u003d \u0027CREATE\u0027"}],"source_content_type":"text/x-python","patch_set":29,"id":"f729531d_f1b6884b","line":1405,"updated":"2023-11-09 11:27:52.000000000","message":"I don\u0027t think we need to make a copy of the zone here, we aren\u0027t re-using the original zone object anywhere later on in the code.","commit_id":"46f8cc33461f75af5dd96b2cbf0be4e8ea5f099b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4c9895597339a099e65135265ae091fca388652c","unresolved":false,"context_lines":[{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"        LOG.info(\"Moving zone \u0027%(zone)s\u0027 to pool \u0027%(pool)s\u0027\","},{"line_number":1404,"context_line":"                 {\u0027zone\u0027: zone.name, \u0027pool\u0027: target_pool_id})"},{"line_number":1405,"context_line":"        clone_zone \u003d copy.deepcopy(zone)"},{"line_number":1406,"context_line":"        clone_zone.pool_id \u003d target_pool_id"},{"line_number":1407,"context_line":"        clone_zone.refresh \u003d self._generate_soa_refresh_interval()"},{"line_number":1408,"context_line":"        clone_zone.action \u003d \u0027CREATE\u0027"}],"source_content_type":"text/x-python","patch_set":29,"id":"5d7ab26a_89c6bd61","line":1405,"in_reply_to":"f729531d_f1b6884b","updated":"2023-11-09 12:27:10.000000000","message":"Done","commit_id":"46f8cc33461f75af5dd96b2cbf0be4e8ea5f099b"}],"designate/common/policies/zone.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"081f35c989a97329ec4f4ab15fded0fa90f11dcc","unresolved":true,"context_lines":[{"line_number":102,"context_line":")"},{"line_number":103,"context_line":"deprecated_pool_move_zone \u003d policy.DeprecatedRule("},{"line_number":104,"context_line":"    name\u003d\"pool_move_zone\","},{"line_number":105,"context_line":"    check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":106,"context_line":"    deprecated_reason\u003dDEPRECATED_REASON,"},{"line_number":107,"context_line":"    deprecated_since\u003dversionutils.deprecated.WALLABY"},{"line_number":108,"context_line":")"}],"source_content_type":"text/x-python","patch_set":10,"id":"27e8fcd2_cd71eb32","line":105,"updated":"2022-10-23 12:51:36.000000000","message":"From the spec this should be admin-only?","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92f4f4c8da5c00dbb74ac9bea0cf201e888b4f76","unresolved":false,"context_lines":[{"line_number":102,"context_line":")"},{"line_number":103,"context_line":"deprecated_pool_move_zone \u003d policy.DeprecatedRule("},{"line_number":104,"context_line":"    name\u003d\"pool_move_zone\","},{"line_number":105,"context_line":"    check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":106,"context_line":"    deprecated_reason\u003dDEPRECATED_REASON,"},{"line_number":107,"context_line":"    deprecated_since\u003dversionutils.deprecated.WALLABY"},{"line_number":108,"context_line":")"}],"source_content_type":"text/x-python","patch_set":10,"id":"99f919ef_2e61dc9d","line":105,"in_reply_to":"27e8fcd2_cd71eb32","updated":"2022-11-03 09:03:29.000000000","message":"Done","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"081f35c989a97329ec4f4ab15fded0fa90f11dcc","unresolved":true,"context_lines":[{"line_number":245,"context_line":"    ),"},{"line_number":246,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":247,"context_line":"        name\u003d\"pool_move_zone\","},{"line_number":248,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":249,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":250,"context_line":"        description\u003d\"Pool Move Zone\","},{"line_number":251,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":10,"id":"a9f65d32_cd00bf6e","line":248,"updated":"2022-10-23 12:51:36.000000000","message":"dito","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92f4f4c8da5c00dbb74ac9bea0cf201e888b4f76","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    ),"},{"line_number":246,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":247,"context_line":"        name\u003d\"pool_move_zone\","},{"line_number":248,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":249,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":250,"context_line":"        description\u003d\"Pool Move Zone\","},{"line_number":251,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":10,"id":"4f23b392_ccfa484b","line":248,"in_reply_to":"a9f65d32_cd00bf6e","updated":"2022-11-03 09:03:29.000000000","message":"Done","commit_id":"64db5510547336e6c2673d319bd72e49998ebfc2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a1468281edf69fcf6ba0f7b8a2d1314c44e7c2d3","unresolved":true,"context_lines":[{"line_number":247,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":248,"context_line":"        name\u003d\"pool_move_zone\","},{"line_number":249,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN,"},{"line_number":250,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":251,"context_line":"        description\u003d\"Pool Move Zone\","},{"line_number":252,"context_line":"        operations\u003d["},{"line_number":253,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":33,"id":"50b28fd2_93d5af87","line":250,"updated":"2023-12-14 19:11:32.000000000","message":"These should be constants.","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"176558e6feed9dd1d551483457962757e04ff1f9","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":248,"context_line":"        name\u003d\"pool_move_zone\","},{"line_number":249,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN,"},{"line_number":250,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":251,"context_line":"        description\u003d\"Pool Move Zone\","},{"line_number":252,"context_line":"        operations\u003d["},{"line_number":253,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":33,"id":"0a7d4056_848d8c77","line":250,"in_reply_to":"50b28fd2_93d5af87","updated":"2023-12-15 15:51:16.000000000","message":"Done","commit_id":"8560c9641178b17cf320f2b3287f15097a5643c9"}],"designate/mdns/handler.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"96f8004889981219fc2719f031f1a39141f02bbc","unresolved":true,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        if tsigkey is None and CONF[\u0027service:mdns\u0027].query_enforce_tsig:"},{"line_number":188,"context_line":"            raise exceptions.Forbidden(\u0027Request is not TSIG signed\u0027)"},{"line_number":189,"context_line":"        elif tsigkey is not None:"},{"line_number":190,"context_line":"            if tsigkey.scope \u003d\u003d \u0027POOL\u0027:"},{"line_number":191,"context_line":"                criterion[\u0027pool_id\u0027] \u003d tsigkey.resource_id"},{"line_number":192,"context_line":"            elif tsigkey.scope \u003d\u003d \u0027ZONE\u0027:"}],"source_content_type":"text/x-python","patch_set":21,"id":"e034707d_44bfb343","line":189,"updated":"2023-08-10 20:25:36.000000000","message":"Why did you make this change? This change could potentially allow unprotected queries that were previously blocked.\nI.e. if tsigkey from the request is none, that will now return the zone data.","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"36dfc98dbd8b3bbc15b14a10596cafac302429da","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        if tsigkey is None and CONF[\u0027service:mdns\u0027].query_enforce_tsig:"},{"line_number":188,"context_line":"            raise exceptions.Forbidden(\u0027Request is not TSIG signed\u0027)"},{"line_number":189,"context_line":"        elif tsigkey is not None:"},{"line_number":190,"context_line":"            if tsigkey.scope \u003d\u003d \u0027POOL\u0027:"},{"line_number":191,"context_line":"                criterion[\u0027pool_id\u0027] \u003d tsigkey.resource_id"},{"line_number":192,"context_line":"            elif tsigkey.scope \u003d\u003d \u0027ZONE\u0027:"}],"source_content_type":"text/x-python","patch_set":21,"id":"2df758d0_3fe1588f","line":189,"in_reply_to":"e034707d_44bfb343","updated":"2023-08-21 14:55:14.000000000","message":"the case of tsigkey is None was making sure criteria of pool_id which was not allowing to update pool_id. Thus needs to change the condition.","commit_id":"693eb3b8d83cf6adff22ada149ba03a3d8c3c168"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a1468281edf69fcf6ba0f7b8a2d1314c44e7c2d3","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        elif tsigkey is None:"},{"line_number":181,"context_line":"            # Default to using the default_pool_id when no TSIG key is"},{"line_number":182,"context_line":"            # available"},{"line_number":183,"context_line":"            criterion[\u0027pool_id\u0027] \u003d CONF[\u0027service:central\u0027].default_pool_id"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            if tsigkey.scope \u003d\u003d \u0027POOL\u0027:"},{"line_number":186,"context_line":"                criterion[\u0027pool_id\u0027] \u003d tsigkey.resource_id"}],"source_content_type":"text/x-python","patch_set":33,"id":"80a8a632_a72bcc32","side":"PARENT","line":183,"updated":"2023-12-14 19:11:32.000000000","message":"This should not change. This is filtering query requests. If no TSIG key was provided, the zone can only exist in the default pool, or it\u0027s an error.\nIf you have moved a zone to a different pool, the pool must be configured with a proper tsig key for mini-DNS query operations.\nWithout this, you cannot have overlapping zones in different pools.","commit_id":"d90691f3a29416dbb209b52aae288a5916bca632"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"176558e6feed9dd1d551483457962757e04ff1f9","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        elif tsigkey is None:"},{"line_number":181,"context_line":"            # Default to using the default_pool_id when no TSIG key is"},{"line_number":182,"context_line":"            # available"},{"line_number":183,"context_line":"            criterion[\u0027pool_id\u0027] \u003d CONF[\u0027service:central\u0027].default_pool_id"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            if tsigkey.scope \u003d\u003d \u0027POOL\u0027:"},{"line_number":186,"context_line":"                criterion[\u0027pool_id\u0027] \u003d tsigkey.resource_id"}],"source_content_type":"text/x-python","patch_set":33,"id":"b4dc70d5_ff259e48","side":"PARENT","line":183,"in_reply_to":"80a8a632_a72bcc32","updated":"2023-12-15 15:51:16.000000000","message":"ok, updated. Also added info in releasenotes.","commit_id":"d90691f3a29416dbb209b52aae288a5916bca632"}],"designate/tests/test_api/test_v2/test_zones.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"df500c29617dae97ff34e25202e42ea3ba74142c","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        pool_id \u003d zone.pool_id"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        body \u003d {\u0027pool_id\u0027: pool_id}"},{"line_number":482,"context_line":"        self._assert_exception(\u0027bad_request\u0027, 400, self.client.patch_json,"},{"line_number":483,"context_line":"                               \u0027/zones/%s/tasks/move\u0027 % zone[\u0027id\u0027], body)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def test_get_zone_tasks(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6e76a61_02ce22a7","line":482,"updated":"2021-06-16 14:21:22.000000000","message":"This is using a PATCH HTTP method in this test, but the API code is for POST.","commit_id":"8f74260a64404b857bf42c08c2330ee25cce27f2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"18528e7e90140461250aedc1ba6c0fde2411c5b0","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        pool_id \u003d zone.pool_id"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        body \u003d {\u0027pool_id\u0027: pool_id}"},{"line_number":482,"context_line":"        self._assert_exception(\u0027bad_request\u0027, 400, self.client.patch_json,"},{"line_number":483,"context_line":"                               \u0027/zones/%s/tasks/move\u0027 % zone[\u0027id\u0027], body)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def test_get_zone_tasks(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e8aa8fae_280b91d1","line":482,"in_reply_to":"e6e76a61_02ce22a7","updated":"2022-04-30 12:20:19.000000000","message":"Done","commit_id":"8f74260a64404b857bf42c08c2330ee25cce27f2"}]}