)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c1d507a2bf9d2ba9aa51d8e95e91f66eecfb7ce9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0635a349_bfcccf16","updated":"2021-10-21 21:50:50.000000000","message":"I am ok with this. I would like to see a release note, but that can follow.","commit_id":"4807c23228fbb23af3087ee072bf73d7fc43aff5"}],"designate/notification_handler/base.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b8d9c20db6159768fc9d65ee02e2a38eabb8ce91","unresolved":true,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        recordset_ids \u003d []"},{"line_number":215,"context_line":"        for record in records:"},{"line_number":216,"context_line":"            recordset_ids.append(record[\u0027recordset_id\u0027])"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        for recordset_id in set(recordset_ids):"},{"line_number":219,"context_line":"            LOG.debug(\u0027Deleting recordset %s\u0027, recordset_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"aef1e400_f3654e47","line":216,"updated":"2021-10-18 18:13:14.000000000","message":"I\u0027m not sure that this is correct, what happens if the recordset contains other records that should not be deleted? I\u0027d say this needs something similar to the _create_or_update_recordset() function above. And best also add a test for that scenarion then.","commit_id":"655d641f806ddac12b257d9b8d2d4b14c3bf791e"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"1ef712ff59d296fd1a5c2bb761653f578c6f97d9","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        recordset_ids \u003d []"},{"line_number":215,"context_line":"        for record in records:"},{"line_number":216,"context_line":"            recordset_ids.append(record[\u0027recordset_id\u0027])"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        for recordset_id in set(recordset_ids):"},{"line_number":219,"context_line":"            LOG.debug(\u0027Deleting recordset %s\u0027, recordset_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"90d887d1_86052792","line":216,"in_reply_to":"a5175fd6_0dab2a7c","updated":"2021-10-19 01:54:33.000000000","message":"Done","commit_id":"655d641f806ddac12b257d9b8d2d4b14c3bf791e"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"b38ecd90c565a54e2e221f35d688e35ad47876a1","unresolved":true,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        recordset_ids \u003d []"},{"line_number":215,"context_line":"        for record in records:"},{"line_number":216,"context_line":"            recordset_ids.append(record[\u0027recordset_id\u0027])"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        for recordset_id in set(recordset_ids):"},{"line_number":219,"context_line":"            LOG.debug(\u0027Deleting recordset %s\u0027, recordset_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c408444d_58286d7b","line":216,"in_reply_to":"aef1e400_f3654e47","updated":"2021-10-18 18:23:10.000000000","message":"If you look at the create code it will only ever create one with a single record. Someone could in theory manually edit the record of course, but in general the design intent was that a managed record should only be managed by the sink. This was of course before recordsets were a thing.\n\u003e [Record(**record_values)]\n\nThe ideal thing here would be that the managed properties were moved to the recordset, but that would require database changes / migrations.","commit_id":"655d641f806ddac12b257d9b8d2d4b14c3bf791e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"354796d607ce62ef9132c1f8cc6c6ef727d196f2","unresolved":true,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        recordset_ids \u003d []"},{"line_number":215,"context_line":"        for record in records:"},{"line_number":216,"context_line":"            recordset_ids.append(record[\u0027recordset_id\u0027])"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        for recordset_id in set(recordset_ids):"},{"line_number":219,"context_line":"            LOG.debug(\u0027Deleting recordset %s\u0027, recordset_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"cac6b3e2_2e2afe76","line":216,"in_reply_to":"c408444d_58286d7b","updated":"2021-10-18 20:36:46.000000000","message":"I\u0027m not very familiar with the notification sink and it\u0027s capabilities, but this seems like a behavior change that could impact someone that is trying to do round-robin.\nCan they build a round-robin recordset via the sink?","commit_id":"655d641f806ddac12b257d9b8d2d4b14c3bf791e"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"35cbef4747e90a5d644b8a6454272008cce33ee7","unresolved":true,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        recordset_ids \u003d []"},{"line_number":215,"context_line":"        for record in records:"},{"line_number":216,"context_line":"            recordset_ids.append(record[\u0027recordset_id\u0027])"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        for recordset_id in set(recordset_ids):"},{"line_number":219,"context_line":"            LOG.debug(\u0027Deleting recordset %s\u0027, recordset_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a5175fd6_0dab2a7c","line":216,"in_reply_to":"cac6b3e2_2e2afe76","updated":"2021-10-18 20:40:47.000000000","message":"Great callout Jens and Michael. Historically that wasn\u0027t possible, but looking at the code it might work today.","commit_id":"655d641f806ddac12b257d9b8d2d4b14c3bf791e"}]}