)]}'
{"designate/api/v2/controllers/fixedips.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"89b00e0539c144a82a57e0fd462c99d70074fced","unresolved":false,"context_lines":[{"line_number":29,"context_line":"REGION_REGEX \u003d \u0027^(?P\u003cregion\u003e[A-Za-z0-9\\\\.\\\\-_]{1,100})$\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def address_key_to_data(key):"},{"line_number":33,"context_line":"    region, address \u003d key.split(\u0027:\u0027, 1)"},{"line_number":34,"context_line":"    match \u003d re.match(REGION_REGEX, region)"},{"line_number":35,"context_line":"    isv4address \u003d format.is_ipv4(address)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F907w%3D","line":32,"updated":"2014-04-01 21:03:58.000000000","message":"Do we need a region name for fixed ips? There will already be an issue if overlapping ip space is turned on in neutron... until we get private servers in place, there will not be the ablity to have overlapping zone names.","commit_id":"4a608d494cbbb53b0e20b3b92c9b271438697661"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"c214d5abe71ecc7f0acb13eb1668657ab22d138c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"REGION_REGEX \u003d \u0027^(?P\u003cregion\u003e[A-Za-z0-9\\\\.\\\\-_]{1,100})$\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def address_key_to_data(key):"},{"line_number":33,"context_line":"    region, address \u003d key.split(\u0027:\u0027, 1)"},{"line_number":34,"context_line":"    match \u003d re.match(REGION_REGEX, region)"},{"line_number":35,"context_line":"    isv4address \u003d format.is_ipv4(address)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9vxU%3D","line":32,"in_reply_to":"AAAAWH%2F907w%3D","updated":"2014-04-02 12:42:15.000000000","message":"Good question - overlapping IP space and multi-region are the big questions.","commit_id":"4a608d494cbbb53b0e20b3b92c9b271438697661"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"c214d5abe71ecc7f0acb13eb1668657ab22d138c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    region, address \u003d key.split(\u0027:\u0027, 1)"},{"line_number":34,"context_line":"    match \u003d re.match(REGION_REGEX, region)"},{"line_number":35,"context_line":"    isv4address \u003d format.is_ipv4(address)"},{"line_number":36,"context_line":"    isv6address \u003d format.is_ipv6(address)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # NOTE: Ensure that the address matches region:address or raise, if"},{"line_number":39,"context_line":"    # not this will cause a 500."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9vw8%3D","line":36,"updated":"2014-04-02 12:42:15.000000000","message":"Totally a style nitpick.. but whatever :)\n\n    isaddress \u003d format.is_ipv4(address) or format.is_ipv6(address)","commit_id":"4a608d494cbbb53b0e20b3b92c9b271438697661"}],"designate/api/v2/views/fixedips.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"c214d5abe71ecc7f0acb13eb1668657ab22d138c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def _get_base_href(self, parents\u003dNone):"},{"line_number":29,"context_line":"        return \u0027%s/reverse/fixedips\u0027 % self.base_uri"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def show_basic(self, context, request, item):"},{"line_number":32,"context_line":"        item[\u0027address\u0027] \u003d \":\".join([item.pop(\u0027region\u0027), item.pop(\u0027address\u0027)])"},{"line_number":33,"context_line":"        item[\u0027links\u0027] \u003d self._get_resource_links("},{"line_number":34,"context_line":"            request, item, [item[\u0027address\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9vuo%3D","line":31,"updated":"2014-04-02 12:42:15.000000000","message":"So, the floatingips view IMO has a bug which you\u0027ve copied :)\n\nWe generally try and be very explicit here in the view about what gets returned e.g. [1]. The idea being that, if a new field is added internally to the FixedIP \"item\" passed in here, it shouldn\u0027t trigger an API change.\n\nI\u0027ll fix the floating IP view in a couple of mins :)\n\n[1]: https://github.com/stackforge/designate/blob/master/designate/api/v2/views/zones.py","commit_id":"4a608d494cbbb53b0e20b3b92c9b271438697661"}],"designate/central/service.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"c214d5abe71ecc7f0acb13eb1668657ab22d138c","unresolved":false,"context_lines":[{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        return data, invalid"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"    def _invalidate_records(self, context, records):"},{"line_number":1102,"context_line":"        \"\"\""},{"line_number":1103,"context_line":"        Utility method to delete a list of records."},{"line_number":1104,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9vtk%3D","line":1101,"updated":"2014-04-02 12:42:15.000000000","message":"_invalidate_records feels too generic to me, I think we\u0027ll want to call it _invalidate_managed_records or something?","commit_id":"4a608d494cbbb53b0e20b3b92c9b271438697661"}]}