)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e406283d0035ed2892df367214f6a88d30115d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c95f2666_54992265","updated":"2021-12-03 21:13:04.000000000","message":"recheck","commit_id":"553755d3a6911e3fba7419f73923fdd14a309592"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"eb8d3d5c1da6dbba7ac6386147bb34d642b95747","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ea03b32e_4e31d5fb","updated":"2022-01-28 17:56:32.000000000","message":"I agree with johnsom that we should probably refactor the agent \u0026 notify handling of _make_and_send_dns_message to handle lower level EAGAIN type errors that were documented with minidns (https://bugs.launchpad.net/designate/+bug/1558096 and https://review.opendev.org/c/openstack/designate/+/293578) and I understand that the agent will never talk to minidns, but lower level errors should be most like handled in the designate.dnsutils, such that it can be handled at a lower level. EAGAIN type of socket non-blocking issues can happen regardless of the end point.","commit_id":"2a43bf1c62fc811512b616839d1dcfe454b1bf1c"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"fd4ef6e63bb3ba43afcda3bba7f3989ce396ebd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"725d8f0f_17d64697","in_reply_to":"ea03b32e_4e31d5fb","updated":"2022-01-28 19:51:32.000000000","message":"Sure, I agree, but this change is just meant to make the code easier to read. I am not going to make any functional changes, as we have no functional test coverage on any of these code paths.","commit_id":"2a43bf1c62fc811512b616839d1dcfe454b1bf1c"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"3d4ba565986d35080666e34f2f693b8636417b14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"57c48772_91559c3b","updated":"2022-02-06 01:50:42.000000000","message":"recheck unknown failure","commit_id":"d586f190db51622423643dbc583686acc915f979"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"94c0e662aca0e0bad2240563ef5ffb933ed2af7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9bee50a6_0c79c1be","updated":"2022-05-05 17:16:41.000000000","message":"LGTM","commit_id":"e5d2fc0657ff71800283b0211b00a32e6e320b6f"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"b60b43127d9c5c9012d76dcb782e3ab15d2b0bbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"522c2643_cbcca2f5","updated":"2022-05-05 01:47:37.000000000","message":"This patch makes it easier to remove some unused mdns code.","commit_id":"e5d2fc0657ff71800283b0211b00a32e6e320b6f"}],"designate/backend/agent.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0704f990e17581aac4d62c7e4f1652575ee0dbbf","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        if response is None:"},{"line_number":105,"context_line":"            raise exceptions.Backend(\u0027Failed delete_zone()\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _make_and_send_dns_message(self, zone_name, timeout, opcode,"},{"line_number":108,"context_line":"                                   rdatatype, rdclass, dest_ip,"},{"line_number":109,"context_line":"                                   dest_port):"},{"line_number":110,"context_line":"        dns_message \u003d self._make_dns_message("}],"source_content_type":"text/x-python","patch_set":5,"id":"727e7881_c7591645","line":107,"updated":"2021-12-03 20:49:14.000000000","message":"Is there a reason we have very similar methods here and in designate/mdns/notify.py? Could these also be consolidated?","commit_id":"553755d3a6911e3fba7419f73923fdd14a309592"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"8d408bb2a91f33a91a4deca2f1c0230b1d8447c9","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        if response is None:"},{"line_number":105,"context_line":"            raise exceptions.Backend(\u0027Failed delete_zone()\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _make_and_send_dns_message(self, zone_name, timeout, opcode,"},{"line_number":108,"context_line":"                                   rdatatype, rdclass, dest_ip,"},{"line_number":109,"context_line":"                                   dest_port):"},{"line_number":110,"context_line":"        dns_message \u003d self._make_dns_message("}],"source_content_type":"text/x-python","patch_set":5,"id":"7173675b_48e23960","line":107,"in_reply_to":"40fcb556_59d58f4c","updated":"2021-12-04 21:41:37.000000000","message":"They are similar, but there are differences that I do not understand and wouldn\u0027t be comfortable changing without having some functional tests around the agent code.","commit_id":"553755d3a6911e3fba7419f73923fdd14a309592"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"038fba6f853c8f483c7edc2a13ddb64912182d5f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        if response is None:"},{"line_number":105,"context_line":"            raise exceptions.Backend(\u0027Failed delete_zone()\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _make_and_send_dns_message(self, zone_name, timeout, opcode,"},{"line_number":108,"context_line":"                                   rdatatype, rdclass, dest_ip,"},{"line_number":109,"context_line":"                                   dest_port):"},{"line_number":110,"context_line":"        dns_message \u003d self._make_dns_message("}],"source_content_type":"text/x-python","patch_set":5,"id":"61171833_de813598","line":107,"in_reply_to":"7173675b_48e23960","updated":"2021-12-14 05:21:46.000000000","message":"Ack","commit_id":"553755d3a6911e3fba7419f73923fdd14a309592"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e406283d0035ed2892df367214f6a88d30115d92","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        if response is None:"},{"line_number":105,"context_line":"            raise exceptions.Backend(\u0027Failed delete_zone()\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _make_and_send_dns_message(self, zone_name, timeout, opcode,"},{"line_number":108,"context_line":"                                   rdatatype, rdclass, dest_ip,"},{"line_number":109,"context_line":"                                   dest_port):"},{"line_number":110,"context_line":"        dns_message \u003d self._make_dns_message("}],"source_content_type":"text/x-python","patch_set":5,"id":"40fcb556_59d58f4c","line":107,"in_reply_to":"727e7881_c7591645","updated":"2021-12-03 21:13:04.000000000","message":"I\u0027ll take a look.","commit_id":"553755d3a6911e3fba7419f73923fdd14a309592"}]}