)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"621051025726658d9257aad4558cd61bd8405457","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9f9edb62_53971a73","updated":"2022-01-09 08:21:54.000000000","message":"recheck getting more test data","commit_id":"1a758d7e02d48a013c9bc56353a11aa5ad4744d4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"da7a66c12569cdca044e913e89fbcf4cdfa63df4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"36b29958_b1039a97","updated":"2022-01-25 07:47:37.000000000","message":"Seems mostly fine as far as I understand things, I\u0027m just worried about the possible implications of the RPC change, seems we haven\u0027t touched this for five years or so.","commit_id":"47ca776ac4e81d90851e7470b9cc7a9b666116c9"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"7728a3c667badfe41ce380e302540603464ffeed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"adfef818_8c637c8c","updated":"2022-01-29 01:54:42.000000000","message":"recheck","commit_id":"6187551f51fd20928ae86de1d548e1701e5d24d4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3d1191852109a5a6563c118c205e0ed81a7a85c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"9ba45b1d_2e9f2f53","updated":"2022-02-02 06:59:39.000000000","message":"I think I\u0027m fine with the code now, just a comment about the reno.","commit_id":"d22fddfdf0c61a9ff892a82e08982a8c3a2edce5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d4eadd6481e0af0fd0d9a538c99713b0d369872d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"7d6e89fb_deab9aa9","updated":"2022-02-04 23:52:25.000000000","message":"I think this looks ok to me. Thanks!","commit_id":"f4c5f7717fd398d21796fbfa4a7d720b8bf8df1a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4d4b4e1d4c5d3e5421d6054112ee2ee2b423550e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"cbea46e7_78cfccab","updated":"2022-02-06 08:02:57.000000000","message":"Re-applying previous +2 after typo fix.","commit_id":"3c495ed76dae17a0d74d4afe5b666f6068cafa47"}],"designate/central/rpcapi.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"da7a66c12569cdca044e913e89fbcf4cdfa63df4","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        6.0 - Renamed domains to zones"},{"line_number":63,"context_line":"        6.1 - Add ServiceStatus methods"},{"line_number":64,"context_line":"        6.2 - Changed \u0027find_recordsets\u0027 method args"},{"line_number":65,"context_line":"        6.3 - Changed `update_status` method args"},{"line_number":66,"context_line":"    \"\"\""},{"line_number":67,"context_line":"    RPC_API_VERSION \u003d \u00276.3\u0027"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"60f9414e_7c7e3526","line":65,"updated":"2022-01-25 07:47:37.000000000","message":"Would this have to be a major version bump since the update isn\u0027t backwards compatible? I\u0027m also wondering how an update in a multi-controller setting would work, likely not too graceful? Probably at least some kind of release note would be needed?","commit_id":"47ca776ac4e81d90851e7470b9cc7a9b666116c9"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ca4b5d295ecea49ab2089cae604d3e2bef3039da","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        6.0 - Renamed domains to zones"},{"line_number":63,"context_line":"        6.1 - Add ServiceStatus methods"},{"line_number":64,"context_line":"        6.2 - Changed \u0027find_recordsets\u0027 method args"},{"line_number":65,"context_line":"        6.3 - Changed `update_status` method args"},{"line_number":66,"context_line":"    \"\"\""},{"line_number":67,"context_line":"    RPC_API_VERSION \u003d \u00276.3\u0027"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dd4c5d72_f9e7d370","line":65,"in_reply_to":"60f9414e_7c7e3526","updated":"2022-01-25 18:00:15.000000000","message":"In theory I could probably make it backwards compatible.","commit_id":"47ca776ac4e81d90851e7470b9cc7a9b666116c9"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"bbaf16a259b71c0c8713dbbd462806bdbd22e35c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        6.0 - Renamed domains to zones"},{"line_number":63,"context_line":"        6.1 - Add ServiceStatus methods"},{"line_number":64,"context_line":"        6.2 - Changed \u0027find_recordsets\u0027 method args"},{"line_number":65,"context_line":"        6.3 - Changed `update_status` method args"},{"line_number":66,"context_line":"    \"\"\""},{"line_number":67,"context_line":"    RPC_API_VERSION \u003d \u00276.3\u0027"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"2ba8a171_dde58e64","line":65,"in_reply_to":"dd4c5d72_f9e7d370","updated":"2022-01-25 18:06:31.000000000","message":"Added release note and made the call backwards compatible (in theory).","commit_id":"47ca776ac4e81d90851e7470b9cc7a9b666116c9"}],"releasenotes/notes/rpc-version-update-f87b852b361d0aad.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3d1191852109a5a6563c118c205e0ed81a7a85c7","unresolved":true,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Designate Central RPC API version updated and may not be backwards"},{"line_number":5,"context_line":"    compatible with older version of the Designate API."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"2e405ce4_34e76da6","line":5,"updated":"2022-02-02 06:59:39.000000000","message":"Do you mean to also say RPC_API here? All in all this comment seems pretty vague, not sure how a deployer would know how to react on it. Maybe add a note that special care is needed for multi-controller deployments?","commit_id":"d22fddfdf0c61a9ff892a82e08982a8c3a2edce5"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"d7c087c32ccf393d3974ecac19db08bfc686b623","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Designate Central RPC API version updated and may not be backwards"},{"line_number":5,"context_line":"    compatible with older version of the Designate API."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"b42b9373_5eb0cbce","line":5,"in_reply_to":"24e558ad_f10a5dc3","updated":"2022-02-02 20:19:35.000000000","message":"Updated. Let me know if that works.","commit_id":"d22fddfdf0c61a9ff892a82e08982a8c3a2edce5"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"334c1af8aebc7e1006806477a430bcc4fc1c9f8b","unresolved":true,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Designate Central RPC API version updated and may not be backwards"},{"line_number":5,"context_line":"    compatible with older version of the Designate API."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"24e558ad_f10a5dc3","line":5,"in_reply_to":"2e405ce4_34e76da6","updated":"2022-02-02 18:15:35.000000000","message":"Yep - exactly. Will update. In fact the Designate API is fully backwards compatible. It\u0027s really just central/worker.","commit_id":"d22fddfdf0c61a9ff892a82e08982a8c3a2edce5"}]}