)]}'
{"id":"openstack%2Fdesignate~828844","triplet_id":"openstack%2Fdesignate~stable%2Fvictoria~If8bc6043d95f52f67899a5ac69a2f72c8fd4de17","project":"openstack/designate","branch":"stable/victoria","topic":"bug/1847200-stable/xena-stable/wallaby-stable/victoria","attention_set":{},"removed_from_attention_set":{"11628":{"account":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"last_update":"2022-02-18 19:08:53.000000000","reason":"Michael Johnson replied on the change"}},"hashtags":[],"change_id":"If8bc6043d95f52f67899a5ac69a2f72c8fd4de17","subject":"Fix recordset_records quota enforcement","status":"MERGED","created":"2022-02-12 18:25:44.000000000","updated":"2022-02-18 21:16:48.000000000","submitted":"2022-02-18 21:14:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"828844-bug/1847200-stable/xena-stable/wallaby-stable/victoria","cherry_pick_of_change":828843,"cherry_pick_of_patch_set":1,"meta_rev_id":"9e62358ac65bc26bc4d6fec06130d9013ce50aa3","_number":828844,"virtual_id_number":828844,"owner":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-02-18 21:14:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-02-15 02:56:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-02-17 21:29:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"CC":[{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-12 18:25:44.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"state":"CC"},{"updated":"2022-02-12 19:29:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-02-15 02:56:05.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"}],"messages":[{"id":"5c5edcd79c87f75f0659af3cfe94bfb9fe050280","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2022-02-12 18:25:44.000000000","message":"Patch Set 1: Cherry Picked from branch stable/wallaby.","accounts_in_message":[],"_revision_number":1},{"id":"60a7dfacec321d1b6461c3c3674d548a38e1dafa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-12 19:29:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/753457c89c5045e1aa435f5f49cb3ec5 : SUCCESS in 35m 43s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/073a1040b4114398a5e209b072ea030f : SUCCESS in 31m 34s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/a481ff32f834491c8e89b3b561e3f6e6 : SUCCESS in 41m 04s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/07fded299c4941c89b7ef642a2c9a25e : SUCCESS in 28m 06s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/fe800e0812ad460695a08d24935c519e : SUCCESS in 28m 34s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bf52a47e00d344b994d92239d367f751 : SUCCESS in 5m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4db83d374e794c22a85fc7299afcd45a : SUCCESS in 4m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9d66403af85c4fb6b89803a5526859dd : SUCCESS in 4m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b5d27a8f8cd0483e8d1794575626caed : SUCCESS in 5m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/76ebcf45ef444b67979b1646313e35ca : SUCCESS in 8m 49s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b28677b15c164be19dc52940030afa4c : SUCCESS in 3m 58s\n- neutron-tempest-plugin-designate-scenario-victoria https://zuul.opendev.org/t/openstack/build/0030fa2414264250b0c418c40f7a47e2 : SUCCESS in 27m 18s","accounts_in_message":[],"_revision_number":1},{"id":"518edfde11ccbe70c420fa50b460a264dfff5995","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2022-02-15 02:56:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"77fbd73a38a0349f81fbebf89f3bc8fbe04c1f1b","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2022-02-17 21:29:22.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4265a6817b0b36eb59ae8bc19a913cbbb0e59eb3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-17 21:30:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"02afd1d04156465565086e027997b955ca4edf0d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-18 01:14:23.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/db681f65d0684dbab4999e7f482cf58f : SUCCESS in 57m 21s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/1ede0bb23d944fb09a5ab9a61caf3947 : SUCCESS in 47m 57s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/2b9cde04b6504bcb888975b0b7b5d54c : FAILURE in 1h 00m 21s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/7223ecf615e4488ba65e81a29a449f70 : SUCCESS in 42m 21s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/2fadfb23860d47c1b3a412ee8d32eec2 : SUCCESS in 46m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f464ea3b320e4a53b3ede9acc893677e : SUCCESS in 4m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cee95323cd2945d285ad318f01af9729 : SUCCESS in 5m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/663dac82764449d09e28a7eaad0ff723 : SUCCESS in 5m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ddab3554baed4b899a9aa81b496948f4 : SUCCESS in 8m 57s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/00b31162ec23417eaf6e6e70d3be6f81 : SUCCESS in 4m 35s","accounts_in_message":[],"_revision_number":1},{"id":"81a6db0c350b077efb131f7a36f6a62421d34c66","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2022-02-18 19:08:53.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"93a891c9b8f4e261cc851b7f0bfdd7998d38df33","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-18 20:07:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/deab2395d57340759e03ae74a3a4b2cf : SUCCESS in 40m 06s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/810690382a9041c5abdab03f66fea55c : SUCCESS in 37m 24s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/86473d74557a41cd9f78841607019b8e : SUCCESS in 57m 49s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/2c54bf65c6bb4e0794b263b854119cd4 : SUCCESS in 42m 45s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/987003cb0745448e985c44b2f94820c9 : SUCCESS in 39m 28s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ee5702bfcedf4e18a9b493c25ea17baa : SUCCESS in 5m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0364d49c7fe14e8090e71705883ac91c : SUCCESS in 4m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d22b20c9c57649a285922ed85a35ce6e : SUCCESS in 6m 55s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e4463cbbee3241a3b958c9cc393cb420 : SUCCESS in 5m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/38472695d01e429a9d635c96fc6793af : SUCCESS in 10m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4b88af7dbab44ed8aeddca8412d836bd : SUCCESS in 4m 11s\n- neutron-tempest-plugin-designate-scenario-victoria https://zuul.opendev.org/t/openstack/build/ca852a60177141a78c5e43aceabf5c89 : SUCCESS in 53m 18s","accounts_in_message":[],"_revision_number":1},{"id":"70cd9c4b67cec6915179c884f73ddac1ce7b8626","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-18 20:09:04.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5a19abaeb893f83f81e88e214be4200a825c63af","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-18 21:14:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/d69da44f7ab3428598511614e4ad8113 : SUCCESS in 48m 51s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/c640937685444dd7a1237137cf2c02d5 : SUCCESS in 44m 50s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/f246e30683d44da4ba47408784a4ed1e : SUCCESS in 1h 05m 28s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/6e9acedae6b24917afbd995cccbb69b2 : SUCCESS in 46m 12s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/2162264fa927493e8a3808e5802d008a : SUCCESS in 47m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e3310b83606342c8a4758a5724ef7ee4 : SUCCESS in 3m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d1c4b96fb25e4ea984456b9f0e8ac1e9 : SUCCESS in 5m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e53d07adccad430cb249e2d46ce4626d : SUCCESS in 4m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2d019132ed934033907e9bf06a4c07b0 : SUCCESS in 7m 18s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ea5d751c11c647a58ed3362558dcd91c : SUCCESS in 4m 09s","accounts_in_message":[],"_revision_number":1},{"id":"cdd4d130abc9288e6ad4aab65ab3df1ceb6f0612","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-18 21:14:44.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"9e62358ac65bc26bc4d6fec06130d9013ce50aa3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-18 21:16:48.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7174af426ffb4209a08561e6c8ccfe9c : SUCCESS in 1m 20s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2e7cf682013741f7942c27dcddde92c9 : SUCCESS in 1m 17s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6d1479a8d998c5ecaeef1671de47323bbfc6fefc","revisions":{"6d1479a8d998c5ecaeef1671de47323bbfc6fefc":{"kind":"REWORK","_number":1,"created":"2022-02-12 18:25:44.000000000","uploader":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"ref":"refs/changes/44/828844/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/44/828844/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/44/828844/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/44/828844/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/44/828844/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/44/828844/1"}}},"commit":{"parents":[{"commit":"1a2c3ca74b73f20508fcbea4e344f4e2976be931","subject":"Fix race condition in the sink when deleting records","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/1a2c3ca74b73f20508fcbea4e344f4e2976be931"}]}],"author":{"name":"zhouhenglc","email":"zhouhenglc@inspur.com","date":"2019-10-08 07:54:40.000000000","tz":480},"committer":{"name":"Michael Johnson","email":"johnsomor@gmail.com","date":"2022-02-12 18:25:44.000000000","tz":0},"subject":"Fix recordset_records quota enforcement","message":"Fix recordset_records quota enforcement\n\nFirst I set recordset_records\u003d3, and I can create recordset with 4 records\nsuccessfully.\nNow enforce record quota by count records in database. when create recordset\nthe number in database is 0., and quotas will not work no matter how much\nquota recordset_records are set. And once the excess quota is created\nsuccessfully, it can not be updated. Unless quotas are updated.\n\nCloses-Bug: #1847200\n\nChange-Id: If8bc6043d95f52f67899a5ac69a2f72c8fd4de17\n(cherry picked from commit df10ff5b5c76657e4287b36fbf525ad91091dd34)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/6d1479a8d998c5ecaeef1671de47323bbfc6fefc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/6d1479a8d998c5ecaeef1671de47323bbfc6fefc"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}