)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"261c2ac9dc2ba37aa56d47bf2d2a05cebefa8ef6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"60bd23f5_9f1b5b6f","updated":"2022-02-25 18:32:49.000000000","message":"See comments.","commit_id":"755d955c1e27a30c85ac45f4e8c61de7ea6c6eb8"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"bf421b67c297d8e212eb1610b5dcfd3e400cb1dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5e8330f1_b4acfd5b","updated":"2022-02-28 22:04:24.000000000","message":"LGTM","commit_id":"772615f7072df987858af388cab1073ed01eedd7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"2626f2df6f3943f22c1619cec328b782ab65c8e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"51ced5b7_a05b195a","updated":"2022-02-28 19:03:29.000000000","message":"recheck","commit_id":"772615f7072df987858af388cab1073ed01eedd7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a396da40840380feac60d78bda2b3882d92d97e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b0d047bf_0b351bb4","updated":"2022-02-28 06:15:01.000000000","message":"recheck","commit_id":"772615f7072df987858af388cab1073ed01eedd7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"d3ab65560bf08645a88aafd61ed1c4ea261b4163","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2dc25429_02687319","updated":"2022-02-26 20:11:28.000000000","message":"recheck digest:crypto error","commit_id":"772615f7072df987858af388cab1073ed01eedd7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e92e1217c567a1d1d3567836aa1938b9f3d2b86e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6288a9d0_eac1ac41","updated":"2022-02-25 21:00:06.000000000","message":"recheck digest:crypto error","commit_id":"772615f7072df987858af388cab1073ed01eedd7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a2f5cc47b872890df3638b1d9b63d39393445558","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"939d9d5a_79e04bca","updated":"2022-02-26 02:36:16.000000000","message":"recheck digest:crypto error","commit_id":"772615f7072df987858af388cab1073ed01eedd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2739683fb4fc70d81adec15fa5f4f5d99c95e6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"91750ae6_add3052d","updated":"2022-03-02 17:30:32.000000000","message":"I have a couple of questions.","commit_id":"56fe66399ff39ad8f0b4a03f9fa95bf567d7d2e7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2252aad882dc952967f3afa0fa6d2a6dbd395ec1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"497aa3f7_7719dab2","updated":"2022-03-03 19:59:27.000000000","message":"I am ok with this.","commit_id":"93ebb1af53d216982210cff21a1bde87489ed0f1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"bd315cd582eb105716e60be04de4894c7d71863c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"060136ab_b1295810","updated":"2022-03-04 04:14:12.000000000","message":"Moving this ahead as it fixes a regression bug, as well as a general designate bug.","commit_id":"93ebb1af53d216982210cff21a1bde87489ed0f1"}],"designate/central/service.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2739683fb4fc70d81adec15fa5f4f5d99c95e6f","unresolved":true,"context_lines":[{"line_number":2012,"context_line":"                LOG.debug(\u0027No recordset found for %s\u0027, fip[\u0027id\u0027])"},{"line_number":2013,"context_line":"                return fip_ptr"},{"line_number":2014,"context_line":""},{"line_number":2015,"context_line":"        if recordset.action in constants.FLOATING_IP_ACTIONS:"},{"line_number":2016,"context_line":"            fip_ptr[\u0027action\u0027] \u003d recordset.action"},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"        if recordset.status in constants.FLOATING_IP_STATUSES:"}],"source_content_type":"text/x-python","patch_set":10,"id":"02bcade0_ef553b0d","line":2015,"updated":"2022-03-02 17:30:32.000000000","message":"Should we log if the state is not a valid FLIP Action?","commit_id":"56fe66399ff39ad8f0b4a03f9fa95bf567d7d2e7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"cf198ab574f5ab39e0a53dc90c7b25eca24f3dae","unresolved":true,"context_lines":[{"line_number":2012,"context_line":"                LOG.debug(\u0027No recordset found for %s\u0027, fip[\u0027id\u0027])"},{"line_number":2013,"context_line":"                return fip_ptr"},{"line_number":2014,"context_line":""},{"line_number":2015,"context_line":"        if recordset.action in constants.FLOATING_IP_ACTIONS:"},{"line_number":2016,"context_line":"            fip_ptr[\u0027action\u0027] \u003d recordset.action"},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"        if recordset.status in constants.FLOATING_IP_STATUSES:"}],"source_content_type":"text/x-python","patch_set":10,"id":"6aba80a6_2e3f4fce","line":2015,"in_reply_to":"02bcade0_ef553b0d","updated":"2022-03-02 18:26:32.000000000","message":"Good idea. Will implement that. It should in theory be impossible, but don\u0027t trust the over arching design here, so logging would help us understand this path better.","commit_id":"56fe66399ff39ad8f0b4a03f9fa95bf567d7d2e7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ac21f5fc6c3b9b2f75ccddff6458ec461e66f746","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"                LOG.debug(\u0027No recordset found for %s\u0027, fip[\u0027id\u0027])"},{"line_number":2013,"context_line":"                return fip_ptr"},{"line_number":2014,"context_line":""},{"line_number":2015,"context_line":"        if recordset.action in constants.FLOATING_IP_ACTIONS:"},{"line_number":2016,"context_line":"            fip_ptr[\u0027action\u0027] \u003d recordset.action"},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"        if recordset.status in constants.FLOATING_IP_STATUSES:"}],"source_content_type":"text/x-python","patch_set":10,"id":"39ffe0f3_c1b5ac16","line":2015,"in_reply_to":"6aba80a6_2e3f4fce","updated":"2022-03-03 02:21:35.000000000","message":"Done","commit_id":"56fe66399ff39ad8f0b4a03f9fa95bf567d7d2e7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2739683fb4fc70d81adec15fa5f4f5d99c95e6f","unresolved":true,"context_lines":[{"line_number":2015,"context_line":"        if recordset.action in constants.FLOATING_IP_ACTIONS:"},{"line_number":2016,"context_line":"            fip_ptr[\u0027action\u0027] \u003d recordset.action"},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"        if recordset.status in constants.FLOATING_IP_STATUSES:"},{"line_number":2019,"context_line":"            fip_ptr[\u0027status\u0027] \u003d recordset.status"},{"line_number":2020,"context_line":""},{"line_number":2021,"context_line":"        if recordset.ttl is not None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"70ac09ea_0b8c90a8","line":2018,"updated":"2022-03-02 17:30:32.000000000","message":"Should we log if the state is not a valid FLIP Status?","commit_id":"56fe66399ff39ad8f0b4a03f9fa95bf567d7d2e7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ac21f5fc6c3b9b2f75ccddff6458ec461e66f746","unresolved":false,"context_lines":[{"line_number":2015,"context_line":"        if recordset.action in constants.FLOATING_IP_ACTIONS:"},{"line_number":2016,"context_line":"            fip_ptr[\u0027action\u0027] \u003d recordset.action"},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"        if recordset.status in constants.FLOATING_IP_STATUSES:"},{"line_number":2019,"context_line":"            fip_ptr[\u0027status\u0027] \u003d recordset.status"},{"line_number":2020,"context_line":""},{"line_number":2021,"context_line":"        if recordset.ttl is not None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"580b8677_53f8f891","line":2018,"in_reply_to":"70ac09ea_0b8c90a8","updated":"2022-03-03 02:21:35.000000000","message":"Done","commit_id":"56fe66399ff39ad8f0b4a03f9fa95bf567d7d2e7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2739683fb4fc70d81adec15fa5f4f5d99c95e6f","unresolved":true,"context_lines":[{"line_number":2022,"context_line":"            fip_ptr[\u0027ttl\u0027] \u003d recordset.ttl"},{"line_number":2023,"context_line":"        else:"},{"line_number":2024,"context_line":"            if not zone:"},{"line_number":2025,"context_line":"                zone \u003d self.get_zone("},{"line_number":2026,"context_line":"                    elevated_context, record.zone_id"},{"line_number":2027,"context_line":"                )"},{"line_number":2028,"context_line":"            fip_ptr[\u0027ttl\u0027] \u003d zone.ttl"}],"source_content_type":"text/x-python","patch_set":10,"id":"15dc9ceb_e82c30e9","line":2025,"updated":"2022-03-02 17:30:32.000000000","message":"Just to be cautious, can we catch not found here as well and return the partial fip_ptr?\nThat would imply moving the two record extractions up.","commit_id":"56fe66399ff39ad8f0b4a03f9fa95bf567d7d2e7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"cf198ab574f5ab39e0a53dc90c7b25eca24f3dae","unresolved":true,"context_lines":[{"line_number":2022,"context_line":"            fip_ptr[\u0027ttl\u0027] \u003d recordset.ttl"},{"line_number":2023,"context_line":"        else:"},{"line_number":2024,"context_line":"            if not zone:"},{"line_number":2025,"context_line":"                zone \u003d self.get_zone("},{"line_number":2026,"context_line":"                    elevated_context, record.zone_id"},{"line_number":2027,"context_line":"                )"},{"line_number":2028,"context_line":"            fip_ptr[\u0027ttl\u0027] \u003d zone.ttl"}],"source_content_type":"text/x-python","patch_set":10,"id":"728bab70_42d78e02","line":2025,"in_reply_to":"15dc9ceb_e82c30e9","updated":"2022-03-02 18:26:32.000000000","message":"Yea - we could do that. I don\u0027t see how we would end up in a situation where the zone does not exists, since we are locked here (maybe without Zookeeper), but does not hurt.","commit_id":"56fe66399ff39ad8f0b4a03f9fa95bf567d7d2e7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ac21f5fc6c3b9b2f75ccddff6458ec461e66f746","unresolved":false,"context_lines":[{"line_number":2022,"context_line":"            fip_ptr[\u0027ttl\u0027] \u003d recordset.ttl"},{"line_number":2023,"context_line":"        else:"},{"line_number":2024,"context_line":"            if not zone:"},{"line_number":2025,"context_line":"                zone \u003d self.get_zone("},{"line_number":2026,"context_line":"                    elevated_context, record.zone_id"},{"line_number":2027,"context_line":"                )"},{"line_number":2028,"context_line":"            fip_ptr[\u0027ttl\u0027] \u003d zone.ttl"}],"source_content_type":"text/x-python","patch_set":10,"id":"69481310_6ee55762","line":2025,"in_reply_to":"728bab70_42d78e02","updated":"2022-03-03 02:21:35.000000000","message":"Done","commit_id":"56fe66399ff39ad8f0b4a03f9fa95bf567d7d2e7"}],"releasenotes/notes/new-ptr-status-69958252a2f294c9.yaml":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"261c2ac9dc2ba37aa56d47bf2d2a05cebefa8ef6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new enum called ``inactive`` to the floating ip status that is"},{"line_number":5,"context_line":"    used to indicate that the floating ip does not currently have a dns record"},{"line_number":6,"context_line":"    assosicated with it."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5ba999c8_6c7add3d","line":4,"updated":"2022-02-25 18:32:49.000000000","message":"Maybe better wording:\nAdded a state ``INACTIVE`` to the floating IP status to indicate that it is not currently associated to a DNS record.","commit_id":"755d955c1e27a30c85ac45f4e8c61de7ea6c6eb8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"db7a1ead169a5f9e8ca488b7c0613c59e0cbd5fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new enum called ``inactive`` to the floating ip status that is"},{"line_number":5,"context_line":"    used to indicate that the floating ip does not currently have a dns record"},{"line_number":6,"context_line":"    assosicated with it."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c1fab04a_fe81a886","line":4,"in_reply_to":"5ba999c8_6c7add3d","updated":"2022-02-25 18:54:28.000000000","message":"Done","commit_id":"755d955c1e27a30c85ac45f4e8c61de7ea6c6eb8"}]}