)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"6e66e05fc5213a77da443b4155ecc0f44a64926d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"89277199_8b826dbe","updated":"2022-04-06 03:41:31.000000000","message":"recheck","commit_id":"e67fc23fdd0d77a71c2dd7f6e896ab7f1f6ee978"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"56c39079154577be2836662692b805944a576438","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"44cbcbe5_f9508f34","updated":"2022-04-07 22:04:58.000000000","message":"LGTM","commit_id":"147e00f44febebf8089a93b58d739dbe174c9f4e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"065b041f8698f8db2d2bbbcb1c2dd8710413823e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8c7ea1d9_fe7226ec","updated":"2022-04-12 20:44:08.000000000","message":"LGTM\nThanks!","commit_id":"147e00f44febebf8089a93b58d739dbe174c9f4e"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"06a03a1c7037326e287acc6a5871b133169fe254","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7b0ee847_6793165f","updated":"2022-04-13 23:31:44.000000000","message":"recheck","commit_id":"147e00f44febebf8089a93b58d739dbe174c9f4e"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"0216e8078f59712d8dfdb3e5f240aa2f8724ba7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b2c935eb_62e999cf","updated":"2022-04-12 22:33:16.000000000","message":"recheck","commit_id":"147e00f44febebf8089a93b58d739dbe174c9f4e"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ef2c919c458399d06068826badedf6a57bf1aa44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4e049a6b_da67054f","updated":"2022-04-14 04:27:17.000000000","message":"recheck general devstack failure","commit_id":"147e00f44febebf8089a93b58d739dbe174c9f4e"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a7cebcc26920857797b6225b6fcf24e65dee59de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7b45feb5_819a0b8d","in_reply_to":"44cbcbe5_f9508f34","updated":"2022-04-08 01:17:23.000000000","message":"Thanks. If you have time, could you compare the logs from before and after and let me know if they are easier to read now? e.g. \n\nNew version\nhttps://zuul.opendev.org/t/openstack/build/9b484207c2bc49dea3a89a2fad5e7eef/log/controller/logs/screen-designate-worker.txt\n\nOld version\nhttps://zuul.opendev.org/t/openstack/build/b2a6dea2994445479de6040a3151dc7b/log/controller/logs/screen-designate-worker.txt","commit_id":"147e00f44febebf8089a93b58d739dbe174c9f4e"}],"designate/worker/service.py":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"9c1c723186d268e89292752c6b241665f192b624","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                if len(pool.targets) \u003e 0:"},{"line_number":92,"context_line":"                    has_targets \u003d True"},{"line_number":93,"context_line":"                else:"},{"line_number":94,"context_line":"                    LOG.error(\u0027No targets for %s found.\u0027, pool)"},{"line_number":95,"context_line":"                    time.sleep(5)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            # Pool data may not have migrated to the DB yet"}],"source_content_type":"text/x-python","patch_set":13,"id":"dc660411_1f834f86","line":94,"updated":"2022-04-07 14:07:27.000000000","message":"I\u0027m confused, I see your changing the double quotes to single quotes, on these two error messages, but you don\u0027t change line #133. By making the change at all seem confusing because according to PEP8 and python in general double quotes or single quotes resolve the same meaning, but the mixture lends itself to confusion. SO I would suggest either change them all or leave them alone.","commit_id":"263f13b0d6ea030a6adbde21b2cdc6353ee9b782"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"613fde409e211f2ec19b81f7cb25544636ce5772","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                if len(pool.targets) \u003e 0:"},{"line_number":92,"context_line":"                    has_targets \u003d True"},{"line_number":93,"context_line":"                else:"},{"line_number":94,"context_line":"                    LOG.error(\u0027No targets for %s found.\u0027, pool)"},{"line_number":95,"context_line":"                    time.sleep(5)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            # Pool data may not have migrated to the DB yet"}],"source_content_type":"text/x-python","patch_set":13,"id":"f3f3f4a7_6ba97662","line":94,"in_reply_to":"7726f400_f261e58e","updated":"2022-04-07 17:16:43.000000000","message":"Done","commit_id":"263f13b0d6ea030a6adbde21b2cdc6353ee9b782"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"d373491bb03fa71a795a38baf7a1b9054e5cb62a","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                if len(pool.targets) \u003e 0:"},{"line_number":92,"context_line":"                    has_targets \u003d True"},{"line_number":93,"context_line":"                else:"},{"line_number":94,"context_line":"                    LOG.error(\u0027No targets for %s found.\u0027, pool)"},{"line_number":95,"context_line":"                    time.sleep(5)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            # Pool data may not have migrated to the DB yet"}],"source_content_type":"text/x-python","patch_set":13,"id":"7726f400_f261e58e","line":94,"in_reply_to":"dc660411_1f834f86","updated":"2022-04-07 17:05:53.000000000","message":"this is a heavy -1 for a nit pick, but can change 133 as well. its fine to mix, but I much prefer consistency when using ‘ or “. it is however not picking and an irrelevant change.","commit_id":"263f13b0d6ea030a6adbde21b2cdc6353ee9b782"}]}
