)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d12f77838a7b3389e4b95ebceec88c8425c033ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cf99e5c4_99055558","updated":"2022-04-13 21:23:03.000000000","message":"One quick question about the \"NONE\" action and this patch. Otherwise looks good.","commit_id":"76d908a7e55c4be9b391ba7637e85fdf041822f0"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"f768e6c2955d172a7be52ef0021ad47ad7e2c00a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"69a5eea6_3fb02235","updated":"2022-04-12 16:50:18.000000000","message":"recheck","commit_id":"76d908a7e55c4be9b391ba7637e85fdf041822f0"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"6805ed06211dee66e24be312be9eaa21ae773038","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a852c836_d56904fc","updated":"2022-04-18 20:58:18.000000000","message":"LGTM","commit_id":"52f28da077d52c99cfeaab5322a167534b2d3858"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"fc2ea4deb55693a919da9880b39ac68a28849f97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3dc18bc3_65bd9615","updated":"2022-04-27 06:03:33.000000000","message":"recheck package mirror failed","commit_id":"51f9148d43442ef39660800c516d008b46beb34f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5319cadaaa4cde8256e71a76a18e90451612054e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"8ae2fdf1_2d739308","updated":"2022-05-04 22:36:07.000000000","message":"LGTM","commit_id":"dc45a03563bc075242b4d27dfbc6d340166c1c0c"}],"designate/worker/tasks/base.py":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"1e502e7a730c1981ba9d9da2088ff9d521f8f624","unresolved":true,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            zone \u003d self.storage.get_zone(context, zone.id)"},{"line_number":171,"context_line":"            if action !\u003d zone.action:"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"                LOG.info("},{"line_number":174,"context_line":"                    \u0027Failed to %(action)s zone_name\u003d%(zone_name)s \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"fd85ec96_be78816a","line":171,"updated":"2022-04-12 22:07:41.000000000","message":"Can you provide some background here, if the action your passing is the current zone.action would that be a problem, or in the case of an UPDATE action are you going to stack these together into a single zone transfer , for example? And in the case of a delete, if the zone.action is currently in an UPDATE, I\u0027m assuming you wait until its complete before issuing the delete task?","commit_id":"76d908a7e55c4be9b391ba7637e85fdf041822f0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d12f77838a7b3389e4b95ebceec88c8425c033ff","unresolved":true,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            zone \u003d self.storage.get_zone(context, zone.id)"},{"line_number":171,"context_line":"            if action !\u003d zone.action:"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"                LOG.info("},{"line_number":174,"context_line":"                    \u0027Failed to %(action)s zone_name\u003d%(zone_name)s \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9dee9376_b62a5e6c","line":171,"range":{"start_line":171,"start_character":25,"end_line":171,"end_character":36},"updated":"2022-04-13 21:23:03.000000000","message":"So looking in the database enum for the actions, for some wacky reason there is a \"NONE\". I would guess we don\u0027t want to cancel the retries on a valid action if the DB goes to NONE right?","commit_id":"76d908a7e55c4be9b391ba7637e85fdf041822f0"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"b21fe46f47ce2b6ec6f238c1082e0536264ea456","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            zone \u003d self.storage.get_zone(context, zone.id)"},{"line_number":171,"context_line":"            if action !\u003d zone.action:"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"                LOG.info("},{"line_number":174,"context_line":"                    \u0027Failed to %(action)s zone_name\u003d%(zone_name)s \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9e39f00c_f19b7ebb","line":171,"in_reply_to":"57b2273d_5349bdc8","updated":"2022-04-13 14:47:49.000000000","message":"Thanks for the clarification.","commit_id":"76d908a7e55c4be9b391ba7637e85fdf041822f0"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"3d2ff8660da382dbbf23abbac78fe507e1fb0c80","unresolved":true,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            zone \u003d self.storage.get_zone(context, zone.id)"},{"line_number":171,"context_line":"            if action !\u003d zone.action:"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"                LOG.info("},{"line_number":174,"context_line":"                    \u0027Failed to %(action)s zone_name\u003d%(zone_name)s \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"e10db4c8_43e8db00","line":171,"range":{"start_line":171,"start_character":25,"end_line":171,"end_character":36},"in_reply_to":"9dee9376_b62a5e6c","updated":"2022-04-14 06:24:58.000000000","message":"Great question. NONE basically means that there is nothing to do. Hmm. Let me think about this.","commit_id":"76d908a7e55c4be9b391ba7637e85fdf041822f0"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ae326d4b48af9a04d9712b3c6dc3120701bc7ca2","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            zone \u003d self.storage.get_zone(context, zone.id)"},{"line_number":171,"context_line":"            if action !\u003d zone.action:"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"                LOG.info("},{"line_number":174,"context_line":"                    \u0027Failed to %(action)s zone_name\u003d%(zone_name)s \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"49a646dc_f6507d4f","line":171,"range":{"start_line":171,"start_character":25,"end_line":171,"end_character":36},"in_reply_to":"e10db4c8_43e8db00","updated":"2022-04-17 19:55:55.000000000","message":"So NONE pretty much means that the \"previous\" action was completed successfully.\nhttps://github.com/openstack/designate/blob/master/designate/central/service.py#L2411\n\nSince all actions to the worker originate from central, it should be safe to assume that if action is NONE (or DELETE) the currently pending options have all been successful, since the serial is checked in central.","commit_id":"76d908a7e55c4be9b391ba7637e85fdf041822f0"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"f88b0f2daa159c52c1b75f4ade381a5cdad909ad","unresolved":true,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            zone \u003d self.storage.get_zone(context, zone.id)"},{"line_number":171,"context_line":"            if action !\u003d zone.action:"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"                LOG.info("},{"line_number":174,"context_line":"                    \u0027Failed to %(action)s zone_name\u003d%(zone_name)s \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"57b2273d_5349bdc8","line":171,"in_reply_to":"fd85ec96_be78816a","updated":"2022-04-12 22:20:53.000000000","message":"The issue here is primarily if you create a zone and instantly delete it. The worker logic (NOTIFY) will get stuck retrying because the zone is gone. This causes a ton of unnecessary log spam. Another issue is if you create or update a record and then delete the zone the same thing will happen. Since the zone is gone there is nothing to update.\n\nWe could probably make this code safer by only stopping when the zone has already been deleted, but I believe that we cannot go from action CREATE to UPDATE without the zone first being successfully completed. We should verify that though.","commit_id":"76d908a7e55c4be9b391ba7637e85fdf041822f0"}]}