)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a4ab0a4e589166fe4ee058cce3eb9d5dff1259ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c020f83c_77e03951","updated":"2022-05-05 06:00:53.000000000","message":"recheck","commit_id":"0557413007cbe9f7d7166a15ece02cc5459777f8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"822a16e3c79334f1c50335921c93940aa0354459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"885ffd74_682c4efe","updated":"2022-05-05 21:12:55.000000000","message":"LGTM, Just one nit comment about making the base back to abstract","commit_id":"5d5d83e511acbf5d6f34e9a998ff16d96c5bb162"}],"designate/backend/agent.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"822a16e3c79334f1c50335921c93940aa0354459","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def update_zone(self, context, zone):"},{"line_number":81,"context_line":"        LOG.debug(\u0027Update Zone\u0027)"},{"line_number":82,"context_line":"        self.mdns_api.notify_zone_changed("},{"line_number":83,"context_line":"            context,"},{"line_number":84,"context_line":"            zone,"},{"line_number":85,"context_line":"            self.host,"}],"source_content_type":"text/x-python","patch_set":6,"id":"0488afab_861b0bcf","side":"PARENT","line":82,"updated":"2022-05-05 21:12:55.000000000","message":"Right, notify has been up leveled in the worker to fire after the backend calls, so this is duplicate.\nhttps://opendev.org/openstack/designate/src/branch/master/designate/worker/tasks/zone.py#L72","commit_id":"95dbf944868ae9cdfe67f8dec0466c07fec98fb1"}],"designate/backend/base.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"822a16e3c79334f1c50335921c93940aa0354459","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        :param zone: the DNS zone."},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def update_zone(self, context, zone):"},{"line_number":76,"context_line":"        \"\"\""},{"line_number":77,"context_line":"        Update a DNS zone."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2f89c713_88127552","line":75,"updated":"2022-05-05 21:12:55.000000000","message":"This should probably also go to abstractmethod and the debug removed.","commit_id":"5d5d83e511acbf5d6f34e9a998ff16d96c5bb162"}],"designate/mdns/notify.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5750398662e9e4237b295a0333f1219959b983fe","unresolved":true,"context_lines":[{"line_number":75,"context_line":"                               retry_interval, max_retries, delay):"},{"line_number":76,"context_line":"        return"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def get_serial_number(self, context, zone, host, port, timeout,"},{"line_number":79,"context_line":"                          retry_interval, max_retries, delay):"},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        Get zone serial number from a resolver using retries."}],"source_content_type":"text/x-python","patch_set":6,"id":"25b8621c_4237fe8c","side":"PARENT","line":78,"range":{"start_line":78,"start_character":32,"end_line":78,"end_character":39},"updated":"2022-05-06 16:58:54.000000000","message":"(I know it\u0027s too late to leave this but ...)\n\nIMO we should avoid this change because it breaks compatibility of rpc api/server in different versions. This makes rolling update difficult because we need to update all of client/server component at once.","commit_id":"95dbf944868ae9cdfe67f8dec0466c07fec98fb1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"dadd081466b6f9e5b7306120fd21a2492f151d73","unresolved":true,"context_lines":[{"line_number":75,"context_line":"                               retry_interval, max_retries, delay):"},{"line_number":76,"context_line":"        return"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def get_serial_number(self, context, zone, host, port, timeout,"},{"line_number":79,"context_line":"                          retry_interval, max_retries, delay):"},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        Get zone serial number from a resolver using retries."}],"source_content_type":"text/x-python","patch_set":6,"id":"6c1caa8b_3d075763","side":"PARENT","line":78,"range":{"start_line":78,"start_character":32,"end_line":78,"end_character":39},"in_reply_to":"25b8621c_4237fe8c","updated":"2022-05-07 01:30:14.000000000","message":"You are right. I\u0027ll upload a fix reverting this part, because I also missed changing the actual call in central. My initial thought here was to move this RPC call to the worker, but when moving it back I changed the signature.","commit_id":"95dbf944868ae9cdfe67f8dec0466c07fec98fb1"}]}