)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"dc97dc001db56b7127d9e22afc64f289527e6eff","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds api_ca_cert configuration variable to pools.yaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adss a configuration variable that allows a user to"},{"line_number":10,"context_line":"declare the CA certificate to be used to verify"},{"line_number":11,"context_line":"traffic with a PowerDNS API endpoint."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c3d7f86f_23797290","line":9,"updated":"2022-05-10 15:27:13.000000000","message":"Spelling nit Adss --\u003e Adds","commit_id":"873a02d14d8d2198df8e0566248d9da0ea6f439c"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"c92013d08e0807f909d6cc0d4af85f84a3a5e987","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds api_ca_cert configuration variable to pools.yaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adss a configuration variable that allows a user to"},{"line_number":10,"context_line":"declare the CA certificate to be used to verify"},{"line_number":11,"context_line":"traffic with a PowerDNS API endpoint."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e4a07306_62b031a6","line":9,"in_reply_to":"c3d7f86f_23797290","updated":"2022-05-10 18:28:57.000000000","message":"Done","commit_id":"873a02d14d8d2198df8e0566248d9da0ea6f439c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1eae1b077ddc3812a87ecff34b0acc712541c093","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aeb8aa43_3e02b4f2","updated":"2022-05-10 00:08:20.000000000","message":"In general I am good with this, just a few comments.","commit_id":"0b202149fdb1f5841d04b8a8e46dbc8db292e798"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"9c311f5e31bd5c234f8af5c0467e8cb1e11b7d68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73259c12_fa467b2c","updated":"2022-05-10 13:58:42.000000000","message":"Thanks for the comments! All are resolved.","commit_id":"9cf3e597f3346f9ae918879a1f38625852467d60"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"dc97dc001db56b7127d9e22afc64f289527e6eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1c6dd91b_ab1be458","updated":"2022-05-10 15:27:13.000000000","message":"Minor spelling error, but looks good.","commit_id":"b5a883a4025bd2ca32d8ddf318d04bb97517dcd2"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"c92013d08e0807f909d6cc0d4af85f84a3a5e987","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d22a8661_197fdf70","updated":"2022-05-10 18:28:57.000000000","message":"Thanks for the comments, addressed them and also added safeguards for the case when the variable is not set and its value is \u0027None\u0027 (if the variable is commented out, for example).","commit_id":"eed98c93afde55728410bd9279238a9241ead313"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0743ef97323ef95f325332d90dc2fcd31582ef17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2c3be6ca_abc51c13","updated":"2022-05-10 22:19:21.000000000","message":"recheck\ncinder install failure with missing botocore, possible mirror issue.","commit_id":"eed98c93afde55728410bd9279238a9241ead313"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7dad52104fa5a3267fefd4a8b61f06987c486028","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f53a67e3_145e5a03","updated":"2022-05-17 21:47:26.000000000","message":"LGTM","commit_id":"c230ddb8c5f71b51f2fa492d6ac076abbecc3841"}],"designate/backend/impl_pdns4.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1eae1b077ddc3812a87ecff34b0acc712541c093","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        jsuazo(Contribution):"},{"line_number":61,"context_line":"        Function to check if variable has been declared."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        If the api_ca_cert is left blank or eith the default \u0027changeme\u0027,"},{"line_number":64,"context_line":"        returns False to disable ssl verification for the request."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        If api_ca_cert is defined, check if the file actually exists. If it"}],"source_content_type":"text/x-python","patch_set":2,"id":"2f9ac136_4325b767","line":63,"range":{"start_line":63,"start_character":44,"end_line":63,"end_character":48},"updated":"2022-05-10 00:08:20.000000000","message":"with","commit_id":"0b202149fdb1f5841d04b8a8e46dbc8db292e798"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"9c311f5e31bd5c234f8af5c0467e8cb1e11b7d68","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        jsuazo(Contribution):"},{"line_number":61,"context_line":"        Function to check if variable has been declared."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        If the api_ca_cert is left blank or eith the default \u0027changeme\u0027,"},{"line_number":64,"context_line":"        returns False to disable ssl verification for the request."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        If api_ca_cert is defined, check if the file actually exists. If it"}],"source_content_type":"text/x-python","patch_set":2,"id":"fc24568a_a1c38949","line":63,"range":{"start_line":63,"start_character":44,"end_line":63,"end_character":48},"in_reply_to":"2f9ac136_4325b767","updated":"2022-05-10 13:58:42.000000000","message":"Done","commit_id":"0b202149fdb1f5841d04b8a8e46dbc8db292e798"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1eae1b077ddc3812a87ecff34b0acc712541c093","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if ca_cert \u003d\u003d \u0027changeme\u0027 or ca_cert \u003d\u003d \u0027\u0027:"},{"line_number":73,"context_line":"            return False"},{"line_number":74,"context_line":"        elif not os.path.exists():"},{"line_number":75,"context_line":"            LOG.error(\"Could not find %s CA certificate.\""},{"line_number":76,"context_line":"                      \"No such file or directory\", "},{"line_number":77,"context_line":"                      ca_cert)"}],"source_content_type":"text/x-python","patch_set":2,"id":"cac8c189_fb0f8976","line":74,"range":{"start_line":74,"start_character":17,"end_line":74,"end_character":33},"updated":"2022-05-10 00:08:20.000000000","message":"The path to check is missing here.","commit_id":"0b202149fdb1f5841d04b8a8e46dbc8db292e798"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"9c311f5e31bd5c234f8af5c0467e8cb1e11b7d68","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if ca_cert \u003d\u003d \u0027changeme\u0027 or ca_cert \u003d\u003d \u0027\u0027:"},{"line_number":73,"context_line":"            return False"},{"line_number":74,"context_line":"        elif not os.path.exists():"},{"line_number":75,"context_line":"            LOG.error(\"Could not find %s CA certificate.\""},{"line_number":76,"context_line":"                      \"No such file or directory\", "},{"line_number":77,"context_line":"                      ca_cert)"}],"source_content_type":"text/x-python","patch_set":2,"id":"94fb5a26_aa6319ea","line":74,"range":{"start_line":74,"start_character":17,"end_line":74,"end_character":33},"in_reply_to":"cac8c189_fb0f8976","updated":"2022-05-10 13:58:42.000000000","message":"Done","commit_id":"0b202149fdb1f5841d04b8a8e46dbc8db292e798"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1eae1b077ddc3812a87ecff34b0acc712541c093","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            return False"},{"line_number":74,"context_line":"        elif not os.path.exists():"},{"line_number":75,"context_line":"            LOG.error(\"Could not find %s CA certificate.\""},{"line_number":76,"context_line":"                      \"No such file or directory\", "},{"line_number":77,"context_line":"                      ca_cert)"},{"line_number":78,"context_line":"            return False"},{"line_number":79,"context_line":"        return ca_cert"}],"source_content_type":"text/x-python","patch_set":2,"id":"e287354d_e49ad5e2","line":76,"range":{"start_line":76,"start_character":50,"end_line":76,"end_character":51},"updated":"2022-05-10 00:08:20.000000000","message":"Extra space here.","commit_id":"0b202149fdb1f5841d04b8a8e46dbc8db292e798"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"9c311f5e31bd5c234f8af5c0467e8cb1e11b7d68","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            return False"},{"line_number":74,"context_line":"        elif not os.path.exists():"},{"line_number":75,"context_line":"            LOG.error(\"Could not find %s CA certificate.\""},{"line_number":76,"context_line":"                      \"No such file or directory\", "},{"line_number":77,"context_line":"                      ca_cert)"},{"line_number":78,"context_line":"            return False"},{"line_number":79,"context_line":"        return ca_cert"}],"source_content_type":"text/x-python","patch_set":2,"id":"d9135076_3cdd1b5c","line":76,"range":{"start_line":76,"start_character":50,"end_line":76,"end_character":51},"in_reply_to":"e287354d_e49ad5e2","updated":"2022-05-10 13:58:42.000000000","message":"Done","commit_id":"0b202149fdb1f5841d04b8a8e46dbc8db292e798"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"4de58b63a228352a848fbd45a852567e1d7a2925","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _verify_ssl(self):"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        jsuazo(Contribution):"},{"line_number":61,"context_line":"        Function to check if variable has been declared."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        If the api_ca_cert is None, left blank or the default value \u0027changeme\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1015d928_1d1edd38","line":60,"updated":"2022-05-13 15:02:33.000000000","message":"Remove this, its unnecessary, use git to determine who did what\"git blame....\" and gerrit is very good at identifying what you added.","commit_id":"eed98c93afde55728410bd9279238a9241ead313"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"d3cc97f55866148401b8ea7aa5690e0db87de839","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _verify_ssl(self):"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        jsuazo(Contribution):"},{"line_number":61,"context_line":"        Function to check if variable has been declared."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        If the api_ca_cert is None, left blank or the default value \u0027changeme\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"a2eb37d6_d380ddf4","line":60,"in_reply_to":"1015d928_1d1edd38","updated":"2022-05-13 15:23:07.000000000","message":"Done","commit_id":"eed98c93afde55728410bd9279238a9241ead313"}],"releasenotes/notes/bugfix-1971856-3938a55b5494b8b8.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1eae1b077ddc3812a87ecff34b0acc712541c093","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes bug where requests to powerDNS fail if the dns is configured for TSL"},{"line_number":5,"context_line":"    traffic."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    It does so by adding a configuration variable, `api_ca_cert`, users can"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"efd0602e_956752b1","line":4,"range":{"start_line":4,"start_character":75,"end_line":4,"end_character":78},"updated":"2022-05-10 00:08:20.000000000","message":"TLS","commit_id":"0b202149fdb1f5841d04b8a8e46dbc8db292e798"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"9c311f5e31bd5c234f8af5c0467e8cb1e11b7d68","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes bug where requests to powerDNS fail if the dns is configured for TSL"},{"line_number":5,"context_line":"    traffic."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    It does so by adding a configuration variable, `api_ca_cert`, users can"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"484aaaa2_4c90cd52","line":4,"range":{"start_line":4,"start_character":75,"end_line":4,"end_character":78},"in_reply_to":"efd0602e_956752b1","updated":"2022-05-10 13:58:42.000000000","message":"Done","commit_id":"0b202149fdb1f5841d04b8a8e46dbc8db292e798"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1eae1b077ddc3812a87ecff34b0acc712541c093","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    traffic."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    It does so by adding a configuration variable, `api_ca_cert`, users can"},{"line_number":8,"context_line":"    use to declare the location of the CA cert needed to verify TSL"},{"line_number":9,"context_line":"    traffic."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    `LP#1971856 \u003chttps://bugs.launchpad.net/designate/+bug/1971856\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"48528094_5fb742a4","line":8,"range":{"start_line":8,"start_character":64,"end_line":8,"end_character":67},"updated":"2022-05-10 00:08:20.000000000","message":"TLS","commit_id":"0b202149fdb1f5841d04b8a8e46dbc8db292e798"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"9c311f5e31bd5c234f8af5c0467e8cb1e11b7d68","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    traffic."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    It does so by adding a configuration variable, `api_ca_cert`, users can"},{"line_number":8,"context_line":"    use to declare the location of the CA cert needed to verify TSL"},{"line_number":9,"context_line":"    traffic."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    `LP#1971856 \u003chttps://bugs.launchpad.net/designate/+bug/1971856\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5b85997a_7cf0857c","line":8,"range":{"start_line":8,"start_character":64,"end_line":8,"end_character":67},"in_reply_to":"48528094_5fb742a4","updated":"2022-05-10 13:58:42.000000000","message":"Done","commit_id":"0b202149fdb1f5841d04b8a8e46dbc8db292e798"}]}