)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"948fd4c52acfa8440fd0fc5931368be253e9952e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"978aa595_df6eaf84","updated":"2022-06-14 23:09:54.000000000","message":"Everything looks good and is much cleaner.\nMy only comment is I don\u0027t like to see hardcoded sleep(1) in the code.","commit_id":"0c68d11e127ee93f6b0503a641ab6b24f3c5374a"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"6c75ce0fafee3e81573a967ea88586d8c0b305f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"5ad489a6_d3bd4fde","updated":"2022-06-15 17:37:48.000000000","message":"This seems like two patches, removal of metrics and removal of PRC calls from MDNS, given the size could you break them into two or more patches.","commit_id":"098fdb763e8648146663d61103913aa659e1ca97"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"55ddccdccccadb7b265941aff4074783867a2a51","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"31bc4a09_95f14e62","in_reply_to":"5ad489a6_d3bd4fde","updated":"2022-06-15 17:41:08.000000000","message":"Originally that was the intent, but as the only use-case for metrics was a single call in MDNS I decided to combine the patches.","commit_id":"098fdb763e8648146663d61103913aa659e1ca97"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"3f24c1d2a04797cf4eccf83cfb56ef90a70ead37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"640d2d65_b3ed06a0","updated":"2022-06-22 17:31:01.000000000","message":"LGTM","commit_id":"793f146d7a2af028892c5045e134fb8ef66125df"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"31ac60dd66e207779a136730b5d36004a23db883","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"82311e7e_ffae6f6d","updated":"2022-06-24 21:04:22.000000000","message":"LGTM","commit_id":"8050680948941482d8816c57e81a9fa3110c3818"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b85a8f7aaf5c22e8cb6f0802683dfd2254540d9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"c76a00c1_f87c1e1c","updated":"2022-06-23 23:32:54.000000000","message":"LGTM","commit_id":"8050680948941482d8816c57e81a9fa3110c3818"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e1a71106beefcbb93d679d38d2eba152d5063ed5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"7c74703a_2576fb82","updated":"2022-06-25 04:26:32.000000000","message":"recheck DesignatePtrRecord RecordsetOwnershipTest","commit_id":"8050680948941482d8816c57e81a9fa3110c3818"}],"designate/conf/mdns.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"948fd4c52acfa8440fd0fc5931368be253e9952e","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    cfg.IntOpt(\u0027xfr_timeout\u0027, help\u003d\"Timeout in seconds for XFR\u0027s.\","},{"line_number":48,"context_line":"               default\u003dNone,"},{"line_number":49,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":50,"context_line":"               deprecated_reason\u003d\u0027This parameter should now be configured in\u0027"},{"line_number":51,"context_line":"                                 \u0027service:worker instead\u0027),"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"52fec905_439b7661","line":50,"updated":"2022-06-14 23:09:54.000000000","message":"nit: deprecated_since is helpful for knowing when something is ready to be removed.\ni.e.\ndeprecated_since\u003d\"Zed\"","commit_id":"0c68d11e127ee93f6b0503a641ab6b24f3c5374a"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"706351d66a9597739dd010a40e211b890836f809","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.IntOpt(\u0027xfr_timeout\u0027, help\u003d\"Timeout in seconds for XFR\u0027s.\","},{"line_number":48,"context_line":"               default\u003dNone,"},{"line_number":49,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":50,"context_line":"               deprecated_reason\u003d\u0027This parameter should now be configured in\u0027"},{"line_number":51,"context_line":"                                 \u0027service:worker instead\u0027),"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"0cb97b96_7b0cb6a2","line":50,"in_reply_to":"52fec905_439b7661","updated":"2022-06-15 00:36:25.000000000","message":"Done","commit_id":"0c68d11e127ee93f6b0503a641ab6b24f3c5374a"}],"designate/worker/tasks/zone.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"b33900e458ad484b8612c96cc3c58660d01faa51","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        return result"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"class GetZoneSerial(base.Task):"},{"line_number":593,"context_line":"    \"\"\""},{"line_number":594,"context_line":"    Get zone serial number from a resolver using retries."},{"line_number":595,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"f52a14d6_4c5e394a","line":592,"updated":"2022-06-13 04:07:35.000000000","message":"This is a lift and shift from MDNS with minor tweaks.\n- Removed NOTIFY as that code was unused.\n- No longer passing in timeout etc as that was hard-coded in central.","commit_id":"584b1be5c23708f4011ff42fdf46a143ebbfaf82"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"948fd4c52acfa8440fd0fc5931368be253e9952e","unresolved":true,"context_lines":[{"line_number":651,"context_line":"                    }"},{"line_number":652,"context_line":"                )"},{"line_number":653,"context_line":"                break"},{"line_number":654,"context_line":"            time.sleep(1)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        return status, actual_serial"},{"line_number":657,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"6637d958_c125d0f1","line":654,"range":{"start_line":654,"start_character":23,"end_line":654,"end_character":24},"updated":"2022-06-14 23:09:54.000000000","message":"I like to always use config settings for these, just in case someone wants to change this retry interval.\nI would say why not use poll_retry_interval, but maybe 15 is a bit long for this call.","commit_id":"0c68d11e127ee93f6b0503a641ab6b24f3c5374a"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"706351d66a9597739dd010a40e211b890836f809","unresolved":false,"context_lines":[{"line_number":651,"context_line":"                    }"},{"line_number":652,"context_line":"                )"},{"line_number":653,"context_line":"                break"},{"line_number":654,"context_line":"            time.sleep(1)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        return status, actual_serial"},{"line_number":657,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"000d76d6_21e2c750","line":654,"range":{"start_line":654,"start_character":23,"end_line":654,"end_character":24},"in_reply_to":"6637d958_c125d0f1","updated":"2022-06-15 00:36:25.000000000","message":"Added three new variables to control interval, retries and timeout.","commit_id":"0c68d11e127ee93f6b0503a641ab6b24f3c5374a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f0e1acc7bfbfbfc8b4230867c8ce256d64a038d4","unresolved":true,"context_lines":[{"line_number":607,"context_line":"        self.serial_timeout \u003d CONF[\u0027service:worker\u0027].serial_timeout"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def __call__(self):"},{"line_number":610,"context_line":"        LOG.info("},{"line_number":611,"context_line":"            \u0027Sending SOA for zone_name\u003d%(zone)s to %(server)s:%(port)d.\u0027,"},{"line_number":612,"context_line":"            {"},{"line_number":613,"context_line":"                \u0027zone\u0027: self.zone.name,"}],"source_content_type":"text/x-python","patch_set":24,"id":"559f62c0_9e7666c6","line":610,"updated":"2022-06-23 22:46:21.000000000","message":"This seems like a debug message. Is it actionable to know we are sending an SOA request?","commit_id":"793f146d7a2af028892c5045e134fb8ef66125df"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"3f8deee1306c2b70542658e5462faea9cfa81857","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        self.serial_timeout \u003d CONF[\u0027service:worker\u0027].serial_timeout"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def __call__(self):"},{"line_number":610,"context_line":"        LOG.info("},{"line_number":611,"context_line":"            \u0027Sending SOA for zone_name\u003d%(zone)s to %(server)s:%(port)d.\u0027,"},{"line_number":612,"context_line":"            {"},{"line_number":613,"context_line":"                \u0027zone\u0027: self.zone.name,"}],"source_content_type":"text/x-python","patch_set":24,"id":"a899a362_0a535ef3","line":610,"in_reply_to":"559f62c0_9e7666c6","updated":"2022-06-23 23:31:56.000000000","message":"Done","commit_id":"793f146d7a2af028892c5045e134fb8ef66125df"}]}