)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"5f4f4a041d37529efa3593650436785dd76f3735","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"849ca7bc_a1acc7ff","updated":"2022-08-28 18:09:44.000000000","message":"recheck","commit_id":"bdd82dd128e71ba502a258dc8863b97846764365"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"7a015f6c03634b44a43a1e1e5117dc0a1480af97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"875a13a5_b3f4c28e","updated":"2022-08-29 16:16:47.000000000","message":"recheck","commit_id":"8fc2f6bde8233327e877cc770295a995cd006667"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"764b7d2789af190c4c96a5d34d2b9eb17407f088","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e8f88c6b_79eb82eb","updated":"2022-08-29 21:52:17.000000000","message":"One question, otherwise looks good. Thanks!","commit_id":"659c81c876f4699e4cdf9e708d9efc5ab241abb8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"06e7139446bdd42838cfd5d128ab8e47ae4dda30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"34d1c6a2_3062d654","updated":"2022-08-29 18:06:34.000000000","message":"recheck","commit_id":"659c81c876f4699e4cdf9e708d9efc5ab241abb8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"128ebf89007f642bdd8db5683382820ef3ae67b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0be65973_a98720d8","updated":"2022-09-01 16:15:47.000000000","message":"LGTM","commit_id":"6d61ad555beefccb854c0850650d931df398d961"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"6da98f3f785b1e290b8c3cf4bd91dd32b738eae1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"b7d60e05_2862a902","updated":"2022-09-01 17:22:31.000000000","message":"LGTM","commit_id":"6d61ad555beefccb854c0850650d931df398d961"}],"designate/manage/pool.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"764b7d2789af190c4c96a5d34d2b9eb17407f088","unresolved":true,"context_lines":[{"line_number":226,"context_line":"            ns_record.validate()"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        for target in pool.targets:"},{"line_number":229,"context_line":"            backend_base.Backend.get_driver(target.type)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    @staticmethod"},{"line_number":232,"context_line":"    def _get_masters_from_pool(pool):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3c98e69b_7bc21423","line":229,"updated":"2022-08-29 21:52:17.000000000","message":"So, doesn\u0027t this now mean you cannot run a dry-run of a pool config without having the driver \"loaded\" into the python environment?\nIt appears the adapter doesn\u0027t need the driver to exist, so maybe there is validation value in being able to run a dry-run without having the driver present?\nI totally realize that it\u0027s not likely there will be an out-of-tree driver, but wondering if we need this here or as part of a \"live\" run only.","commit_id":"659c81c876f4699e4cdf9e708d9efc5ab241abb8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"f2d93bfe2eef2348df14ef2595fc73f493beafd6","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            ns_record.validate()"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        for target in pool.targets:"},{"line_number":229,"context_line":"            backend_base.Backend.get_driver(target.type)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    @staticmethod"},{"line_number":232,"context_line":"    def _get_masters_from_pool(pool):"}],"source_content_type":"text/x-python","patch_set":18,"id":"d6a83a7e_60bd3d92","line":229,"in_reply_to":"3c98e69b_7bc21423","updated":"2022-08-30 00:11:49.000000000","message":"Good idea. I also added an option to just skip the driver verification.","commit_id":"659c81c876f4699e4cdf9e708d9efc5ab241abb8"}]}
