)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":11,"context_line":"locations. The build up of the /etc/designate/pools.yaml reflects"},{"line_number":12,"context_line":"the changes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: Don Kehn \u003cdekehn@gmail.com\u003e"},{"line_number":15,"context_line":"Change-Id: Icf73e730b31ab26b8be65347239636c0137ab4bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"9860a70d_68bf93cf","line":14,"updated":"2024-05-28 19:02:59.000000000","message":"Don is the patch owner, so I would also add Omer to the Co-Authored-By list.","commit_id":"bd19b7ff91110d99a1fc49ecb47d0c786a490d9d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":11,"context_line":"locations. The build up of the /etc/designate/pools.yaml reflects"},{"line_number":12,"context_line":"the changes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: Don Kehn \u003cdekehn@gmail.com\u003e"},{"line_number":15,"context_line":"Change-Id: Icf73e730b31ab26b8be65347239636c0137ab4bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"cde48a69_96dfb537","line":14,"in_reply_to":"9860a70d_68bf93cf","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"bd19b7ff91110d99a1fc49ecb47d0c786a490d9d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"076d47352d0e7b8e3efd806a06fdd60c75064ebd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5e8c6f17_426648de","updated":"2024-04-29 12:39:20.000000000","message":"recheck the failed test is not related to the patch","commit_id":"6d8759e90e9e3ca32cd2e08580c057dda08cdf09"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"784feec872f6950e6bbe4ab618109bd385108550","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f78b3aba_6ee4ed15","updated":"2024-04-30 14:48:51.000000000","message":"I think that there is a problem with the yaml adapter. It fails when it tries to show the config after loading the contents of multiple-pools.yaml","commit_id":"708441c52e5cb34269c7249c85e8cb9021e90dce"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"743f200c7b4c41557d7a070c262dfa423306c0a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"fcfe14f8_9e6c87c5","updated":"2024-05-14 12:01:03.000000000","message":"Calling for opinions:\nI saw that running `designate-manage pool update --file \u003cnon-default-pool-id-file-path\u003e --delete`  will delete the default pool. So afterwards running `designate-manage pool show_config`  without specifying which pool id will result with \"no pools were found\" (it will look for the default pool defined in the designate config).\nDo we want this behavior? I also don\u0027t know any way to retrieve the default pool after we deleted it, as after what I wrote above, there could be a different, new pool with the name \"default\", but with a different id created for it.\nSo even if we run `designate-manage pool generate_file` before committing any change, and then run `designate-manage pool update --file \u003cfile-with-default-pool\u003e`, it will result with duplicated pool error.\nMaybe we should either skip the default pool deletion on the --delete argument, or change the behavior of falling back to the default pool when there is no pool-id provided on show_config? Maybe we could add an additional --delete-default-pool argument and make it the only way to delete the pool? (Just throwing ideas). What do you guys think?","commit_id":"7f66e63348d52bfbc131c7e5e437aedee22a7487"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"725b80a1291207b422183a14da6168a846ee7103","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"c36f3cef_e50ba358","updated":"2024-05-10 12:32:36.000000000","message":"This would be my recommended change.\nhttps://paste.openstack.org/show/bYqGtl1nRV92gcMrByPp/","commit_id":"7f66e63348d52bfbc131c7e5e437aedee22a7487"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c59ce33354fc8953452d7ab9f4c97e49fa3bf35f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"8b63979b_f64a2010","in_reply_to":"30717f08_628e7b4d","updated":"2024-05-21 08:35:52.000000000","message":"I tested show_config with the all_pools change and it works for me. The cool thing is that now it works both with \u0027--all\u0027 and with \u0027--all_pools\u0027. Maybe that mechanism works with prefixes as well.","commit_id":"7f66e63348d52bfbc131c7e5e437aedee22a7487"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f0975c178e163cb35d9da4d4fd87f32fe45fd0a3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"30717f08_628e7b4d","in_reply_to":"572ee733_5445ec58","updated":"2024-05-20 17:41:55.000000000","message":"Thanks for looking at the patch Erik, I only see the comments now. I agree, and I will try the changes you suggested soon.","commit_id":"7f66e63348d52bfbc131c7e5e437aedee22a7487"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"b6ea80f21031e361bac086e297a33f7744317b3a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"572ee733_5445ec58","in_reply_to":"c36f3cef_e50ba358","updated":"2024-05-10 12:33:35.000000000","message":"Just fyi I didn\u0027t check the output of show_config with this change.","commit_id":"7f66e63348d52bfbc131c7e5e437aedee22a7487"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"52c2466dc816d5bd90c7f541f904ffc5a396b262","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"eb8c4b22_cb44fd3d","updated":"2024-05-28 11:58:36.000000000","message":"I am rebasing this patch on top of its parent change, only because https://review.opendev.org/c/openstack/designate-tempest-plugin/+/918726 won\u0027t be run in the zuul status queue, as long as this current patch has a \"Not current\" relation with its parent patch. Thanks for the reviews and comments you made so far, Erik.","commit_id":"bd19b7ff91110d99a1fc49ecb47d0c786a490d9d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"6f460a62c9cbd15ea2f5bd0a5a8cb0025df1b697","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"998c25ed_7ada4b5a","updated":"2024-05-21 14:37:28.000000000","message":"LGTM","commit_id":"bd19b7ff91110d99a1fc49ecb47d0c786a490d9d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"4982998f_638d02f4","updated":"2024-05-28 19:02:59.000000000","message":"I think we have a bit of cleanup to do still.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"5af5b8e5_2e6462c0","updated":"2024-05-29 17:24:01.000000000","message":"Thanks for the review Michael! I will test this change again","commit_id":"1d861cbca468c6cd777c8fbd4ee615f34a067543"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"ad8556c4d15210c0c5891d6caf7327d1192d749d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"07963acb_25dd6f8d","updated":"2024-06-04 13:12:04.000000000","message":"I tested the current version of the patch on devstack and the feature keeps working. It would be great to hear your opinions on the current version.","commit_id":"1f22935212c407db011d62286ab5a22127f09a27"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2ba6a25141e35ed0117d4d9e2392d6bfc873605f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"75ca61ac_f9694575","updated":"2024-06-13 10:59:54.000000000","message":"FYI I am testing this patch on https://review.opendev.org/c/openstack/designate-tempest-plugin/+/920653","commit_id":"1d7f5e598915421d834737c3757e3b727d5fce55"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6ec99dc903578f1bfcd33ad71f2cc0c20cdf8172","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"efe7818e_fdd450ee","updated":"2024-07-01 12:04:50.000000000","message":"Thanks for the review Michael, I will upload another version, as it is on Merge Conflict now","commit_id":"8cd36485172ea2f8714a1aac48b311c14ad1d4cc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"24bd1ac0ca96796228409ddab14dafbd18ac9960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"0436cf44_9e320a39","updated":"2024-06-28 22:49:13.000000000","message":"This looks pretty good to me, just two more questions.","commit_id":"8cd36485172ea2f8714a1aac48b311c14ad1d4cc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5112d04a7263940c0ff5680339ba343f65b40d37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"4c178dbc_fba1d025","updated":"2024-08-13 22:21:17.000000000","message":"LGTM\nI think this is in good enough shape we can merge it.","commit_id":"0e9294aca19d1909209a8ef730fda60f9914df0f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2e92d01709ef698183d8283814b539e113ce90db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"6da2ea03_3345b752","updated":"2024-08-27 23:34:25.000000000","message":"This has been in +2 for a while and I think it\u0027s good to get merged.","commit_id":"0e9294aca19d1909209a8ef730fda60f9914df0f"}],"designate/dnsutils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"988a33a99474bdf36d0201e928ea14b3e9d8c017","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    def __init__(self, storage):"},{"line_number":174,"context_line":"        self.storage \u003d storage"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def __call__(self, message, dns_key):"},{"line_number":177,"context_line":"        try:"},{"line_number":178,"context_line":"            name \u003d dns_key.to_text(True)"},{"line_number":179,"context_line":"            if isinstance(name, bytes):"}],"source_content_type":"text/x-python","patch_set":10,"id":"6898dbe5_b6143a85","line":176,"updated":"2023-04-07 15:58:48.000000000","message":"This should have a test","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"ad8556c4d15210c0c5891d6caf7327d1192d749d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    def __init__(self, storage):"},{"line_number":174,"context_line":"        self.storage \u003d storage"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def __call__(self, message, dns_key):"},{"line_number":177,"context_line":"        try:"},{"line_number":178,"context_line":"            name \u003d dns_key.to_text(True)"},{"line_number":179,"context_line":"            if isinstance(name, bytes):"}],"source_content_type":"text/x-python","patch_set":10,"id":"be01d9fc_2257ec86","line":176,"in_reply_to":"6898dbe5_b6143a85","updated":"2024-06-04 13:12:04.000000000","message":"Not relevant anymore, I deleted that part from the patch.","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"}],"designate/manage/pool.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"725b80a1291207b422183a14da6168a846ee7103","unresolved":true,"context_lines":[{"line_number":69,"context_line":"               default\u003dCONF[\u0027service:central\u0027].default_pool_id)"},{"line_number":70,"context_line":"    @base.args(\u0027--all\u0027, help\u003d\u0027show the config of all the pools\u0027,"},{"line_number":71,"context_line":"               default\u003dFalse, required\u003dFalse, action\u003d\u0027store_true\u0027)"},{"line_number":72,"context_line":"    def show_config(self, pool_id, all):"},{"line_number":73,"context_line":"        self._setup()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.output_message.append(\u0027Pool Configuration:\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa83cdb3_6ecb19b3","line":72,"updated":"2024-05-10 12:32:36.000000000","message":"I understand why you used `all` here, but `all` is a reserved keyword. Ideally it would be nice to come up with a different naming schema here.","commit_id":"7f66e63348d52bfbc131c7e5e437aedee22a7487"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"45f17ffe5fbd5b2f67186331277701a09507d355","unresolved":false,"context_lines":[{"line_number":69,"context_line":"               default\u003dCONF[\u0027service:central\u0027].default_pool_id)"},{"line_number":70,"context_line":"    @base.args(\u0027--all\u0027, help\u003d\u0027show the config of all the pools\u0027,"},{"line_number":71,"context_line":"               default\u003dFalse, required\u003dFalse, action\u003d\u0027store_true\u0027)"},{"line_number":72,"context_line":"    def show_config(self, pool_id, all):"},{"line_number":73,"context_line":"        self._setup()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.output_message.append(\u0027Pool Configuration:\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f10b02a_89a95b47","line":72,"in_reply_to":"fa83cdb3_6ecb19b3","updated":"2024-05-21 13:48:03.000000000","message":"Done","commit_id":"7f66e63348d52bfbc131c7e5e437aedee22a7487"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"725b80a1291207b422183a14da6168a846ee7103","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        try:"},{"line_number":79,"context_line":"            if all:"},{"line_number":80,"context_line":"                data \u003d self.central_api.find_pools(self.context)"},{"line_number":81,"context_line":"            else:"},{"line_number":82,"context_line":"                if not utils.is_uuid_like(pool_id):"},{"line_number":83,"context_line":"                    self.output_message.append("}],"source_content_type":"text/x-python","patch_set":21,"id":"a42f6ce4_7e1d74db","line":80,"updated":"2024-05-10 12:32:36.000000000","message":"Nit: I personally prefer just keeping `pools` as the name of this variable instead of `data`.","commit_id":"7f66e63348d52bfbc131c7e5e437aedee22a7487"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"45f17ffe5fbd5b2f67186331277701a09507d355","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        try:"},{"line_number":79,"context_line":"            if all:"},{"line_number":80,"context_line":"                data \u003d self.central_api.find_pools(self.context)"},{"line_number":81,"context_line":"            else:"},{"line_number":82,"context_line":"                if not utils.is_uuid_like(pool_id):"},{"line_number":83,"context_line":"                    self.output_message.append("}],"source_content_type":"text/x-python","patch_set":21,"id":"61eeeb6c_9c8cbded","line":80,"in_reply_to":"a42f6ce4_7e1d74db","updated":"2024-05-21 13:48:03.000000000","message":"Done","commit_id":"7f66e63348d52bfbc131c7e5e437aedee22a7487"}],"devstack/README.rst":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"988a33a99474bdf36d0201e928ea14b3e9d8c017","unresolved":true,"context_lines":[{"line_number":21,"context_line":"   Perform the above step, and in addition set the backend driver and"},{"line_number":22,"context_line":"   scheduler filters::"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    SCHEDULER_FILTERS+\u003dattribute,pool_id_attributes,in_doubt_default_pool"},{"line_number":25,"context_line":"    DESIGNATE_BACKEND_DRIVER\u003dmultipool-bind9}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"3. run ``stack.sh``"}],"source_content_type":"text/x-rst","patch_set":10,"id":"27a7206a_1b246b2c","line":24,"range":{"start_line":24,"start_character":21,"end_line":24,"end_character":23},"updated":"2023-04-07 15:58:48.000000000","message":"Why is this an append? Since this is an ordered list, I think appending could end up with a strange scenario and confuse people.","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":21,"context_line":"   Perform the above step, and in addition set the backend driver and"},{"line_number":22,"context_line":"   scheduler filters::"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    SCHEDULER_FILTERS+\u003dattribute,pool_id_attributes,in_doubt_default_pool"},{"line_number":25,"context_line":"    DESIGNATE_BACKEND_DRIVER\u003dmultipool-bind9}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"3. run ``stack.sh``"}],"source_content_type":"text/x-rst","patch_set":10,"id":"cfb31641_1147eb87","line":24,"range":{"start_line":24,"start_character":21,"end_line":24,"end_character":23},"in_reply_to":"27a7206a_1b246b2c","updated":"2024-04-25 14:31:49.000000000","message":"todo: remove the +","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e93608148e5158e3564a3d2a276d799f06e89351","unresolved":false,"context_lines":[{"line_number":21,"context_line":"   Perform the above step, and in addition set the backend driver and"},{"line_number":22,"context_line":"   scheduler filters::"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    SCHEDULER_FILTERS+\u003dattribute,pool_id_attributes,in_doubt_default_pool"},{"line_number":25,"context_line":"    DESIGNATE_BACKEND_DRIVER\u003dmultipool-bind9}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"3. run ``stack.sh``"}],"source_content_type":"text/x-rst","patch_set":10,"id":"37f2fc85_95e3853f","line":24,"range":{"start_line":24,"start_character":21,"end_line":24,"end_character":23},"in_reply_to":"cfb31641_1147eb87","updated":"2024-04-29 11:25:53.000000000","message":"Done","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":22,"context_line":"   scheduler filters::"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    SCHEDULER_FILTERS\u003dattribute,pool_id_attributes,in_doubt_default_pool"},{"line_number":25,"context_line":"    DESIGNATE_BACKEND_DRIVER\u003dmultipool-bind9}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"3. run ``stack.sh``"}],"source_content_type":"text/x-rst","patch_set":25,"id":"db44c03e_d1516e27","line":25,"updated":"2024-05-28 19:02:59.000000000","message":"Is that bracket on the end of this line a typo?","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":22,"context_line":"   scheduler filters::"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    SCHEDULER_FILTERS\u003dattribute,pool_id_attributes,in_doubt_default_pool"},{"line_number":25,"context_line":"    DESIGNATE_BACKEND_DRIVER\u003dmultipool-bind9}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"3. run ``stack.sh``"}],"source_content_type":"text/x-rst","patch_set":25,"id":"e7d8489e_504e05a8","line":25,"in_reply_to":"db44c03e_d1516e27","updated":"2024-05-29 17:24:01.000000000","message":"Good catch, yes it is, thanks. I am removing it.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"}],"devstack/designate_plugins/backend-multipool-bind9":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0989f34d683d7260e91d45a831e94a8bc3a9f8f2","unresolved":true,"context_lines":[{"line_number":86,"context_line":"OPTIONS\u003d\"-u bind -c $BIND2_CFG_DIR/named.conf -p $BIND2_DNS_PORT -D named-2\""},{"line_number":87,"context_line":"EOF"},{"line_number":88,"context_line":"      # copy the default bind to the bind-2 \u0026 make sure the dirs are pointint to bind-2"},{"line_number":89,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf $BIND2_CFG_DIR/named.conf"},{"line_number":90,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"      # Copy the necessary confuration file and set the bind-2 directories"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1e926ec1_6ee18659","line":89,"updated":"2022-09-19 20:13:22.000000000","message":"$BIND2_CFG_DIR doesn\u0027t exist here.","commit_id":"2da1d7822cbe44c977fd745cc8bf2a81e638c5fd"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"1661e2cb2496d00d962bcbe94101bea92bc6489d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"OPTIONS\u003d\"-u bind -c $BIND2_CFG_DIR/named.conf -p $BIND2_DNS_PORT -D named-2\""},{"line_number":87,"context_line":"EOF"},{"line_number":88,"context_line":"      # copy the default bind to the bind-2 \u0026 make sure the dirs are pointint to bind-2"},{"line_number":89,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf $BIND2_CFG_DIR/named.conf"},{"line_number":90,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"      # Copy the necessary confuration file and set the bind-2 directories"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1b4f60d2_d37a8f4e","line":89,"in_reply_to":"1e926ec1_6ee18659","updated":"2022-11-21 15:31:52.000000000","message":"Yes, fixing, there is another place when the /var/bind-2/cache ownership is changed.","commit_id":"2da1d7822cbe44c977fd745cc8bf2a81e638c5fd"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":22,"context_line":"# --------"},{"line_number":23,"context_line":"BIND2_DNS_PORT\u003d${DESIGNATE_SERVICE_PORT2_DNS:-1053}"},{"line_number":24,"context_line":"BIND_SERVICE_NAME\u003dbind9"},{"line_number":25,"context_line":"BIND2_SERVICE_NAME\u003dbind9"},{"line_number":26,"context_line":"BIND2_DEFAULT_FILE\u003d/etc/default/named-2"},{"line_number":27,"context_line":"BIND2_SERVICE_NAME\u003dnamed-2.service"},{"line_number":28,"context_line":"BIND2_SERVICE_FILE\u003d/etc/systemd/system/$BIND2_SERVICE_NAME"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"d019eb74_d166e0c9","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":18},"updated":"2024-04-25 14:31:49.000000000","message":"This default entry get overridden on line 27. Should we remove line 27?","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# --------"},{"line_number":23,"context_line":"BIND2_DNS_PORT\u003d${DESIGNATE_SERVICE_PORT2_DNS:-1053}"},{"line_number":24,"context_line":"BIND_SERVICE_NAME\u003dbind9"},{"line_number":25,"context_line":"BIND2_SERVICE_NAME\u003dbind9"},{"line_number":26,"context_line":"BIND2_DEFAULT_FILE\u003d/etc/default/named-2"},{"line_number":27,"context_line":"BIND2_SERVICE_NAME\u003dnamed-2.service"},{"line_number":28,"context_line":"BIND2_SERVICE_FILE\u003d/etc/systemd/system/$BIND2_SERVICE_NAME"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"47ca4b13_611b96eb","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":18},"in_reply_to":"d019eb74_d166e0c9","updated":"2024-05-29 17:24:01.000000000","message":"I removed line 27, done.","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":80,"context_line":"        # generate a defaults/named2 file"},{"line_number":81,"context_line":"        sudo tee $BIND2_DEFAULT_FILE \u003e /dev/null \u003c\u003cEOF"},{"line_number":82,"context_line":"#"},{"line_number":83,"context_line":"# run resolvconf?"},{"line_number":84,"context_line":"RESOLVCONF\u003dno"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# startup options for the server"},{"line_number":87,"context_line":"OPTIONS\u003d\"-u bind -c $BIND2_CFG_DIR/named.conf -p $BIND2_DNS_PORT -D named-2\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"136c15e8_37531ff5","line":84,"range":{"start_line":83,"start_character":0,"end_line":84,"end_character":13},"updated":"2024-04-25 14:31:49.000000000","message":"I wonder why we wouldn\u0027t like to use the resolver here, only on the multipool scenario. I couldn\u0027t find this line anywhere else in the code.","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":80,"context_line":"        # generate a defaults/named2 file"},{"line_number":81,"context_line":"        sudo tee $BIND2_DEFAULT_FILE \u003e /dev/null \u003c\u003cEOF"},{"line_number":82,"context_line":"#"},{"line_number":83,"context_line":"# run resolvconf?"},{"line_number":84,"context_line":"RESOLVCONF\u003dno"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# startup options for the server"},{"line_number":87,"context_line":"OPTIONS\u003d\"-u bind -c $BIND2_CFG_DIR/named.conf -p $BIND2_DNS_PORT -D named-2\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"8ac5e820_30f24173","line":84,"range":{"start_line":83,"start_character":0,"end_line":84,"end_character":13},"in_reply_to":"136c15e8_37531ff5","updated":"2024-05-28 19:02:59.000000000","message":"I agree, I think this is dead code that should be removed. systemd subverts this setting as far as I know.","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # generate a defaults/named2 file"},{"line_number":81,"context_line":"        sudo tee $BIND2_DEFAULT_FILE \u003e /dev/null \u003c\u003cEOF"},{"line_number":82,"context_line":"#"},{"line_number":83,"context_line":"# run resolvconf?"},{"line_number":84,"context_line":"RESOLVCONF\u003dno"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# startup options for the server"},{"line_number":87,"context_line":"OPTIONS\u003d\"-u bind -c $BIND2_CFG_DIR/named.conf -p $BIND2_DNS_PORT -D named-2\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"e39e0e3b_52407430","line":84,"range":{"start_line":83,"start_character":0,"end_line":84,"end_character":13},"in_reply_to":"8ac5e820_30f24173","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":92,"context_line":"      fi"},{"line_number":93,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf $BIND2_CFG_DIR/named.conf"},{"line_number":94,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":95,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"      # Copy the necessary confuration file and set the bind-2 directories"},{"line_number":98,"context_line":"      sudo cp $BIND_CFG_DIR/zones.rfc1918 $BIND2_CFG_DIR"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"df41301d_032b92ca","line":95,"range":{"start_line":95,"start_character":11,"end_line":95,"end_character":34},"updated":"2024-04-25 14:31:49.000000000","message":"I wonder if we should make it\nsed -i \u0027s/bind/bind-2/g\u0027\n\n(replace all instances)\n\nI am asking the same about lines 102, 103","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      fi"},{"line_number":93,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf $BIND2_CFG_DIR/named.conf"},{"line_number":94,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":95,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"      # Copy the necessary confuration file and set the bind-2 directories"},{"line_number":98,"context_line":"      sudo cp $BIND_CFG_DIR/zones.rfc1918 $BIND2_CFG_DIR"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"67d532d4_c9be8b4f","line":95,"range":{"start_line":95,"start_character":11,"end_line":95,"end_character":34},"in_reply_to":"a03d1a46_a05c755f","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":92,"context_line":"      fi"},{"line_number":93,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf $BIND2_CFG_DIR/named.conf"},{"line_number":94,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":95,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"      # Copy the necessary confuration file and set the bind-2 directories"},{"line_number":98,"context_line":"      sudo cp $BIND_CFG_DIR/zones.rfc1918 $BIND2_CFG_DIR"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"a03d1a46_a05c755f","line":95,"range":{"start_line":95,"start_character":11,"end_line":95,"end_character":34},"in_reply_to":"df41301d_032b92ca","updated":"2024-05-28 19:02:59.000000000","message":"Yes, I think so. In my devstack there are three includes that point to /etc/bind","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":94,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":95,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"      # Copy the necessary confuration file and set the bind-2 directories"},{"line_number":98,"context_line":"      sudo cp $BIND_CFG_DIR/zones.rfc1918 $BIND2_CFG_DIR"},{"line_number":99,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf.local $BIND2_CFG_DIR"},{"line_number":100,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"18c7e6fe_e311a0d1","line":97,"range":{"start_line":97,"start_character":27,"end_line":97,"end_character":38},"updated":"2024-04-25 14:31:49.000000000","message":"todo: typo configuration","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e93608148e5158e3564a3d2a276d799f06e89351","unresolved":false,"context_lines":[{"line_number":94,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":95,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"      # Copy the necessary confuration file and set the bind-2 directories"},{"line_number":98,"context_line":"      sudo cp $BIND_CFG_DIR/zones.rfc1918 $BIND2_CFG_DIR"},{"line_number":99,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf.local $BIND2_CFG_DIR"},{"line_number":100,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"4d16efba_0524c8ea","line":97,"range":{"start_line":97,"start_character":27,"end_line":97,"end_character":38},"in_reply_to":"18c7e6fe_e311a0d1","updated":"2024-04-29 11:25:53.000000000","message":"Done","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        fi"},{"line_number":125,"context_line":"        sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # Copy the necessary confuration files and set the named-2 directories"},{"line_number":128,"context_line":"        for d in $(ls /etc/named.*); do"},{"line_number":129,"context_line":"            cpfile\u003d$(echo $d | sed \u0027s/named/named-2/\u0027)"},{"line_number":130,"context_line":"            sudo cp $d $cpfile"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"a3629714_b5a556db","line":127,"range":{"start_line":127,"start_character":29,"end_line":127,"end_character":40},"updated":"2024-04-25 14:31:49.000000000","message":"todo: typo configuration","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e93608148e5158e3564a3d2a276d799f06e89351","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        fi"},{"line_number":125,"context_line":"        sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # Copy the necessary confuration files and set the named-2 directories"},{"line_number":128,"context_line":"        for d in $(ls /etc/named.*); do"},{"line_number":129,"context_line":"            cpfile\u003d$(echo $d | sed \u0027s/named/named-2/\u0027)"},{"line_number":130,"context_line":"            sudo cp $d $cpfile"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"383a8923_c2be59d3","line":127,"range":{"start_line":127,"start_character":29,"end_line":127,"end_character":40},"in_reply_to":"a3629714_b5a556db","updated":"2024-04-29 11:25:53.000000000","message":"Done","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":296,"context_line":"    sudo chown $BIND_USER:$BIND_GROUP $BIND_CFG_DIR/rndc.key"},{"line_number":297,"context_line":"    sudo chmod g+r $BIND_CFG_DIR/rndc.key"},{"line_number":298,"context_line":"    sudo tee $BIND_CFG_FILE \u003e /dev/null \u003c\u003cEOF"},{"line_number":299,"context_line":" "},{"line_number":300,"context_line":"include \"$BIND_CFG_DIR/rndc.key\";"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"options {"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"e4c48d55_6858291a","line":299,"range":{"start_line":299,"start_character":0,"end_line":299,"end_character":1},"updated":"2024-04-25 14:31:49.000000000","message":"todo:  remove extra whitespace","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e93608148e5158e3564a3d2a276d799f06e89351","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    sudo chown $BIND_USER:$BIND_GROUP $BIND_CFG_DIR/rndc.key"},{"line_number":297,"context_line":"    sudo chmod g+r $BIND_CFG_DIR/rndc.key"},{"line_number":298,"context_line":"    sudo tee $BIND_CFG_FILE \u003e /dev/null \u003c\u003cEOF"},{"line_number":299,"context_line":" "},{"line_number":300,"context_line":"include \"$BIND_CFG_DIR/rndc.key\";"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"options {"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"e39696d2_270326e1","line":299,"range":{"start_line":299,"start_character":0,"end_line":299,"end_character":1},"in_reply_to":"e4c48d55_6858291a","updated":"2024-04-29 11:25:53.000000000","message":"Done","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":24,"context_line":"BIND_SERVICE_NAME\u003dbind9"},{"line_number":25,"context_line":"BIND2_SERVICE_NAME\u003dbind9"},{"line_number":26,"context_line":"BIND2_DEFAULT_FILE\u003d/etc/default/named-2"},{"line_number":27,"context_line":"BIND2_SERVICE_NAME\u003dnamed-2.service"},{"line_number":28,"context_line":"BIND2_SERVICE_FILE\u003d/etc/systemd/system/$BIND2_SERVICE_NAME"},{"line_number":29,"context_line":"BIND_CFG_DIR\u003d/etc/bind"},{"line_number":30,"context_line":"BIND2_CFG_DIR\u003d/etc/bind-2"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"b308e409_726759d3","line":27,"updated":"2024-05-28 19:02:59.000000000","message":"As mentioned above, this is a duplicate, we should remove the above set.","commit_id":"bd19b7ff91110d99a1fc49ecb47d0c786a490d9d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":24,"context_line":"BIND_SERVICE_NAME\u003dbind9"},{"line_number":25,"context_line":"BIND2_SERVICE_NAME\u003dbind9"},{"line_number":26,"context_line":"BIND2_DEFAULT_FILE\u003d/etc/default/named-2"},{"line_number":27,"context_line":"BIND2_SERVICE_NAME\u003dnamed-2.service"},{"line_number":28,"context_line":"BIND2_SERVICE_FILE\u003d/etc/systemd/system/$BIND2_SERVICE_NAME"},{"line_number":29,"context_line":"BIND_CFG_DIR\u003d/etc/bind"},{"line_number":30,"context_line":"BIND2_CFG_DIR\u003d/etc/bind-2"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"99321df1_e4fa5539","line":27,"in_reply_to":"b308e409_726759d3","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"bd19b7ff91110d99a1fc49ecb47d0c786a490d9d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"if is_fedora; then"},{"line_number":44,"context_line":"    BIND_SERVICE_NAME\u003dnamed"},{"line_number":45,"context_line":"    BIND2_SERVICE_NAME\u003dnamed-2"},{"line_number":46,"context_line":"    BIND_CFG_DIR\u003d/etc/named"},{"line_number":47,"context_line":"    BIND2_CFG_DIR\u003d/etc/named-2"},{"line_number":48,"context_line":"    BIND_CFG_FILE\u003d/etc/named.conf"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"f369b043_27f9652e","line":45,"updated":"2024-05-28 19:02:59.000000000","message":"Why is this fedora dependent? I understand paths are different, but service names?","commit_id":"bd19b7ff91110d99a1fc49ecb47d0c786a490d9d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"ad8556c4d15210c0c5891d6caf7327d1192d749d","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"if is_fedora; then"},{"line_number":44,"context_line":"    BIND_SERVICE_NAME\u003dnamed"},{"line_number":45,"context_line":"    BIND2_SERVICE_NAME\u003dnamed-2"},{"line_number":46,"context_line":"    BIND_CFG_DIR\u003d/etc/named"},{"line_number":47,"context_line":"    BIND2_CFG_DIR\u003d/etc/named-2"},{"line_number":48,"context_line":"    BIND_CFG_FILE\u003d/etc/named.conf"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"fbc77ed3_c9c57090","line":45,"in_reply_to":"e38d2cee_0ca72b94","updated":"2024-06-04 13:12:04.000000000","message":"Changing it to \"named\" works.","commit_id":"bd19b7ff91110d99a1fc49ecb47d0c786a490d9d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"if is_fedora; then"},{"line_number":44,"context_line":"    BIND_SERVICE_NAME\u003dnamed"},{"line_number":45,"context_line":"    BIND2_SERVICE_NAME\u003dnamed-2"},{"line_number":46,"context_line":"    BIND_CFG_DIR\u003d/etc/named"},{"line_number":47,"context_line":"    BIND2_CFG_DIR\u003d/etc/named-2"},{"line_number":48,"context_line":"    BIND_CFG_FILE\u003d/etc/named.conf"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"e38d2cee_0ca72b94","line":45,"in_reply_to":"f369b043_27f9652e","updated":"2024-05-29 17:24:01.000000000","message":"I switched it to be\nBIND2_SERVICE_NAME\u003dnamed\n\nI don\u0027t know if we even need BIND2_SERVICE_NAME as a variable. Anyway, I will try to test the changes soon.","commit_id":"bd19b7ff91110d99a1fc49ecb47d0c786a490d9d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    BIND2_TSIGKEY_FILE\u003d$BIND2_CFG_DIR/named.conf.tsigkeys"},{"line_number":56,"context_line":"fi"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"if is_suse; then"},{"line_number":59,"context_line":"    BIND_SERVICE_NAME\u003dnamed"},{"line_number":60,"context_line":"    BIND2_SERVICE_NAME\u003dnamed-2"},{"line_number":61,"context_line":"    BIND_CFG_DIR\u003d/etc/named"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"1321f138_52ae4e54","line":58,"updated":"2024-05-28 19:02:59.000000000","message":"All references to \"is_suse\" should be removed.\nSee: https://review.opendev.org/c/openstack/designate/+/900932","commit_id":"bd19b7ff91110d99a1fc49ecb47d0c786a490d9d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    BIND2_TSIGKEY_FILE\u003d$BIND2_CFG_DIR/named.conf.tsigkeys"},{"line_number":56,"context_line":"fi"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"if is_suse; then"},{"line_number":59,"context_line":"    BIND_SERVICE_NAME\u003dnamed"},{"line_number":60,"context_line":"    BIND2_SERVICE_NAME\u003dnamed-2"},{"line_number":61,"context_line":"    BIND_CFG_DIR\u003d/etc/named"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"32b70a71_b630e8bd","line":58,"in_reply_to":"1321f138_52ae4e54","updated":"2024-05-29 17:24:01.000000000","message":"Thanks, done.","commit_id":"bd19b7ff91110d99a1fc49ecb47d0c786a490d9d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":87,"context_line":"OPTIONS\u003d\"-u bind -c $BIND2_CFG_DIR/named.conf -p $BIND2_DNS_PORT -D named-2\""},{"line_number":88,"context_line":"EOF"},{"line_number":89,"context_line":"      # copy the default bind to the bind-2 \u0026 make sure the dirs are pointint to bind-2"},{"line_number":90,"context_line":"      if [ ! -d $BIND2_CFG_DIR ]; then"},{"line_number":91,"context_line":"\t      sudo mkdir -p $BIND2_CFG_DIR"},{"line_number":92,"context_line":"      fi"},{"line_number":93,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf $BIND2_CFG_DIR/named.conf"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"e70b3e4d_83f08234","line":90,"updated":"2024-05-28 19:02:59.000000000","message":"There is no need for this check, just run mkdir -p","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":87,"context_line":"OPTIONS\u003d\"-u bind -c $BIND2_CFG_DIR/named.conf -p $BIND2_DNS_PORT -D named-2\""},{"line_number":88,"context_line":"EOF"},{"line_number":89,"context_line":"      # copy the default bind to the bind-2 \u0026 make sure the dirs are pointint to bind-2"},{"line_number":90,"context_line":"      if [ ! -d $BIND2_CFG_DIR ]; then"},{"line_number":91,"context_line":"\t      sudo mkdir -p $BIND2_CFG_DIR"},{"line_number":92,"context_line":"      fi"},{"line_number":93,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf $BIND2_CFG_DIR/named.conf"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"129450fd_c7ba16e5","line":90,"in_reply_to":"e70b3e4d_83f08234","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":100,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"},{"line_number":101,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":102,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.local"},{"line_number":103,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.default-zones"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      # create a second service file"},{"line_number":106,"context_line":"      sudo cp /lib/systemd/system/named.service $BIND2_SERVICE_FILE"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"01d5be57_b8a1bca2","line":103,"updated":"2024-05-28 19:02:59.000000000","message":"This file references the /etc/bind/db.* files, but I don\u0027t see copies of them made for the bind-2 directory.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":true,"context_lines":[{"line_number":100,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"},{"line_number":101,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":102,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.local"},{"line_number":103,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.default-zones"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      # create a second service file"},{"line_number":106,"context_line":"      sudo cp /lib/systemd/system/named.service $BIND2_SERVICE_FILE"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"fd77a80e_438f66ce","line":103,"in_reply_to":"01d5be57_b8a1bca2","updated":"2024-05-29 17:24:01.000000000","message":"ok, I am changing it to sed -i \u0027s/bind/bind-2/g\u0027, I hope that will fix it.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6ec99dc903578f1bfcd33ad71f2cc0c20cdf8172","unresolved":true,"context_lines":[{"line_number":100,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"},{"line_number":101,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":102,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.local"},{"line_number":103,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.default-zones"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      # create a second service file"},{"line_number":106,"context_line":"      sudo cp /lib/systemd/system/named.service $BIND2_SERVICE_FILE"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"4438493d_03186c6e","line":103,"in_reply_to":"35d79b41_2dcf9649","updated":"2024-07-01 12:04:50.000000000","message":"As far as I understand, the zone datafiles are in $BIND_VAR_DIR or $BIND2_VAR_DIR, which are /var/cache/bind{,-2} or /var/named{,-2} depends on the OS.\n\nI do see on my devstack instance (on /var/named/ directory) files like:\nslave.example.com.98fe9760-4fe2-425e-b46c-dc538455b5e9\nslave.100.51.198.in-addr.arpa.36d9c5a6-365b-4e29-ae03-4e443e2ffdc1\n\nI suspect those are the db/zone files, and they are copied on line #130. It is bad though, they are only copied if_fedora. I will move it so it will be executed for any OS. Thanks, good catch!","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"eddac3a87124dccf9443d605b4869d418844a772","unresolved":true,"context_lines":[{"line_number":100,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"},{"line_number":101,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":102,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.local"},{"line_number":103,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.default-zones"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      # create a second service file"},{"line_number":106,"context_line":"      sudo cp /lib/systemd/system/named.service $BIND2_SERVICE_FILE"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"a8ebf9ea_e0c48562","line":103,"in_reply_to":"4438493d_03186c6e","updated":"2024-07-11 17:40:18.000000000","message":"We are still talking about two different things.\nOn Ubuntu (at least), when I open /etc/bind/named.conf.default-zones it has includes for a few /etc/bin/db.* files. For example it references /etc/bind/db.local.\nMy concern here is I don\u0027t see anything copying those db* files into the bind-2 directory, so I worry that something in bind may break as it is missing files referenced in the configuration.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"893a029be9365634f123fe6bcd427bebb8d2f99c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"},{"line_number":101,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":102,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.local"},{"line_number":103,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.default-zones"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      # create a second service file"},{"line_number":106,"context_line":"      sudo cp /lib/systemd/system/named.service $BIND2_SERVICE_FILE"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"652907b6_5fca848e","line":103,"in_reply_to":"4c64a5d9_0fbb90ca","updated":"2024-08-14 10:31:38.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"585ee2a506b1544d3ee8017c15638d81c3a9c74a","unresolved":true,"context_lines":[{"line_number":100,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"},{"line_number":101,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":102,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.local"},{"line_number":103,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.default-zones"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      # create a second service file"},{"line_number":106,"context_line":"      sudo cp /lib/systemd/system/named.service $BIND2_SERVICE_FILE"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"4c64a5d9_0fbb90ca","line":103,"in_reply_to":"a8ebf9ea_e0c48562","updated":"2024-07-12 11:32:23.000000000","message":"ok, I see. The /etc/bind* files are created and manipulated on Ubuntu, and as I am using centos9, I didn\u0027t see that problem before. I think this patch will be ready after I check and take care of the Ubuntu stuff.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"24bd1ac0ca96796228409ddab14dafbd18ac9960","unresolved":true,"context_lines":[{"line_number":100,"context_line":"      sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"},{"line_number":101,"context_line":"      sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"},{"line_number":102,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.local"},{"line_number":103,"context_line":"      sudo sed -i \u0027s/bind/bind-2/\u0027 $BIND2_CFG_DIR/named.conf.default-zones"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      # create a second service file"},{"line_number":106,"context_line":"      sudo cp /lib/systemd/system/named.service $BIND2_SERVICE_FILE"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"35d79b41_2dcf9649","line":103,"in_reply_to":"fd77a80e_438f66ce","updated":"2024-06-28 22:49:13.000000000","message":"Is this comment meant for another line?\nMy concern in the original comment was that the \"named.confg.default-zones\" file references files /etc/bind/db.* but I didn\u0027t see those files copied over in the script. Maybe they are and I didn\u0027t seem them?","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":109,"context_line":"      iniset -sudo $BIND2_SERVICE_FILE \"Install\" \"Alias\" \"bind9-2.service\""},{"line_number":110,"context_line":"      sudo chmod 644 $BIND2_SERVICE_FILE"},{"line_number":111,"context_line":"      sudo chmod g+s $BIND2_CFG_DIR"},{"line_number":112,"context_line":"      if [ ! -d $BIND2_RUN_DIR ]; then"},{"line_number":113,"context_line":"          sudo mkdir -p $BIND2_RUN_DIR"},{"line_number":114,"context_line":"      fi"},{"line_number":115,"context_line":"      sudo chgrp $BIND_GROUP $BIND2_RUN_DIR"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"2217962c_0536eede","line":112,"updated":"2024-05-28 19:02:59.000000000","message":"This conditional is not needed, just run mkdir -p","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      iniset -sudo $BIND2_SERVICE_FILE \"Install\" \"Alias\" \"bind9-2.service\""},{"line_number":110,"context_line":"      sudo chmod 644 $BIND2_SERVICE_FILE"},{"line_number":111,"context_line":"      sudo chmod g+s $BIND2_CFG_DIR"},{"line_number":112,"context_line":"      if [ ! -d $BIND2_RUN_DIR ]; then"},{"line_number":113,"context_line":"          sudo mkdir -p $BIND2_RUN_DIR"},{"line_number":114,"context_line":"      fi"},{"line_number":115,"context_line":"      sudo chgrp $BIND_GROUP $BIND2_RUN_DIR"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"59847d64_9cc1b993","line":112,"in_reply_to":"2217962c_0536eede","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        set -o xtrace"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # if the /etc/named-2 doesn\u0027t exist create it"},{"line_number":122,"context_line":"        if [ ! -d $BIND2_CFG_DIR ]; then"},{"line_number":123,"context_line":"            sudo mkdir -p $BIND2_CFG_DIR"},{"line_number":124,"context_line":"        fi"},{"line_number":125,"context_line":"        sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"85fb3a78_66cb7172","line":122,"updated":"2024-05-28 19:02:59.000000000","message":"This conditional is not needed, just run mkdir -p","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        set -o xtrace"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # if the /etc/named-2 doesn\u0027t exist create it"},{"line_number":122,"context_line":"        if [ ! -d $BIND2_CFG_DIR ]; then"},{"line_number":123,"context_line":"            sudo mkdir -p $BIND2_CFG_DIR"},{"line_number":124,"context_line":"        fi"},{"line_number":125,"context_line":"        sudo chown -R $STACK_USER:$BIND_GROUP $BIND2_CFG_DIR"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"7d43bf07_39caf772","line":122,"in_reply_to":"85fb3a78_66cb7172","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            if [[ \"$d\" \u003d\u003d *\"named.conf\"* ]]; then"},{"line_number":132,"context_line":"                sudo chown -R $BIND_USER:$BIND_GROUP $cpfile"},{"line_number":133,"context_line":"                sudo sed -i \u0027s/port 53/port \u0027$BIND2_DNS_PORT\u0027/g\u0027 $cpfile"},{"line_number":134,"context_line":"                sudo sed -i \u0027s/named/named-2/\u0027 $cpfile"},{"line_number":135,"context_line":"            else"},{"line_number":136,"context_line":"                sudo chown -R root:$BIND_GROUP $cpfile"},{"line_number":137,"context_line":"            fi"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"2f89d44f_16483090","line":134,"updated":"2024-05-28 19:02:59.000000000","message":"missing \"g\" here too","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            if [[ \"$d\" \u003d\u003d *\"named.conf\"* ]]; then"},{"line_number":132,"context_line":"                sudo chown -R $BIND_USER:$BIND_GROUP $cpfile"},{"line_number":133,"context_line":"                sudo sed -i \u0027s/port 53/port \u0027$BIND2_DNS_PORT\u0027/g\u0027 $cpfile"},{"line_number":134,"context_line":"                sudo sed -i \u0027s/named/named-2/\u0027 $cpfile"},{"line_number":135,"context_line":"            else"},{"line_number":136,"context_line":"                sudo chown -R root:$BIND_GROUP $cpfile"},{"line_number":137,"context_line":"            fi"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"68624a28_6fe1f15f","line":134,"in_reply_to":"2f89d44f_16483090","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":135,"context_line":"            else"},{"line_number":136,"context_line":"                sudo chown -R root:$BIND_GROUP $cpfile"},{"line_number":137,"context_line":"            fi"},{"line_number":138,"context_line":"            sudo sed -i \u0027s/bind/bind-2/\u0027 $cpfile"},{"line_number":139,"context_line":"        done"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # create a second service file \u0026 and set options into the units params file."}],"source_content_type":"application/octet-stream","patch_set":25,"id":"b39bb5a0_3395e525","line":138,"updated":"2024-05-28 19:02:59.000000000","message":"missing \"g\" here too","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            else"},{"line_number":136,"context_line":"                sudo chown -R root:$BIND_GROUP $cpfile"},{"line_number":137,"context_line":"            fi"},{"line_number":138,"context_line":"            sudo sed -i \u0027s/bind/bind-2/\u0027 $cpfile"},{"line_number":139,"context_line":"        done"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # create a second service file \u0026 and set options into the units params file."}],"source_content_type":"application/octet-stream","patch_set":25,"id":"387b6dce_11028f9b","line":138,"in_reply_to":"b39bb5a0_3395e525","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":141,"context_line":"        # create a second service file \u0026 and set options into the units params file."},{"line_number":142,"context_line":"        sudo cp /etc/sysconfig/named $BIND2_UNIT_CFG_FILE"},{"line_number":143,"context_line":"        uc_file_permissions\u003d$(stat -c \"%a\" $BIND2_UNIT_CFG_FILE)"},{"line_number":144,"context_line":"        sudo chmod 777 $BIND2_UNIT_CFG_FILE"},{"line_number":145,"context_line":"        OPTIONS\u003d\u0027OPTIONS\u003d\"-p \u0027$BIND2_DNS_PORT\u0027 -D named-2\"\u0027"},{"line_number":146,"context_line":"        NAMEDCONF\u003d\"NAMEDCONF\u003d/etc/named-2.conf\""},{"line_number":147,"context_line":"        sudo echo \"$OPTIONS\" \u003e\u003e $BIND2_UNIT_CFG_FILE"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"d067552b_0ff7f015","line":144,"updated":"2024-05-28 19:02:59.000000000","message":"Why is this file world write?","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        # create a second service file \u0026 and set options into the units params file."},{"line_number":142,"context_line":"        sudo cp /etc/sysconfig/named $BIND2_UNIT_CFG_FILE"},{"line_number":143,"context_line":"        uc_file_permissions\u003d$(stat -c \"%a\" $BIND2_UNIT_CFG_FILE)"},{"line_number":144,"context_line":"        sudo chmod 777 $BIND2_UNIT_CFG_FILE"},{"line_number":145,"context_line":"        OPTIONS\u003d\u0027OPTIONS\u003d\"-p \u0027$BIND2_DNS_PORT\u0027 -D named-2\"\u0027"},{"line_number":146,"context_line":"        NAMEDCONF\u003d\"NAMEDCONF\u003d/etc/named-2.conf\""},{"line_number":147,"context_line":"        sudo echo \"$OPTIONS\" \u003e\u003e $BIND2_UNIT_CFG_FILE"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"1311193d_bc94cea6","line":144,"in_reply_to":"d067552b_0ff7f015","updated":"2024-05-29 17:24:01.000000000","message":"I am removing lines 143, 144, 149\nOn my devstack, this file has 644 permissions.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        sudo chmod $uc_file_permissions $BIND2_UNIT_CFG_FILE"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        sudo cp /lib/systemd/system/named.service $BIND2_SERVICE_FILE"},{"line_number":152,"context_line":"        if [ ! -d $BIND2_RUN_DIR ]; then"},{"line_number":153,"context_line":"            sudo mkdir $BIND2_RUN_DIR"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":25,"id":"0f194fa9_e8bbb616","line":152,"updated":"2024-05-28 19:02:59.000000000","message":"Conditional is not needed here.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        sudo chmod $uc_file_permissions $BIND2_UNIT_CFG_FILE"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        sudo cp /lib/systemd/system/named.service $BIND2_SERVICE_FILE"},{"line_number":152,"context_line":"        if [ ! -d $BIND2_RUN_DIR ]; then"},{"line_number":153,"context_line":"            sudo mkdir $BIND2_RUN_DIR"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":25,"id":"d5f96d65_ee65f112","line":152,"in_reply_to":"0f194fa9_e8bbb616","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        sudo cp /lib/systemd/system/named.service $BIND2_SERVICE_FILE"},{"line_number":152,"context_line":"        if [ ! -d $BIND2_RUN_DIR ]; then"},{"line_number":153,"context_line":"            sudo mkdir $BIND2_RUN_DIR"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # set the various declarations"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"832bc45f_3aff41fb","line":153,"updated":"2024-05-28 19:02:59.000000000","message":"This should be mkdir -p in case part of the path is missing","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        sudo cp /lib/systemd/system/named.service $BIND2_SERVICE_FILE"},{"line_number":152,"context_line":"        if [ ! -d $BIND2_RUN_DIR ]; then"},{"line_number":153,"context_line":"            sudo mkdir $BIND2_RUN_DIR"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # set the various declarations"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"f5b2060d_1f4d73c8","line":153,"in_reply_to":"832bc45f_3aff41fb","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":169,"context_line":"        sudo chown -R $BIND_USER:$BIND_GROUP $BIND2_VAR_DIR"},{"line_number":170,"context_line":"        sudo cat $BIND2_CFG_FILE"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    elif is_suse; then"},{"line_number":173,"context_line":"        install_package bind"},{"line_number":174,"context_line":"    fi"},{"line_number":175,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":25,"id":"cc72966d_a5e9b429","line":172,"updated":"2024-05-28 19:02:59.000000000","message":"All references to \"is_suse\" should be removed.\nSee: https://review.opendev.org/c/openstack/designate/+/900932","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        sudo chown -R $BIND_USER:$BIND_GROUP $BIND2_VAR_DIR"},{"line_number":170,"context_line":"        sudo cat $BIND2_CFG_FILE"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    elif is_suse; then"},{"line_number":173,"context_line":"        install_package bind"},{"line_number":174,"context_line":"    fi"},{"line_number":175,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":25,"id":"07155864_9f488b4a","line":172,"in_reply_to":"cc72966d_a5e9b429","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":181,"context_line":"    add_user_to_group $STACK_USER $BIND_GROUP"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    for cfg_dir in \"$BIND_CFG_DIR\" \"$BIND2_CFG_DIR\"; do"},{"line_number":184,"context_line":"    \tif [[ ! -d $cfg_dir ]]; then"},{"line_number":185,"context_line":"            sudo mkdir -p $cfg_dir"},{"line_number":186,"context_line":"      fi"},{"line_number":187,"context_line":"      sudo chown $BIND_USER:$BIND_GROUP $cfg_dir"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"94cf4685_427103a5","line":184,"updated":"2024-05-28 19:02:59.000000000","message":"This conditional is not necessary","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    add_user_to_group $STACK_USER $BIND_GROUP"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    for cfg_dir in \"$BIND_CFG_DIR\" \"$BIND2_CFG_DIR\"; do"},{"line_number":184,"context_line":"    \tif [[ ! -d $cfg_dir ]]; then"},{"line_number":185,"context_line":"            sudo mkdir -p $cfg_dir"},{"line_number":186,"context_line":"      fi"},{"line_number":187,"context_line":"      sudo chown $BIND_USER:$BIND_GROUP $cfg_dir"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"10c65414_ba2bb147","line":184,"in_reply_to":"94cf4685_427103a5","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":185,"context_line":"            sudo mkdir -p $cfg_dir"},{"line_number":186,"context_line":"      fi"},{"line_number":187,"context_line":"      sudo chown $BIND_USER:$BIND_GROUP $cfg_dir"},{"line_number":188,"context_line":"    \tsudo chown -R $BIND_USER:$BIND_GROUP $cfg_dir"},{"line_number":189,"context_line":"    \tsudo chmod -R g+r $cfg_dir"},{"line_number":190,"context_line":"    done"},{"line_number":191,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":25,"id":"e1f7c71c_e407b293","line":188,"updated":"2024-05-28 19:02:59.000000000","message":"These lines appear to have tabs.\n\nAnother patch is fixing the bashate configuration to look at the backend plugin files. It might be good to run bashate on this file to get ahead of the game (or rebase on top of that one). I expect there are a number of style issues in this file.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            sudo mkdir -p $cfg_dir"},{"line_number":186,"context_line":"      fi"},{"line_number":187,"context_line":"      sudo chown $BIND_USER:$BIND_GROUP $cfg_dir"},{"line_number":188,"context_line":"    \tsudo chown -R $BIND_USER:$BIND_GROUP $cfg_dir"},{"line_number":189,"context_line":"    \tsudo chmod -R g+r $cfg_dir"},{"line_number":190,"context_line":"    done"},{"line_number":191,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":25,"id":"70aa988a_6f9c38f2","line":188,"in_reply_to":"e1f7c71c_e407b293","updated":"2024-05-29 17:24:01.000000000","message":"Cool, I didn\u0027t know we could just run that linter.\nI ran it and fixed most of what I found, now I have a few warnings and one error, as it is not a bash script. I think it is ok now, I will upload it again.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":217,"context_line":"    if [ -d $BIND2_CFG_DIR ]; then"},{"line_number":218,"context_line":"        sudo systemctl enable $BIND2_SERVICE_NAME"},{"line_number":219,"context_line":"        # if is_ubuntu; then"},{"line_number":220,"context_line":"        #     sudo systemctl start $BIND2_SERVICE_NAME"},{"line_number":221,"context_line":"        # fi"},{"line_number":222,"context_line":"    fi"},{"line_number":223,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"3fc4d015_052b5020","line":220,"updated":"2024-05-28 19:02:59.000000000","message":"These comments can be removed, the service is started on line 392 / 403","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    if [ -d $BIND2_CFG_DIR ]; then"},{"line_number":218,"context_line":"        sudo systemctl enable $BIND2_SERVICE_NAME"},{"line_number":219,"context_line":"        # if is_ubuntu; then"},{"line_number":220,"context_line":"        #     sudo systemctl start $BIND2_SERVICE_NAME"},{"line_number":221,"context_line":"        # fi"},{"line_number":222,"context_line":"    fi"},{"line_number":223,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"4585d35a_a661cc48","line":220,"in_reply_to":"3fc4d015_052b5020","updated":"2024-05-29 17:24:01.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":289,"context_line":"EOF"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    # Configure Bind #1 instance"},{"line_number":292,"context_line":"    sudo chown $STACK_USER $BIND_CFG_DIR"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    # create rndc key and config"},{"line_number":295,"context_line":"    sudo rndc-confgen -a -c $BIND_CFG_DIR/rndc.key"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"8a20000b_2d8c2c52","line":292,"updated":"2024-05-28 19:02:59.000000000","message":"Wasn\u0027t this already done on line 187?\nI\u0027m not sure why this ownership is changed again.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":289,"context_line":"EOF"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    # Configure Bind #1 instance"},{"line_number":292,"context_line":"    sudo chown $STACK_USER $BIND_CFG_DIR"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    # create rndc key and config"},{"line_number":295,"context_line":"    sudo rndc-confgen -a -c $BIND_CFG_DIR/rndc.key"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"d1a47b28_1cd2177b","line":292,"in_reply_to":"8a20000b_2d8c2c52","updated":"2024-05-29 17:24:01.000000000","message":"Might be copy paste / just to be sure. I will remove this line.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":317,"context_line":"};"},{"line_number":318,"context_line":"EOF"},{"line_number":319,"context_line":"    # Configure Bind #2 instance"},{"line_number":320,"context_line":"    sudo chown $STACK_USER $BIND2_CFG_DIR"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    # Create the tsigkeys for the secondary pool \u0026 add it to the bind-2"},{"line_number":323,"context_line":"    # named.conf file."}],"source_content_type":"application/octet-stream","patch_set":25,"id":"7c31f0c1_9981b322","line":320,"updated":"2024-05-28 19:02:59.000000000","message":"Same question as above, why is this ownership changed again here when it was set on line 187?","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":317,"context_line":"};"},{"line_number":318,"context_line":"EOF"},{"line_number":319,"context_line":"    # Configure Bind #2 instance"},{"line_number":320,"context_line":"    sudo chown $STACK_USER $BIND2_CFG_DIR"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    # Create the tsigkeys for the secondary pool \u0026 add it to the bind-2"},{"line_number":323,"context_line":"    # named.conf file."}],"source_content_type":"application/octet-stream","patch_set":25,"id":"00902bed_0b8b0f0a","line":320,"in_reply_to":"7c31f0c1_9981b322","updated":"2024-05-29 17:24:01.000000000","message":"Might be copy paste / just to be sure. I will remove this line.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    # Create the tsigkeys for the secondary pool \u0026 add it to the bind-2"},{"line_number":323,"context_line":"    # named.conf file."},{"line_number":324,"context_line":"    if [ -f $BIND2_TSIGKEY_FILE ]; then"},{"line_number":325,"context_line":"        sudo chmod 777 $BIND2_TSIGKEY_FILE"},{"line_number":326,"context_line":"        sudo rm -rf $BIND2_TSIGKEY_FILE"},{"line_number":327,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"465200b5_92dc60c5","line":324,"updated":"2024-05-28 19:02:59.000000000","message":"If you are just going to remove the file, why the conditional?","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    # Create the tsigkeys for the secondary pool \u0026 add it to the bind-2"},{"line_number":323,"context_line":"    # named.conf file."},{"line_number":324,"context_line":"    if [ -f $BIND2_TSIGKEY_FILE ]; then"},{"line_number":325,"context_line":"        sudo chmod 777 $BIND2_TSIGKEY_FILE"},{"line_number":326,"context_line":"        sudo rm -rf $BIND2_TSIGKEY_FILE"},{"line_number":327,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"c66c093d_509f21db","line":324,"in_reply_to":"465200b5_92dc60c5","updated":"2024-05-29 17:24:01.000000000","message":"I am deleting lines 324, 325 327, I am also not sure why they are here.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":322,"context_line":"    # Create the tsigkeys for the secondary pool \u0026 add it to the bind-2"},{"line_number":323,"context_line":"    # named.conf file."},{"line_number":324,"context_line":"    if [ -f $BIND2_TSIGKEY_FILE ]; then"},{"line_number":325,"context_line":"        sudo chmod 777 $BIND2_TSIGKEY_FILE"},{"line_number":326,"context_line":"        sudo rm -rf $BIND2_TSIGKEY_FILE"},{"line_number":327,"context_line":"    fi"},{"line_number":328,"context_line":"    sudo tsig-keygen -a hmac-sha256 poolsecondarykey \u003e $BIND2_TSIGKEY_FILE"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"a3a591c5_ce4bdb19","line":325,"updated":"2024-05-28 19:02:59.000000000","message":"Why is this file world write?","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    # Create the tsigkeys for the secondary pool \u0026 add it to the bind-2"},{"line_number":323,"context_line":"    # named.conf file."},{"line_number":324,"context_line":"    if [ -f $BIND2_TSIGKEY_FILE ]; then"},{"line_number":325,"context_line":"        sudo chmod 777 $BIND2_TSIGKEY_FILE"},{"line_number":326,"context_line":"        sudo rm -rf $BIND2_TSIGKEY_FILE"},{"line_number":327,"context_line":"    fi"},{"line_number":328,"context_line":"    sudo tsig-keygen -a hmac-sha256 poolsecondarykey \u003e $BIND2_TSIGKEY_FILE"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"2aec5968_3762ca0d","line":325,"in_reply_to":"a3a591c5_ce4bdb19","updated":"2024-05-29 17:24:01.000000000","message":"I am deleting lines 324, 325 327, I am also not sure why they are here.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":323,"context_line":"    # named.conf file."},{"line_number":324,"context_line":"    if [ -f $BIND2_TSIGKEY_FILE ]; then"},{"line_number":325,"context_line":"        sudo chmod 777 $BIND2_TSIGKEY_FILE"},{"line_number":326,"context_line":"        sudo rm -rf $BIND2_TSIGKEY_FILE"},{"line_number":327,"context_line":"    fi"},{"line_number":328,"context_line":"    sudo tsig-keygen -a hmac-sha256 poolsecondarykey \u003e $BIND2_TSIGKEY_FILE"},{"line_number":329,"context_line":"    NAME\u003d`cat $BIND2_TSIGKEY_FILE | grep \u0027key\u0027 | \\"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"ef672cc9_96ae4236","line":326,"updated":"2024-05-28 19:02:59.000000000","message":"If you are going to remove the file anyway, why change the permissions in the line above?","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    # named.conf file."},{"line_number":324,"context_line":"    if [ -f $BIND2_TSIGKEY_FILE ]; then"},{"line_number":325,"context_line":"        sudo chmod 777 $BIND2_TSIGKEY_FILE"},{"line_number":326,"context_line":"        sudo rm -rf $BIND2_TSIGKEY_FILE"},{"line_number":327,"context_line":"    fi"},{"line_number":328,"context_line":"    sudo tsig-keygen -a hmac-sha256 poolsecondarykey \u003e $BIND2_TSIGKEY_FILE"},{"line_number":329,"context_line":"    NAME\u003d`cat $BIND2_TSIGKEY_FILE | grep \u0027key\u0027 | \\"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"5016d40f_9a5b284c","line":326,"in_reply_to":"ef672cc9_96ae4236","updated":"2024-05-29 17:24:01.000000000","message":"I am deleting lines 324, 325 327, I am also not sure why they are here.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5e0e5381366ee00fa777ef4ce8cab82fd41cf76f","unresolved":true,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    # Create the tsigkeys for the secondary pool \u0026 add it to the bind-2"},{"line_number":265,"context_line":"    # named.conf file."},{"line_number":266,"context_line":"    if [ -f $BIND2_TSIGKEY_FILE ]; then"},{"line_number":267,"context_line":"        sudo chmod 777 $BIND2_TSIGKEY_FILE"},{"line_number":268,"context_line":"        sudo rm -rf $BIND2_TSIGKEY_FILE"},{"line_number":269,"context_line":"    fi"},{"line_number":270,"context_line":"    sudo tsig-keygen -a hmac-sha256 poolsecondarykey \u003e $BIND2_TSIGKEY_FILE"},{"line_number":271,"context_line":"    NAME\u003d`cat $BIND2_TSIGKEY_FILE | grep \u0027key\u0027 | \\"},{"line_number":272,"context_line":"        awk \u0027{split($0, a, \" \"); print a[2];}\u0027 | \\"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"4bb282f8_cd2b2a7a","line":269,"range":{"start_line":266,"start_character":4,"end_line":269,"end_character":6},"updated":"2024-06-04 13:15:11.000000000","message":"TODO oschwart: change that world writable permission","commit_id":"1f22935212c407db011d62286ab5a22127f09a27"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"36cec414048b83b6452e198ef3c980d62af11907","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    # Create the tsigkeys for the secondary pool \u0026 add it to the bind-2"},{"line_number":265,"context_line":"    # named.conf file."},{"line_number":266,"context_line":"    if [ -f $BIND2_TSIGKEY_FILE ]; then"},{"line_number":267,"context_line":"        sudo chmod 777 $BIND2_TSIGKEY_FILE"},{"line_number":268,"context_line":"        sudo rm -rf $BIND2_TSIGKEY_FILE"},{"line_number":269,"context_line":"    fi"},{"line_number":270,"context_line":"    sudo tsig-keygen -a hmac-sha256 poolsecondarykey \u003e $BIND2_TSIGKEY_FILE"},{"line_number":271,"context_line":"    NAME\u003d`cat $BIND2_TSIGKEY_FILE | grep \u0027key\u0027 | \\"},{"line_number":272,"context_line":"        awk \u0027{split($0, a, \" \"); print a[2];}\u0027 | \\"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"63b3a636_ca555eb5","line":269,"range":{"start_line":266,"start_character":4,"end_line":269,"end_character":6},"in_reply_to":"4bb282f8_cd2b2a7a","updated":"2024-06-04 15:07:08.000000000","message":"Done","commit_id":"1f22935212c407db011d62286ab5a22127f09a27"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"24bd1ac0ca96796228409ddab14dafbd18ac9960","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    sudo cp $BIND_CFG_DIR/zones.rfc1918 $BIND2_CFG_DIR"},{"line_number":82,"context_line":"    sudo cp $BIND_CFG_DIR/named.conf.local $BIND2_CFG_DIR"},{"line_number":83,"context_line":"    sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"},{"line_number":84,"context_line":"    sudo sed -i \u0027s/bind/bind-2/g\u0027 $BIND2_CFG_DIR/named.conf.local"},{"line_number":85,"context_line":"    sudo sed -i \u0027s/bind/bind-2/g\u0027 $BIND2_CFG_DIR/named.conf.default-zones"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # create a second service file"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"ff2c268f_bb9c92f6","line":84,"updated":"2024-06-28 22:49:13.000000000","message":"This actually brings up an interesting question. I don\u0027t see the /etc/bind nor /etc/bind-2 configuration files being captured in the tempest test run.\nMaybe we should enhance the tempest job to collect those as well?\n\nLike we do here: https://github.com/openstack/octavia/blob/master/zuul.d/jobs.yaml#L75","commit_id":"8cd36485172ea2f8714a1aac48b311c14ad1d4cc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"eddac3a87124dccf9443d605b4869d418844a772","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    sudo cp $BIND_CFG_DIR/zones.rfc1918 $BIND2_CFG_DIR"},{"line_number":82,"context_line":"    sudo cp $BIND_CFG_DIR/named.conf.local $BIND2_CFG_DIR"},{"line_number":83,"context_line":"    sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"},{"line_number":84,"context_line":"    sudo sed -i \u0027s/bind/bind-2/g\u0027 $BIND2_CFG_DIR/named.conf.local"},{"line_number":85,"context_line":"    sudo sed -i \u0027s/bind/bind-2/g\u0027 $BIND2_CFG_DIR/named.conf.default-zones"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # create a second service file"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"9d37d015_feab5052","line":84,"in_reply_to":"bff8374a_a5f7c3cd","updated":"2024-07-11 17:40:18.000000000","message":"A different patch is fine, I just wanted to raise the question if it would be helpful for debugging to capture those config files.","commit_id":"8cd36485172ea2f8714a1aac48b311c14ad1d4cc"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6ec99dc903578f1bfcd33ad71f2cc0c20cdf8172","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    sudo cp $BIND_CFG_DIR/zones.rfc1918 $BIND2_CFG_DIR"},{"line_number":82,"context_line":"    sudo cp $BIND_CFG_DIR/named.conf.local $BIND2_CFG_DIR"},{"line_number":83,"context_line":"    sudo cp $BIND_CFG_DIR/named.conf.default-zones $BIND2_CFG_DIR"},{"line_number":84,"context_line":"    sudo sed -i \u0027s/bind/bind-2/g\u0027 $BIND2_CFG_DIR/named.conf.local"},{"line_number":85,"context_line":"    sudo sed -i \u0027s/bind/bind-2/g\u0027 $BIND2_CFG_DIR/named.conf.default-zones"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # create a second service file"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"bff8374a_a5f7c3cd","line":84,"in_reply_to":"ff2c268f_bb9c92f6","updated":"2024-07-01 12:04:50.000000000","message":"Sounds good to me, I can add those.\n\nIs it related to this patch? Or should I add it as another patch in the chain?\n\nA reminder to myself:\nThe bind/named config files are different between fedora-like OSes, and Debian/Ubuntu-like OSes. After looking at .zuul.yaml files of both designate and designate-tempest-plugin repos, it looks like the correct place the add those lines is on designate\u0027s .zuul.yaml file. we have both Ubuntu\u0027s focal and jammy nodesets, and centos-9s. It will require different paths to include the configuration files for each OS.","commit_id":"8cd36485172ea2f8714a1aac48b311c14ad1d4cc"}],"devstack/plugin.sh":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":212,"context_line":"    if [ \"$DESIGNATE_BACKEND_DRIVER\" \u003d\u003d \"multipool-bind9\" ] \u0026\u0026"},{"line_number":213,"context_line":"           [ -d $BIND2_CFG_DIR ] \u0026\u0026 [ -f $BIND2_TSIGKEY_FILE ]; then"},{"line_number":214,"context_line":"        # parse the data from the bind-2/named.conf.tsigkeys file,"},{"line_number":215,"context_line":"        # whcih was created during the init_designate_backend section."},{"line_number":216,"context_line":"        NAME\u003d`cat $BIND2_TSIGKEY_FILE | grep \u0027key\u0027 | \\"},{"line_number":217,"context_line":"            awk \u0027{split($0, a, \" \"); print a[2];}\u0027 | \\"},{"line_number":218,"context_line":"            sed -e \u0027s/^\"//\u0027 -e \u0027s/\"$//\u0027| \\"}],"source_content_type":"text/x-sh","patch_set":11,"id":"29a49da0_17ede281","line":215,"range":{"start_line":215,"start_character":10,"end_line":215,"end_character":15},"updated":"2024-04-25 14:31:49.000000000","message":"todo: typo","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e93608148e5158e3564a3d2a276d799f06e89351","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    if [ \"$DESIGNATE_BACKEND_DRIVER\" \u003d\u003d \"multipool-bind9\" ] \u0026\u0026"},{"line_number":213,"context_line":"           [ -d $BIND2_CFG_DIR ] \u0026\u0026 [ -f $BIND2_TSIGKEY_FILE ]; then"},{"line_number":214,"context_line":"        # parse the data from the bind-2/named.conf.tsigkeys file,"},{"line_number":215,"context_line":"        # whcih was created during the init_designate_backend section."},{"line_number":216,"context_line":"        NAME\u003d`cat $BIND2_TSIGKEY_FILE | grep \u0027key\u0027 | \\"},{"line_number":217,"context_line":"            awk \u0027{split($0, a, \" \"); print a[2];}\u0027 | \\"},{"line_number":218,"context_line":"            sed -e \u0027s/^\"//\u0027 -e \u0027s/\"$//\u0027| \\"}],"source_content_type":"text/x-sh","patch_set":11,"id":"1c551540_247eea67","line":215,"range":{"start_line":215,"start_character":10,"end_line":215,"end_character":15},"in_reply_to":"29a49da0_17ede281","updated":"2024-04-29 11:25:53.000000000","message":"Done","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"}],"devstack/settings":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":3,"context_line":"DESIGNATE_AGENT_BACKEND_DRIVER\u003d${DESIGNATE_AGENT_BACKEND_DRIVER:-\"fake\"}"},{"line_number":4,"context_line":"DESIGNATE_POOL_ID\u003d${DESIGNATE_POOL_ID:-794ccc2c-d751-44fe-b57f-8894c9f5c842}"},{"line_number":5,"context_line":"DESIGNATE_DEFAULT_NS_RECORD\u003d${DESIGNATE_DEFAULT_NS_RECORD:-ns1.devstack.org.}"},{"line_number":6,"context_line":"DESIGNATE_DEFAULT_NS2_RECORD\u003d${DESIGNATE_DEFAULT_NS_RECORD:-ns2.devstack.org.}"},{"line_number":7,"context_line":"DESIGNATE_NOTIFICATION_DRIVER\u003d${DESIGNATE_NOTIFICATION_DRIVER:-messagingv2}"},{"line_number":8,"context_line":"DESIGNATE_NOTIFICATION_TOPICS\u003d${DESIGNATE_NOTIFICATION_TOPICS:-notifications}"},{"line_number":9,"context_line":"DESIGNATE_PERIODIC_RECOVERY_INTERVAL\u003d${DESIGNATE_PERIODIC_RECOVERY_INTERVAL:-120}"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"74b24bdf_42e2ebeb","line":6,"range":{"start_line":6,"start_character":31,"end_line":6,"end_character":58},"updated":"2024-04-25 14:31:49.000000000","message":"I see that in case DESIGNATE_DEFAULT_NS_RECORD is not defined, we want both of the NS records to be different. So I would suggest to add a DESIGNATE_DEFAULT_NS2_RECORD variable","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":3,"context_line":"DESIGNATE_AGENT_BACKEND_DRIVER\u003d${DESIGNATE_AGENT_BACKEND_DRIVER:-\"fake\"}"},{"line_number":4,"context_line":"DESIGNATE_POOL_ID\u003d${DESIGNATE_POOL_ID:-794ccc2c-d751-44fe-b57f-8894c9f5c842}"},{"line_number":5,"context_line":"DESIGNATE_DEFAULT_NS_RECORD\u003d${DESIGNATE_DEFAULT_NS_RECORD:-ns1.devstack.org.}"},{"line_number":6,"context_line":"DESIGNATE_DEFAULT_NS2_RECORD\u003d${DESIGNATE_DEFAULT_NS_RECORD:-ns2.devstack.org.}"},{"line_number":7,"context_line":"DESIGNATE_NOTIFICATION_DRIVER\u003d${DESIGNATE_NOTIFICATION_DRIVER:-messagingv2}"},{"line_number":8,"context_line":"DESIGNATE_NOTIFICATION_TOPICS\u003d${DESIGNATE_NOTIFICATION_TOPICS:-notifications}"},{"line_number":9,"context_line":"DESIGNATE_PERIODIC_RECOVERY_INTERVAL\u003d${DESIGNATE_PERIODIC_RECOVERY_INTERVAL:-120}"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"72607b3a_c8413090","line":6,"range":{"start_line":6,"start_character":31,"end_line":6,"end_character":58},"in_reply_to":"74b24bdf_42e2ebeb","updated":"2024-05-29 17:24:01.000000000","message":"ok I am not sure what I saw / wanted to do here lol. I am marking it as resolved.","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":38,"context_line":"DESIGNATE_SERVICE_PORT_DNS\u003d${DESIGNATE_SERVICE_PORT_DNS:-53}"},{"line_number":39,"context_line":"DESIGNATE_SERVICE_PORT2_DNS\u003d${DESIGNATE_SERVICE_PORT2_DNS:-1053}"},{"line_number":40,"context_line":"DESIGNATE_SERVICE_PORT_MDNS\u003d${DESIGNATE_SERVICE_PORT_MDNS:-5354}"},{"line_number":41,"context_line":"DESIGNATE_SERVICE_PORT2_MDNS\u003d${DESIGNATE_SERVICE_PORT2_MDNS:-5354}"},{"line_number":42,"context_line":"DESIGNATE_SERVICE_PORT_AGENT\u003d${DESIGNATE_SERVICE_PORT_AGENT:-5358}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"DESIGNATE_DIR\u003d$DEST/designate"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"f41014b6_e011299b","line":41,"range":{"start_line":41,"start_character":61,"end_line":41,"end_character":65},"updated":"2024-04-25 14:31:49.000000000","message":"would it work if both DESIGNATE_SERVICE_PORT_MDNS \u0026 2 will use the same port?","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":false,"context_lines":[{"line_number":38,"context_line":"DESIGNATE_SERVICE_PORT_DNS\u003d${DESIGNATE_SERVICE_PORT_DNS:-53}"},{"line_number":39,"context_line":"DESIGNATE_SERVICE_PORT2_DNS\u003d${DESIGNATE_SERVICE_PORT2_DNS:-1053}"},{"line_number":40,"context_line":"DESIGNATE_SERVICE_PORT_MDNS\u003d${DESIGNATE_SERVICE_PORT_MDNS:-5354}"},{"line_number":41,"context_line":"DESIGNATE_SERVICE_PORT2_MDNS\u003d${DESIGNATE_SERVICE_PORT2_MDNS:-5354}"},{"line_number":42,"context_line":"DESIGNATE_SERVICE_PORT_AGENT\u003d${DESIGNATE_SERVICE_PORT_AGENT:-5358}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"DESIGNATE_DIR\u003d$DEST/designate"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"baeaa6ee_27dd226b","line":41,"range":{"start_line":41,"start_character":61,"end_line":41,"end_character":65},"in_reply_to":"3b057b79_d2009404","updated":"2024-05-29 17:24:01.000000000","message":"ok, thanks.","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":38,"context_line":"DESIGNATE_SERVICE_PORT_DNS\u003d${DESIGNATE_SERVICE_PORT_DNS:-53}"},{"line_number":39,"context_line":"DESIGNATE_SERVICE_PORT2_DNS\u003d${DESIGNATE_SERVICE_PORT2_DNS:-1053}"},{"line_number":40,"context_line":"DESIGNATE_SERVICE_PORT_MDNS\u003d${DESIGNATE_SERVICE_PORT_MDNS:-5354}"},{"line_number":41,"context_line":"DESIGNATE_SERVICE_PORT2_MDNS\u003d${DESIGNATE_SERVICE_PORT2_MDNS:-5354}"},{"line_number":42,"context_line":"DESIGNATE_SERVICE_PORT_AGENT\u003d${DESIGNATE_SERVICE_PORT_AGENT:-5358}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"DESIGNATE_DIR\u003d$DEST/designate"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"3b057b79_d2009404","line":41,"range":{"start_line":41,"start_character":61,"end_line":41,"end_character":65},"in_reply_to":"f41014b6_e011299b","updated":"2024-05-28 19:02:59.000000000","message":"They should use the same mini-DNS.","commit_id":"f2c91dafd269d04bcf3b24dfede20646f0b65ee1"}],"doc/source/user/manage-zones.rst":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"988a33a99474bdf36d0201e928ea14b3e9d8c017","unresolved":true,"context_lines":[{"line_number":187,"context_line":"    |                |                                      |"},{"line_number":188,"context_line":"    | created_at     | 2023-01-24T18:30:45.000000           |"},{"line_number":189,"context_line":"    | description    | None                                 |"},{"line_number":190,"context_line":"    | email          | dnsmaster@example2.com               |"},{"line_number":191,"context_line":"    | id             | d106e7b0-9973-41a1-b3db-0fb34b6d952c |"},{"line_number":192,"context_line":"    | masters        |                                      |"},{"line_number":193,"context_line":"    | name           | example2.com.                        |"}],"source_content_type":"text/x-rst","patch_set":10,"id":"d04f320c_fb1d3055","line":190,"updated":"2023-04-07 15:58:48.000000000","message":"We should stick to example.com or example.org. Those are reserved for testing/docs.","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":187,"context_line":"    |                |                                      |"},{"line_number":188,"context_line":"    | created_at     | 2023-01-24T18:30:45.000000           |"},{"line_number":189,"context_line":"    | description    | None                                 |"},{"line_number":190,"context_line":"    | email          | dnsmaster@example2.com               |"},{"line_number":191,"context_line":"    | id             | d106e7b0-9973-41a1-b3db-0fb34b6d952c |"},{"line_number":192,"context_line":"    | masters        |                                      |"},{"line_number":193,"context_line":"    | name           | example2.com.                        |"}],"source_content_type":"text/x-rst","patch_set":10,"id":"e9c15a47_81d6a7e1","line":190,"in_reply_to":"d04f320c_fb1d3055","updated":"2024-04-25 14:31:49.000000000","message":"todo: change it to example@example.com","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e93608148e5158e3564a3d2a276d799f06e89351","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    |                |                                      |"},{"line_number":188,"context_line":"    | created_at     | 2023-01-24T18:30:45.000000           |"},{"line_number":189,"context_line":"    | description    | None                                 |"},{"line_number":190,"context_line":"    | email          | dnsmaster@example2.com               |"},{"line_number":191,"context_line":"    | id             | d106e7b0-9973-41a1-b3db-0fb34b6d952c |"},{"line_number":192,"context_line":"    | masters        |                                      |"},{"line_number":193,"context_line":"    | name           | example2.com.                        |"}],"source_content_type":"text/x-rst","patch_set":10,"id":"b3fcdd0a_1364a289","line":190,"in_reply_to":"e9c15a47_81d6a7e1","updated":"2024-04-29 11:25:53.000000000","message":"Done","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"988a33a99474bdf36d0201e928ea14b3e9d8c017","unresolved":true,"context_lines":[{"line_number":190,"context_line":"    | email          | dnsmaster@example2.com               |"},{"line_number":191,"context_line":"    | id             | d106e7b0-9973-41a1-b3db-0fb34b6d952c |"},{"line_number":192,"context_line":"    | masters        |                                      |"},{"line_number":193,"context_line":"    | name           | example2.com.                        |"},{"line_number":194,"context_line":"    | pool_id        | 10cec123-43f0-4b60-98a8-1204dd826c67 |"},{"line_number":195,"context_line":"    | project_id     | 5160768b59524fd283a4fa82d7327644     |"},{"line_number":196,"context_line":"    | serial         | 1674585045                           |"}],"source_content_type":"text/x-rst","patch_set":10,"id":"6e5dfcde_72446e92","line":193,"updated":"2023-04-07 15:58:48.000000000","message":"Same","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":190,"context_line":"    | email          | dnsmaster@example2.com               |"},{"line_number":191,"context_line":"    | id             | d106e7b0-9973-41a1-b3db-0fb34b6d952c |"},{"line_number":192,"context_line":"    | masters        |                                      |"},{"line_number":193,"context_line":"    | name           | example2.com.                        |"},{"line_number":194,"context_line":"    | pool_id        | 10cec123-43f0-4b60-98a8-1204dd826c67 |"},{"line_number":195,"context_line":"    | project_id     | 5160768b59524fd283a4fa82d7327644     |"},{"line_number":196,"context_line":"    | serial         | 1674585045                           |"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7ff1174f_d82a193e","line":193,"in_reply_to":"6e5dfcde_72446e92","updated":"2024-04-25 14:31:49.000000000","message":"todo: change it to example@example.com","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e93608148e5158e3564a3d2a276d799f06e89351","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    | email          | dnsmaster@example2.com               |"},{"line_number":191,"context_line":"    | id             | d106e7b0-9973-41a1-b3db-0fb34b6d952c |"},{"line_number":192,"context_line":"    | masters        |                                      |"},{"line_number":193,"context_line":"    | name           | example2.com.                        |"},{"line_number":194,"context_line":"    | pool_id        | 10cec123-43f0-4b60-98a8-1204dd826c67 |"},{"line_number":195,"context_line":"    | project_id     | 5160768b59524fd283a4fa82d7327644     |"},{"line_number":196,"context_line":"    | serial         | 1674585045                           |"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3886dea4_206c642d","line":193,"in_reply_to":"7ff1174f_d82a193e","updated":"2024-04-29 11:25:53.000000000","message":"Done","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"988a33a99474bdf36d0201e928ea14b3e9d8c017","unresolved":true,"context_lines":[{"line_number":206,"context_line":"    +--------------------------------------+---------------+---------+------------+--------+--------+"},{"line_number":207,"context_line":"    | id                                   | name          | type    |     serial | status | action |"},{"line_number":208,"context_line":"    +--------------------------------------+---------------+---------+------------+--------+--------+"},{"line_number":209,"context_line":"    | d106e7b0-9973-41a1-b3db-0fb34b6d952c | example2.com. | PRIMARY | 1674585045 | ACTIVE | NONE   |"},{"line_number":210,"context_line":"    +--------------------------------------+---------------+---------+------------+--------+--------+"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"97a2eaf6_fe4dbf85","line":209,"range":{"start_line":209,"start_character":45,"end_line":209,"end_character":58},"updated":"2023-04-07 15:58:48.000000000","message":"same","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e93608148e5158e3564a3d2a276d799f06e89351","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    +--------------------------------------+---------------+---------+------------+--------+--------+"},{"line_number":207,"context_line":"    | id                                   | name          | type    |     serial | status | action |"},{"line_number":208,"context_line":"    +--------------------------------------+---------------+---------+------------+--------+--------+"},{"line_number":209,"context_line":"    | d106e7b0-9973-41a1-b3db-0fb34b6d952c | example2.com. | PRIMARY | 1674585045 | ACTIVE | NONE   |"},{"line_number":210,"context_line":"    +--------------------------------------+---------------+---------+------------+--------+--------+"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"8deca7fc_b4fd0f7e","line":209,"range":{"start_line":209,"start_character":45,"end_line":209,"end_character":58},"in_reply_to":"829a939f_a6b3fce1","updated":"2024-04-29 11:25:53.000000000","message":"Done","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":206,"context_line":"    +--------------------------------------+---------------+---------+------------+--------+--------+"},{"line_number":207,"context_line":"    | id                                   | name          | type    |     serial | status | action |"},{"line_number":208,"context_line":"    +--------------------------------------+---------------+---------+------------+--------+--------+"},{"line_number":209,"context_line":"    | d106e7b0-9973-41a1-b3db-0fb34b6d952c | example2.com. | PRIMARY | 1674585045 | ACTIVE | NONE   |"},{"line_number":210,"context_line":"    +--------------------------------------+---------------+---------+------------+--------+--------+"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"829a939f_a6b3fce1","line":209,"range":{"start_line":209,"start_character":45,"end_line":209,"end_character":58},"in_reply_to":"97a2eaf6_fe4dbf85","updated":"2024-04-25 14:31:49.000000000","message":"todo: change it to example@example.com","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"988a33a99474bdf36d0201e928ea14b3e9d8c017","unresolved":true,"context_lines":[{"line_number":243,"context_line":"Any records present in the zone are also deleted and will no longer resolve."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Multiple Pools Zone Delete"},{"line_number":247,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"When deleting the zone in a mult-pool configuration you would would perform"}],"source_content_type":"text/x-rst","patch_set":10,"id":"c97a205e_7e5df2d0","line":246,"updated":"2023-04-07 15:58:48.000000000","message":"Do we need this section? The zone delete process is no different than the section above.","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e93608148e5158e3564a3d2a276d799f06e89351","unresolved":false,"context_lines":[{"line_number":243,"context_line":"Any records present in the zone are also deleted and will no longer resolve."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Multiple Pools Zone Delete"},{"line_number":247,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"When deleting the zone in a mult-pool configuration you would would perform"}],"source_content_type":"text/x-rst","patch_set":10,"id":"975c8f12_95216599","line":246,"in_reply_to":"4c506287_951f28a1","updated":"2024-04-29 11:25:53.000000000","message":"Done","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2c7f4fa7142a24727f158a870fe2b64bfc58cf62","unresolved":true,"context_lines":[{"line_number":243,"context_line":"Any records present in the zone are also deleted and will no longer resolve."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Multiple Pools Zone Delete"},{"line_number":247,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"When deleting the zone in a mult-pool configuration you would would perform"}],"source_content_type":"text/x-rst","patch_set":10,"id":"4c506287_951f28a1","line":246,"in_reply_to":"c97a205e_7e5df2d0","updated":"2024-04-25 14:31:49.000000000","message":"todo: delete this section","commit_id":"eaf3637fa622becad5e2a4393ea0c0e132c7f919"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"659d9e2982ce51e658653586aa85cff4cc781f2d","unresolved":true,"context_lines":[{"line_number":172,"context_line":"Multiple Pools Zone Creation"},{"line_number":173,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":174,"context_line":"When Multipools is configured, you must indicate the pool your zone will be"},{"line_number":175,"context_line":"attached to. This is done via the attributes options and **MUST** be included"},{"line_number":176,"context_line":"during the zone creation to identify the pool:"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"  .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1c3d092f_013689b2","line":175,"updated":"2024-05-28 19:02:59.000000000","message":"I wonder if this \"**MUST**\" is true given it would still fall back to the \"default\" pool with some scheduling filters defined.","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a243fc78dfa9347a2ebb7e9fb33e46c34bf8f198","unresolved":true,"context_lines":[{"line_number":172,"context_line":"Multiple Pools Zone Creation"},{"line_number":173,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":174,"context_line":"When Multipools is configured, you must indicate the pool your zone will be"},{"line_number":175,"context_line":"attached to. This is done via the attributes options and **MUST** be included"},{"line_number":176,"context_line":"during the zone creation to identify the pool:"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"  .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":25,"id":"67277418_c4aa3ac2","line":175,"in_reply_to":"1c3d092f_013689b2","updated":"2024-05-29 17:24:01.000000000","message":"Hmm right, I agree.\nSo I suggest to change it to the following:\n\nWhen Multipools is configured, if you want to create a zone and attach it to a\ndifferent pool than the default one, you must indicate to which pool your zone\nwill be attached to. This is done via the attributes options during the zone\ncreation.\n\nSee the following example:","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"893a029be9365634f123fe6bcd427bebb8d2f99c","unresolved":false,"context_lines":[{"line_number":172,"context_line":"Multiple Pools Zone Creation"},{"line_number":173,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":174,"context_line":"When Multipools is configured, you must indicate the pool your zone will be"},{"line_number":175,"context_line":"attached to. This is done via the attributes options and **MUST** be included"},{"line_number":176,"context_line":"during the zone creation to identify the pool:"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"  .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":25,"id":"dc47f165_bb1595b9","line":175,"in_reply_to":"67277418_c4aa3ac2","updated":"2024-08-14 10:31:38.000000000","message":"Done","commit_id":"3dc94ef48553c110b723cbf476c7d7dddb0fdac6"}]}