)]}'
{"designate/central/__init__.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"7a8e4080fa99aa935b8ad00bd60eb4ab54e2a889","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027E-Mail for Managed resources\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027managed_resource_tenant_id\u0027,"},{"line_number":39,"context_line":"               help\u003d\"The Tenant ID that will own any managed resources.\"),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027min_ttl\u0027, default\u003d60, help\u003d\"Minimum TTL allowed\")"},{"line_number":41,"context_line":"], group\u003d\u0027service:central\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2Fp48%3D","line":40,"updated":"2014-04-11 11:50:39.000000000","message":"This should changed to an IntOpt rather than StrOpt.\n\nAlso - We should include some tests to ensure that a value of None is accepted, and that any TTL is accepted when min_ttl\u003dNone","commit_id":"6c7c35036ae5015aded477e095a8911bb0a6ff5d"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"125be9cf1b173a56666cab927dcb724f1fa8eb1c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027E-Mail for Managed resources\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027managed_resource_tenant_id\u0027,"},{"line_number":39,"context_line":"               help\u003d\"The Tenant ID that will own any managed resources.\"),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027min_ttl\u0027, default\u003d\"None\", help\u003d\"Minimum TTL allowed\")"},{"line_number":41,"context_line":"], group\u003d\u0027service:central\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2FPco%3D","line":40,"updated":"2014-04-15 20:38:03.000000000","message":"I decided to keep it a StrOpt to allow for a \"None\" option.","commit_id":"5442ee202ebe1008d2e04da429da90427754bfc9"}],"designate/central/service.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"4efe7f6149f532924d7842a2582b15dc1b759694","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    def _is_valid_ttl(self, context, ttl):"},{"line_number":238,"context_line":"        min_ttl \u003d int(cfg.CONF[\u0027service:central\u0027].min_ttl)"},{"line_number":239,"context_line":"        if ttl \u003c min_ttl:"},{"line_number":240,"context_line":"            if not policy.check(\u0027use_minimum_ttl\u0027, context):"},{"line_number":241,"context_line":"                raise exceptions.InvalidTTL(\u0027TTL is below the minimum of %s\u0027"},{"line_number":242,"context_line":"                                            % min_ttl)"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FwIQ%3D","line":240,"updated":"2014-04-10 16:18:37.000000000","message":"Can we change the policy name here? The current name doesn\u0027t suggest that the user can use TTLs below the configured minimum.\n\nI have to admit though - I can\u0027t think of a good name off the top of my head :)","commit_id":"6ae84dbd987e6cb9df5ecabe973a544d4591bacb"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"29524c2d3fe3846049a39580e2b20879d07d1e2a","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    def _is_valid_ttl(self, context, ttl):"},{"line_number":238,"context_line":"        min_ttl \u003d int(cfg.CONF[\u0027service:central\u0027].min_ttl)"},{"line_number":239,"context_line":"        if ttl \u003c min_ttl:"},{"line_number":240,"context_line":"            if not policy.check(\u0027use_minimum_ttl\u0027, context):"},{"line_number":241,"context_line":"                raise exceptions.InvalidTTL(\u0027TTL is below the minimum of %s\u0027"},{"line_number":242,"context_line":"                                            % min_ttl)"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FvTI%3D","line":240,"in_reply_to":"AAAAW3%2F%2FwIQ%3D","updated":"2014-04-10 18:01:19.000000000","message":"Yeah I didn\u0027t like it either. \n\nHow about \"use_low_ttl\"?","commit_id":"6ae84dbd987e6cb9df5ecabe973a544d4591bacb"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"4efe7f6149f532924d7842a2582b15dc1b759694","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        self._is_valid_domain_name(context, values[\u0027name\u0027])"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # Ensure TTL is above the minimum"},{"line_number":500,"context_line":"        self._is_valid_ttl(context, values[\u0027ttl\u0027])"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        # Handle sub-domains appropriately"},{"line_number":503,"context_line":"        parent_domain \u003d self._is_subdomain(context, values[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FwHU%3D","line":500,"updated":"2014-04-10 16:18:37.000000000","message":"Since TTL is optional, we\u0027ll need to cater for that:\n\n    ttl \u003d values.get(\u0027ttl\u0027, None)\n\n    if ttl is not None:\n        self._is_valid_ttl(context, ttl)","commit_id":"6ae84dbd987e6cb9df5ecabe973a544d4591bacb"}],"designate/tests/test_central/test_service.py":[{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"23a101c42971581c50adf771be6e05a3546e6e7c","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        _ok(sub_domain, \u0027record.example.org.\u0027)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_is_valid_ttl(self):"},{"line_number":151,"context_line":"        context \u003d self.get_context(tenant\u003d\u0027b\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        values \u003d self.get_domain_fixture(1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2Fuq4%3D","line":150,"updated":"2014-04-10 19:33:14.000000000","message":"When I ran these two tests alone, they would pass, but when I ran them with everything else they were failing. I think the main issue is the policy check, these should be non-admin users. When I ran them alone it seemed to get that, when I ran all the tests it didn\u0027t seem to get it.","commit_id":"ff27fef0c23b16b91b7078f2011e753ba848cb02"}]}