)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1f41edde62d0097cc2acb92034fae9687f5d7f9e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Erik Olof Gunnar Andersson \u003ceandersson@blizzard.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-10-23 00:25:49 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for pdns 4.5 and Ubuntu 22.04"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I04a3a48c7e72797092fd1c3bdc6252085eff04df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"90ec6779_c3585240","line":7,"updated":"2022-10-23 12:07:41.000000000","message":"Add \"[CI]\" or maybe \"devstack:\" to make it clear that this is only about the CI setup, not support in designate itself.","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ac044c23ee674f7b652ce964cdeea7cfabf8c6b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Erik Olof Gunnar Andersson \u003ceandersson@blizzard.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-10-23 00:25:49 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for pdns 4.5 and Ubuntu 22.04"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I04a3a48c7e72797092fd1c3bdc6252085eff04df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"725b7e0c_19f9948b","line":7,"in_reply_to":"90ec6779_c3585240","updated":"2022-10-24 03:07:54.000000000","message":"Done","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c6bf442d00b0374f6e44b0666116f3f9fe54c38c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"df7b7bdf_54a03343","updated":"2022-10-17 02:32:46.000000000","message":"recheck holding a node for investigation","commit_id":"69f644f024d987276275f951082af6b3f2f62364"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6b31654dc8ed27ed41f19116df5e9fe3bea5c497","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"81d6a60d_bc02b6b1","updated":"2022-10-25 20:31:01.000000000","message":"LGTM\nI wish they provided a tool for the schema, but....","commit_id":"0b162a4c48ff7806ee0dda0f871a884a32374ed9"}],"devstack/designate_plugins/backend-pdns4":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1f41edde62d0097cc2acb92034fae9687f5d7f9e","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    install_package $PDNS"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # Wait for the pdns4 config \u0026 schema."},{"line_number":51,"context_line":"    stop_designate_backend"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"8f7dc7b2_a2fceca3","line":50,"updated":"2022-10-23 12:07:41.000000000","message":"Doing a stop during install is so confusing that IMO this deserves a more verbose explanation.","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e8475d392b983358d7f2407c9ce8bbf9811327bc","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    install_package $PDNS"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # Wait for the pdns4 config \u0026 schema."},{"line_number":51,"context_line":"    stop_designate_backend"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"2b2bbce0_a874d9b3","line":50,"in_reply_to":"4e45b997_d06e6723","updated":"2022-10-25 07:32:40.000000000","message":"Ack","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"756c25124ff217fd2adf904775acbc62e4febf40","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    install_package $PDNS"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # Wait for the pdns4 config \u0026 schema."},{"line_number":51,"context_line":"    stop_designate_backend"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"4e45b997_d06e6723","line":50,"in_reply_to":"8f7dc7b2_a2fceca3","updated":"2022-10-23 16:26:59.000000000","message":"The stops are there to stop log spam. The problem is that the order of operations makes this tricky.","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1f41edde62d0097cc2acb92034fae9687f5d7f9e","unresolved":true,"context_lines":[{"line_number":93,"context_line":"guardian\u003dyes"},{"line_number":94,"context_line":"daemon\u003dyes"},{"line_number":95,"context_line":"disable-axfr\u003dno"},{"line_number":96,"context_line":"# local-address\u003d$HOST_IP $HOST_IPV6"},{"line_number":97,"context_line":"local-port\u003d$DESIGNATE_SERVICE_PORT_DNS"},{"line_number":98,"context_line":"master\u003dno"},{"line_number":99,"context_line":"slave\u003dyes"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"33a938b0_b551587a","line":96,"updated":"2022-10-23 12:07:41.000000000","message":"Why is this commented out? Binding to all IPs may be dangerous.","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"756c25124ff217fd2adf904775acbc62e4febf40","unresolved":true,"context_lines":[{"line_number":93,"context_line":"guardian\u003dyes"},{"line_number":94,"context_line":"daemon\u003dyes"},{"line_number":95,"context_line":"disable-axfr\u003dno"},{"line_number":96,"context_line":"# local-address\u003d$HOST_IP $HOST_IPV6"},{"line_number":97,"context_line":"local-port\u003d$DESIGNATE_SERVICE_PORT_DNS"},{"line_number":98,"context_line":"master\u003dno"},{"line_number":99,"context_line":"slave\u003dyes"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"c5c3e02b_ea9f54c0","line":96,"in_reply_to":"33a938b0_b551587a","updated":"2022-10-23 16:26:59.000000000","message":"The problem here is that the way we did it before, and the way it is done in 22.04 are both incompatible, so we would need to check if we are on PDNS 4.3 or 4.5 and use different styles.\nhttps://github.com/PowerDNS/pdns/pull/10251/files\n\nWe could also just only support 22.04 in our CI, but this would support both 20.04 and 22.04.","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e8475d392b983358d7f2407c9ce8bbf9811327bc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"guardian\u003dyes"},{"line_number":94,"context_line":"daemon\u003dyes"},{"line_number":95,"context_line":"disable-axfr\u003dno"},{"line_number":96,"context_line":"# local-address\u003d$HOST_IP $HOST_IPV6"},{"line_number":97,"context_line":"local-port\u003d$DESIGNATE_SERVICE_PORT_DNS"},{"line_number":98,"context_line":"master\u003dno"},{"line_number":99,"context_line":"slave\u003dyes"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"7fbc3e0c_c4fee799","line":96,"in_reply_to":"c5c3e02b_ea9f54c0","updated":"2022-10-25 07:32:40.000000000","message":"Making the address configuration dynamic based on which host we are running on would be better, but I\u0027m fine with this as a workaround for now.","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1f41edde62d0097cc2acb92034fae9687f5d7f9e","unresolved":true,"context_lines":[{"line_number":136,"context_line":"    fi"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    # Wait for the pdns4 schema to be created."},{"line_number":139,"context_line":"    stop_designate_backend"},{"line_number":140,"context_line":"}"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# init_designate_backend - initialize databases, etc."}],"source_content_type":"application/octet-stream","patch_set":16,"id":"f86386af_79933d2c","line":139,"updated":"2022-10-23 12:07:41.000000000","message":"Do we really need to do this once more if it was already done during the install phase?","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e8475d392b983358d7f2407c9ce8bbf9811327bc","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    fi"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    # Wait for the pdns4 schema to be created."},{"line_number":139,"context_line":"    stop_designate_backend"},{"line_number":140,"context_line":"}"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# init_designate_backend - initialize databases, etc."}],"source_content_type":"application/octet-stream","patch_set":16,"id":"b3154c86_c411d445","line":139,"in_reply_to":"bc8738ff_bd353dfe","updated":"2022-10-25 07:32:40.000000000","message":"Ack","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"756c25124ff217fd2adf904775acbc62e4febf40","unresolved":true,"context_lines":[{"line_number":136,"context_line":"    fi"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    # Wait for the pdns4 schema to be created."},{"line_number":139,"context_line":"    stop_designate_backend"},{"line_number":140,"context_line":"}"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# init_designate_backend - initialize databases, etc."}],"source_content_type":"application/octet-stream","patch_set":16,"id":"bc8738ff_bd353dfe","line":139,"in_reply_to":"f86386af_79933d2c","updated":"2022-10-23 16:26:59.000000000","message":"We might not need this one. For context, we were getting hundreds of logs of spam before these were added.","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"}],"devstack/designate_plugins/backend-pdns4-mysql-db.sql":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1f41edde62d0097cc2acb92034fae9687f5d7f9e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  notified_serial       INT UNSIGNED DEFAULT NULL,"},{"line_number":8,"context_line":"  account               VARCHAR(40) CHARACTER SET \u0027utf8\u0027 DEFAULT NULL,"},{"line_number":9,"context_line":"  options               TEXT DEFAULT NULL,"},{"line_number":10,"context_line":"  catalog               VARCHAR(255) DEFAULT NULL,"},{"line_number":11,"context_line":"  PRIMARY KEY (id)"},{"line_number":12,"context_line":") Engine\u003dInnoDB;"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-sql","patch_set":16,"id":"929f2f73_a4e183c3","line":10,"updated":"2022-10-23 12:07:41.000000000","message":"Where did you get these updates from? Does is make sense to add a reference somewhere so that we can get back to it for the next update?","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ac044c23ee674f7b652ce964cdeea7cfabf8c6b3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  notified_serial       INT UNSIGNED DEFAULT NULL,"},{"line_number":8,"context_line":"  account               VARCHAR(40) CHARACTER SET \u0027utf8\u0027 DEFAULT NULL,"},{"line_number":9,"context_line":"  options               TEXT DEFAULT NULL,"},{"line_number":10,"context_line":"  catalog               VARCHAR(255) DEFAULT NULL,"},{"line_number":11,"context_line":"  PRIMARY KEY (id)"},{"line_number":12,"context_line":") Engine\u003dInnoDB;"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-sql","patch_set":16,"id":"87d6f38d_ebc38809","line":10,"in_reply_to":"19ec3bfc_2d19c8e1","updated":"2022-10-24 03:07:54.000000000","message":"Done","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"5079aa9136274b4b5ca0158e4e0a7c3d0a577b63","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  notified_serial       INT UNSIGNED DEFAULT NULL,"},{"line_number":8,"context_line":"  account               VARCHAR(40) CHARACTER SET \u0027utf8\u0027 DEFAULT NULL,"},{"line_number":9,"context_line":"  options               TEXT DEFAULT NULL,"},{"line_number":10,"context_line":"  catalog               VARCHAR(255) DEFAULT NULL,"},{"line_number":11,"context_line":"  PRIMARY KEY (id)"},{"line_number":12,"context_line":") Engine\u003dInnoDB;"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-sql","patch_set":16,"id":"19ec3bfc_2d19c8e1","line":10,"in_reply_to":"39201f05_a721cf0e","updated":"2022-10-23 16:47:00.000000000","message":"https://docs.powerdns.com/authoritative/backends/generic-mysql.html","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"4595d5cf917cb9d72e27573df77d5c2c6fd7bacd","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  notified_serial       INT UNSIGNED DEFAULT NULL,"},{"line_number":8,"context_line":"  account               VARCHAR(40) CHARACTER SET \u0027utf8\u0027 DEFAULT NULL,"},{"line_number":9,"context_line":"  options               TEXT DEFAULT NULL,"},{"line_number":10,"context_line":"  catalog               VARCHAR(255) DEFAULT NULL,"},{"line_number":11,"context_line":"  PRIMARY KEY (id)"},{"line_number":12,"context_line":") Engine\u003dInnoDB;"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-sql","patch_set":16,"id":"39201f05_a721cf0e","line":10,"in_reply_to":"641d1c9d_e78839da","updated":"2022-10-23 16:39:20.000000000","message":"Having that said had to modify it slightly as it did not work out of the box on our version of MySQL.","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e5a181e28f0ebfcfdee875aa03079ac020a74d04","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  notified_serial       INT UNSIGNED DEFAULT NULL,"},{"line_number":8,"context_line":"  account               VARCHAR(40) CHARACTER SET \u0027utf8\u0027 DEFAULT NULL,"},{"line_number":9,"context_line":"  options               TEXT DEFAULT NULL,"},{"line_number":10,"context_line":"  catalog               VARCHAR(255) DEFAULT NULL,"},{"line_number":11,"context_line":"  PRIMARY KEY (id)"},{"line_number":12,"context_line":") Engine\u003dInnoDB;"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-sql","patch_set":16,"id":"641d1c9d_e78839da","line":10,"in_reply_to":"929f2f73_a4e183c3","updated":"2022-10-23 16:27:19.000000000","message":"These are taken directly from the pdns4 documentation.","commit_id":"27e84ecbc66f38510aa43ca292785f62362397de"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e8475d392b983358d7f2407c9ce8bbf9811327bc","unresolved":true,"context_lines":[{"line_number":94,"context_line":"  PRIMARY KEY (id)"},{"line_number":95,"context_line":") Engine\u003dInnoDB;"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"CREATE UNIQUE INDEX namealgoindex ON tsigkeys(name, algorithm);"}],"source_content_type":"text/x-sql","patch_set":19,"id":"bcf752ab_7db02535","line":97,"updated":"2022-10-25 07:32:40.000000000","message":"Nit: missing newline at the end of the file","commit_id":"0b162a4c48ff7806ee0dda0f871a884a32374ed9"}]}