)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ea808c081ec6b0d5e442c5bdff19104b9d2fbde1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"596e755a_57cbe875","updated":"2023-02-07 22:49:30.000000000","message":"I can\u0027t reproduce this. Do you have a set of steps to reproduce the traceback?\n\nI can see there may be an issue here:\nhttps://github.com/openstack/designate/blob/master/designate/storage/impl_sqlalchemy/__init__.py#L373\nhttps://github.com/openstack/designate/blob/master/designate/storage/impl_sqlalchemy/__init__.py#L377\n\nWhere maybe the master is both in the remove and update list. I\u0027m just not sure how to trigger that.","commit_id":"b707dd53708331cb41792f04f76428975c0da631"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"80208cd6032609bf8b5fc4d89633a73e6321a332","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cf5ec5e1_5da641f5","updated":"2023-02-07 19:52:16.000000000","message":"My initial concern here is that this adds an extra DB round trip for a lot of calls.","commit_id":"b707dd53708331cb41792f04f76428975c0da631"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"5da087091f9b12d7f9f5ee612d40a738e0696885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dda67da8_5134d686","updated":"2022-12-12 09:52:50.000000000","message":"The CI failure is about \u0027venv: failed with tempest is not allowed, use allowlist_externals to allow it\u0027, it was fixed at Dec 09 6:42 by the patch https://review.opendev.org/c/openstack/devstack/+/867066/ , while my last build failure is at Dec 09 6:42, so I will trigger re-check again","commit_id":"b707dd53708331cb41792f04f76428975c0da631"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"369ce8c8007fac81c2b5aa02d3a3b1f47ceed64a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8243019d_305c0bb1","updated":"2022-12-12 09:53:07.000000000","message":"recheck","commit_id":"b707dd53708331cb41792f04f76428975c0da631"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"414748a49cb089183185e93e3e0b13d6b23b9b29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9c2abef4_2a913593","updated":"2022-12-09 09:24:27.000000000","message":"recheck","commit_id":"b707dd53708331cb41792f04f76428975c0da631"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"93d718a549488e6002227374eeaa6db8aac5bd3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a951040e_466b7332","in_reply_to":"596e755a_57cbe875","updated":"2023-02-14 04:16:08.000000000","message":"hey Erik and Michael, I will drop this patch according to the comment[1], thank you very much for your review.\n\n[1] https://bugs.launchpad.net/designate/+bug/1995918/comments/6","commit_id":"b707dd53708331cb41792f04f76428975c0da631"}],"designate/storage/impl_sqlalchemy/__init__.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ea808c081ec6b0d5e442c5bdff19104b9d2fbde1","unresolved":true,"context_lines":[{"line_number":223,"context_line":"            sort_key, sort_dir)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        def _load_relations(zone):"},{"line_number":226,"context_line":"            zone.masters \u003d self._find_zone_masters("},{"line_number":227,"context_line":"                context, {\u0027zone_id\u0027: zone.id})"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            zone.attributes \u003d self._find_zone_attributes("}],"source_content_type":"text/x-python","patch_set":1,"id":"7ee966fb_a4256e7c","line":226,"updated":"2023-02-07 22:49:30.000000000","message":"I don\u0027t understand this change. We don\u0027t store zone masters for \"PRIMARY\" zones in the DB zone_masters table. They are always going to be the mini-DNS instances, so tracked via the pools.yaml data.\n\nLooking through the","commit_id":"b707dd53708331cb41792f04f76428975c0da631"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"93d718a549488e6002227374eeaa6db8aac5bd3e","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            sort_key, sort_dir)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        def _load_relations(zone):"},{"line_number":226,"context_line":"            zone.masters \u003d self._find_zone_masters("},{"line_number":227,"context_line":"                context, {\u0027zone_id\u0027: zone.id})"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            zone.attributes \u003d self._find_zone_attributes("}],"source_content_type":"text/x-python","patch_set":1,"id":"8825cb33_68f1acc8","line":226,"in_reply_to":"7ee966fb_a4256e7c","updated":"2023-02-14 04:16:08.000000000","message":"hey Erik and Michael, I will drop this patch according to the comment[1], thank you very much for your review.\n\n[1] https://bugs.launchpad.net/designate/+bug/1995918/comments/6","commit_id":"b707dd53708331cb41792f04f76428975c0da631"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a133094727dcea931ec0c64efa74ded1b559ce46","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            sort_key, sort_dir)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        def _load_relations(zone):"},{"line_number":226,"context_line":"            zone.masters \u003d self._find_zone_masters("},{"line_number":227,"context_line":"                context, {\u0027zone_id\u0027: zone.id})"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            zone.attributes \u003d self._find_zone_attributes("}],"source_content_type":"text/x-python","patch_set":1,"id":"2461735d_a4b7941d","line":226,"in_reply_to":"8825cb33_68f1acc8","updated":"2023-02-14 05:44:23.000000000","message":"Thanks for the update!","commit_id":"b707dd53708331cb41792f04f76428975c0da631"}]}