)]}'
{"designate/api/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"e999e486525d0988b0ee1359418885588a50d73f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    cfg.IntOpt(\u0027workers\u0027, default\u003dNone,"},{"line_number":25,"context_line":"               help\u003d\u0027Number of API worker processes to spawn\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027api-base-uri\u0027, default\u003d\u0027http://127.0.0.1:9001/\u0027),"},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027api_host\u0027, default\u003d\u00270.0.0.0\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027API Host\u0027),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027api_port\u0027, default\u003d9001,"},{"line_number":30,"context_line":"               help\u003d\u0027API Port Number\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F3Rg%3D","line":27,"updated":"2014-04-16 20:43:54.000000000","message":"Should it be api-host or api_host here?  i.e. should the name here have a hyphen or an underscore.  Similarly for other options below and in other files","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"19a8596b7fd6aa07bae3ff256ec41e7d04a37899","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    cfg.IntOpt(\u0027workers\u0027, default\u003dNone,"},{"line_number":25,"context_line":"               help\u003d\u0027Number of API worker processes to spawn\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027api-base-uri\u0027, default\u003d\u0027http://127.0.0.1:9001/\u0027),"},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027api_host\u0027, default\u003d\u00270.0.0.0\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027API Host\u0027),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027api_port\u0027, default\u003d9001,"},{"line_number":30,"context_line":"               help\u003d\u0027API Port Number\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FWhA%3D","line":27,"in_reply_to":"AAAAXH%2F%2F3Rg%3D","updated":"2014-04-22 11:21:27.000000000","message":"I tend to do \"-\" rather than \"_\" in config options, so args passed via the CLI \"look right\".. But, I\u0027ve intentionally avoided changing anything that wasn\u0027t directly related to generating the sample config file here..\n\nAdd the \"API\" into the workers argument description was actually intentional, as it allowed the generator to tell the difference between the central/api/agent worker config options.","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"}],"designate/backend/impl_nsd4slave.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"e999e486525d0988b0ee1359418885588a50d73f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.ListOpt(\u0027servers\u0027,"},{"line_number":42,"context_line":"                help\u003d\u0027Comma-separated list of servers to control, in \u0027"},{"line_number":43,"context_line":"                     \u0027 \u003chost\u003e:\u003cport\u003e format. If \u003cport\u003e is omitted, \u0027"},{"line_number":44,"context_line":"                     \u0027 the default 8952 is used.\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027pattern\u0027, default\u003d\u0027slave\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Pattern to use when creating zones on the NSD4 servers. \u0027"},{"line_number":47,"context_line":"                    \u0027This pattern must be identically configured on all NSD4 \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F3ac%3D","line":44,"updated":"2014-04-16 20:43:54.000000000","message":"The default for other list options elsewhere is [].  Here it defaults to None.  Does it make sense to have the same defaults as elsewhere here?","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"19a8596b7fd6aa07bae3ff256ec41e7d04a37899","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.ListOpt(\u0027servers\u0027,"},{"line_number":42,"context_line":"                help\u003d\u0027Comma-separated list of servers to control, in \u0027"},{"line_number":43,"context_line":"                     \u0027 \u003chost\u003e:\u003cport\u003e format. If \u003cport\u003e is omitted, \u0027"},{"line_number":44,"context_line":"                     \u0027 the default 8952 is used.\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027pattern\u0027, default\u003d\u0027slave\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Pattern to use when creating zones on the NSD4 servers. \u0027"},{"line_number":47,"context_line":"                    \u0027This pattern must be identically configured on all NSD4 \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FWgs%3D","line":44,"in_reply_to":"AAAAXH%2F%2F3ac%3D","updated":"2014-04-22 11:21:27.000000000","message":"See my other comment, I\u0027ve intentionally changed as little as possible in this commit.","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"5fc5223f726e8eabe1106c91f397c5f7148d465b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.ListOpt(\u0027servers\u0027,"},{"line_number":42,"context_line":"                help\u003d\u0027Comma-separated list of servers to control, in \u0027"},{"line_number":43,"context_line":"                     \u0027 \u003chost\u003e:\u003cport\u003e format. If \u003cport\u003e is omitted, \u0027"},{"line_number":44,"context_line":"                     \u0027 the default 8952 is used.\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027pattern\u0027, default\u003d\u0027slave\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Pattern to use when creating zones on the NSD4 servers. \u0027"},{"line_number":47,"context_line":"                    \u0027This pattern must be identically configured on all NSD4 \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_b4cb2449","line":44,"in_reply_to":"AAAAXH%2F%2F3ac%3D","updated":"2014-06-10 12:36:58.000000000","message":"The change Kiall is doing should be as non-invasive to existing options as possible so this is right","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"}],"designate/central/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"e999e486525d0988b0ee1359418885588a50d73f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.IntOpt(\u0027max_recordset_name_len\u0027, default\u003d255,"},{"line_number":34,"context_line":"               help\u003d\"Maximum recordset name length\","},{"line_number":35,"context_line":"               deprecated_name\u003d\u0027max_record_name_len\u0027),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027managed_resource_email\u0027, default\u003d\u0027email@example.io\u0027,"},{"line_number":37,"context_line":"               help\u003d\u0027E-Mail for Managed resources\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027managed_resource_tenant_id\u0027,"},{"line_number":39,"context_line":"               help\u003d\"The Tenant ID that will own any managed resources.\"),"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F3UA%3D","line":36,"updated":"2014-04-16 20:43:54.000000000","message":"Is this a valid default or should it be None?","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"19a8596b7fd6aa07bae3ff256ec41e7d04a37899","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.IntOpt(\u0027max_recordset_name_len\u0027, default\u003d255,"},{"line_number":34,"context_line":"               help\u003d\"Maximum recordset name length\","},{"line_number":35,"context_line":"               deprecated_name\u003d\u0027max_record_name_len\u0027),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027managed_resource_email\u0027, default\u003d\u0027email@example.io\u0027,"},{"line_number":37,"context_line":"               help\u003d\u0027E-Mail for Managed resources\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027managed_resource_tenant_id\u0027,"},{"line_number":39,"context_line":"               help\u003d\"The Tenant ID that will own any managed resources.\"),"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FWfE%3D","line":36,"in_reply_to":"AAAAXH%2F%2F3UA%3D","updated":"2014-04-22 11:21:27.000000000","message":"See my other comment, I\u0027ve only changed what\u0027s absolutely necessary for config generation to work.","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"e999e486525d0988b0ee1359418885588a50d73f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027E-Mail for Managed resources\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027managed_resource_tenant_id\u0027,"},{"line_number":39,"context_line":"               help\u003d\"The Tenant ID that will own any managed resources.\"),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027min_ttl\u0027, default\u003d\"None\", help\u003d\"Minimum TTL allowed\")"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\u0027service:central\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F3Vw%3D","line":40,"updated":"2014-04-16 20:43:54.000000000","message":"min_ttl goes to the [DEFAULT] group and not to [service:central].  Also the default for other string options is None and not \"None\" -i.e. there are no quotes around None.","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"19a8596b7fd6aa07bae3ff256ec41e7d04a37899","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027E-Mail for Managed resources\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027managed_resource_tenant_id\u0027,"},{"line_number":39,"context_line":"               help\u003d\"The Tenant ID that will own any managed resources.\"),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027min_ttl\u0027, default\u003d\"None\", help\u003d\"Minimum TTL allowed\")"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\u0027service:central\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FWfU%3D","line":40,"in_reply_to":"AAAAXH%2F%2F3Vw%3D","updated":"2014-04-22 11:21:27.000000000","message":"Looks like a bug in the config generator.. Ugh -_-","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"f3702a2d48ee18e6f78ac6fd01f8c45b3b1ddad0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027E-Mail for Managed resources\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027managed_resource_tenant_id\u0027,"},{"line_number":39,"context_line":"               help\u003d\"The Tenant ID that will own any managed resources.\"),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027min_ttl\u0027, default\u003d\"None\", help\u003d\"Minimum TTL allowed\")"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\u0027service:central\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXX%2F%2Fz48%3D","line":40,"in_reply_to":"AAAAXH%2F%2FNm4%3D","updated":"2014-04-26 09:43:11.000000000","message":"I\u0027ve been using `tox -e genconfig` - could you try that and see where min_ttl lands?","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"b13903061255a7a6f5339df32169e29c9800f2fd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027E-Mail for Managed resources\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027managed_resource_tenant_id\u0027,"},{"line_number":39,"context_line":"               help\u003d\"The Tenant ID that will own any managed resources.\"),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027min_ttl\u0027, default\u003d\"None\", help\u003d\"Minimum TTL allowed\")"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\u0027service:central\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FNm4%3D","line":40,"in_reply_to":"AAAAXH%2F%2FWfU%3D","updated":"2014-04-23 09:42:29.000000000","message":"Kiall, when I ran the config generator now(without any options), I actually see min_ttl go to [service:central] section.  I am not sure what is different in my environment.  The sections too are in a different order.  The sample that I generated is at http://pastebin.com/KPWjCxVy","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"5fc5223f726e8eabe1106c91f397c5f7148d465b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027E-Mail for Managed resources\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027managed_resource_tenant_id\u0027,"},{"line_number":39,"context_line":"               help\u003d\"The Tenant ID that will own any managed resources.\"),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027min_ttl\u0027, default\u003d\"None\", help\u003d\"Minimum TTL allowed\")"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\u0027service:central\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_1703f00d","line":40,"in_reply_to":"AAAAXX%2F%2Fs6k%3D","updated":"2014-06-10 12:36:58.000000000","message":"I see that min_ttl goes to service:central and works fine as it should?","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"5999219c8eec1fa483fd0a4ea6125f387d108975","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027E-Mail for Managed resources\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027managed_resource_tenant_id\u0027,"},{"line_number":39,"context_line":"               help\u003d\"The Tenant ID that will own any managed resources.\"),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027min_ttl\u0027, default\u003d\"None\", help\u003d\"Minimum TTL allowed\")"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\u0027service:central\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXX%2F%2Fs6k%3D","line":40,"in_reply_to":"AAAAXX%2F%2Fz48%3D","updated":"2014-04-28 15:30:14.000000000","message":"I still see the same behavior, I saw earlier.  min_ttl goes to [service:central].  New file at http://pastebin.com/5tmtCVBu","commit_id":"2998ec407736a616f64362f4a996b3b7bea01143"}],"designate/sqlalchemy/session.py":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"ec26913b7bd74773c8bfa8dd6e4fb80a2b49f1f0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    generator, we hide them inside a function."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    postfix is used to ensure the config option is \"different\" for each"},{"line_number":43,"context_line":"    compontent making use of them, allowing the config generation to detect"},{"line_number":44,"context_line":"    the option is used multiple times."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    return ["}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAW3%2F%2FPCY%3D","line":43,"updated":"2014-04-15 21:34:53.000000000","message":"compontent -\u003e component","commit_id":"d0af0abeb73d4e0bc9435ca7c9ce22bedc1cf850"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a4ea7a223373dfb303e4864ffe34525c91bde27d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    generator, we hide them inside a function."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    postfix is used to ensure the config option is \"different\" for each"},{"line_number":43,"context_line":"    compontent making use of them, allowing the config generation to detect"},{"line_number":44,"context_line":"    the option is used multiple times."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    return ["}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXH%2F%2F75U%3D","line":43,"in_reply_to":"AAAAW3%2F%2FPCY%3D","updated":"2014-04-16 12:04:52.000000000","message":"Done","commit_id":"d0af0abeb73d4e0bc9435ca7c9ce22bedc1cf850"}],"etc/designate/designate.conf.sample":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"19127dc8f693a533fc0cacdc66a82c627069c818","unresolved":false,"context_lines":[{"line_number":968,"context_line":"#"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"# Number of worker processes to spawn (integer value)"},{"line_number":971,"context_line":"#workers\u003d\u003cNone\u003e"},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"# The backend driver to use (string value)"},{"line_number":974,"context_line":"#backend_driver\u003dfake"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAW3%2F%2FZ%2F8%3D","line":971,"updated":"2014-04-14 19:43:41.000000000","message":"In this case, both the central AND api\u0027s workers values got placed here... Grr.","commit_id":"4ab24390465fd2b184586801cb48c092b55b1eb8"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"90e3d1c49d1a7adf9b50796d39428e24fdf90e16","unresolved":false,"context_lines":[{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"[service:sink]"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":1073,"context_line":"#-----------------------"},{"line_number":1074,"context_line":"# mDNS Service"},{"line_number":1075,"context_line":"#-----------------------"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1ae5cdf2_772514c1","line":1072,"updated":"2014-06-10 13:00:25.000000000","message":"Whoops","commit_id":"a94abfc445bd7d0800ed37801fcb9902281000cd"}],"tox.ini":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d2c7d4c49275b99d80e26d4860dda3c980915665","unresolved":false,"context_lines":[{"line_number":29,"context_line":"sitepackages \u003d False"},{"line_number":30,"context_line":"commands \u003d"},{"line_number":31,"context_line":"  bash tools/config/generate_sample.sh -b . -p designate -o etc/designate -l oslo.messaging"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[testenv:venv]"},{"line_number":34,"context_line":"commands \u003d {posargs}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAW3%2F%2Fpag%3D","line":32,"updated":"2014-04-11 12:48:27.000000000","message":"Should there not be a \u0027[testenv:checkconfiguptodate]\u0027 check as well?","commit_id":"3da2f98ba236ba415022e04acdf9bd39e55b3fb1"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"3207defa69365862a18f3464caf765491329b25e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"sitepackages \u003d False"},{"line_number":30,"context_line":"commands \u003d"},{"line_number":31,"context_line":"  bash tools/config/generate_sample.sh -b . -p designate -o etc/designate -l oslo.messaging"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[testenv:venv]"},{"line_number":34,"context_line":"commands \u003d {posargs}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAW3%2F%2FpD0%3D","line":32,"in_reply_to":"AAAAW3%2F%2Fpag%3D","updated":"2014-04-11 13:29:20.000000000","message":"No clue ;) None of the other projects use that, so I\u0027m still trying to figure out how/if they gate on the sample config being up to date","commit_id":"3da2f98ba236ba415022e04acdf9bd39e55b3fb1"}]}