)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f0ab7cfdbfb61350bf437b8de598309d7a51b57f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"18d24928_da60b0d8","updated":"2023-02-16 17:28:30.000000000","message":"I\u0027m surprised that there isn\u0027t a general hacking rule for this yet, I like the idea except in one situation commented below.","commit_id":"ddf723d343ae64ead886ab3f10be5207625be80f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"817a35a9e21c19587ac52b8df6cf14813da986d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f49a2d87_02007f30","updated":"2023-02-20 21:31:20.000000000","message":"LGTM","commit_id":"af40125191cca55f23a9882e0e1782323c2a732d"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"7d9cb1d348ae2c7a38d2d01380bfe813c1638ba5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"70f0e19a_283e048f","updated":"2023-02-20 22:03:47.000000000","message":"LGTM - thanks for getting rid the \u0027\\\u0027 continuation.\nLooks to be all of them:\nstack@ospr1-069 python-designateclient] (master) \u003e grep -r \u0027\\\\\u0027 * |grep -v \u0027\\\\n\u0027|grep -v \u0027\\\\.\u0027\nBinary file designateclient/__pycache__/utils.cpython-38.pyc matches\nBinary file designateclient/__pycache__/client.cpython-38.pyc matches\nBinary file designateclient/tests/osc/v2/__pycache__/test_recordsets.cpython-38.pyc matches\nBinary file designateclient/tests/osc/v2/__pycache__/test_zone.cpython-38.pyc matches\nBinary file designateclient/tests/__pycache__/base.cpython-38.pyc matches\nBinary file designateclient/tests/v2/__pycache__/test_timeout.cpython-38.pyc matches\nBinary file designateclient/tests/v2/__pycache__/test_zones.cpython-38.pyc matches\nBinary file designateclient/tests/v2/__pycache__/__init__.cpython-38.pyc matches\nBinary file designateclient/v2/__pycache__/utils.cpython-38.pyc matches\nBinary file designateclient/v2/__pycache__/client.cpython-38.pyc matches\nBinary file designateclient/v2/__pycache__/zones.cpython-38.pyc matches\nBinary file designateclient/v2/__pycache__/base.cpython-38.pyc matches\nBinary file designateclient/v2/__pycache__/recordsets.cpython-38.pyc matches\nBinary file designateclient/v2/cli/__pycache__/zones.cpython-38.pyc matches\nBinary file designateclient/v2/cli/__pycache__/recordsets.cpython-38.pyc matches\n[stack@ospr1-069 python-designateclient] (master) \u003e","commit_id":"af40125191cca55f23a9882e0e1782323c2a732d"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"9406124308cd8f078d187692b5a6a1117aa3066d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"233c106c_2b0bb864","updated":"2023-02-20 22:31:03.000000000","message":"LGTM:\nLGTM - thanks for getting rid the \u0027\\\u0027 continuation.\nLooks to be all of them:\ngrep -r \u0027\\\\\u0027 *|grep -v \u0027\\\\*\u0027|grep -v -E \"releasenotes|doc|tox|test|devstack\"|grep -v \u0027\\\\\\\\\u0027\n","commit_id":"af40125191cca55f23a9882e0e1782323c2a732d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"bfc19c209736682a18ea720c99fb845b0681fb26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5140fa5d_e0caab44","updated":"2023-02-21 03:47:57.000000000","message":"recheck DesignatePtrRecord","commit_id":"af40125191cca55f23a9882e0e1782323c2a732d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"24a9e661efd03e17ce6b4beb47ed9acebef93af4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"be714333_9c5b723d","updated":"2023-02-21 19:45:24.000000000","message":"recheck DesignatePtrRecord","commit_id":"af40125191cca55f23a9882e0e1782323c2a732d"}],"designate/tests/unit/test_central/test_basic.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f0ab7cfdbfb61350bf437b8de598309d7a51b57f","unresolved":true,"context_lines":[{"line_number":617,"context_line":"    def test_is_valid_recordset_name_too_long(self):"},{"line_number":618,"context_line":"        zone \u003d RoObject(name\u003d\u0027example.org.\u0027)"},{"line_number":619,"context_line":"        designate.central.service.cfg.CONF["},{"line_number":620,"context_line":"            \u0027service:central\u0027].max_recordset_name_len \u003d 255"},{"line_number":621,"context_line":"        rs_name \u003d \u0027a\u0027 * 255 + \u0027.org.\u0027"},{"line_number":622,"context_line":"        with testtools.ExpectedException(exceptions.InvalidRecordSetName) as e:"},{"line_number":623,"context_line":"            self.service._is_valid_recordset_name(self.context, zone, rs_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b7128e5_49db7f94","line":620,"updated":"2023-02-16 17:28:30.000000000","message":"This one looks really ugly to my python brain, but I don\u0027t see a good way to solve it, maybe someone else has an idea?","commit_id":"ddf723d343ae64ead886ab3f10be5207625be80f"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"9a96df498cd59f6f116ca1e9908fc80980b3cfb4","unresolved":false,"context_lines":[{"line_number":617,"context_line":"    def test_is_valid_recordset_name_too_long(self):"},{"line_number":618,"context_line":"        zone \u003d RoObject(name\u003d\u0027example.org.\u0027)"},{"line_number":619,"context_line":"        designate.central.service.cfg.CONF["},{"line_number":620,"context_line":"            \u0027service:central\u0027].max_recordset_name_len \u003d 255"},{"line_number":621,"context_line":"        rs_name \u003d \u0027a\u0027 * 255 + \u0027.org.\u0027"},{"line_number":622,"context_line":"        with testtools.ExpectedException(exceptions.InvalidRecordSetName) as e:"},{"line_number":623,"context_line":"            self.service._is_valid_recordset_name(self.context, zone, rs_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9844d947_379a8c9d","line":620,"in_reply_to":"4b7128e5_49db7f94","updated":"2023-02-16 17:40:09.000000000","message":"I really wanted to fix those, but skipped over it as I was just rebasing, but is an easy fix.","commit_id":"ddf723d343ae64ead886ab3f10be5207625be80f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"23f8d7e28d9e38e5a08e2c2cfbc9edc0ac64517d","unresolved":false,"context_lines":[{"line_number":617,"context_line":"    def test_is_valid_recordset_name_too_long(self):"},{"line_number":618,"context_line":"        zone \u003d RoObject(name\u003d\u0027example.org.\u0027)"},{"line_number":619,"context_line":"        designate.central.service.cfg.CONF["},{"line_number":620,"context_line":"            \u0027service:central\u0027].max_recordset_name_len \u003d 255"},{"line_number":621,"context_line":"        rs_name \u003d \u0027a\u0027 * 255 + \u0027.org.\u0027"},{"line_number":622,"context_line":"        with testtools.ExpectedException(exceptions.InvalidRecordSetName) as e:"},{"line_number":623,"context_line":"            self.service._is_valid_recordset_name(self.context, zone, rs_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c8453c1_8137d7b1","line":620,"in_reply_to":"9844d947_379a8c9d","updated":"2023-02-16 17:58:24.000000000","message":"I wasn\u0027t sure whether designate.central.service.cfg would really be the same object as oslo_config.cfg, but if this works then this is much better.","commit_id":"ddf723d343ae64ead886ab3f10be5207625be80f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"23f8d7e28d9e38e5a08e2c2cfbc9edc0ac64517d","unresolved":true,"context_lines":[{"line_number":32,"context_line":"from designate.tests.fixtures import random_seed"},{"line_number":33,"context_line":"from designate.tests import TestCase"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CONF \u003d cfg.CONF"},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"12fd24f9_6c2c5c39","line":35,"updated":"2023-02-16 17:58:24.000000000","message":"Seems you don\u0027t really need this since you still reference cfg.CONF below?","commit_id":"d3a4bc7209e542ee2d2060e44cbef8776c58ff24"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"37289a4c23899f0d04afb6ddfd27e04fa3919049","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from designate.tests.fixtures import random_seed"},{"line_number":33,"context_line":"from designate.tests import TestCase"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CONF \u003d cfg.CONF"},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a23b66a1_265738e5","line":35,"in_reply_to":"12fd24f9_6c2c5c39","updated":"2023-02-16 18:49:31.000000000","message":"Ack","commit_id":"d3a4bc7209e542ee2d2060e44cbef8776c58ff24"}]}