)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"0ed5b6a0d17bf2383b5d58002c9dc40f7ba3906e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"496f94fc_cc254283","updated":"2023-04-18 15:02:08.000000000","message":"LGTM - does simplfy the query a bit.","commit_id":"3c505fafd11f95a79ecfc75eb7e98b5d4437a5d4"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"d80e75daf1d961c90f5300fef147ca798af9eccf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ca5f6409_e0ec9a78","updated":"2023-05-07 02:13:27.000000000","message":"recheck increment serial","commit_id":"7b08880d4e6c49c3a28f0a5ccd75fa37c70ea5ef"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1d5361949ed36583a50b502a29dd02ac7c6ce816","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f794949f_ffc047aa","updated":"2023-05-22 20:36:54.000000000","message":"LGTM\nSome minor nits about the doc strings, but not important enough for a new spin IMO","commit_id":"0c30fc491b0012da13a562c9107f4451790607dd"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"f97b482fc8210bd8df6f0e985e06a9a5af16d6e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d65151ae_4d368e96","updated":"2023-05-23 14:32:16.000000000","message":"LGTM - I agree with @johnsom that there are some nits that can be addressed in another smaller patch, please.","commit_id":"0c30fc491b0012da13a562c9107f4451790607dd"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"8f9f562f706fd9d5f61371e74f5bafee3b6d3c34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"597831f3_c63ddef7","in_reply_to":"d65151ae_4d368e96","updated":"2023-05-23 16:27:05.000000000","message":"Thanks! Yep fully agree. All these should be fixed in a follow up patch, but all of these were here before this patch.","commit_id":"0c30fc491b0012da13a562c9107f4451790607dd"}],"designate/storage/sqlalchemy/__init__.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1d5361949ed36583a50b502a29dd02ac7c6ce816","unresolved":true,"context_lines":[{"line_number":125,"context_line":"        Delete a Quota via ID."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        :param context: RPC Context."},{"line_number":128,"context_line":"        :param quota_id: Delete a Quota via ID"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        # Fetch the existing quota, we\u0027ll need to return it."},{"line_number":131,"context_line":"        quota \u003d self._find_quotas(context, {\u0027id\u0027: quota_id}, one\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9d90150f_7ac42034","line":128,"range":{"start_line":128,"start_character":25,"end_line":128,"end_character":46},"updated":"2023-05-22 20:36:54.000000000","message":"nit: Maybe: The ID of the quota to delete","commit_id":"0c30fc491b0012da13a562c9107f4451790607dd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1d5361949ed36583a50b502a29dd02ac7c6ce816","unresolved":true,"context_lines":[{"line_number":201,"context_line":"        Delete a TLD via ID."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        :param context: RPC Context."},{"line_number":204,"context_line":"        :param tld_id: Delete a TLD via ID"},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        # Fetch the existing tld, we\u0027ll need to return it."},{"line_number":207,"context_line":"        tld \u003d self._find_tlds(context, {\u0027id\u0027: tld_id}, one\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ccb48903_70c174e4","line":204,"range":{"start_line":204,"start_character":23,"end_line":204,"end_character":42},"updated":"2023-05-22 20:36:54.000000000","message":"Same nit here","commit_id":"0c30fc491b0012da13a562c9107f4451790607dd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1d5361949ed36583a50b502a29dd02ac7c6ce816","unresolved":true,"context_lines":[{"line_number":277,"context_line":"        Delete a TSIG Key via ID."},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        :param context: RPC Context."},{"line_number":280,"context_line":"        :param tsigkey_id: Delete a TSIG Key via ID"},{"line_number":281,"context_line":"        \"\"\""},{"line_number":282,"context_line":"        # Fetch the existing tsigkey, we\u0027ll need to return it."},{"line_number":283,"context_line":"        tsigkey \u003d self._find_tsigkeys(context, {\u0027id\u0027: tsigkey_id}, one\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"2c3132e5_b0667960","line":280,"range":{"start_line":280,"start_character":27,"end_line":280,"end_character":51},"updated":"2023-05-22 20:36:54.000000000","message":"Same nit","commit_id":"0c30fc491b0012da13a562c9107f4451790607dd"}],"designate/storage/sqlalchemy/base.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1d5361949ed36583a50b502a29dd02ac7c6ce816","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    # RS Info"},{"line_number":37,"context_line":"    tables.recordsets.c.id,                    # 0 - RS ID"},{"line_number":38,"context_line":"    tables.recordsets.c.version,               # 1 - RS Version"},{"line_number":39,"context_line":"    tables.recordsets.c.created_at,            # 2 - RS Created"},{"line_number":40,"context_line":"    tables.recordsets.c.updated_at,            # 3 - RS Updated"},{"line_number":41,"context_line":"    tables.recordsets.c.tenant_id,             # 4 - RS Tenant"},{"line_number":42,"context_line":"    tables.recordsets.c.zone_id,               # 5 - RS Zone"}],"source_content_type":"text/x-python","patch_set":13,"id":"cbfd22e7_4d6f346d","line":39,"updated":"2023-05-22 20:36:54.000000000","message":"When I look at the recordset object[1], I don\u0027t see these _at fields. I wonder if we need to pull these back from the DB or not.\n\n[1] https://github.com/openstack/designate/blob/master/designate/objects/recordset.py#L84\n\nAgain, something for a future patch","commit_id":"0c30fc491b0012da13a562c9107f4451790607dd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1d5361949ed36583a50b502a29dd02ac7c6ce816","unresolved":true,"context_lines":[{"line_number":446,"context_line":"                # Set up a new rrset"},{"line_number":447,"context_line":"                current_rrset \u003d objects.RecordSet()"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"                rrset_id \u003d record[RECORDSET_MAP[\u0027id\u0027]]"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"                # Add all the loaded vars into RecordSet object"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"4dada400_98320746","line":449,"range":{"start_line":449,"start_character":33,"end_line":449,"end_character":53},"updated":"2023-05-22 20:36:54.000000000","message":"I still don\u0027t know why these maps are needed, you should be able to access the rows columns by name. You just need alias the columns with the same name in the two tables.\nThis is something to fix in a future patch.","commit_id":"0c30fc491b0012da13a562c9107f4451790607dd"}]}