)]}'
{"id":"openstack%2Fdesignate~889261","triplet_id":"openstack%2Fdesignate~master~Iab105ec5f45083a9026718572d77870fd908d660","project":"openstack/designate","branch":"master","attention_set":{},"removed_from_attention_set":{"22623":{"account":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"last_update":"2023-07-25 07:56:05.000000000","reason":"\u003cGERRIT_ACCOUNT_22623\u003e replied on the change","reason_account":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}}},"hashtags":[],"change_id":"Iab105ec5f45083a9026718572d77870fd908d660","subject":"Removed unused code path in sql base","status":"MERGED","created":"2023-07-22 21:17:42.000000000","updated":"2023-07-25 09:00:25.000000000","submitted":"2023-07-25 08:58:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"889261","meta_rev_id":"2f0dfe6e7a5fdaa61af950c3e4d88ea4f3199d18","_number":889261,"virtual_id_number":889261,"owner":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-07-25 08:58:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":2,"date":"2023-07-24 16:23:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-07-25 07:56:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-22 22:28:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-07-24 16:23:44.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"}],"messages":[{"id":"eba8fd0f0f5d5932b69a665e2193dada4b905c28","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2023-07-22 21:17:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"eadcc4599728f7330848278e933425e001b2c379","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-22 22:28:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/746f065e5f33436ea178d5d979913e67\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/9438186d864c4bdda23bd2a7efdfc0d4 : SUCCESS in 50m 07s\n- designate-bind9-centos9stream-fips https://zuul.opendev.org/t/openstack/build/d71bef65ba864d318c411cff8c7e0492 : SUCCESS in 41m 26s (non-voting)\n- designate-bind9-centos-9-stream https://zuul.opendev.org/t/openstack/build/39681dc9ab64469e98eecce8a676824e : SUCCESS in 56m 48s (non-voting)\n- designate-bind9-keystone-default-roles https://zuul.opendev.org/t/openstack/build/e6b1606a175e4052ae41d27ff22bc6cc : SUCCESS in 46m 38s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/f9c74e5d856847b585ff0ece031d28a1 : SUCCESS in 32m 19s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/c0a48f879b9f4c0281c723151a0fb385 : SUCCESS in 45m 09s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/939739551edb47e1a5f067f55fe22507 : SUCCESS in 1h 05m 31s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/b23c3d04406647ee9538b43c8324b527 : SUCCESS in 49m 18s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/079b8c59745d4c6dad94da7eac11c376 : SUCCESS in 52m 53s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1186254caa584822a181afb904eb1431 : SUCCESS in 5m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6bef5bb1d7fa478990b5200f15cce54f : SUCCESS in 2m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/318ec4cb10ee4caa825f2a3f8d14bd96 : SUCCESS in 6m 49s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e15f6469999d4f47af874fb4e533bad3 : SUCCESS in 3m 57s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/22247631ef614b87a86bb548475078d6 : SUCCESS in 3m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ba2d34d7b47b44958a76567530ccd3c6 : SUCCESS in 7m 52s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/c1efe85a3b1e4e1ca63c781e4c646eed : SUCCESS in 36m 46s\n- designate-tox-py310-with-sqlalchemy-2x https://zuul.opendev.org/t/openstack/build/b202080596f249fda5ac530114d11eb1 : SUCCESS in 5m 36s\n- designate-bind9-sqlalchemy-2x https://zuul.opendev.org/t/openstack/build/8385725e828d4efc8bea698225076ce9 : SUCCESS in 33m 15s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/12810eb921c34ba6af565dd2aaac0317 : SUCCESS in 4m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9223271747aa7e9717c18fe5c9ed36a462cdf501","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2023-07-24 16:23:44.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0b44657b004e8df84ef4d9471315a6da4d1ee61c","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2023-07-25 07:56:05.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e4246a8016c379d0081f21e756f2295349bc14d9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-25 07:56:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2655a5951998f35c0e8a378bc2750641d6a59e36","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-25 08:58:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/489254eba951454ba6b9503c3632f85a\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/f5ad20d7540b4afd8982532f88732fb4 : SUCCESS in 36m 01s\n- designate-bind9-keystone-default-roles https://zuul.opendev.org/t/openstack/build/c00f89b73b7b4427853b538de96e7f0f : SUCCESS in 42m 27s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/f60f4f59ec4447c3aa09af706c86f8ea : SUCCESS in 39m 48s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/b61a44ae31064935884c5de96c71cd84 : SUCCESS in 58m 37s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/4455c06876bb49b69b299b20003010b7 : SUCCESS in 38m 34s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/ab7acb215a9041df90ea8b547f6fd806 : SUCCESS in 42m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/148a7d3a79aa4af7b83b8a599ea72202 : SUCCESS in 3m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b8ddbcafe72f44eba02f69c090e20bd1 : SUCCESS in 4m 31s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e9ad75385756450f9c11039b23b9b1b3 : SUCCESS in 4m 07s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/5c312042d09649eb8437507204011012 : SUCCESS in 4m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/114603965b9a4821b4a64225e6d16065 : SUCCESS in 6m 50s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/3d3a6a2c9cad4422ac21b7137cb8dab4 : SUCCESS in 33m 02s\n- designate-tox-py310-with-sqlalchemy-2x https://zuul.opendev.org/t/openstack/build/c6043d5172af46b68fc21320bd75f03f : SUCCESS in 5m 59s\n- designate-bind9-sqlalchemy-2x https://zuul.opendev.org/t/openstack/build/ed3dab0cfc2c4acc81d5bd1c94c7ced3 : SUCCESS in 38m 26s","accounts_in_message":[],"_revision_number":1},{"id":"250c60e4e462804a00f88d16283e2e227fee0bfa","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-25 08:58:34.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"2f0dfe6e7a5fdaa61af950c3e4d88ea4f3199d18","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-25 09:00:25.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e26f0cef8bf14dcda5f626404b96092d\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/680b8719d8a04f369a1b8f6a4931cc91 : SUCCESS in 43s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e003d7aa68182cdace7c35965e68eeb77d5686fa","revisions":{"e003d7aa68182cdace7c35965e68eeb77d5686fa":{"kind":"REWORK","_number":1,"created":"2023-07-22 21:17:42.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/61/889261/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/61/889261/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/61/889261/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/61/889261/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/61/889261/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/61/889261/1"}}},"commit":{"parents":[{"commit":"61b408287ff0bbb94e03f0fcd137af9f5413e2ca","subject":"Merge \"Add a tempest test job with sqlalchemy 2.x\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/61b408287ff0bbb94e03f0fcd137af9f5413e2ca"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2023-07-22 21:16:32.000000000","tz":120},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2023-07-22 21:16:32.000000000","tz":120},"subject":"Removed unused code path in sql base","message":"Removed unused code path in sql base\n\nWe never provide any extra parameters in any\nof these code paths and instead of adding missing\ntesting coverage it\u0027s better to just remove these\ncode paths.\n\nChange-Id: Iab105ec5f45083a9026718572d77870fd908d660\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/e003d7aa68182cdace7c35965e68eeb77d5686fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/e003d7aa68182cdace7c35965e68eeb77d5686fa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
