)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"022e8b7047c9b6f4a833f6920a5fb937be70c956","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add catalog zone support to devstack plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch addes the ability to configure devstack to use catalog zones"},{"line_number":10,"context_line":"when using the BIND9 backend."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/designate-tempest-plugin/+/900870"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3c7651ba_59973570","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":16},"updated":"2024-01-31 09:43:45.000000000","message":"nit: adds","commit_id":"b0852562a56a11a3df9747aa57c68087be200916"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"52d1e735c93f7f6af2ef9f4f39ebfdfd9d1ec1f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add catalog zone support to devstack plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch addes the ability to configure devstack to use catalog zones"},{"line_number":10,"context_line":"when using the BIND9 backend."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/designate-tempest-plugin/+/900870"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"4de485eb_5a1cb979","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":16},"in_reply_to":"3c7651ba_59973570","updated":"2024-02-19 16:40:22.000000000","message":"Done","commit_id":"b0852562a56a11a3df9747aa57c68087be200916"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"022e8b7047c9b6f4a833f6920a5fb937be70c956","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add catalog zone support to devstack plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch addes the ability to configure devstack to use catalog zones"},{"line_number":10,"context_line":"when using the BIND9 backend."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/designate-tempest-plugin/+/900870"},{"line_number":13,"context_line":"Change-Id: Ib618d7850b0a86a8eb10eaa52b0e330cf908883a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"8099b18a_c8b9b763","line":10,"updated":"2024-01-31 09:43:45.000000000","message":"it also adds a job to zuul that actually tests this variant","commit_id":"b0852562a56a11a3df9747aa57c68087be200916"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"52d1e735c93f7f6af2ef9f4f39ebfdfd9d1ec1f9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add catalog zone support to devstack plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch addes the ability to configure devstack to use catalog zones"},{"line_number":10,"context_line":"when using the BIND9 backend."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/designate-tempest-plugin/+/900870"},{"line_number":13,"context_line":"Change-Id: Ib618d7850b0a86a8eb10eaa52b0e330cf908883a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"354f717d_b20bbb2c","line":10,"in_reply_to":"8099b18a_c8b9b763","updated":"2024-02-19 16:40:22.000000000","message":"Done","commit_id":"b0852562a56a11a3df9747aa57c68087be200916"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6a8c66ce96fc43dfa6ce6657cb6637faa0b13bd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f1f4d2b7_8dfdf1c2","updated":"2023-08-25 20:16:38.000000000","message":"WIP","commit_id":"e85dc103f4a0319b6129dc585c3e50e5258bf73e"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"ecdc268d0eff10afe787b439726e689326607989","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fb59595_1d08010e","updated":"2023-10-26 12:39:14.000000000","message":"Michael, could you kindly rebase this one, so we have a fresh recheck and can fix any issues with the catalog zones ...","commit_id":"9a1811170e2bc3d7529a35259217a90ea9258f0a"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"fa113f144bc91ba30d249f2f69f13ba23f52af40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"91a8dd26_9a06b8ca","updated":"2023-10-26 12:38:19.000000000","message":"recheck","commit_id":"9a1811170e2bc3d7529a35259217a90ea9258f0a"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"bc4be3d32e7ba8431e9acf69742ac5d491c104ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"66f79ac4_8eb674f6","updated":"2024-01-09 12:36:09.000000000","message":"recheck designate-bind9-catalog-zones","commit_id":"8ad82835fa5a8e6448b2c92cd3050cb4b53200f1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"022e8b7047c9b6f4a833f6920a5fb937be70c956","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"dfa501e7_1a2d2753","updated":"2024-01-31 09:43:45.000000000","message":"I can\u0027t say much about the actual catalog zones feature, just some general remarks","commit_id":"b0852562a56a11a3df9747aa57c68087be200916"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"84d855a8e6608415b8122a920ed98a96bfb7bba9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e3e458ea_3e1778c8","updated":"2024-01-31 09:53:55.000000000","message":"Michael, will you be addressing Jens remarks?","commit_id":"b0852562a56a11a3df9747aa57c68087be200916"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c9c9dd35c9b16f0a479ff07d11ce8378a7bde648","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":19,"id":"ed605360_5ffd3dba","in_reply_to":"e3e458ea_3e1778c8","updated":"2024-02-14 18:58:20.000000000","message":"Yes, I will","commit_id":"b0852562a56a11a3df9747aa57c68087be200916"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c93145c55cbd26a630a9789e8c4659570f1b129c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"825195fa_3910d036","updated":"2024-02-27 15:30:36.000000000","message":"Workflowing this as it has a core review +2","commit_id":"4258633ae5713b2dbec3bfe1a047bc76fd7a10f0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ba835f14fec6af249b9b31e0d18881238640ddec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"29e93ed3_2f84aae1","updated":"2024-02-20 21:00:11.000000000","message":"recheck\nCatalog zone failed zone abandon test on record update timeout","commit_id":"4258633ae5713b2dbec3bfe1a047bc76fd7a10f0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d0010417ee44dd141c7fdb0794517e00395f2fc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"d523d5c9_795709c2","updated":"2024-02-20 22:24:42.000000000","message":"recheck\ncinder.sh SSH error","commit_id":"4258633ae5713b2dbec3bfe1a047bc76fd7a10f0"}],"devstack/designate_plugins/backend-bind9":[{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"8a7a34cdb8df702c24d33be3af2fd9dccd183fe1","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      masters:"},{"line_number":112,"context_line":"        - host: $(ipv6_unquote $DESIGNATE_SERVICE_HOST)"},{"line_number":113,"context_line":"          port: $DESIGNATE_SERVICE_PORT_MDNS"},{"line_number":114,"context_line":"EOF"},{"line_number":115,"context_line":"    else"},{"line_number":116,"context_line":"        sudo tee -a $DESIGNATE_CONF_DIR/pools.yaml \u003e /dev/null \u003c\u003cEOF"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"f58faf33_dca25983","line":113,"updated":"2023-11-09 16:31:28.000000000","message":"I think this is missing the options key, with host and port. Without this, Designate does not know where to send the NOTIFY messages and hence Bind does not receive them.\n\nOn my DevStack setup, all tests (except one) are passing with this.\n\nCould those options be added?","commit_id":"65a40bb43ba673c79772bf4cb3e5768b23d5b46d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cd7801c411a6435bf60d4eecad8754c07237ec00","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      masters:"},{"line_number":112,"context_line":"        - host: $(ipv6_unquote $DESIGNATE_SERVICE_HOST)"},{"line_number":113,"context_line":"          port: $DESIGNATE_SERVICE_PORT_MDNS"},{"line_number":114,"context_line":"EOF"},{"line_number":115,"context_line":"    else"},{"line_number":116,"context_line":"        sudo tee -a $DESIGNATE_CONF_DIR/pools.yaml \u003e /dev/null \u003c\u003cEOF"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"e681d24e_09858db4","line":113,"in_reply_to":"d8df0ac2_8890c565","updated":"2023-11-14 17:47:22.000000000","message":"This is interesting as it should use the nameservers list, not options. Looking into this.","commit_id":"65a40bb43ba673c79772bf4cb3e5768b23d5b46d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"949139b1b21071759b058a3c68598ce349410580","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      masters:"},{"line_number":112,"context_line":"        - host: $(ipv6_unquote $DESIGNATE_SERVICE_HOST)"},{"line_number":113,"context_line":"          port: $DESIGNATE_SERVICE_PORT_MDNS"},{"line_number":114,"context_line":"EOF"},{"line_number":115,"context_line":"    else"},{"line_number":116,"context_line":"        sudo tee -a $DESIGNATE_CONF_DIR/pools.yaml \u003e /dev/null \u003c\u003cEOF"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"2e2ecb41_0858f063","line":113,"in_reply_to":"e681d24e_09858db4","updated":"2023-11-14 17:52:05.000000000","message":"Yeah, ok, this was a mistake.","commit_id":"65a40bb43ba673c79772bf4cb3e5768b23d5b46d"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"796f69af4ed0fd6608eaf079677a71cf4ac6ab7d","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      masters:"},{"line_number":112,"context_line":"        - host: $(ipv6_unquote $DESIGNATE_SERVICE_HOST)"},{"line_number":113,"context_line":"          port: $DESIGNATE_SERVICE_PORT_MDNS"},{"line_number":114,"context_line":"EOF"},{"line_number":115,"context_line":"    else"},{"line_number":116,"context_line":"        sudo tee -a $DESIGNATE_CONF_DIR/pools.yaml \u003e /dev/null \u003c\u003cEOF"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"d8df0ac2_8890c565","line":113,"in_reply_to":"f58faf33_dca25983","updated":"2023-11-14 10:53:49.000000000","message":"I took the liberty and implemented this change (PS 5).\n\nThe one failing test should also be fixed via a small change in designate-tempest-plugin (see https://review.opendev.org/c/openstack/designate-tempest-plugin/+/900870) via PS 6.","commit_id":"65a40bb43ba673c79772bf4cb3e5768b23d5b46d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"022e8b7047c9b6f4a833f6920a5fb937be70c956","unresolved":true,"context_lines":[{"line_number":92,"context_line":"EOF"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    if [[ \"$DESIGNATE_USE_CATALOG_ZONES\" \u003d\u003d \"True\" ]]; then"},{"line_number":95,"context_line":"        sudo tee -a $DESIGNATE_CONF_DIR/pools.yaml \u003e /dev/null \u003c\u003cEOF"},{"line_number":96,"context_line":"  targets:"},{"line_number":97,"context_line":"    - type: fake"},{"line_number":98,"context_line":"      description: BIND Instance"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"319915a5_d5dfd412","line":95,"updated":"2024-01-31 09:43:45.000000000","message":"all these conditionals are very ugly. maybe time to switch to some proper templating like using jinja2?","commit_id":"b0852562a56a11a3df9747aa57c68087be200916"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"84d855a8e6608415b8122a920ed98a96bfb7bba9","unresolved":true,"context_lines":[{"line_number":92,"context_line":"EOF"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    if [[ \"$DESIGNATE_USE_CATALOG_ZONES\" \u003d\u003d \"True\" ]]; then"},{"line_number":95,"context_line":"        sudo tee -a $DESIGNATE_CONF_DIR/pools.yaml \u003e /dev/null \u003c\u003cEOF"},{"line_number":96,"context_line":"  targets:"},{"line_number":97,"context_line":"    - type: fake"},{"line_number":98,"context_line":"      description: BIND Instance"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"94d50ed5_a4e82338","line":95,"in_reply_to":"319915a5_d5dfd412","updated":"2024-01-31 09:53:55.000000000","message":"Maybe. But this only follows the style that devstack uses: pure BASH.\nBut there are some helpers here: https://opendev.org/openstack/devstack/src/branch/master/inc, mostly iniset seems to be used, if you look at the various built-in plugins: https://opendev.org/openstack/devstack/src/branch/master/lib","commit_id":"b0852562a56a11a3df9747aa57c68087be200916"}],"devstack/settings":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"022e8b7047c9b6f4a833f6920a5fb937be70c956","unresolved":true,"context_lines":[{"line_number":10,"context_line":"DESIGNATE_POLL_INTERVAL\u003d${DESIGNATE_POLL_INTERVAL:-5}"},{"line_number":11,"context_line":"DESIGNATE_POLL_RETRIES\u003d${DESIGNATE_POLL_RETRIES:-6}"},{"line_number":12,"context_line":"DESIGNATE_WSGI_MODE\u003d${DESIGNATE_WSGI_MODE:-\"uwsgi\"}"},{"line_number":13,"context_line":"DESIGNATE_USE_CATALOG_ZONES\u003d${DESIGNATE_USE_CATALOG_ZONES:-\"False\"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Quota Options"},{"line_number":16,"context_line":"DESIGNATE_QUOTA_ZONES\u003d${DESIGNATE_QUOTA_ZONES:-10}"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"d0edd193_cb464946","line":13,"updated":"2024-01-31 09:43:45.000000000","message":"This should use devstack\u0027s helper function for bool vars:\n\nDESIGNATE_USE_CATALOG_ZONES\u003d$(trueorfalse False DESIGNATE_USE_CATALOG_ZONES)","commit_id":"b0852562a56a11a3df9747aa57c68087be200916"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"52d1e735c93f7f6af2ef9f4f39ebfdfd9d1ec1f9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"DESIGNATE_POLL_INTERVAL\u003d${DESIGNATE_POLL_INTERVAL:-5}"},{"line_number":11,"context_line":"DESIGNATE_POLL_RETRIES\u003d${DESIGNATE_POLL_RETRIES:-6}"},{"line_number":12,"context_line":"DESIGNATE_WSGI_MODE\u003d${DESIGNATE_WSGI_MODE:-\"uwsgi\"}"},{"line_number":13,"context_line":"DESIGNATE_USE_CATALOG_ZONES\u003d${DESIGNATE_USE_CATALOG_ZONES:-\"False\"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Quota Options"},{"line_number":16,"context_line":"DESIGNATE_QUOTA_ZONES\u003d${DESIGNATE_QUOTA_ZONES:-10}"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"204a0405_5bb49f5b","line":13,"in_reply_to":"d0edd193_cb464946","updated":"2024-02-19 16:40:22.000000000","message":"Done","commit_id":"b0852562a56a11a3df9747aa57c68087be200916"}]}